Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/ specialpurpose/solr/conf/ specialpurpose/solr/config/ specialpurpose/solr/entitydef/ special

Hi Jacopo, Let me clean the OFBizSolrContextFilter now. Kind Regards, Shi Jinghai -邮件原件- 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] 发送时间: 2016年9月5日 22:20 收件人: dev@ofbiz.apache.org 主题: Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/

Re: Michael Brohl joins OFBiz PMC

Congratulations! Wai -- View this message in context: http://ofbiz.135035.n4.nabble.com/Michael-Brohl-joins-OFBiz-PMC-tp4692278p4692811.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/ specialpurpose/solr/conf/ specialpurpose/solr/config/ specialpurpose/solr/entitydef/ special

Hi Jinghai, I have noticed that when you have committed the Solr component you have created a class named OFBizSolrContextFilter.java that is mostly the copy of ContextFilter: as a consequence the logic implemented in its utility methods has been duplicated. I didn't check, but it is possible

Re: svn commit: r1759250 - /ofbiz/trunk/build.gradle

Taher, Actually it was the description of the issue I created back then. I saw it after routinely copying it, but did not change it, because I had to move. I will edit the commit comment, to have something meaningful there. Jacques Le 05/09/2016 à 14:30, Taher Alkhateeb a écrit : Hi

Re: Michael Brohl joins OFBiz PMC

Congratulations Michael! Best regards, Pranay Pandey HotWax Systems http://www.hotwaxsystems.com/ On Mon, Sep 5, 2016 at 6:01 PM, Vogelsme wrote: > Congratulations Michael! ;) > > > > -- > View this message in context: http://ofbiz.135035.n4.nabble. >

Re: Michael Brohl joins OFBiz PMC

Congratulations Michael! ;) -- View this message in context: http://ofbiz.135035.n4.nabble.com/Michael-Brohl-joins-OFBiz-PMC-tp4692278p4692806.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Re: svn commit: r1759250 - /ofbiz/trunk/build.gradle

Hi Jacques, I don't understand your concern described below? What is the problem of having jars not related to OFBiz in gradle's cache? What is the problem? Regards, Taher Alkhateeb On Sep 5, 2016 3:24 PM, wrote: > Author: jleroux > Date: Mon Sep 5 12:24:21 2016 > New

Re: Taking action on problems with using JIRA

Hi Sharan, I saw you created https://cwiki.apache.org/confluence/display/OFBIZ/Guidelines+for+Using+Jira In this thread I suggested We could start by extracting this section

Re: Taking action on problems with using JIRA

I think one thing we should consider before all the rest is Jiras issues with patches. Those are more valuable than others and patches have a disconcerting tendency to become stale, we should avoid that. I have a rule for that (I did not invent it, thanks Internet): the 10 min rule. If I

Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name

Thanks, Jacques, I will do the work during our Community Day so we'll have some time to wait for additional comments. Regards, Michael Brohl ecomify GmbH www.ecomify.de Am 05.09.16 um 13:51 schrieb Jacques Le Roux: Michael, I'd wait 2 days before applying a lazy consensus, ie if nobody

Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name

Michael, I'd wait 2 days before applying a lazy consensus, ie if nobody chime in, please commit... Jacques Le 05/09/2016 à 13:40, Akash Jain a écrit : +1 for the single commit! Thanks and Regards -- Akash Jain On Mon, Sep 5, 2016 at 2:56 PM, Michael Brohl wrote:

Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name

+1 for the single commit! Thanks and Regards -- Akash Jain On Mon, Sep 5, 2016 at 2:56 PM, Michael Brohl wrote: > Thanks for your suggestions, Akash and Jacques. > > To be clear, my question is only for these specific changes which I plan > do review and commit. > >

Re: Taking action on problems with using JIRA

Hi Taher +1 You have raised some good actionable points here. I think you are right that the Jira guidelines need be completely separated out into something that is clear and can be used as an easy reference. I will create a wiki page to start pulling the information together. Thanks Sharan

Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name

A single commit is fine IMO if the changes are all focused on something specific. The only style of commit I would object to are ones that incorporate a non-trivial number of unrelated changes, otherwise whatever works best for the committer is fine by me. Regards Scott On 5 September 2016 at

Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name

Thanks for your suggestions, Akash and Jacques. To be clear, my question is only for these specific changes which I plan do review and commit. They are all of the same nature, easy to review and a single commit would avoid to write a lot of similar commit messages, references to different

Re: Michael Brohl joins OFBiz PMC

Congratulations Michael! Kind regards, Sebastian Sebastian Leitner Diplom-Wirtschaftsinformatiker Bereichsleiter Digital Lynx-Consulting GmbH Johanniskirchplatz 6 33615 Bielefeld Germany Fon: +49 521 5247-0 Fax: +49 521 5247-250 Mobil: +49 151 1256 86 05 Lynx-Consulting GmbH,

Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name

BTW, this was not exactly Michael's question (apart your 1st point). We can have several sub-tasks but commit all of them in one shoot. Others opinions? Anyway I don't think we can have a global agreement (for every Jiras) on this, because it really dependd on the content of the subtasks

Re: OFBiz logo files in repo?

The ofbiz logo in the code base is used as: - an icon in the browser window (.ico file) - default logo in the themes, when there is none set in the company record. Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace

Re: OFBiz logo files in repo?

I think the wiki is okay, maybe the website repo is okay, but not in trunk unless it serves a purpose (used somewhere in some screen) On Mon, Sep 5, 2016 at 11:40 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > Previously we had some OFBiz logo files in repo, should we put

OFBiz logo files in repo?

Hi, Previously we had some OFBiz logo files in repo, should we put the new files there or simply remove the old and have logos only in wiki? Jacques

Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name

Makes sense Akash, thanks! Jacques Le 05/09/2016 à 07:39, Akash Jain a écrit : I think both ways are fine but personally I like to do this kind of changes component wise because, -- it's easy to review -- more users and committers can involve -- easy for beginners to contribute Thanks and

Re: Michael Brohl joins OFBiz PMC

Many congratulations Michael :-) - Best Regards, Swapnil M Mane On Fri, Sep 2, 2016 at 4:06 PM, Sharan Foga wrote: > Hi Everyone > > Please join me in welcoming Michael Brohl as our newest member of the > OFBiz PMC. > > Congratulations Michael and welcome! :-) > > Thanks

Re: Michael Brohl joins OFBiz PMC

Many Congratulations Michael! Thanks and Regards -- Akash Jain On Fri, Sep 2, 2016 at 4:06 PM, Sharan Foga wrote: > Hi Everyone > > Please join me in welcoming Michael Brohl as our newest member of the > OFBiz PMC. > > Congratulations Michael and welcome! :-) > > Thanks

Re: Michael Brohl joins OFBiz PMC

Congratulations Michael ! Gil On 04/09/2016 09:49, Gavin Mabie wrote: Congratulations Michael. On Fri, Sep 2, 2016 at 1:32 PM, Ashish Vijaywargiya < ashish.vijaywarg...@hotwaxsystems.com> wrote: Many-Many Congrats Michael. :-) -- Kind Regards Ashish Vijaywargiya HotWax Systems - est.