Re: Proposal to rename specialpurpose to plugins

2017-01-09 Thread Gavin Mabie
+1 to rename as plugins On Mon, Jan 9, 2017 at 12:23 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks for the update Nicolas > > Jacques > > > > Le 09/01/2017 à 11:04, Nicolas Malin a écrit : > >> +1 to change specialpurpose. >> >> For remove hot-deploy, I prefer wait to have

Re: Inconsistent String Comparisons

2017-01-09 Thread Pranay Pandey
+1 Devanshu. Best regards, Pranay Pandey HotWax Systems http://www.hotwaxsystems.com/ On Mon, Jan 9, 2017 at 2:52 PM, Devanshu Vyas wrote: > Hello Devs, > > I found an inconsistency in the code for string comparison > *statusId.equals("PRUN_COMPLETED")* whereas it

Re: Proposal to rename specialpurpose to plugins

2017-01-09 Thread Jacques Le Roux
Thanks for the update Nicolas Jacques Le 09/01/2017 à 11:04, Nicolas Malin a écrit : +1 to change specialpurpose. For remove hot-deploy, I prefer wait to have a good namespace management to identify correctly the origin of each plugin. I work with Jacques on the

Re: Inconsistent String Comparisons

2017-01-09 Thread Swapnil Mane
+1 Devanshu. - Best Regards, Swapnil M Mane On Mon, Jan 9, 2017 at 2:52 PM, Devanshu Vyas wrote: > Hello Devs, > > I found an inconsistency in the code for string comparison > *statusId.equals("PRUN_COMPLETED")* whereas it should be written as >

Re: Proposal to rename specialpurpose to plugins

2017-01-09 Thread Nicolas Malin
+1 to change specialpurpose. For remove hot-deploy, I prefer wait to have a good namespace management to identify correctly the origin of each plugin. I work with Jacques on the https://issues.apache.org/jira/browse/OFBIZ-6919 but I take to much time to finish this task, so I think you can

Re: Inconsistent String Comparisons

2017-01-09 Thread Michael Brohl
+1 Regards, Michael Am 09.01.17 um 10:27 schrieb Nicolas Malin: Hello Devanshu, Yes your welcome to submit a patch :) Nicolas Le 09/01/2017 à 10:22, Devanshu Vyas a écrit : Hello Devs, I found an inconsistency in the code for string comparison *statusId.equals("PRUN_COMPLETED")* whereas

Re: Inconsistent String Comparisons

2017-01-09 Thread Nicolas Malin
Hello Devanshu, Yes your welcome to submit a patch :) Nicolas Le 09/01/2017 à 10:22, Devanshu Vyas a écrit : Hello Devs, I found an inconsistency in the code for string comparison *statusId.equals("PRUN_COMPLETED")* whereas it should be written as *"PRUN_COMPLETED".equals(statusId)* cause

Inconsistent String Comparisons

2017-01-09 Thread Devanshu Vyas
Hello Devs, I found an inconsistency in the code for string comparison *statusId.equals("PRUN_COMPLETED")* whereas it should be written as *"PRUN_COMPLETED".equals(statusId)* cause the former can throw NullPointerException if the variable found to be NULL. This code pattern can be found at