Re: Welcome Swapnil Shah as a New Committer!

2017-02-17 Thread Aditya Sharma 
Felicitations Swapnil Shah...

Thanks & Regards,
Aditya Sharma
Enterprise Software Engineer
Hotwax Systems
http://www.hotwaxsystems.com/

On Sat, Feb 18, 2017 at 10:32 AM, Ratnesh Upadhyay <
upadhyay.ratn...@gmail.com> wrote:

> Many Congratulations Swapnil.
>
> Regards,
> Ratnesh Upadhyay
>
> On Tue, Feb 14, 2017 at 4:30 PM, Sharan Foga  wrote:
>
> > The OFBiz PMC has invited Swapnil Shah to become a new committer and are
> > happy to announce that he has accepted.
> >
> > Swapnil has been involved in OFBiz for a few years and has been active on
> > both the development and user mailing lists responding to some quite
> > technical functional questions.
> >
> > Some of the key factors considered for inviting him were as follows:
> >
> > - He has very good functional knowledge about OFBiz and this is a
> valuable
> > skill that is useful to developers and users
> > - He is polite, positive, friendly and collaborative when dealing the
> > community discussions on the mailings lists or Jira
> > - He has raised Jiras, performed testing on patches and new other
> > functionality
> > - The PMC would like to see a wide range of people from the community
> > (developers and non-developers) recognised for their contributions to the
> > project.
> >
> > Please join me in welcoming and congratulating Swapnil.
> >
> > Thanks
> > Sharan
> >
>
>
>
> --
> --
> 
> Cheers,
> Thanks and Regards,
> Ratnesh Upadhyay
> Senior Business Analyst (Enterprise Software Solutions)
> HotWax Media, Inc.
> http://www.hotwaxmedia.com
> 
> E-mail : ratnesh.upadh...@hotwaxmedia.com
> Mobile : +919826886909
>

Re: Inconsistent String Comparisons

2017-02-17 Thread Taher Alkhateeb 
+1

On Feb 18, 2017 8:16 AM, "Ratnesh Upadhyay" 
wrote:

+1 for the initiation, also we can enforce it as best practice for future
implementations and patches.

Thanks!!

Regards,
Ratnesh Upadhyay
HotWax Systems
www.hotwaxsystems.com

On Mon, Jan 9, 2017 at 2:52 PM, Devanshu Vyas 
wrote:

> Hello Devs,
>
> I found an inconsistency in the code for string comparison
> *statusId.equals("PRUN_COMPLETED")* whereas it should be written as
> *"PRUN_COMPLETED".equals(statusId)*
> cause the former can throw NullPointerException if the variable found to
be
> NULL.
>
> This code pattern can be found at several places and if you all agree with
> this I can provide a patch for correcting code.
>
> Let me know your thoughts.
>
> Thanks & Regards,
> Devanshu Vyas.
>



--
--

Cheers,
Thanks and Regards,
Ratnesh Upadhyay
Senior Business Analyst (Enterprise Software Solutions)
HotWax Media, Inc.
http://www.hotwaxmedia.com

E-mail : ratnesh.upadh...@hotwaxmedia.com
Mobile : +919826886909

Re: Inconsistent String Comparisons

2017-02-17 Thread Ratnesh Upadhyay 
+1 for the initiation, also we can enforce it as best practice for future
implementations and patches.

Thanks!!

Regards,
Ratnesh Upadhyay
HotWax Systems
www.hotwaxsystems.com

On Mon, Jan 9, 2017 at 2:52 PM, Devanshu Vyas 
wrote:

> Hello Devs,
>
> I found an inconsistency in the code for string comparison
> *statusId.equals("PRUN_COMPLETED")* whereas it should be written as
> *"PRUN_COMPLETED".equals(statusId)*
> cause the former can throw NullPointerException if the variable found to be
> NULL.
>
> This code pattern can be found at several places and if you all agree with
> this I can provide a patch for correcting code.
>
> Let me know your thoughts.
>
> Thanks & Regards,
> Devanshu Vyas.
>



-- 
-- 

Cheers,
Thanks and Regards,
Ratnesh Upadhyay
Senior Business Analyst (Enterprise Software Solutions)
HotWax Media, Inc.
http://www.hotwaxmedia.com

E-mail : ratnesh.upadh...@hotwaxmedia.com
Mobile : +919826886909

Re: Welcome Swapnil Shah as a New Committer!

2017-02-17 Thread Ratnesh Upadhyay 
Many Congratulations Swapnil.

Regards,
Ratnesh Upadhyay

On Tue, Feb 14, 2017 at 4:30 PM, Sharan Foga  wrote:

> The OFBiz PMC has invited Swapnil Shah to become a new committer and are
> happy to announce that he has accepted.
>
> Swapnil has been involved in OFBiz for a few years and has been active on
> both the development and user mailing lists responding to some quite
> technical functional questions.
>
> Some of the key factors considered for inviting him were as follows:
>
> - He has very good functional knowledge about OFBiz and this is a valuable
> skill that is useful to developers and users
> - He is polite, positive, friendly and collaborative when dealing the
> community discussions on the mailings lists or Jira
> - He has raised Jiras, performed testing on patches and new other
> functionality
> - The PMC would like to see a wide range of people from the community
> (developers and non-developers) recognised for their contributions to the
> project.
>
> Please join me in welcoming and congratulating Swapnil.
>
> Thanks
> Sharan
>



-- 
-- 

Cheers,
Thanks and Regards,
Ratnesh Upadhyay
Senior Business Analyst (Enterprise Software Solutions)
HotWax Media, Inc.
http://www.hotwaxmedia.com

E-mail : ratnesh.upadh...@hotwaxmedia.com
Mobile : +919826886909

buildbot success in on ofbiz-branch15

2017-02-17 Thread buildbot 
The Buildbot has detected a restored build on builder ofbiz-branch15 while 
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-branch15/builds/302

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: forced: by IRC user  (privmsg): forces manual build 
after port issue fixed
Build Source Stamp: HEAD
Blamelist: 

Build succeeded!

Sincerely,
 -The Buildbot

Re: About https://github.com/apache/ofbiz

2017-02-17 Thread Taher Alkhateeb 
+1

On Feb 17, 2017 5:57 PM, "Julien NICOLAS"  wrote:

> +1
>
>
> On 17/02/2017 14:21, Jacques Le Roux wrote:
>
>> I think we should remove a lot of useless and old confusing branches in
>> svn
>>
>
>

Re: About https://github.com/apache/ofbiz

2017-02-17 Thread Julien NICOLAS 

+1


On 17/02/2017 14:21, Jacques Le Roux wrote:
I think we should remove a lot of useless and old confusing branches 
in svn

Re: About https://github.com/apache/ofbiz

2017-02-17 Thread Deepak Dixit 
> I think we should remove a lot of useless and old confusing branches in
> svn and document the fact in GitHub that the ofbiz-framework/trunk is the
> new trunk. But how I'm still unsure, I guess at top of the README.MD ?
>
> I'll make a list of branches to remove...
>
> Jacques
>
>
+1

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

Re: About https://github.com/apache/ofbiz

2017-02-17 Thread Jacopo Cappellato 
On Fri, Feb 17, 2017 at 2:21 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

>
> I think we should remove a lot of useless and old confusing branches in svn


+1

Jacopo

Re: About https://github.com/apache/ofbiz

2017-02-17 Thread Pierre Smits 
+1

Dev branches have a life-span and - if all goes well - feed back into
trunk. When that has happened the branch can be pruned.

Best regards,

Pierre

On Friday, February 17, 2017, Jacques Le Roux 
wrote:

> Hi,
>
> I made a request to update it through INFRA-13497 because it does not
> contain the 2 new ofbiz-framework/trunk and ofbiz-plugins/trunk branches.
>
> I think we should remove a lot of useless and old confusing branches in
> svn and document the fact in GitHub that the ofbiz-framework/trunk is the
> new trunk. But how I'm still unsure, I guess at top of the README.MD ?
>
> I'll make a list of branches to remove...
>
> Jacques
>
>

-- 
Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

Re: About https://github.com/apache/ofbiz

2017-02-17 Thread Nicolas Malin 

I agree, If I can help to clean branches ?

Nicolas


Le 17/02/2017 à 14:21, Jacques Le Roux a écrit :

Hi,

I made a request to update it through INFRA-13497 because it does not 
contain the 2 new ofbiz-framework/trunk and ofbiz-plugins/trunk branches.


I think we should remove a lot of useless and old confusing branches 
in svn and document the fact in GitHub that the ofbiz-framework/trunk 
is the new trunk. But how I'm still unsure, I guess at top of the 
README.MD ?


I'll make a list of branches to remove...

Jacques

About https://github.com/apache/ofbiz

2017-02-17 Thread Jacques Le Roux 

Hi,

I made a request to update it through INFRA-13497 because it does not contain 
the 2 new ofbiz-framework/trunk and ofbiz-plugins/trunk branches.

I think we should remove a lot of useless and old confusing branches in svn and document the fact in GitHub that the ofbiz-framework/trunk is the new 
trunk. But how I'm still unsure, I guess at top of the README.MD ?


I'll make a list of branches to remove...

Jacques

Re: Improve FindGeneric on webtools

2017-02-17 Thread Jacques Le Roux 

That's certainly a good idea Taher,

In the meantime I like Nicolas's proposition, notably to be able to search on 
dates!

Jacques


Le 17/02/2017 à 09:13, Taher Alkhateeb a écrit :

Great initiative Nicolas.

I remember once trying to extend the functionality of performFind but it
contained so much logic that I couldn't reuse it in any reasonable way. The
entire implementation of find services needs heavy refactoring or
replacement because it tries to do everything (searching, parsing,
paginating, displaying, validating). It's just one big monster

I would recommend instead of creating new services, trying to replace the
existing ones (if possible and you go the energy). I think we need multiple
separate components (parser, renderer, paginator, searcher, etc ...). It
would be really great to have small specialized classes or groovy scripts
that split the responsibility instead of this painful implementation we
have at the moment.

On Fri, Feb 17, 2017 at 11:04 AM, Nicolas Malin 
wrote:


I opened the issue https://issues.apache.org/jira/browse/OFBIZ-9217

It's not finish yet but already usefull ;)

Nicolas

Le 17/02/2017 à 06:24, Rishi Solanki a écrit :


+1


On Thu, Feb 16, 2017 at 3:31 PM, Nicolas Malin mailto:nicolas.ma...@nereide.fr>> wrote:

 Hello, I want just sharing a small improvement realized  yesterday.

 During a travel, I was bored on the train I tried to replace the
 old ftl FindGeneric screen to display and search all entity by an
 xml form with auto-attribute-entity.

 The main problem came from it's impossible to create a xml file
 with use dynamiclay an entityName for the element
  (for cache/performance reason) so I tried to
 generate on the fly by groovy the xml flow, and call without cache
 the rendering, like this :
 *
 String dynamicAutoEntityFieldForm = 'http://www.w3.org/2001/XMLSchema-instance";
 
 xmlns="http://ofbiz.apache.org/Widget-Form";
 
 xsi:schemaLocation="http://ofbiz.apache.org/Widget-Form
 http://ofbiz.apache.org/dtds/widget-form.xsd";
 >'


 '' +
 '' +
 '' +
 '' +
 '' +
 ''
 Document dynamicAutoEntityFieldFormXml =
 UtilXml.readXmlDocument(dynamicAutoEntityFieldForm, true, true)
 [...]
 dynamicAutoEntitySearchFormRenderer.render(writer, context)
 
 and on the ftl
 
 ${dynamicAutoEntitySearchForm?string}
 
 I realized this on the search and list form so now I can use
 complex search operator and the performFind for all entity. What
 do you thinks about that ?

 I will open an issue.

 Nicolas


 -- logoNrd 
 Nicolas Malin
 The apache way  : *Openness* Technical
 decisions are made publicly
 informat...@nereide.fr 
 8 rue des Déportés 37000 TOURS, 02 47 50 30 54

 Apache OFBiz |The Apache Way
 |ofbiz-fr
 |réseau LE

Re: Improve FindGeneric on webtools

2017-02-17 Thread Taher Alkhateeb 
Great initiative Nicolas.

I remember once trying to extend the functionality of performFind but it
contained so much logic that I couldn't reuse it in any reasonable way. The
entire implementation of find services needs heavy refactoring or
replacement because it tries to do everything (searching, parsing,
paginating, displaying, validating). It's just one big monster

I would recommend instead of creating new services, trying to replace the
existing ones (if possible and you go the energy). I think we need multiple
separate components (parser, renderer, paginator, searcher, etc ...). It
would be really great to have small specialized classes or groovy scripts
that split the responsibility instead of this painful implementation we
have at the moment.

On Fri, Feb 17, 2017 at 11:04 AM, Nicolas Malin 
wrote:

> I opened the issue https://issues.apache.org/jira/browse/OFBIZ-9217
>
> It's not finish yet but already usefull ;)
>
> Nicolas
>
> Le 17/02/2017 à 06:24, Rishi Solanki a écrit :
>
>> +1
>>
>>
>> On Thu, Feb 16, 2017 at 3:31 PM, Nicolas Malin > > wrote:
>>
>> Hello, I want just sharing a small improvement realized  yesterday.
>>
>> During a travel, I was bored on the train I tried to replace the
>> old ftl FindGeneric screen to display and search all entity by an
>> xml form with auto-attribute-entity.
>>
>> The main problem came from it's impossible to create a xml file
>> with use dynamiclay an entityName for the element
>>  (for cache/performance reason) so I tried to
>> generate on the fly by groovy the xml flow, and call without cache
>> the rendering, like this :
>> *
>> String dynamicAutoEntityFieldForm = '> encoding="UTF-8"?>> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>> 
>> xmlns="http://ofbiz.apache.org/Widget-Form";
>> 
>> xsi:schemaLocation="http://ofbiz.apache.org/Widget-Form
>> http://ofbiz.apache.org/dtds/widget-form.xsd";
>> > dtds/widget-form.xsd>>'
>>
>>
>> '> target="FindGeneric">' +
>> '> default-field-type="find"/>' +
>> '' +
>> '' +
>> '> "FormFieldTitle_searchButton", locale) + '">' +
>> ''
>> Document dynamicAutoEntityFieldFormXml =
>> UtilXml.readXmlDocument(dynamicAutoEntityFieldForm, true, true)
>> [...]
>> dynamicAutoEntitySearchFormRenderer.render(writer, context)
>> 
>> and on the ftl
>> 
>> ${dynamicAutoEntitySearchForm?string}
>> 
>> I realized this on the search and list form so now I can use
>> complex search operator and the performFind for all entity. What
>> do you thinks about that ?
>>
>> I will open an issue.
>>
>> Nicolas
>>
>>
>> -- logoNrd 
>> Nicolas Malin
>> The apache way  : *Openness* Technical
>> decisions are made publicly
>> informat...@nereide.fr 
>> 8 rue des Déportés 37000 TOURS, 02 47 50 30 54
>>
>> Apache OFBiz |The Apache Way
>> |ofbiz-fr
>> |réseau LE
>> 
>>
>>
>>
>

Re: Improve FindGeneric on webtools

2017-02-17 Thread Nicolas Malin 

I opened the issue https://issues.apache.org/jira/browse/OFBIZ-9217

It's not finish yet but already usefull ;)

Nicolas

Le 17/02/2017 à 06:24, Rishi Solanki a écrit :

+1


On Thu, Feb 16, 2017 at 3:31 PM, Nicolas Malin 
mailto:nicolas.ma...@nereide.fr>> wrote:


Hello, I want just sharing a small improvement realized  yesterday.

During a travel, I was bored on the train I tried to replace the
old ftl FindGeneric screen to display and search all entity by an
xml form with auto-attribute-entity.

The main problem came from it's impossible to create a xml file
with use dynamiclay an entityName for the element
 (for cache/performance reason) so I tried to
generate on the fly by groovy the xml flow, and call without cache
the rendering, like this :
*
String dynamicAutoEntityFieldForm = 'http://www.w3.org/2001/XMLSchema-instance";

xmlns="http://ofbiz.apache.org/Widget-Form";

xsi:schemaLocation="http://ofbiz.apache.org/Widget-Form
http://ofbiz.apache.org/dtds/widget-form.xsd";

>'

'' +
'' +
'' +
'' +
'' +
''
Document dynamicAutoEntityFieldFormXml =
UtilXml.readXmlDocument(dynamicAutoEntityFieldForm, true, true)
[...]
dynamicAutoEntitySearchFormRenderer.render(writer, context)

and on the ftl

${dynamicAutoEntitySearchForm?string}

I realized this on the search and list form so now I can use
complex search operator and the performFind for all entity. What
do you thinks about that ?

I will open an issue.

Nicolas


-- 
logoNrd 

Nicolas Malin
The apache way  : *Openness* Technical
decisions are made publicly
informat...@nereide.fr 
8 rue des Déportés 37000 TOURS, 02 47 50 30 54

Apache OFBiz |The Apache Way
|ofbiz-fr
|réseau LE