Re: [VOTE] [RELEASE] Apache OFBiz 16.11.03 - second attempt

[Aditya Sharma]

+1

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P, India - 452010
Cell phone: +91 7415786147





HotWax Systems recently received 8 mentions in *The Gartner Digital
Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
research and advisory company. Learn more about our research here

.



On Thu, Jun 22, 2017 at 10:13 AM, Swapnil Mane <
swapnil.m...@hotwaxsystems.com> wrote:

> +1
>
>
> - Best Regards,
> Swapnil
>
> On Wed, Jun 21, 2017 at 7:11 PM, Jacopo Cappellato <
> jacopo.cappell...@hotwaxsystems.com> wrote:
>
> > This is the vote thread for the second attempt to release a new bug fix
> > release for the release16.11 branch. This new release, "Apache OFBiz
> > 16.11.03" will supersede the recently published 16.11.02 release that was
> > affected by a major bug (OFBIZ-9410).
> >
> > The release files can be downloaded from here:
> >
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> >
> > and are:
> >
> > * apache-ofbiz-16.11.03.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-16.11.03.zip.asc: the detached signature file
> > * apache-ofbiz-16.11.03.zip.md5, apache-ofbiz-16.11.03.zip.sha: hashes
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see http://www.apache.org/info/
> verification.html
> > ).
> >
> > Vote:
> >
> > [ +1] release as Apache OFBiz 16.11.03
> > [ -1] do not release
> >
> > This vote will be open for at least 5 days, unless it is cancelled
> before.
> >
> > For more details about this process please refer to:
> > http://www.apache.org/
> > foundation/voting.html
> >
>

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.03 - second attempt

[Swapnil Mane]

+1


- Best Regards,
Swapnil

On Wed, Jun 21, 2017 at 7:11 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

> This is the vote thread for the second attempt to release a new bug fix
> release for the release16.11 branch. This new release, "Apache OFBiz
> 16.11.03" will supersede the recently published 16.11.02 release that was
> affected by a major bug (OFBIZ-9410).
>
> The release files can be downloaded from here:
>
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
>
> * apache-ofbiz-16.11.03.zip
> * KEYS: text file with keys
> * apache-ofbiz-16.11.03.zip.asc: the detached signature file
> * apache-ofbiz-16.11.03.zip.md5, apache-ofbiz-16.11.03.zip.sha: hashes
>
> Please download and test the zip file and its signatures (for instructions
> on testing the signatures see http://www.apache.org/info/verification.html
> ).
>
> Vote:
>
> [ +1] release as Apache OFBiz 16.11.03
> [ -1] do not release
>
> This vote will be open for at least 5 days, unless it is cancelled before.
>
> For more details about this process please refer to:
> http://www.apache.org/
> foundation/voting.html
>

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.03 - second attempt

[Taher Alkhateeb]

Tests running, Basic smoke tests reveal nothing from my side.

+1

On Wed, Jun 21, 2017 at 9:45 PM, Deepak Dixit <
deepak.di...@hotwaxsystems.com> wrote:

> +1
>
> Thanks & Regards
> --
> Deepak Dixit
>
> On Wednesday, June 21, 2017, Michael Brohl 
> wrote:
>
> > +1
> >
> > ===
> >
> > mbrohl$ ~/Projects/apache-ofbiz/ofbiz-tools/verify-ofbiz-release.sh
> > apache-ofbiz-16.11.03.zip
> > md5 check of file: apache-ofbiz-16.11.03.zip
> > Using md5 file: apache-ofbiz-16.11.03.zip.md5
> > apache-ofbiz-16.11.03.zip: 05 77 C8 C4 1A 00 BE DC 8B 00 58 AE A0 93 70
> 12
> > apache-ofbiz-16.11.03.zip: 05 77 C8 C4 1A 00 BE DC 8B 00 58 AE A0 93 70
> 12
> > md5 checksum OK
> >
> > sha check of file: apache-ofbiz-16.11.03.zip
> > Using sha file: apache-ofbiz-16.11.03.zip.sha
> > apache-ofbiz-16.11.03.zip: 089B9D51 96D5DC57 CC778522 084FE4E2 5AD8AAD7
> > 34B05ED9 1C3EF965 42E90DFF 0FF6CC95 D8BD64DC 64FCB97C BB42B96F A1C9C4D4
> > E15D3E3F 1FFF54C9 05ED57B1
> > apache-ofbiz-16.11.03.zip: 089B9D51 96D5DC57 CC778522 084FE4E2 5AD8AAD7
> > 34B05ED9 1C3EF965 42E90DFF 0FF6CC95 D8BD64DC 64FCB97C BB42B96F A1C9C4D4
> > E15D3E3F 1FFF54C9 05ED57B1
> > sha checksum OK
> >
> > GPG verification output
> > gpg: Signatur vom Mi 21 Jun 15:53:36 2017 CEST mittels RSA-Schlüssel ID
> > 847AF9E0
> > gpg: Korrekte Signatur von "Jacopo Cappellato (CODE SIGNING KEY) <
> > jaco...@apache.org>" [uneingeschränkt]
> >
> > ./gradlew loadDefault testIntegration -> BUILD SUCCESSFUL
> >
> > All tests pass.
> >
> > ===
> >
> >
> > Thanks and regards,
> >
> > Michael Brohl
> > ecomify GmbH
> > www.ecomify.de
> >
> >
> > Am 21.06.17 um 15:41 schrieb Jacopo Cappellato:
> >
> >> This is the vote thread for the second attempt to release a new bug fix
> >> release for the release16.11 branch. This new release, "Apache OFBiz
> >> 16.11.03" will supersede the recently published 16.11.02 release that
> was
> >> affected by a major bug (OFBIZ-9410).
> >>
> >> The release files can be downloaded from here:
> >>
> >> https://dist.apache.org/repos/dist/dev/ofbiz/
> >>
> >> and are:
> >>
> >> * apache-ofbiz-16.11.03.zip
> >> * KEYS: text file with keys
> >> * apache-ofbiz-16.11.03.zip.asc: the detached signature file
> >> * apache-ofbiz-16.11.03.zip.md5, apache-ofbiz-16.11.03.zip.sha: hashes
> >>
> >> Please download and test the zip file and its signatures (for
> instructions
> >> on testing the signatures see http://www.apache.org/info/ver
> >> ification.html).
> >>
> >> Vote:
> >>
> >> [ +1] release as Apache OFBiz 16.11.03
> >> [ -1] do not release
> >>
> >> This vote will be open for at least 5 days, unless it is cancelled
> before.
> >>
> >> For more details about this process please refer to:
> >> http://www.apache.org/
> >> foundation/voting.html
> >>
> >>
> >
> >
>
> --
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.03 - second attempt

[Deepak Dixit]

+1

Thanks & Regards
--
Deepak Dixit

On Wednesday, June 21, 2017, Michael Brohl  wrote:

> +1
>
> ===
>
> mbrohl$ ~/Projects/apache-ofbiz/ofbiz-tools/verify-ofbiz-release.sh
> apache-ofbiz-16.11.03.zip
> md5 check of file: apache-ofbiz-16.11.03.zip
> Using md5 file: apache-ofbiz-16.11.03.zip.md5
> apache-ofbiz-16.11.03.zip: 05 77 C8 C4 1A 00 BE DC 8B 00 58 AE A0 93 70 12
> apache-ofbiz-16.11.03.zip: 05 77 C8 C4 1A 00 BE DC 8B 00 58 AE A0 93 70 12
> md5 checksum OK
>
> sha check of file: apache-ofbiz-16.11.03.zip
> Using sha file: apache-ofbiz-16.11.03.zip.sha
> apache-ofbiz-16.11.03.zip: 089B9D51 96D5DC57 CC778522 084FE4E2 5AD8AAD7
> 34B05ED9 1C3EF965 42E90DFF 0FF6CC95 D8BD64DC 64FCB97C BB42B96F A1C9C4D4
> E15D3E3F 1FFF54C9 05ED57B1
> apache-ofbiz-16.11.03.zip: 089B9D51 96D5DC57 CC778522 084FE4E2 5AD8AAD7
> 34B05ED9 1C3EF965 42E90DFF 0FF6CC95 D8BD64DC 64FCB97C BB42B96F A1C9C4D4
> E15D3E3F 1FFF54C9 05ED57B1
> sha checksum OK
>
> GPG verification output
> gpg: Signatur vom Mi 21 Jun 15:53:36 2017 CEST mittels RSA-Schlüssel ID
> 847AF9E0
> gpg: Korrekte Signatur von "Jacopo Cappellato (CODE SIGNING KEY) <
> jaco...@apache.org>" [uneingeschränkt]
>
> ./gradlew loadDefault testIntegration -> BUILD SUCCESSFUL
>
> All tests pass.
>
> ===
>
>
> Thanks and regards,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>
>
> Am 21.06.17 um 15:41 schrieb Jacopo Cappellato:
>
>> This is the vote thread for the second attempt to release a new bug fix
>> release for the release16.11 branch. This new release, "Apache OFBiz
>> 16.11.03" will supersede the recently published 16.11.02 release that was
>> affected by a major bug (OFBIZ-9410).
>>
>> The release files can be downloaded from here:
>>
>> https://dist.apache.org/repos/dist/dev/ofbiz/
>>
>> and are:
>>
>> * apache-ofbiz-16.11.03.zip
>> * KEYS: text file with keys
>> * apache-ofbiz-16.11.03.zip.asc: the detached signature file
>> * apache-ofbiz-16.11.03.zip.md5, apache-ofbiz-16.11.03.zip.sha: hashes
>>
>> Please download and test the zip file and its signatures (for instructions
>> on testing the signatures see http://www.apache.org/info/ver
>> ification.html).
>>
>> Vote:
>>
>> [ +1] release as Apache OFBiz 16.11.03
>> [ -1] do not release
>>
>> This vote will be open for at least 5 days, unless it is cancelled before.
>>
>> For more details about this process please refer to:
>> http://www.apache.org/
>> foundation/voting.html
>>
>>
>
>

-- 
Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.03 - second attempt

[Michael Brohl]

+1

===

mbrohl$ ~/Projects/apache-ofbiz/ofbiz-tools/verify-ofbiz-release.sh 
apache-ofbiz-16.11.03.zip

md5 check of file: apache-ofbiz-16.11.03.zip
Using md5 file: apache-ofbiz-16.11.03.zip.md5
apache-ofbiz-16.11.03.zip: 05 77 C8 C4 1A 00 BE DC 8B 00 58 AE A0 93 70 12
apache-ofbiz-16.11.03.zip: 05 77 C8 C4 1A 00 BE DC 8B 00 58 AE A0 93 70 12
md5 checksum OK

sha check of file: apache-ofbiz-16.11.03.zip
Using sha file: apache-ofbiz-16.11.03.zip.sha
apache-ofbiz-16.11.03.zip: 089B9D51 96D5DC57 CC778522 084FE4E2 5AD8AAD7 
34B05ED9 1C3EF965 42E90DFF 0FF6CC95 D8BD64DC 64FCB97C BB42B96F A1C9C4D4 
E15D3E3F 1FFF54C9 05ED57B1
apache-ofbiz-16.11.03.zip: 089B9D51 96D5DC57 CC778522 084FE4E2 5AD8AAD7 
34B05ED9 1C3EF965 42E90DFF 0FF6CC95 D8BD64DC 64FCB97C BB42B96F A1C9C4D4 
E15D3E3F 1FFF54C9 05ED57B1

sha checksum OK

GPG verification output
gpg: Signatur vom Mi 21 Jun 15:53:36 2017 CEST mittels RSA-Schlüssel ID 
847AF9E0
gpg: Korrekte Signatur von "Jacopo Cappellato (CODE SIGNING KEY) 
" [uneingeschränkt]


./gradlew loadDefault testIntegration -> BUILD SUCCESSFUL

All tests pass.

===


Thanks and regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 21.06.17 um 15:41 schrieb Jacopo Cappellato:

This is the vote thread for the second attempt to release a new bug fix
release for the release16.11 branch. This new release, "Apache OFBiz
16.11.03" will supersede the recently published 16.11.02 release that was
affected by a major bug (OFBIZ-9410).

The release files can be downloaded from here:

https://dist.apache.org/repos/dist/dev/ofbiz/

and are:

* apache-ofbiz-16.11.03.zip
* KEYS: text file with keys
* apache-ofbiz-16.11.03.zip.asc: the detached signature file
* apache-ofbiz-16.11.03.zip.md5, apache-ofbiz-16.11.03.zip.sha: hashes

Please download and test the zip file and its signatures (for instructions
on testing the signatures see http://www.apache.org/info/verification.html).

Vote:

[ +1] release as Apache OFBiz 16.11.03
[ -1] do not release

This vote will be open for at least 5 days, unless it is cancelled before.

For more details about this process please refer to: http://www.apache.org/
foundation/voting.html






smime.p7s
Description: S/MIME Cryptographic Signature

Re: Release file check script Re: svn commit: r1799436 - /ofbiz/tools/verify-ofbiz-release.sh

[Jacopo Cappellato]

Thank you Michael,

I have created the new release files and started the second vote so now we
will all have a chance to use your script!

Jacopo

On Wed, Jun 21, 2017 at 3:00 PM, Michael Brohl 
wrote:

> Hi everyone,
>
> I've added a convenience bash script to check the release files checksums
> and gpg signature to the tools repository.
>
> Hope this makes life easier :-)
>
> Best regards,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>
>
> Am 21.06.17 um 14:55 schrieb mbr...@apache.org:
>
>> Author: mbrohl
>> Date: Wed Jun 21 12:55:02 2017
>> New Revision: 1799436
>>
>> URL: http://svn.apache.org/viewvc?rev=1799436&view=rev
>> Log:
>> Improved: Added a bash script to verify the release file, checking
>> md5/sha checksums and the signature.
>>
>> Added:
>>  ofbiz/tools/verify-ofbiz-release.sh   (with props)
>>
>> Added: ofbiz/tools/verify-ofbiz-release.sh
>> URL: http://svn.apache.org/viewvc/ofbiz/tools/verify-ofbiz-releas
>> e.sh?rev=1799436&view=auto
>> 
>> ==
>> --- ofbiz/tools/verify-ofbiz-release.sh (added)
>> +++ ofbiz/tools/verify-ofbiz-release.sh Wed Jun 21 12:55:02 2017
>> @@ -0,0 +1,79 @@
>> +#!/bin/bash
>> +
>> +# verify-ofbiz-release.sh
>> +# checks the given release zip file for correct md5/SHA checksums and
>> signing certificate
>> +# see https://www.apache.org/dev/release-signing.html
>> +
>> +# color definitions for output
>> +RED='\033[0;31m'
>> +GRN='\033[0;32m'
>> +NC='\033[0m' # No Color
>> +
>> +if [[ $# -eq 0 ]] ; then
>> +echo "Usage: $0 [apache-ofbiz-xx.xx.xx.zip]"
>> +exit 1
>> +fi
>> +
>> +checkMD5() {
>> +file1=`gpg --print-md MD5 $1`
>> +file2=`cut -d* -f1 $1.md5`
>> +
>> +echo "md5 check of file: $1"
>> +echo "Using md5 file: $1.md5"
>> +echo $file1
>> +echo $file2
>> +
>> +if [ "$file1" != "$file2" ]
>> +then
>> +echo -e "${RED}md5 sums mismatch!${NC}"
>> +else
>> +echo -e "${GRN}md5 checksum OK${NC}"
>> +fi
>> +
>> +echo ""
>> +
>> +return 0
>> +}
>> +
>> +checkSHA () {
>> +file1=`gpg --print-md SHA512 $1`
>> +file2=`cut -d* -f1 $1.sha`
>> +
>> +echo "sha check of file: $1"
>> +echo "Using sha file: $1.sha"
>> +echo $file1
>> +echo $file2
>> +
>> +if [ "$file1" != "$file2" ]
>> +then
>> +echo -e "${RED}sha sums mismatch!${NC}"
>> +else
>> +echo -e "${GRN}sha checksum OK${NC}"
>> +fi
>> +
>> +echo ""
>> +
>> +return 0
>> +}
>> +
>> +if [ ! -f $1.md5 ];
>> +then
>> +echo -e "${RED}skipping md5 check!${NC} (md5 checksum file $1.md5
>> not found)\n"
>> +else
>> +checkMD5 $1
>> +fi
>> +
>> +if [ ! -f $1.sha ];
>> +then
>> +echo -e "${RED}skipping sha check!${NC} (sha checksum file $1.sha
>> not found)\n"
>> +else
>> +checkSHA $1
>> +fi
>> +
>> +if [ ! -f $1.asc ];
>> +then
>> +echo -e "${RED}skipping signature check!${NC} (signature file $1.asc
>> not found)"
>> +else
>> +echo "GPG verification output"
>> +gpg --verify $1.asc $1
>> +fi
>>
>> Propchange: ofbiz/tools/verify-ofbiz-release.sh
>> 
>> --
>>  svn:eol-style = native
>>
>> Propchange: ofbiz/tools/verify-ofbiz-release.sh
>> 
>> --
>>  svn:executable = *
>>
>> Propchange: ofbiz/tools/verify-ofbiz-release.sh
>> 
>> --
>>  svn:keywords = Date Rev Author URL Id
>>
>> Propchange: ofbiz/tools/verify-ofbiz-release.sh
>> 
>> --
>>  svn:mime-type = text/plain
>>
>>
>>
>
>

[VOTE] [RELEASE] Apache OFBiz 16.11.03 - second attempt

[Jacopo Cappellato]

This is the vote thread for the second attempt to release a new bug fix
release for the release16.11 branch. This new release, "Apache OFBiz
16.11.03" will supersede the recently published 16.11.02 release that was
affected by a major bug (OFBIZ-9410).

The release files can be downloaded from here:

https://dist.apache.org/repos/dist/dev/ofbiz/

and are:

* apache-ofbiz-16.11.03.zip
* KEYS: text file with keys
* apache-ofbiz-16.11.03.zip.asc: the detached signature file
* apache-ofbiz-16.11.03.zip.md5, apache-ofbiz-16.11.03.zip.sha: hashes

Please download and test the zip file and its signatures (for instructions
on testing the signatures see http://www.apache.org/info/verification.html).

Vote:

[ +1] release as Apache OFBiz 16.11.03
[ -1] do not release

This vote will be open for at least 5 days, unless it is cancelled before.

For more details about this process please refer to: http://www.apache.org/
foundation/voting.html

Release file check script Re: svn commit: r1799436 - /ofbiz/tools/verify-ofbiz-release.sh

[Michael Brohl]

Hi everyone,

I've added a convenience bash script to check the release files 
checksums and gpg signature to the tools repository.


Hope this makes life easier :-)

Best regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 21.06.17 um 14:55 schrieb mbr...@apache.org:

Author: mbrohl
Date: Wed Jun 21 12:55:02 2017
New Revision: 1799436

URL: http://svn.apache.org/viewvc?rev=1799436&view=rev
Log:
Improved: Added a bash script to verify the release file, checking md5/sha 
checksums and the signature.

Added:
 ofbiz/tools/verify-ofbiz-release.sh   (with props)

Added: ofbiz/tools/verify-ofbiz-release.sh
URL: 
http://svn.apache.org/viewvc/ofbiz/tools/verify-ofbiz-release.sh?rev=1799436&view=auto
==
--- ofbiz/tools/verify-ofbiz-release.sh (added)
+++ ofbiz/tools/verify-ofbiz-release.sh Wed Jun 21 12:55:02 2017
@@ -0,0 +1,79 @@
+#!/bin/bash
+
+# verify-ofbiz-release.sh
+# checks the given release zip file for correct md5/SHA checksums and signing 
certificate
+# see https://www.apache.org/dev/release-signing.html
+
+# color definitions for output
+RED='\033[0;31m'
+GRN='\033[0;32m'
+NC='\033[0m' # No Color
+
+if [[ $# -eq 0 ]] ; then
+echo "Usage: $0 [apache-ofbiz-xx.xx.xx.zip]"
+exit 1
+fi
+
+checkMD5() {
+file1=`gpg --print-md MD5 $1`
+file2=`cut -d* -f1 $1.md5`
+
+echo "md5 check of file: $1"
+echo "Using md5 file: $1.md5"
+echo $file1
+echo $file2
+
+if [ "$file1" != "$file2" ]
+then
+echo -e "${RED}md5 sums mismatch!${NC}"
+else
+echo -e "${GRN}md5 checksum OK${NC}"
+fi
+
+echo ""
+
+return 0
+}
+
+checkSHA () {
+file1=`gpg --print-md SHA512 $1`
+file2=`cut -d* -f1 $1.sha`
+
+echo "sha check of file: $1"
+echo "Using sha file: $1.sha"
+echo $file1
+echo $file2
+
+if [ "$file1" != "$file2" ]
+then
+echo -e "${RED}sha sums mismatch!${NC}"
+else
+echo -e "${GRN}sha checksum OK${NC}"
+fi
+
+echo ""
+
+return 0
+}
+
+if [ ! -f $1.md5 ];
+then
+echo -e "${RED}skipping md5 check!${NC} (md5 checksum file $1.md5 not 
found)\n"
+else
+checkMD5 $1
+fi
+
+if [ ! -f $1.sha ];
+then
+echo -e "${RED}skipping sha check!${NC} (sha checksum file $1.sha not 
found)\n"
+else
+checkSHA $1
+fi
+
+if [ ! -f $1.asc ];
+then
+echo -e "${RED}skipping signature check!${NC} (signature file $1.asc not 
found)"
+else
+echo "GPG verification output"
+gpg --verify $1.asc $1
+fi

Propchange: ofbiz/tools/verify-ofbiz-release.sh
--
 svn:eol-style = native

Propchange: ofbiz/tools/verify-ofbiz-release.sh
--
 svn:executable = *

Propchange: ofbiz/tools/verify-ofbiz-release.sh
--
 svn:keywords = Date Rev Author URL Id

Propchange: ofbiz/tools/verify-ofbiz-release.sh
--
 svn:mime-type = text/plain







smime.p7s
Description: S/MIME Cryptographic Signature

Re: Reducing excessive and improperly studied commits

[Michael Brohl]

+1

I agree, this matches my suggestions in [1].

[1] 
https://lists.apache.org/thread.html/1cc84ded035247ec439199ae0694d699fe1bcffb5d067c3ae732a0e9@%3Cdev.ofbiz.apache.org%3E


Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 21.06.17 um 12:37 schrieb Taher Alkhateeb:

Hello Everyone,

I am starting this thread because of the latest unexpected release thread
[1] due to a major bug introduced by Jacques Le Roux in [2].

We had multiple discussion with Jacques, one such discussion [3] was due to
a bad commit in which I made a recommendation to stop doing bulk commits
and focus instead on slowly refactoring code and Jacopo mentioned in the
same thread that before doing bulk try-with-resources to start a new thread
and discuss this issue.

We faced multiple quality issues from improper commits. One such issue was
with respect to improperly closing streams [4] in which both Jacopo and
myself asked Jacques to revert and get a better understanding of how
streams work. Other discussions occured around committing quickly without
testing and hence crashing the system in [5] and [6].

Jacques continues with his stream of commits [7] and we continue to witness
some negative consequences accordingly. I'm not even sure we caught all
problems yet.

I think avoiding improperly studied, rushed or bulk commits is important
because such commits are:
- Requireing a lot of time from reviewers
- Difficult to review
- Lowering code quality

It is therefore my recommendation to agree as a community on reducing such
commits and to ask Jacques and other committers to follow the
review-then-commit process for large / complex commits.

WDYT?

[1] https://s.apache.org/clpW
[2] https://issues.apache.org/jira/browse/OFBIZ-9410
[3] https://s.apache.org/8Wq3
[4] https://s.apache.org/DpvM
[5] https://s.apache.org/IN2U
[6] https://s.apache.org/c8GG
[7] r1798571 r1798566 r1798353 r1797792 r1797791 r1797790 r1797744 r1797743
r1797742 r1797373 r1797356 r1797222 r1797161 r1797160 r1797159 r1797158
r1797155 r1797097 r1797079 r1797074 r1789045 r1788065 r1787949 r1761047
r1761045 r1761023 r1759944 r1759088 r1759082 r1758951






smime.p7s
Description: S/MIME Cryptographic Signature

Reducing excessive and improperly studied commits

[Taher Alkhateeb]

Hello Everyone,

I am starting this thread because of the latest unexpected release thread
[1] due to a major bug introduced by Jacques Le Roux in [2].

We had multiple discussion with Jacques, one such discussion [3] was due to
a bad commit in which I made a recommendation to stop doing bulk commits
and focus instead on slowly refactoring code and Jacopo mentioned in the
same thread that before doing bulk try-with-resources to start a new thread
and discuss this issue.

We faced multiple quality issues from improper commits. One such issue was
with respect to improperly closing streams [4] in which both Jacopo and
myself asked Jacques to revert and get a better understanding of how
streams work. Other discussions occured around committing quickly without
testing and hence crashing the system in [5] and [6].

Jacques continues with his stream of commits [7] and we continue to witness
some negative consequences accordingly. I'm not even sure we caught all
problems yet.

I think avoiding improperly studied, rushed or bulk commits is important
because such commits are:
- Requireing a lot of time from reviewers
- Difficult to review
- Lowering code quality

It is therefore my recommendation to agree as a community on reducing such
commits and to ask Jacques and other committers to follow the
review-then-commit process for large / complex commits.

WDYT?

[1] https://s.apache.org/clpW
[2] https://issues.apache.org/jira/browse/OFBIZ-9410
[3] https://s.apache.org/8Wq3
[4] https://s.apache.org/DpvM
[5] https://s.apache.org/IN2U
[6] https://s.apache.org/c8GG
[7] r1798571 r1798566 r1798353 r1797792 r1797791 r1797790 r1797744 r1797743
r1797742 r1797373 r1797356 r1797222 r1797161 r1797160 r1797159 r1797158
r1797155 r1797097 r1797079 r1797074 r1789045 r1788065 r1787949 r1761047
r1761045 r1761023 r1759944 r1759088 r1759082 r1758951

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.03

[Michael Brohl]

Ah, sorry, did not see the cancel vote message.

Michael

Am 21.06.17 um 12:25 schrieb Michael Brohl:

+1

md5/sha hashes OK

gpg signature OK

./gradle loadDefault testIntegration -> BUILD SUCCESSFUL

Thanks Jacopo,

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 21.06.17 um 09:42 schrieb Jacopo Cappellato:

This is the vote thread to release a new bug fix release for the
release16.11 branch. This new release, "Apache OFBiz 16.11.03" will
supersede the recently published 16.11.02 release that was affected by a
major bug (OFBIZ-9410).

The release files can be downloaded from here:

https://dist.apache.org/repos/dist/dev/ofbiz/

and are:

* apache-ofbiz-16.11.03.zip
* KEYS: text file with keys
* apache-ofbiz-16.11.03.zip.asc: the detached signature file
* apache-ofbiz-16.11.03.zip.md5, apache-ofbiz-16.11.03.zip.sha: hashes

Please download and test the zip file and its signatures (for 
instructions
on testing the signatures see 
http://www.apache.org/info/verification.html).


Vote:

[ +1] release as Apache OFBiz 16.11.03
[ -1] do not release

This vote will be open for at least 5 days, unless it is cancelled 
before.


For more details about this process please refer to:
http://www.apache.org/foundation/voting.html









smime.p7s
Description: S/MIME Cryptographic Signature

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.03

[Deepak Dixit]

+1

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Wed, Jun 21, 2017 at 3:55 PM, Michael Brohl 
wrote:

> +1
>
> md5/sha hashes OK
>
> gpg signature OK
>
> ./gradle loadDefault testIntegration -> BUILD SUCCESSFUL
>
> Thanks Jacopo,
>
> Regards,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>
>
> Am 21.06.17 um 09:42 schrieb Jacopo Cappellato:
>
> This is the vote thread to release a new bug fix release for the
>> release16.11 branch. This new release, "Apache OFBiz 16.11.03" will
>> supersede the recently published 16.11.02 release that was affected by a
>> major bug (OFBIZ-9410).
>>
>> The release files can be downloaded from here:
>>
>> https://dist.apache.org/repos/dist/dev/ofbiz/
>>
>> and are:
>>
>> * apache-ofbiz-16.11.03.zip
>> * KEYS: text file with keys
>> * apache-ofbiz-16.11.03.zip.asc: the detached signature file
>> * apache-ofbiz-16.11.03.zip.md5, apache-ofbiz-16.11.03.zip.sha: hashes
>>
>> Please download and test the zip file and its signatures (for instructions
>> on testing the signatures see http://www.apache.org/info/ver
>> ification.html).
>>
>> Vote:
>>
>> [ +1] release as Apache OFBiz 16.11.03
>> [ -1] do not release
>>
>> This vote will be open for at least 5 days, unless it is cancelled before.
>>
>> For more details about this process please refer to:
>> http://www.apache.org/foundation/voting.html
>>
>>
>
>

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.03

[Michael Brohl]

+1

md5/sha hashes OK

gpg signature OK

./gradle loadDefault testIntegration -> BUILD SUCCESSFUL

Thanks Jacopo,

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 21.06.17 um 09:42 schrieb Jacopo Cappellato:

This is the vote thread to release a new bug fix release for the
release16.11 branch. This new release, "Apache OFBiz 16.11.03" will
supersede the recently published 16.11.02 release that was affected by a
major bug (OFBIZ-9410).

The release files can be downloaded from here:

https://dist.apache.org/repos/dist/dev/ofbiz/

and are:

* apache-ofbiz-16.11.03.zip
* KEYS: text file with keys
* apache-ofbiz-16.11.03.zip.asc: the detached signature file
* apache-ofbiz-16.11.03.zip.md5, apache-ofbiz-16.11.03.zip.sha: hashes

Please download and test the zip file and its signatures (for instructions
on testing the signatures see http://www.apache.org/info/verification.html).

Vote:

[ +1] release as Apache OFBiz 16.11.03
[ -1] do not release

This vote will be open for at least 5 days, unless it is cancelled before.

For more details about this process please refer to:
http://www.apache.org/foundation/voting.html






smime.p7s
Description: S/MIME Cryptographic Signature

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.03

[Jacopo Cappellato]

since no one has voted yet, I would like to cancel this vote and restart a
new one to include the fix with rev. 1799419
At least we will have a bit more to add to the release notes of 16.11.03

Jacopo

On Wed, Jun 21, 2017 at 9:42 AM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

> This is the vote thread to release a new bug fix release for the
> release16.11 branch. This new release, "Apache OFBiz 16.11.03" will
> supersede the recently published 16.11.02 release that was affected by a
> major bug (OFBIZ-9410).
>
> The release files can be downloaded from here:
>
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
>
> * apache-ofbiz-16.11.03.zip
> * KEYS: text file with keys
> * apache-ofbiz-16.11.03.zip.asc: the detached signature file
> * apache-ofbiz-16.11.03.zip.md5, apache-ofbiz-16.11.03.zip.sha: hashes
>
> Please download and test the zip file and its signatures (for instructions
> on testing the signatures see http://www.apache.org/info/verification.html
> ).
>
> Vote:
>
> [ +1] release as Apache OFBiz 16.11.03
> [ -1] do not release
>
> This vote will be open for at least 5 days, unless it is cancelled before.
>
> For more details about this process please refer to:
> http://www.apache.org/foundation/voting.html
>

buildbot failure in on ofbiz-branch16

[buildbot]

The Buildbot has detected a new failure on builder ofbiz-branch16 while 
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-branch16/builds/68

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz16-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/branches/release16.11] 1799419
Blamelist: jacopoc

BUILD FAILED: failed shell_2

Sincerely,
 -The Buildbot

[VOTE] [RELEASE] Apache OFBiz 16.11.03

[Jacopo Cappellato]

This is the vote thread to release a new bug fix release for the
release16.11 branch. This new release, "Apache OFBiz 16.11.03" will
supersede the recently published 16.11.02 release that was affected by a
major bug (OFBIZ-9410).

The release files can be downloaded from here:

https://dist.apache.org/repos/dist/dev/ofbiz/

and are:

* apache-ofbiz-16.11.03.zip
* KEYS: text file with keys
* apache-ofbiz-16.11.03.zip.asc: the detached signature file
* apache-ofbiz-16.11.03.zip.md5, apache-ofbiz-16.11.03.zip.sha: hashes

Please download and test the zip file and its signatures (for instructions
on testing the signatures see http://www.apache.org/info/verification.html).

Vote:

[ +1] release as Apache OFBiz 16.11.03
[ -1] do not release

This vote will be open for at least 5 days, unless it is cancelled before.

For more details about this process please refer to:
http://www.apache.org/foundation/voting.html