*[image: Inline image 1]*Attn: *OFBiz Dev Mailing List*
Re: *Bitcoin Support*
Hi All,
Further to our discussion,
I am going to look at the code referred to.
- How can I contribute code??
- Can I simply do a pull request on https://github.com/apache/o
fbiz-framework ???
- Or do I
Thanks Scott, inline...
Le 05/09/2017 à 06:21, Scott Gray a écrit :
Definitely changes the behavior, but the behavior wasn't good before (and
still isn't good now). If we can't return an accurate order item sub-total
then we should be throwing an exception IMO.
This is often why we can't just
Yes thanks Michael,
I agree with Scott about rather throwing an exception
Jacques
Le 04/09/2017 à 21:28, Michael Brohl a écrit :
Hi Jacques,
I think directly returning the result inside the catch block changes the logic
of the code (the adjustments are not added).
Please have another look.
Definitely changes the behavior, but the behavior wasn't good before (and
still isn't good now). If we can't return an accurate order item sub-total
then we should be throwing an exception IMO.
This is often why we can't just bulk fix the issues reported by static
analysis tools, because the fix
I'll contribute a patch. Thanks.
--
Sent from: http://ofbiz.135035.n4.nabble.com/OFBiz-Dev-f165671.html
Hi Jacques,
I think directly returning the result inside the catch block changes the
logic of the code (the adjustments are not added).
Please have another look.
Thanks,
Michael
Am 04.09.17 um 17:12 schrieb jler...@apache.org:
Author: jleroux
Date: Mon Sep 4 15:12:23 2017
New Revision: 1
Hi Wai (I suppose :))
Do you want to contribute your changes? Else you can do that on your custom
project w/o needing to change in OOTB.
Jacques
Le 04/09/2017 à 15:01, bzb.of...@gmail.com a écrit :
I'm deriving from CommonEvents.java and creating a new method that calls CommonEvent.writeJSONt
I'm deriving from CommonEvents.java and creating a new method that calls
CommonEvent.writeJSONtoResponse(). Unfortunately,
CommonEvent.writeJSONtoResponse() is private. Hence, I could not
compile. I believe that methods that should not be accessible from other
classes should at least allow deri
Nice write-up Taher.
Yes, your thoughts are making sense to me. I would like to add one more
point from my side is, using DSL make learning curve steeper for the
newbies to the framework.
Thanks and Regards
--
Pritam Kute
On Mon, Sep 4, 2017 at 3:50 PM, Taher Alkhateeb
wrote:
> Hello everyone,
Before I open a Jira for that, please raise a hand if you know this problem is
somehow solved
Thanks
Jacques
Le 27/06/2010 à 11:00, Ravindra Mandre a écrit :
Yes , you are right but the problem is not of position, the problem is that
, when I use the tag then fields are arranged in the
way
Hello everyone,
I've been thinking for a few weeks about this topic, so I thought I'd
just share my thoughts here.
OFBiz has great DSL, it is a blessing, it makes things easier
OFBiz has great DSL, it is a curse, it makes things sloppy
I think OFBiz is unique and it's rare to find software proje
Thanks Jacques. I did know that :( .
On 4 September 2017 at 18:52, Jacques Le Roux
wrote:
> Hi Paul,
>
> I did not review yet, but by and large you should rather refer to
> ofbiz-framework
>
> https://github.com/apache/ofbiz-framework/blob/trunk/applica
> tions/product/src/main/java/org/apache/o
Hi Paul,
I did not review yet, but by and large you should rather refer to
ofbiz-framework
https://github.com/apache/ofbiz-framework/blob/trunk/applications/product/src/main/java/org/apache/ofbiz/shipment/packing/PackingSession.java#L132
;)
Jacques
Le 04/09/2017 à 08:58, Paul Foxworthy a éc
13 matches
Mail list logo
