Re: [Proposal] Support for more decimals in price fields

2017-10-03 Thread Vaibhav Jain
+1 Taher Vaibhav Jain Hotwax Systems, vaibhav.j...@hotwaxsystems.com On Tue, Oct 3, 2017 at 1:09 PM, Deepak Dixit wrote: > Looks good Taher. > > > On Sun, Oct 1, 2017 at 2:18 PM, Taher Alkhateeb < > slidingfilame...@gmail.com> > wrote: > > > So this is one area where I faced many problems in th

Re: Make usage of EntitySyncRemove configurable

2017-10-03 Thread Jacques Le Roux
Hi Chandan, Then indeed a new mechanism should be introduced to prevent this.saveEntitySyncRemoveInfo(value.getPrimaryKey()); in GenericDelegator.removeValue() It seems to me that this should be set in entityengine.xml by delegator. Or maybe even simpler with a general property. Jacques Le

Re: Make usage of EntitySyncRemove configurable

2017-10-03 Thread Chandan Khandelwal
Hi Jacques, cleanSyncRemoveInfo service will be used to clean/delete the EntitySyncRemove records of specific time interval. When any records are removed the primary key will be saved in the EntitySyncRemove entity's for syncing purpose, I am talking about to not create EntitySyncRemove records (

Re: [Site] OFBIZ-9665

2017-10-03 Thread Aditya Sharma
Interesting. Thanks Deepak for sharing that. +1 for having target="external" at all places as consistency is key to good user experience. Thanks and Regards, *Aditya Sharma* | Enterprise Software Engineer HotWax Systems

Re: [Site] OFBIZ-9665

2017-10-03 Thread Devanshu Vyas
Thanks Deepak, I looked for similar info, but was unable to find. And in the meantime, got to know about the Rel attribute, so I thought the intended code was rel rather than target='external'. Now, with the new information at hand, I think target="_blank" or target="external" both are correct. All

Re: [Site] OFBIZ-9665

2017-10-03 Thread Jacques Le Roux
Ha thanks Deepak, This is interesting (and surprising), so we should change ALL target="_blank" to target="external" rather for consistency sake If everybody agree I will do so Jacques Le 03/10/2017 à 10:18, Deepak Dixit a écrit : Hi Devanshu, I think target="external" is correct. https:/

Re: [Site] OFBIZ-9665

2017-10-03 Thread Deepak Dixit
Hi Devanshu, I think target="external" is correct. https://www.quackit.com/html/codes/html_open_link_in_new_window.cfm {info} Instead of calling your window _blank, you can give it a name of your choosing. Then all URLs will load in that same tab (as long as you use the same name). For example,

Re: [Site] OFBIZ-9665

2017-10-03 Thread Jacques Le Roux
Thanks Devanshu, It clarifies it all :) I'll change to rel="external" and add target="_blank" Jacques Le 03/10/2017 à 10:10, Devanshu Vyas a écrit : Hello, I agree with Jacques and Aditya, we should set all external links with target="_blank". I have also mentioned the same on the JIRA tick

Re: [Site] OFBIZ-9665

2017-10-03 Thread Devanshu Vyas
Hello, I agree with Jacques and Aditya, we should set all external links with target="_blank". I have also mentioned the same on the JIRA ticket . I think the intended use is rel="external", which was somehow written as target="external", refer: ht

Re: Make usage of EntitySyncRemove configurable

2017-10-03 Thread Jacques Le Roux
Ah, actually EntitySyncRemove is automatically used by the "Clear EntitySyncRemove Info" job which uses cleanSyncRemoveInfo Maybe you only need to deactivate this job? Jacques Le 01/10/2017 à 10:51, Jacques Le Roux a écrit : Hi Chandan, Could you give us more information please? In my mind

Re: [Proposal] Support for more decimals in price fields

2017-10-03 Thread Deepak Dixit
Looks good Taher. On Sun, Oct 1, 2017 at 2:18 PM, Taher Alkhateeb wrote: > So this is one area where I faced many problems in the past, with > units generally and money specifically. You could be surprised how > many times something like rounding and accuracy can end up being a > _big_ problem