Makes perfect sense, thanks so much for the input Scott.
I will do the suggested changes.
- Best Regards,
Swapnil M Mane,
ofbiz.apache.org
On Fri, Mar 15, 2019 at 5:36 AM Scott Gray
wrote:
> Hi Swapnil,
>
> A minor thing, but I wonder if it would be better to move this check
> underneath
Hi Swapnil,
A minor thing, but I wonder if it would be better to move this check
underneath node.getTextContent()? If we assume that most nodes will
contain text then it might be more efficient to do a null check after
retrieving nodeValue.
e.g.
Node node = (Node) obj;
String nodeValue =
Thanks Deepak!
Le 14/03/2019 à 10:38, Deepak Dixit a écrit :
Done, Committed slightly modified version of the suggested patch.
Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org
On Thu, Mar 14, 2019 at 2:41 PM Deepak Dixit wrote:
Sure Jacques, Will do
Thanks & Regards
--
Deepak Dixit
Done, Committed slightly modified version of the suggested patch.
Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org
On Thu, Mar 14, 2019 at 2:41 PM Deepak Dixit wrote:
> Sure Jacques, Will do
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Thu, Mar 14, 2019 at 2:16 PM
Sure Jacques, Will do
Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org
On Thu, Mar 14, 2019 at 2:16 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> Thanks Deepak,
>
> Unfortunately it's difficult to use it as us and I have not created a Jira
> for that.
>
> Could you please commit
Thanks Deepak,
Unfortunately it's difficult to use it as us and I have not created a Jira for
that.
Could you please commit it?
TIA
Jacques
Le 13/03/2019 à 06:42, Deepak Dixit a écrit :
Hi Jacques,
I tested the following patch and it works
=
Index: build.gradle
Hi All,
While working on https://markmail.org/message/q5etvmwtkswgyakj I noticed this
issue
2019-03-14 09:28:01,585 |sse-nio-8443-exec-10 |ControlServlet |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]-
total:0.0,since last(Begin):0.0]]
2019-03-14
