Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-20 Thread Pierre Smits
Maybe we should move the load aspects regarding tests out of the test suite invocations altogether. The gradlew tasks states: task testIntegration(group: ofbizServer) { dependsOn 'ofbiz --test' description 'Run OFBiz integration tests; You must run loadAll before running this task' } IMO,

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-20 Thread Mathieu Lirzin
Pierre Smits writes: > I believe there are a few more where testing individual test-suites and/or > test-cases are dependent on data loaded in other test-suites and/or other > test-cases. I have the same experience. Moreover another source of fragility is that tests depend on other tests

Day name and Month Name

2019-04-20 Thread Pierre Smits
HI all, Are there functions in ofbiz to get: 1. the name of the Day given a particular date? And equally to get the abreviation?, E.g 'Sunday' > 'Sun'; 2. the name of the Month given a particular month number (derived from either a date/timestamp or month number)? And equally so to

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-20 Thread Pierre Smits
I believe there are a few more where testing individual test-suites and/or test-cases are dependent on data loaded in other test-suites and/or other test-cases. While I don't hear/read about failing testIntegration (except where code in the base is faulty, not when test-suites/cases are faulty),

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-20 Thread Pierre Smits
HI Mathieu, My apologies for the inconvenience caused. I should have made it more clear that the suggestion was just that. And that the 'would' in the following sentence should have been 'could': Taking the load process to the suite level would solve this Best regards, Pierre Smits *Apache

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-20 Thread Mathieu Lirzin
Hello Pierre, Pierre Smits writes: > Loading of test data should be happening on suite level, before any > test-case is executed. > > Currently the code block in [1] is like: > > > > > > entity-xml-url="component://testdef/data/TestData.xml"/> > > > > > >

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-20 Thread Pierre Smits
Removing the code element that is causing the CI to fail is not the right solution. It will mask the issue (and is like saying 'there is nothing wrong with the code'), only to reappear in next iteration (when similar is introduced). Loading of test data should be happening on suite level, before