Improve steps on Mailing Lists page

2019-06-04 Thread Aditya Sharma
Hello everyone,

The current steps for subscribing on Mailing lists page[1]:
1. Click the button of the mailing list you want to subscribe to
2. On the following page, click the 'Subscribe' button
3. Send the automatically created email from your email client
4. You will receive an email about the mailing list manager program (EZMLM)
Congratulations! You are now subscribed

The issue with current steps is on list page[2] when user clicks subscribe
button it opens up the email client but it is not necessary that user uses
any email client. I think we should also add direct steps as available for
unsubscribing.

To subscribe from any of the following lists, please send an empty,
subjectless email to mailing list subscribe addresses.

   -  user-subscr...@ofbiz.apache.org
   -  dev-subscr...@ofbiz.apache.org
   -  commits-subscr...@ofbiz.apache.org
   -  notifications-subscr...@ofbiz.apache.org

1. https://ofbiz.apache.org/mailing-lists.html
2. https://lists.apache.org/list.html?u...@ofbiz.apache.org

Thanks and Regards
Aditya Sharma


Re: [DISCUSSION] Committing Minilang test patches under OFBIZ-1463

2019-06-04 Thread Mathieu Lirzin
Hello

Jacques Le Roux  writes:

> Le 02/06/2019 à 15:50, Mathieu Lirzin a écrit :
>>
>> Jacques Le Roux  writes:
>>
>>> We started a discussion in OFBIZ-1463 about committing or not the Minilang 
>>> test patches.
>>>
>>> There are already few mixed opinions there (Michael, Aditya, Suraj and I).
>>>
>>> Before voting I'd like to know if we can come to a consensus.
>>>
>>> Please read in OFBIZ-1463 and come back with your opinion.
>>>
>>> I have just changed mine because I believe using the tests as soon they are 
>>> reading is a good thing.
>>>
>>> Waiting would be a waste of not only work done but also time for code
>>> safety. We can still move them to Groovy later, it's not more work, I
>>> guess it's even less.
>> If it's less work, then why people interested in having those patches
>> applied has not migrate those tests yet? :-)
>>
>> Having contributed to the migration of the “quoteTests” I know for a
>> fact that this is painful work. Applying those patches in their current
>> state would simply mean putting the burden on someone else to do the
>> work. So I am strongly opposed to committing thoses patches before the
>> tests are migrated.
>>
>> As far as I am concerned, if people want stuff to be committed then they
>> have to do their homework first.
>
> Wait Mathieu,
>
> Could you explain why it would me more work to migrate from a patch than to 
> migrate from code already in the repo?

I was not saying either solution is more work, I was just acknowledging
that right now, nobody wants to do the work of migration for those
tests.

> Maybe you mean that migrating is a burden anyway, and it's better to
> directly write test in Groovy?

Yes I expect people having proposed the patches to update their patches
with the groovy migration before applying those patches.

> Then I see no problems doing that and having already Minilang tests
> present. We "just have" to drop Minilang tests when Groovy ones are
> ready.
>
> What I'm missing?

The problem I see is that if the people proposing the patches are not
willing to do the migration work right now, I see no reason why they
would want to do it afterwards when there will be no incentives to do
so.

If we apply those patches as they are, then the rest of us will
eventually have to understand/maintain/debug them when they fail. Given
the current sad state of OFBiz integration tests we cannot afford to let
more “stuff to be cleaned up later” enter the codebase.

To explain my hard feeling regarding OFBiz integration tests. I find
them really hard to understand/debug due to the following points:

- Logs are unreadable! I mean understanding which test has failed is
  already an endeavour.

- The global nature of the data loaded during the tests makes things
  brittle. We saw a lot of that in previous weeks where tests were
  succeding when having both the framework and the plugins but failing
  when having only the framework.

- People tend to be confused between integration and unit tests,
  resulting in integration tests written in an atomic way which is not a
  good thing. For example for testing services manipulating an
  hypothetical entity ‘foo’, we would have a ‘testCreateFooService’ that
  adds some stuff in the database and ‘testUpdateFooService’ that
  retrieve the stuff added by the other.  This is bad since it
  introduces a order dependency between those tests.  Instead of small
  integration tests we should have bigger independant ones following a
  scenario with multiple asserts.

Sorry for being long but I wanted to make clear that this is a real
issue.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

-
To unsubscribe, e-mail: dev-unsubscr...@ofbiz.apache.org
For additional commands, e-mail: dev-h...@ofbiz.apache.org



Re: Ecommerce image distorted in trunk demo main page

2019-06-04 Thread Jacques Le Roux

Thanks Nitish,

Much appreciated, will you create the Jira?

Jacques

Le 04/06/2019 à 13:14, Nitish Mishra a écrit :

Hi Jacques

Thanks for figuring it out. Yes, it is due to bootstrap changes.
I will fix it soon.


On Tue, Jun 4, 2019 at 1:40 PM Jacques Le Roux mailto:jacques.le.r...@les7arts.com>> wrote:

Hi,

I'm not sure why, I guess a Bootstrap change (see subject)

Thanks

Jacques


-
To unsubscribe, e-mail: dev-unsubscr...@ofbiz.apache.org 

For additional commands, e-mail: dev-h...@ofbiz.apache.org 




--

Kind Regards,
Nitish Mishra
Enterprise Software Engineer
*HotWax Systems*
/Enterprise open source experts/
cell: +91-81032-58737
office: 0731-409-3684
http://www.hotwaxsystems.com 




Ecommerce image distorted in trunk demo main page

2019-06-04 Thread Jacques Le Roux

Hi,

I'm not sure why, I guess a Bootstrap change (see subject)

Thanks

Jacques


-
To unsubscribe, e-mail: dev-unsubscr...@ofbiz.apache.org
For additional commands, e-mail: dev-h...@ofbiz.apache.org