Re: [DISCUSSION] Best of both Groovy worlds: compile and on the fly

2019-09-20 Thread Taher Alkhateeb
I see, in this case I think it's a good idea to comply with conventions. It's strange that while I was working in the beginnings on gradle I remember the opposite suggestion happening "keep the scripts where they are" is what I heard repeatedly. Anyway, if it is just a matter of moving, then it's

Re: [DISCUSSION] Best of both Groovy worlds: compile and on the fly

2019-09-20 Thread Jacques Le Roux
In a 1st time I intend to do only what I wrote in OFBIZ-10226, OFBIZ-10205 and this thread, ie indeed mostly "move them to src/main/groovy". That's enough for my need. Using @CompileStatic is out of my scope because I want to keep Groovy scripts dynamic. Le 20/09/2019 à 16:27, Taher Alkhateeb

Re: [DISCUSSION] Best of both Groovy worlds: compile and on the fly

2019-09-20 Thread Taher Alkhateeb
I'm not sure I understand the outcome from reading the JIRA and this thread. What will happen exactly? Are you going to make groovy scripts part of the call stack? Are you going to use @CompileStatic? Or are you just going to move them to src/main/groovy? On Fri, Sep 20, 2019 at 5:14 PM Jacques

Re: [DISCUSSION] Best of both Groovy worlds: compile and on the fly

2019-09-20 Thread Jacques Le Roux
Thanks Paul, Gil, for your suggestions, I have created OFBIZ-11205 for that Jacques Le 16/09/2019 à 12:28, Jacques Le Roux a écrit : Hi Devs, While working on OFBIZ-10226 "Adds groovyScripts in the Gradle sourceSets" I discussed with Mathieu and we had some ideas. Mathieu suggested to move

Re: OrderItemPriceInfo: Accounting angle

2019-09-20 Thread Rishi Solanki
This is known that ProductStore.explodeOrderItems reposible for OrderItemPriceInfo. IMO, It should also take care of InvoiceItem creation conditionally. Best Regards, -- Rishi Solanki Sr Manager, Enterprise Software Development *HotWax Systems* *Enterprise open source experts* cell:

Re: Advance OFBiz tutorials

2019-09-20 Thread Rishi Solanki
+1 Swapnil and Big +1 for all suggestions made by Pranay! Best Regards, -- Rishi Solanki Sr Manager, Enterprise Software Development *HotWax Systems* *Enterprise open source experts* cell: +91-98932-87847 http://www.hotwaxsystems.com On Mon, Sep 2, 2019 at 11:44 AM Pranay Pandey <

Re: Default transaction timeout on screen widget

2019-09-20 Thread Nicolas Malin
Hello Scott, thanks for your return, in line ... On 9/17/19 10:45 AM, Scott Gray wrote: Has anyone ever had a good experience with transaction timeouts? I feel like they achieve nothing useful in that: 1. They don't interrupt any work that is taking too long (they just prevent it from being

Re: Default transaction timeout on screen widget

2019-09-20 Thread Gil Portenseigne
Same feeling here, i just see it as a smell to analyse, to detect bad design, system failure (disk access...) or regression. Regards Gil Le 20:45 - mardi 17 sept., Scott Gray a écrit : > Has anyone ever had a good experience with transaction timeouts? I feel > like they achieve nothing useful

Re: [DISCUSSION] Best of both Groovy worlds: compile and on the fly

2019-09-20 Thread Gil Portenseigne
Hello Jacques, I also discussed about it with Mathieu and i find it very interesting. The main advantage I see is, beside compilation, the integration in your IDE, that was not optimum, and the possibility to re-use methods from these script migrated to explicit classes. So +1 Gil Le 12:28 -