Re: [ofbiz-framework] branch trunk updated: Improved: no functional change

2020-02-24 Thread Michael Brohl
Hi Jacques, I think the comment was correct, more precise would have been javadoc.options.links though. Regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 24.02.20 um 21:50 schrieb jler...@apache.org: This is an automated email from the ASF dual-hosted git repository. jleroux

ShowPromoText/ProductPromoWorker nulls all product promotions after a single condition check failure

2020-02-24 Thread Giulio Speri - MpStyle Srl
Hello everyone, I am facing a strange behaviour regarding Product Store Promotions that are active for one of the ecommerce sites that my company manage. In all the pages of the sites, we have included the ShowPromoText.groovy script that retrieves the promotions active for a specific store: we

Re: Fix version: which to select when release is pending?

2020-02-24 Thread Michael Brohl
Thanks, Jacopo! Will amend my fix versions. Michael Am 24.02.20 um 15:56 schrieb Jacopo Cappellato: Hi Michael, I have just created the version in Jira for 17.12.02: we should now use it. Thanks, Jacopo On Mon, Feb 24, 2020 at 3:42 PM Michael Brohl wrote: Hi all, how do set the "fixed

Re: Fix version: which to select when release is pending?

2020-02-24 Thread Jacopo Cappellato
Hi Michael, I have just created the version in Jira for 17.12.02: we should now use it. Thanks, Jacopo On Mon, Feb 24, 2020 at 3:42 PM Michael Brohl wrote: > Hi all, > > how do set the "fixed versions" in the case of a pending release like we > have with 17.12.01 now? > > IMO 17.12.01 would

Re: Fix version: which to select when release is pending?

2020-02-24 Thread Michael Brohl
I should have mentioned that there is no 17.12.02 release available at the moment, therefore I chose the Release Branch. The provided link does not seem to be related to my particular question though. Michael Brohl ecomify GmbH - www.ecomify.de Am 24.02.20 um 15:52 schrieb Pierre Smits:

Re: Fix version: which to select when release is pending?

2020-02-24 Thread Pierre Smits
As an addendum to my previous posting regarding 'Project following that methodology often have a release branch for the next release.' In this case 'r17.12.01' so that there is an alignment between ticket and repository. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache

Re: Fix version: which to select when release is pending?

2020-02-24 Thread Pierre Smits
Michael, all, It is very common that when an issue is identified for a particular release (in this case 17.12.01) that, when fixed, the 'version field' is set to the next version (to be released). That way, when the moment of releasing the next release comes around, tickets can be identified. And

Re: Fix version: which to select when release is pending?

2020-02-24 Thread Michael Brohl
Reference to the issue where I selected "Release branch 17.12": https://issues.apache.org/jira/browse/OFBIZ-11346 Michael Brohl ecomify GmbH - www.ecomify.de Am 24.02.20 um 15:42 schrieb Michael Brohl: Hi all, how do set the "fixed versions" in the case of a pending release like we have

Fix version: which to select when release is pending?

2020-02-24 Thread Michael Brohl
Hi all, how do set the "fixed versions" in the case of a pending release like we have with 17.12.01 now? IMO 17.12.01 would be wrong because it was tagged before and the change would go to 17.12.02. In some case at the weekend I selected "Release Branch 17.12" but not sure about it.

Re: PMC/Committer resignation

2020-02-24 Thread Jacques Le Roux
Hi Mathieu, All, It's a heartbreaking news indeed. We all followed progress the project made when you were active Mathieu. I for one was hoping much from your changes. Your departure will be a big loss not only for the project future but also for the community! I'm sad that "community over

Re: PMC/Committer resignation

2020-02-24 Thread Jacopo Cappellato
Hi Mathieu, this is just to inform you that your resignation is effective and we will soon update our records to reflect this change: there is a window of 72 hours for you to withdraw the resignation ([*]), so I am going to complete these tasks after this time is expired. Thanks for articulating

Re: buildbot exception in on ofbizBranch17Framework

2020-02-24 Thread Jacques Le Roux
OK It needs more work, I'm on it... Jacques Le 24/02/2020 à 12:03, build...@apache.org a écrit : The Buildbot has detected a build exception on builder ofbizBranch17Framework while building ofbiz-framework. Full details are available at:

Re: How do committers decide which features to backport to 18.12?

2020-02-24 Thread Jacques Le Roux
Hi Daniel, The rule is normally we only backport bug fixes, obviously to avoid regression But if nobody disagree for simple new features or improvements sometimes we backport. Most of the time a simple comment in the related Jira is enough. If discussion is needed (big or complicate stuff)

Re: PMC/Committer resignation

2020-02-24 Thread Gil Portenseigne
I second Nicolas opinion. I hope that we will evolve and that will allow you to come back in the community in the future. Let me thank you again for your time and kind help. Gil On Sat, Feb 22, 2020 at 02:51:28PM +0100, Nicolas Malin wrote: > It's sad new that you sharing. > > This community