Organize OFBiz Wiki

[Devanshu Vyas]

Hello Devs,

We have discussed the need to clean our Wiki for a long time and we did
some work as well. But, with recent opinion shared on the user list, I feel
we should make our priority to clear the haystack of documentation
specially for the need of new OFBiz adaptors.

I would suggest aligning the documentation in such a way that a new person
visiting/exploring OFBiz has a seamless experience in identifying and
learning the traits of OFBiz.

@Jacques, It would be great if you could share more thoughts on the
concern, as you have been very vocal on this effort.

Wating for your thoughts.

Thanks & Regards,
Devanshu Vyas.

Re: MethodLength checkstyle rule

[Suraj Khurana]

Hello team,

Any thoughts on this, IMO we can make it to 450 or something, it's quite
readable by then.
Please suggest.

--

Best Regards,
Suraj Khurana
Senior Technical Consultant


On Sun, Jul 26, 2020 at 9:12 PM Suraj Khurana 
wrote:

> Hello team,
>
> Currently there are around 200 issues due method length.
>
> Its default value is 150, we need to decide this configuration. In current
> code, maximum method length I noticed is of 945 lines
> (createOrder#OrderServices.java)
>
> I have created OFBIZ-11915 for this, we can continue this effort as per
> conclusions drawn in this thread.
>
> Please share your thoughts on this.
> --
> Best Regards,
> Suraj Khurana
> SENIOR TECHNICAL CONSULTANT
> mobile: +91 9669750002
> email: suraj.khur...@hotwax.co
> *www.hotwax.co *
>

ParameterNumber checkstyle rule

[Suraj Khurana]

Hello team,

Currently there are around 175 issues due parameter count in java methods

Its default value is 7 [1], we should decide this configuration for
checkstyle. In current code, there are some methods having around 20
parameters (addOrIncreaseItem).

[1]:
https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/sizes/ParameterNumberCheck.html

Please share your thoughts on this.

--
Best Regards,
Suraj Khurana
Senior Technical Consultant

Re: Single line statements - checkstyle

[Suraj Khurana]

Thanks everyone.

This was done a few days ago.

--

Best Regards,
Suraj Khurana
Senior Technical Consultant


On Sat, Jul 18, 2020 at 1:56 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Le 14/07/2020 à 10:15, Jacques Le Roux a écrit :
> > My conclusion is that could be discussed again and I for one I'm not
> against changing this rule for 2 reasons:
> >
> > 1.  We can't use our current formatter to do it right
> > 2.  With a single line statement there are less chances to confuse
> and fall in the error-prone form mentioned above
> >
> > Another option would be to find a way to improve our formatter to do the
> right thing (ie add braces when splitting).
>
> We discussed the point 1 with Suraj in Slack. It's actually possible in
> both IntelliJ
>
>
> https://www.jetbrains.com/help/resharper/Braces_for_Single_Line_Statements.html
>
> https://stackoverflow.com/questions/55248370/intellij-checkstyle-plugin-reformat
>
> and Eclipse
>
>
> https://stackoverflow.com/questions/3704308/how-to-make-eclipse-automatically-add-braces-to-an-if-statement
>
> I don't know for IntelliJ, but in Eclipse it's not a formatting option but
> a clean-up option.
> And when you clean-up you can't select a block of code, it's all the file
> or nothing.
> There are then more changes and some are unwanted.
>
> So I agree with Suraj and Pritam, let's do that. There would be anyway so
> much changes to do by hand that it's not rational!
>
> Jacques
>
>

Re: Welcome Pawan Verma as new PMC member

[Deepak Nigam]

Many congratulations, Pawan.


Thanks & Regards
--
Deepak Nigam

On Wed, Jul 29, 2020, 3:56 PM Ankush Upadhyay <
ankush.upadh...@hotwaxsystems.com> wrote:

> Many Congratulations Pawan!
>
> Kind Regards,
> Ankush Upadhyay
> Senior Technical Consultant
>
> *HotWax Systems*
> *Enterprise open source experts*
> cell: +91-8109201285
> office: 0731-409-3684
> http://www.hotwaxsystems.com
>
>
> On Wed, Jul 29, 2020 at 3:02 PM Arvind Singh Tomar <
> arvind.to...@hotwaxsystems.com> wrote:
>
> > Many congratulations Pawan!
> >
> > Kind regards
> > --
> > Arvind Singh Tomar
> >
> > On Tue, Jul 28, 2020 at 7:33 PM Mridul Pathak <
> > mridul.pat...@hotwaxsystems.com> wrote:
> >
> > > Many congratulations Pawan!!
> > >
> > > Thanks.
> > > --
> > > Mridul Pathak
> > >
> > > > On 28-Jul-2020, at 1:21 PM, Jacques Le Roux <
> > > jacques.le.r...@les7arts.com> wrote:
> > > >
> > > > The OFBiz PMC has invited Pawan Verma to become member of the
> committee
> > > and we are glad to announce that he has accepted the nomination.
> > > >
> > > > On behalf of the OFBiz PMC, welcome on board Pawan!
> > > >
> > >
> > >
> >
>

Re: Welcome Pawan Verma as new PMC member

[Ankush Upadhyay]

Many Congratulations Pawan!

Kind Regards,
Ankush Upadhyay
Senior Technical Consultant

*HotWax Systems*
*Enterprise open source experts*
cell: +91-8109201285
office: 0731-409-3684
http://www.hotwaxsystems.com


On Wed, Jul 29, 2020 at 3:02 PM Arvind Singh Tomar <
arvind.to...@hotwaxsystems.com> wrote:

> Many congratulations Pawan!
>
> Kind regards
> --
> Arvind Singh Tomar
>
> On Tue, Jul 28, 2020 at 7:33 PM Mridul Pathak <
> mridul.pat...@hotwaxsystems.com> wrote:
>
> > Many congratulations Pawan!!
> >
> > Thanks.
> > --
> > Mridul Pathak
> >
> > > On 28-Jul-2020, at 1:21 PM, Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> > >
> > > The OFBiz PMC has invited Pawan Verma to become member of the committee
> > and we are glad to announce that he has accepted the nomination.
> > >
> > > On behalf of the OFBiz PMC, welcome on board Pawan!
> > >
> >
> >
>

Re: Welcome Pawan Verma as new PMC member

[Arvind Singh Tomar]

Many congratulations Pawan!

Kind regards
--
Arvind Singh Tomar

On Tue, Jul 28, 2020 at 7:33 PM Mridul Pathak <
mridul.pat...@hotwaxsystems.com> wrote:

> Many congratulations Pawan!!
>
> Thanks.
> --
> Mridul Pathak
>
> > On 28-Jul-2020, at 1:21 PM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
> >
> > The OFBiz PMC has invited Pawan Verma to become member of the committee
> and we are glad to announce that he has accepted the nomination.
> >
> > On behalf of the OFBiz PMC, welcome on board Pawan!
> >
>
>