Re: Codenarc integration, rules to use.

2022-07-12 Thread gil . portenseigne
Hello Michael, Sure, you can see in the pull request I started to separate the commit, a commit for one rule fix. The last one is a big one :) https://github.com/apache/ofbiz-framework/pull/517/commits/384894dfafce5e7261e2564b40261650deda7a22 Regards, Gil Le Dimanche, Juillet 10, 2022

Re: Codenarc integration, rules to use.

2022-07-12 Thread Gil Portenseigne
Forgot the ref https://github.com/CodeNarc/CodeNarc/issues/331 Le 12 juillet 2022 21:11:13 GMT+02:00, Gil Portenseigne a écrit : >Hello, > >I agree with you, i find out here [1] that it is customisable. > >So we can agree upon this variation of the rule ! > >I have not tested yet, will see in

Re: Possible issue in balanceInventoryItems/reassignInventoryReservation service

2022-07-12 Thread Scott Gray
Hi Giulio, It seems to me your problem isn't that you have a reservation containing a quantityNotAvailable, the real problem is that you have an order you can't fulfill. Cancelling the affected order line item would seem to be the best solution, it removes the reservation and cleans up the

Re: Codenarc integration, rules to use.

2022-07-12 Thread Gil Portenseigne
Hello, I agree with you, i find out here [1] that it is customisable. So we can agree upon this variation of the rule ! I have not tested yet, will see in the near future Thanks Gil Le 11 juillet 2022 17:57:45 GMT+02:00, Scott Gray a écrit : >+1 in general from me although some of those