Re: CodeNarc Gradle plugin

2023-01-28 Thread Jacques Le Roux
Hi Michael, All, If you are interested in CodeNarc integration you may help to review https://github.com/apache/ofbiz-framework/pull/517 And mark your reviews at https://cwiki.apache.org/confluence/display/OFBIZ/Codenarc+integration+review+tracker TIA Jacques Le 12/12/2021 à 17:55, Jacques

Re: Welcome to Daniel Watford as new PMC member

2023-01-28 Thread Jacques Le Roux
Happy to have you with us Daniel! Jacques Le 28/01/2023 à 12:08, Taher Alkhateeb a écrit : Congratulations! On Saturday, January 28, 2023 13:57 +03, Jacopo Cappellato wrote:  The OFBiz PMC has invited Daniel Watford as a new PMC member and we are glad to announce that Daniel has accepted

Re: Welcome to Daniel Watford as new PMC member

2023-01-28 Thread Taher Alkhateeb
Congratulations! On Saturday, January 28, 2023 13:57 +03, Jacopo Cappellato wrote:  The OFBiz PMC has invited Daniel Watford as a new PMC member and we are glad to announce that Daniel has accepted the nomination. On behalf of the OFBiz PMC, welcome on board!

Welcome to Daniel Watford as new PMC member

2023-01-28 Thread Jacopo Cappellato
The OFBiz PMC has invited Daniel Watford as a new PMC member and we are glad to announce that Daniel has accepted the nomination. On behalf of the OFBiz PMC, welcome on board!

Re: Codenarc integration process

2023-01-28 Thread Gil Portenseigne
Oh sorry indeed i overview the review approach section. The table is nice, thanks Dan ! 28 janv. 2023 09:37:50 Daniel Watford : > Hi Gil, > > I don't think a checklist is quite enough, assuming we want to track the > status of each file reviewed. > > From the review approach section: > > >  

Re: Codenarc integration process

2023-01-28 Thread Jacques Le Roux
Thanks Daniel, Looks great, but indeed a bit more work, notably because you need to C/P, modify and save. Also looks like we are still only 3 to review, so about 150 files each. Some help would be appreciated :) Jacques Le 28/01/2023 à 09:46, Daniel Watford a écrit : Turns out I was able

Re: Codenarc integration process

2023-01-28 Thread Daniel Watford
Turns out I was able to import the list of files into Excel and copy and paste the table from Excel to Confluence. On Sat, 28 Jan 2023 at 08:37, Daniel Watford wrote: > Hi Gil, > > I don't think a checklist is quite enough, assuming we want to track the > status of each file reviewed. > > From

Re: Codenarc integration process

2023-01-28 Thread Daniel Watford
Hi Gil, I don't think a checklist is quite enough, assuming we want to track the status of each file reviewed. >From the review approach section: - If in the reviewers opinion a file change will not change OFBiz behaviour in any way they should mark the corresponding entry in the table