Re: svn commit: r1767974 - /ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests .xml

2016-11-05 Thread Deepak Nigam
I think this issue should be fixed after correcting the sequence of test
cases in the file AutoAcctgFinAccountTests.xml.

Thanks & Regards
--
Deepak Nigam
Sr. Enterprise Software Engineer
Hotwax Systems
www.hotwaxsystems.com

On Fri, Nov 4, 2016 at 4:43 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Ha no sorry, it's another error but not related to organizationPartyId
>
> The FinAccountRole data are OK
>
> The error is here https://ci.apache.org/projects/ofbiz/logs/trunk/html/
>
> Jacques
>
>
>
> Le 04/11/2016 à 11:56, Deepak Dixit a écrit :
>
>> Let me check Jacques.
>>
>> Thanks for review.
>>
>> Thanks & Regards
>> --
>> Deepak Dixit
>> www.hotwaxsystems.com
>>
>> On Fri, Nov 4, 2016 at 4:22 PM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> Hi Deepak,
>>>
>>> The testUpdateFinAccountRole test fails because the data are wrong the
>>> FinAccountRole entity PKs are
>>>
>>> finAccountId (String)
>>> fromDate (java.sql.Timestamp)
>>> partyId (String)
>>> roleTypeId (String)
>>>
>>> When the data are
>>>
>>>  
>>>  >> finAccountName="Deposit Account" finAccountCode="1001"
>>> currencyUomId="USD"
>>> organizationPartyId="DEMO_COMPANY" fromDate="2016-11-03 00:00:00"
>>> actualBalance="2000.00" availableBalance="1500.00"/>
>>>  >> roleTypeId="SUPPLIER" fromDate="2016-11-03 00:00:00"/>
>>>
>>> At least organizationPartyId is wrong, should be partyId
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>> Le 03/11/2016 à 22:03, dee...@apache.org a écrit :
>>>
>>> Author: deepak
>>>> Date: Thu Nov  3 21:03:13 2016
>>>> New Revision: 1767974
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1767974=rev
>>>> Log:
>>>> Improved: Added missing file for accounting fin service test cases.
>>>>
>>>> Added:
>>>>   ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
>>>> inAccountTests.xml
>>>>   (with props)
>>>>
>>>> Added: ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
>>>> inAccountTests.xml
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accoun
>>>> ting/minilang/test/AutoAcctgFinAccountTests.xml?rev=1767974=auto
>>>> 
>>>> ==
>>>> --- ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
>>>> inAccountTests.xml
>>>> (added)
>>>> +++ ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
>>>> inAccountTests.xml
>>>> Thu Nov  3 21:03:13 2016
>>>> @@ -0,0 +1,182 @@
>>>> +
>>>> +
>>>> +
>>>> +http://www.w3.org/2001/XMLSchema-instance;
>>>> +xmlns="http://ofbiz.apache.org/Simple-Method;
>>>> xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method
>>>> http://ofbiz.apache.org/dtds/simple-methods.xsd;>
>>>> +>>> short-description="Test case for service deleteFinAccountRole"
>>>> login-required="false">
>>>> +
>>>> +
>>>> +
>>>> +>>> type="Timestamp"/>
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +>>> in-map-name="serviceCtx"/>
>>>> +>>> entity-name="FinAccountRole">
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +>>> list="finAccountRoles"/>
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +>>> short-description="Test case for service updateFinAccountRole"
>>>> login-required="false">
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +>>> type="Timestamp"/>
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +
>&g

Re: analyse the user permission

2017-07-19 Thread Deepak Nigam
Hi Ismail,

You can refer the following set of data (copied from HumanResDemoData.xml)













Thanks & Regards
--
Deepak Nigam
Technical Consultant/Team Lead
Hotwax Systems
www.hotwaxsystems.com

On Wed, Jul 19, 2017 at 5:03 PM, Ismail Al Kouz <ialk...@bi-bst.com> wrote:

> Hello Guys.
>
>
>
> How I can analyze the user permission based on userLoginId or PartyId
>
>
>
> thanks
>
>
>
> *Best Regards,*
>
>
>
> *Ismail Alkouz*
>
> Java Developer
>
>
>
> [image: Description: Logo for Office-4]
>
>
>
> [image: Description: bi email-3-02]
>
>
>
> P.O.Box 3516 Amman, 11821
>
> The Hashemite Kingdom of Jordan
>
> *Tel.* +962 (6) 556 2620
>
> *Mob (Jordan).*   +962 79 282 2098
>
> [image: Description: bi email-3-04]
>
> [image: Description: bi email-3-05]
>
> /biict
>
> @biict
>
>
>
>
>


Re: Missing Method Implementations in OrderChangeHelper

2017-08-03 Thread Deepak Nigam
Hi Kyra,

It seems that these changes are intentional, you can also check the comment
inside the code itself:

"NOTE DEJ20080609 commenting out this code because the old OFBiz Workflow
Engine is being deprecated and this was only for that get the delegator
from the dispatcher"

For more information, please have a look at the following:

https://svn.apache.org/viewvc?view=revision=665981

Thanks & Regards
--
Deepak Nigam
Technical Consultant/Team Lead
HotWax Systems
www.hotwaxsystems.com

On Thu, Aug 3, 2017 at 2:08 PM, Kyra Pritzel-Hentley <
kyra.pritzel-hent...@ecomify.de> wrote:

> Hello OFBiz Enthusiasts,
>
> I am working to rid OFBiz of Bugs using the help of a code analysis tool
> called FindBugs. With this, I find all kinds of peculiar code in the OFBiz
> project. This JIRA ticket describes further details about this effort:
> https://issues.apache.org/jira/browse/OFBIZ-9450
>
> FindBugs pointed out to me that inside PayPalEvents#payPalIPN the method
> OrderChangeHelper.releaseInitialOrderHold is called. But looking at the
> implementation of the method, it only returns true  even though the
> parameters LocalDispatcher dispatcher and String orderId are handed over to
> the method. The same problem arises with OrderChangeHelper#
> abortOrderProcessing.
>
> There doesn’t seem to be a ticket working on this issue. I am fairly
> certain, looking at the names of the methods, that something more should
> happen other than just returning true. Does somebody have an idea what is
> supposed to happen with these methods?
>
> Thank you,
> Kyra Pritzel-Hentley
>
> ecomify GmbH
> Bielefeld, Germany


Re: Updates to EntityQuery

2017-10-25 Thread deepak nigam
Looking good to me also. Let me know if I can be of any help.


Thanks & Regards
--
Deepak Nigam

On Wed, Oct 25, 2017 at 6:26 PM, Yash Sharma <yash.sha...@hotwaxsystems.com>
wrote:

> I am all up for it, please let me know if I could help.
>
> Thanks & Regards,
> --
> *Pradhan Yash Sharma*
> *HotWax Systems* | www.hotwaxsystems.com
>
> On Wed, Oct 25, 2017 at 6:23 PM, Yash Sharma <
> yash.sha...@hotwaxsystems.com>
> wrote:
>
> > Yes, Usage of the stream will surely enhance performance to a certain
> > extent and removes ceremony from the code base. I think Parallel streams
> > will add enhancements in many folds as we are using a multicore processor
> > (I have not tested yet), but the Functional approach seems promising.
> >
> > Thanks & Regards,
> > --
> > *Pradhan Yash Sharma*
> > *HotWax Systems* | www.hotwaxsystems.com
> >
> > On Wed, Oct 25, 2017 at 5:59 PM, Gareth Carter <
> > gareth.car...@stannah.co.uk> wrote:
> >
> >> forUpdate
> >>
> >> We patched EntityFindOptions with a new field "forUpdate" with shorthand
> >> methods in EntityQuery to enable. We then made a change to
> >> GenericDAO.selectListIteratorByCondition to add "FOR UPDATE" on the end
> >> of the SQL select statement - this allows for DB row locks (we use
> postgres
> >> and works but have not tested other databases). I believe there may have
> >> been a discussion about this before
> >>
> >>
> >> forEach on EntityQuery
> >>
> >> Use Consumer in java and groovy to iterate over a query. This can reduce
> >> memory consumption (replacement for queryList()) and boiler plate code
> (eg
> >> queryIterator(), while loop and close)
> >>
> >> Example:
> >>
> >> EntityQuery.use(delegator).from("Foobar")
> >> .forEach(item ->
> >> Debug.logInfo(item.toString(), module);
> >> );
> >>
> >> A further update could be to provide stream capabilities
> >>
> >> Hope this helps, I can provide a patch aswell
> >>
> >> Gareth Carter
> >> Software Development Analyst
> >> Stannah Management Services Ltd
> >> IT Department
> >> Ext:
> >> 7036
> >> DDI:
> >> 01264 364311
> >>
> >>
> >> Please consider the environment before printing this email.
> >>
> >> -Original Message-
> >> From: Arun Patidar [mailto:arun.pati...@hotwaxsystems.com]
> >> Sent: 25 October 2017 5:49 AM
> >> To: dev@ofbiz.apache.org
> >> Cc: arunpati...@apache.org
> >> Subject: Re: Updates to EntityQuery
> >>
> >> Hello Gareth,
> >>
> >> Please provide some more details or patch to understand  - forUpdate and
> >> forEach method utility.
> >>
> >> getFieldMap method looks good to me.
> >>
> >>
> >>
> >> --
> >> Thanks & Regards
> >> ---
> >> Arun Patidar
> >> Manager, Enterprise Software Development
> >>
> >> HotWax Systems Pvt Ltd.
> >>
> >> www.hotwaxsystems.com
> >>
> >>
> >> On Tue, Oct 24, 2017 at 9:06 PM, Gareth Carter <
> >> gareth.car...@stannah.co.uk>
> >> wrote:
> >>
> >> > Hi all
> >> >
> >> > We have internally patched EntityQuery with some additional
> >> > functionality and before I create a Jira was going to see what the
> >> community thinks.
> >> >
> >> > New functionality:
> >> >
> >> > -   New method getFieldMap which returns a Map object of selected
> >> > fields from GenericValue objects, useful for creating cache map
> >> > objects for lookup
> >> >
> >> > -   Support forUpdate
> >> >
> >> > -   forEach method to accept Consumer
> >> >
> >> > We have found these useful and believe the project can benefit, let me
> >> > know what you think
> >> >
> >> > Regards
> >> >
> >> > Gareth Carter
> >> >
> >> >
> >> > Software Development Analyst
> >> >
> >> >
> >> > Stannah Management Services Ltd
> >> >
> >> >
> >> > IT Department
> >> >
> >> >
> >> > Ext:
> >> >
> >> >
> >> > 7036
> >> >
> >>

Re: New ASF Member from OFBiz Community

2018-05-03 Thread deepak nigam
Congratulations Deepak!

Thanks & Regards
--
Deepak Nigam

On Thu, May 3, 2018 at 11:34 AM, Devanshu Vyas <vyas.devansh...@gmail.com>
wrote:

> Many Congratulations Deepak!!!
>
>
> Thanks & Regards,
> Devanshu Vyas.
>
>
> On Wed, May 2, 2018 at 9:08 PM Jacopo Cappellato <
> jacopo.cappell...@hotwaxsystems.com> wrote:
>
> > Hi Everyone,
> >
> > today the ASF has published the list of newly nominated members and "our"
> > Deepak Dixit is one of them:
> >
> >
> > https://blogs.apache.org/foundation/entry/the-apache-
> software-foundation-welcomes2
> > <
> > https://www.google.com/url?q=https://blogs.apache.org/
> foundation/entry/the-apache-software-foundation-welcomes2&
> sa=D=hangouts=1525357595561000=
> AFQjCNHXDpgnyJ1wgnbZ06kEPTsbXs9MDQ
> > >
> >
> > Congratulations Deepak!
> >
> > Jacopo
> >
>


Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity

2018-08-07 Thread deepak nigam
Hello Devs,

While creating the sales order from the backend, if we set the 'Ship Before
Date' it will be stored in OrderItemShipGroup.shipByDate field and same
will be propagated to OrderItemShipGrpInvRes.promisedDateTime
and OrderItemShipGrpInvRes.currentPromisedDate fields.

On updating the 'Ship Before Date' from the order view page later, the
value gets updated in OrderItemShipGroup entity but remains the same in
OrderItemShipGroupInvRes entity.

Is this the expected behaviour or OrderItemShipGroupInvRes should also get
updated? OrderItemShipGrpInvRes.promisedDateTime &
OrderItemShipGrpInvRes.currentPromisedDate is used in many services like
'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity',
'reserveProductInventory' etc.


Thanks & Regards
--
Deepak Nigam


Re: Inventory Allocation Planning

2018-08-16 Thread deepak nigam
Moving thread to the dev mailing list.

On Thu, Aug 16, 2018 at 3:33 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Deepak,
>
> Interesting proposition, this should be discussed in dev ML
>
> Thanks
>
> Jacques
>
>
> Le 16/08/2018 à 11:28, deepak nigam a écrit :
> > While creating orders from the backend, we have the option to set
> > parameters like 'Ship After Date' and 'Ship Before Date' to manage the
> > fulfilment cycle more efficiently. Inventory gets reserved for the
> product
> > based on a FIFO basis. Sometimes the fulfilment time for the order is
> high
> > and inventory unnecessarily gets locked for some time period.
> >
> > We can introduce a new parameter (at order item level) 'Reserve After
> Date'
> > which will indicate the date only after which reservation can happen. In
> > this way, we can manage the stock availability more efficiently.
> >
> > On Mon, Aug 13, 2018 at 10:35 AM deepak nigam <
> deepak.nigam1...@gmail.com>
> > wrote:
> >
> >> Thanks, James.
> >>
> >> Here is the JIRA ticket
> >> <https://issues.apache.org/jira/browse/OFBIZ-10518> for the same. Soon
> I
> >> will share detailed design notes here and in the ticker also.
> >>
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Nigam
> >>
> >> On Mon, Aug 13, 2018 at 2:17 AM  wrote:
> >>
> >>> Deepak - I did not see it in OFbiz but I did in Opentaps.  I can send
> >>> you a video of the functionality
> >>>
> >>>  Original Message 
> >>> Subject: Re: Inventory Allocation Planning
> >>> From: deepak nigam 
> >>> Date: Thu, August 09, 2018 2:24 am
> >>> To: u...@ofbiz.apache.org, ja...@productive1.com
> >>>
> >>> Hi James,
> >>>
> >>> Did you get a chance to confirm it in OFBiz?
> >>>
> >>>
> >>> @All,
> >>> As far as I came to know, the feature to allocate the inventory (not
> >>> actual reservation at this point) is not available OOTB. We can think
> >>> about the idea of its implementation.
> >>>
> >>>
> >>>
> >>>
> >>> Thanks & Regards
> >>> --
> >>> Deepak Nigam
> >>>
> >>>
> >>>
> >>>
> >>> On Sun, Aug 5, 2018 at 10:14 PM  wrote:
> >>>
> >>> This will only allocate the current inventory.  I see it in
> >>>   opentaps...let me confirm in Ofbiz.
> >>>
> >>>    Original Message 
> >>>   Subject: Re: Inventory Allocation Planning
> >>>   From: deepak nigam 
> >>>   Date: Fri, August 03, 2018 12:40 am
> >>>   To: u...@ofbiz.apache.org
> >>>
> >>>   Thanks, James.
> >>>
> >>>   Will this method honour the upcoming supply also? I am more
> interested
> >>>   in a
> >>>   supply allocation plan by using which I can allocate the available
> and
> >>>   upcoming supply amongst the open orders.
> >>>
> >>>
> >>>   Thanks & Regards
> >>>   --
> >>>   Deepak Nigam
> >>>
> >>>   On Wed, Aug 1, 2018 at 12:26 AM Paul Mandeltort 
> >>>   wrote:
> >>>
> >>>   > Where is this screen located? Or are you referring to the order
> >>>   > priority field in ordermgr?
> >>>   >
> >>>   > —P
> >>>   >
> >>>   > > On Jul 31, 2018, at 1:48 PM,  <
> >>>   > ja...@productive1.com> wrote:
> >>>   > >
> >>>   > >
> >>>   > > There is a way to reallocate using the order priority screen. You
> >>> can
> >>>   > > bump backorders up and give them a higher priority.
> >>>   > >
> >>>   > > Thanks,
> >>>   > >
> >>>   > > James
> >>>   > >  Original Message ----
> >>>   > > Subject: Inventory Allocation Planning
> >>>   > > From: deepak nigam 
> >>>   > > Date: Tue, July 31, 2018 5:28 am
> >>>   > > To: u...@ofbiz.apache.org
> >>>   > >
> >>>   > > Hi All,
> >>>   > >
> >>>   > > In the current implementation of inventory reservation flow,
> >>> inventory
> >>>   > > gets
> >>>   > > reserved for the order based on the reservation algorithm (FIFO,
> >>> LIFO
> >>>   > > etc).
> >>>   > > Many times, the fulfilment cycle of the order is too long or due
> to
> >>> some
> >>>   > > unexpected circumstances, the order holds the inventory for a
> long
> >>> time.
> >>>   > > In
> >>>   > > such scenarios, inventory availability becomes one of the major
> >>>   > > bottlenecks
> >>>   > > in fulfilling the other sales order and businesses often remains
> >>> short
> >>>   > > supplied against the demand.
> >>>   > >
> >>>   > > Is there a way to allocate the available and any future supply
> >>>   > > judiciously
> >>>   > > amongst existing customers orders by considering different
> factors
> >>> like
> >>>   > > estimated delivery dates, order priority, customer preference
> etc?
> >>>   > >
> >>>   > >
> >>>   > > Thanks & Regards
> >>>   > > --
> >>>   > > Deepak Nigam
> >>>   >
> >>>
>
>


Re: Inventory Allocation Planning

2018-08-16 Thread deepak nigam
I have started some implementation regarding this. Here is the link for the
reference,

https://github.com/Deepak27021990/ofbiz-framework/tree/sales-allocation-plan

Thanks & Regards
--
Deepak Nigam

On Thu, Aug 16, 2018 at 5:39 PM deepak nigam 
wrote:

> Moving thread to the dev mailing list.
>
> On Thu, Aug 16, 2018 at 3:33 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
>> Hi Deepak,
>>
>> Interesting proposition, this should be discussed in dev ML
>>
>> Thanks
>>
>> Jacques
>>
>>
>> Le 16/08/2018 à 11:28, deepak nigam a écrit :
>> > While creating orders from the backend, we have the option to set
>> > parameters like 'Ship After Date' and 'Ship Before Date' to manage the
>> > fulfilment cycle more efficiently. Inventory gets reserved for the
>> product
>> > based on a FIFO basis. Sometimes the fulfilment time for the order is
>> high
>> > and inventory unnecessarily gets locked for some time period.
>> >
>> > We can introduce a new parameter (at order item level) 'Reserve After
>> Date'
>> > which will indicate the date only after which reservation can happen. In
>> > this way, we can manage the stock availability more efficiently.
>> >
>> > On Mon, Aug 13, 2018 at 10:35 AM deepak nigam <
>> deepak.nigam1...@gmail.com>
>> > wrote:
>> >
>> >> Thanks, James.
>> >>
>> >> Here is the JIRA ticket
>> >> <https://issues.apache.org/jira/browse/OFBIZ-10518> for the same.
>> Soon I
>> >> will share detailed design notes here and in the ticker also.
>> >>
>> >>
>> >> Thanks & Regards
>> >> --
>> >> Deepak Nigam
>> >>
>> >> On Mon, Aug 13, 2018 at 2:17 AM  wrote:
>> >>
>> >>> Deepak - I did not see it in OFbiz but I did in Opentaps.  I can send
>> >>> you a video of the functionality
>> >>>
>> >>>  Original Message 
>> >>> Subject: Re: Inventory Allocation Planning
>> >>> From: deepak nigam 
>> >>> Date: Thu, August 09, 2018 2:24 am
>> >>> To: u...@ofbiz.apache.org, ja...@productive1.com
>> >>>
>> >>> Hi James,
>> >>>
>> >>> Did you get a chance to confirm it in OFBiz?
>> >>>
>> >>>
>> >>> @All,
>> >>> As far as I came to know, the feature to allocate the inventory (not
>> >>> actual reservation at this point) is not available OOTB. We can think
>> >>> about the idea of its implementation.
>> >>>
>> >>>
>> >>>
>> >>>
>> >>> Thanks & Regards
>> >>> --
>> >>> Deepak Nigam
>> >>>
>> >>>
>> >>>
>> >>>
>> >>> On Sun, Aug 5, 2018 at 10:14 PM  wrote:
>> >>>
>> >>> This will only allocate the current inventory.  I see it in
>> >>>   opentaps...let me confirm in Ofbiz.
>> >>>
>> >>>    Original Message 
>> >>>   Subject: Re: Inventory Allocation Planning
>> >>>   From: deepak nigam 
>> >>>   Date: Fri, August 03, 2018 12:40 am
>> >>>   To: u...@ofbiz.apache.org
>> >>>
>> >>>   Thanks, James.
>> >>>
>> >>>   Will this method honour the upcoming supply also? I am more
>> interested
>> >>>   in a
>> >>>   supply allocation plan by using which I can allocate the available
>> and
>> >>>   upcoming supply amongst the open orders.
>> >>>
>> >>>
>> >>>   Thanks & Regards
>> >>>   --
>> >>>   Deepak Nigam
>> >>>
>> >>>   On Wed, Aug 1, 2018 at 12:26 AM Paul Mandeltort > >
>> >>>   wrote:
>> >>>
>> >>>   > Where is this screen located? Or are you referring to the order
>> >>>   > priority field in ordermgr?
>> >>>   >
>> >>>   > —P
>> >>>   >
>> >>>   > > On Jul 31, 2018, at 1:48 PM,  <
>> >>>   > ja...@productive1.com> wrote:
>> >>>   > >
>> >>>   > >
>> >>>   > > There is a way to reallocate using the order priority screen.
>> You
>> >>> can
>> >>>   > > bump backorders up and give them a higher priority.
>> >>>   > >
>> >>>   > > Thanks,
>> >>>   > >
>> >>>   > > James
>> >>>   > >  Original Message 
>> >>>   > > Subject: Inventory Allocation Planning
>> >>>   > > From: deepak nigam 
>> >>>   > > Date: Tue, July 31, 2018 5:28 am
>> >>>   > > To: u...@ofbiz.apache.org
>> >>>   > >
>> >>>   > > Hi All,
>> >>>   > >
>> >>>   > > In the current implementation of inventory reservation flow,
>> >>> inventory
>> >>>   > > gets
>> >>>   > > reserved for the order based on the reservation algorithm (FIFO,
>> >>> LIFO
>> >>>   > > etc).
>> >>>   > > Many times, the fulfilment cycle of the order is too long or
>> due to
>> >>> some
>> >>>   > > unexpected circumstances, the order holds the inventory for a
>> long
>> >>> time.
>> >>>   > > In
>> >>>   > > such scenarios, inventory availability becomes one of the major
>> >>>   > > bottlenecks
>> >>>   > > in fulfilling the other sales order and businesses often remains
>> >>> short
>> >>>   > > supplied against the demand.
>> >>>   > >
>> >>>   > > Is there a way to allocate the available and any future supply
>> >>>   > > judiciously
>> >>>   > > amongst existing customers orders by considering different
>> factors
>> >>> like
>> >>>   > > estimated delivery dates, order priority, customer preference
>> etc?
>> >>>   > >
>> >>>   > >
>> >>>   > > Thanks & Regards
>> >>>   > > --
>> >>>   > > Deepak Nigam
>> >>>   >
>> >>>
>>
>>


Re: Inventory Allocation Planning

2018-08-21 Thread deepak nigam
Here is the JIRA ticket for the 'reserverAfterDate' feature.
https://issues.apache.org/jira/browse/OFBIZ-10534

I have uploaded the patch and screenshots of the feature.

Thanks & Regards
--
Deepak Nigam
HotWax Systems

On Mon, Aug 20, 2018 at 2:31 PM deepak nigam 
wrote:

> Here is the JIRA ticket for the same:
> https://issues.apache.org/jira/browse/OFBIZ-10518
>
> I will provide the updated patch soon.
>
> On Sat, Aug 18, 2018 at 5:51 PM Pierre Smits 
> wrote:
>
>> Without a JIRA ticket providing the necessary business and use cases, et
>> al, it is difficult to address this topic.
>>
>> One thing to keep in mind though, is that the (ultimate) gatekeeper
>> regarding fulfilment of orders is the warehouse manager.
>>
>>
>> Best regards,
>>
>> Pierre Smits
>>
>> Apache Trafodion <https://trafodion.apache.org>, Vice President
>> Apache Directory <https://directory.apache.org>, PMC Member
>> Apache Incubator <https://incubator.apache.org>, committer
>> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
>> privileges)
>> since 2008*
>> Apache Steve <https://steve.apache.org>, committer
>>
>> On Sat, Aug 18, 2018 at 9:01 AM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> > Hi Deepak,
>> >
>> > Will you later provide a patch in a Jira? It's easier for review.
>> >
>> > Jacques
>> >
>> >
>> >
>> > Le 17/08/2018 à 07:42, deepak nigam a écrit :
>> >
>> >> I have started some implementation regarding this. Here is the link for
>> >> the
>> >> reference,
>> >>
>> >> https://github.com/Deepak27021990/ofbiz-framework/tree/
>> >> sales-allocation-plan
>> >>
>> >> Thanks & Regards
>> >> --
>> >> Deepak Nigam
>> >>
>> >> On Thu, Aug 16, 2018 at 5:39 PM deepak nigam <
>> deepak.nigam1...@gmail.com>
>> >> wrote:
>> >>
>> >> Moving thread to the dev mailing list.
>> >>>
>> >>> On Thu, Aug 16, 2018 at 3:33 PM Jacques Le Roux <
>> >>> jacques.le.r...@les7arts.com> wrote:
>> >>>
>> >>> Hi Deepak,
>> >>>>
>> >>>> Interesting proposition, this should be discussed in dev ML
>> >>>>
>> >>>> Thanks
>> >>>>
>> >>>> Jacques
>> >>>>
>> >>>>
>> >>>> Le 16/08/2018 à 11:28, deepak nigam a écrit :
>> >>>>
>> >>>>> While creating orders from the backend, we have the option to set
>> >>>>> parameters like 'Ship After Date' and 'Ship Before Date' to manage
>> the
>> >>>>> fulfilment cycle more efficiently. Inventory gets reserved for the
>> >>>>>
>> >>>> product
>> >>>>
>> >>>>> based on a FIFO basis. Sometimes the fulfilment time for the order
>> is
>> >>>>>
>> >>>> high
>> >>>>
>> >>>>> and inventory unnecessarily gets locked for some time period.
>> >>>>>
>> >>>>> We can introduce a new parameter (at order item level) 'Reserve
>> After
>> >>>>>
>> >>>> Date'
>> >>>>
>> >>>>> which will indicate the date only after which reservation can
>> happen.
>> >>>>> In
>> >>>>> this way, we can manage the stock availability more efficiently.
>> >>>>>
>> >>>>> On Mon, Aug 13, 2018 at 10:35 AM deepak nigam <
>> >>>>>
>> >>>> deepak.nigam1...@gmail.com>
>> >>>>
>> >>>>> wrote:
>> >>>>>
>> >>>>> Thanks, James.
>> >>>>>>
>> >>>>>> Here is the JIRA ticket
>> >>>>>> <https://issues.apache.org/jira/browse/OFBIZ-10518> for the same.
>> >>>>>>
>> >>>>> Soon I
>> >>>>
>> >>>>> will share detailed design notes here and in the ticker also.
>> >>>>>>
>> >>>>>>
>> >>>>>> Thanks & Regards
>> >>>>>> --
>> >>>>>> Deepak Nigam
>> >>>>>>
>&g

Re: Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity

2018-08-24 Thread deepak nigam
Here is the JIRA ticket for addressing this issue:

https://issues.apache.org/jira/browse/OFBIZ-10538

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


On Wed, Aug 8, 2018 at 9:42 PM Jacques Le Roux 
wrote:

> Hi Suraj, Deepak,
>
> I agree, I see no reasons why it would be created and not update.
> While at it, using currentPromisedDate in services seems also better
> indeed.
>
> Jacques
>
> Le 08/08/2018 à 11:17, Suraj Khurana a écrit :
> > Hello Deepak,
> >
> > This is interesting case. IMO, currentPromisedDate should also be updated
> > after updating 'Ship Before Date'.
> > Also, in mentioned services, I propose we should use currentPromisedDate
> > instead of promisedDateTime field.
> >
> > --
> > Best Regards,
> > Suraj Khurana | Omni-channel OMS Technical Expert
> > Cell phone: +91 96697-50002
> >
> >
> > On Tue, Aug 7, 2018 at 11:29 AM, deepak nigam <
> deepak.nigam1...@gmail.com>
> > wrote:
> >
> >> Hello Devs,
> >>
> >> While creating the sales order from the backend, if we set the 'Ship
> Before
> >> Date' it will be stored in OrderItemShipGroup.shipByDate field and same
> >> will be propagated to OrderItemShipGrpInvRes.promisedDateTime
> >> and OrderItemShipGrpInvRes.currentPromisedDate fields.
> >>
> >> On updating the 'Ship Before Date' from the order view page later, the
> >> value gets updated in OrderItemShipGroup entity but remains the same in
> >> OrderItemShipGroupInvRes entity.
> >>
> >> Is this the expected behaviour or OrderItemShipGroupInvRes should also
> get
> >> updated? OrderItemShipGrpInvRes.promisedDateTime &
> >> OrderItemShipGrpInvRes.currentPromisedDate is used in many services like
> >> 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity',
> >> 'reserveProductInventory' etc.
> >>
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Nigam
> >>
>
>


Re: Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity

2018-08-24 Thread deepak nigam
Thanks, Taher.

Update the description in the ticket.

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


On Fri, Aug 24, 2018 at 12:04 PM Taher Alkhateeb 
wrote:

> Or alternatively, perhaps update the description to propose that the date
> _should_ be updated
>
> On Fri, Aug 24, 2018, 9:32 AM Taher Alkhateeb 
> wrote:
>
> > Hi Deepak,
> >
> > I could be wrong but the JIRA seems to more like a question, not a bug
> > report.
> >
> > Perhaps it would be better to issue a JIRA when:
> > - you have identified and confirmed a bug
> > - you can provide an explanation for it.
> > - you can provide _repeat_ steps for others to replicate.
> >
> > On Fri, Aug 24, 2018, 9:24 AM deepak nigam 
> > wrote:
> >
> >> Here is the JIRA ticket for addressing this issue:
> >>
> >> https://issues.apache.org/jira/browse/OFBIZ-10538
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Nigam
> >> HotWax Systems Pvt. Ltd.
> >>
> >>
> >> On Wed, Aug 8, 2018 at 9:42 PM Jacques Le Roux <
> >> jacques.le.r...@les7arts.com>
> >> wrote:
> >>
> >> > Hi Suraj, Deepak,
> >> >
> >> > I agree, I see no reasons why it would be created and not update.
> >> > While at it, using currentPromisedDate in services seems also better
> >> > indeed.
> >> >
> >> > Jacques
> >> >
> >> > Le 08/08/2018 à 11:17, Suraj Khurana a écrit :
> >> > > Hello Deepak,
> >> > >
> >> > > This is interesting case. IMO, currentPromisedDate should also be
> >> updated
> >> > > after updating 'Ship Before Date'.
> >> > > Also, in mentioned services, I propose we should use
> >> currentPromisedDate
> >> > > instead of promisedDateTime field.
> >> > >
> >> > > --
> >> > > Best Regards,
> >> > > Suraj Khurana | Omni-channel OMS Technical Expert
> >> > > Cell phone: +91 96697-50002
> >> > >
> >> > >
> >> > > On Tue, Aug 7, 2018 at 11:29 AM, deepak nigam <
> >> > deepak.nigam1...@gmail.com>
> >> > > wrote:
> >> > >
> >> > >> Hello Devs,
> >> > >>
> >> > >> While creating the sales order from the backend, if we set the
> 'Ship
> >> > Before
> >> > >> Date' it will be stored in OrderItemShipGroup.shipByDate field and
> >> same
> >> > >> will be propagated to OrderItemShipGrpInvRes.promisedDateTime
> >> > >> and OrderItemShipGrpInvRes.currentPromisedDate fields.
> >> > >>
> >> > >> On updating the 'Ship Before Date' from the order view page later,
> >> the
> >> > >> value gets updated in OrderItemShipGroup entity but remains the
> same
> >> in
> >> > >> OrderItemShipGroupInvRes entity.
> >> > >>
> >> > >> Is this the expected behaviour or OrderItemShipGroupInvRes should
> >> also
> >> > get
> >> > >> updated? OrderItemShipGrpInvRes.promisedDateTime &
> >> > >> OrderItemShipGrpInvRes.currentPromisedDate is used in many services
> >> like
> >> > >> 'getOrderItemShipGroupEstimatedShipDate',
> >> 'getItemBackOrderedQuantity',
> >> > >> 'reserveProductInventory' etc.
> >> > >>
> >> > >>
> >> > >> Thanks & Regards
> >> > >> --
> >> > >> Deepak Nigam
> >> > >>
> >> >
> >> >
> >>
> >
>


Re: Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity

2018-08-24 Thread deepak nigam
*Updated the description.* :)

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.

On Fri, Aug 24, 2018 at 1:17 PM deepak nigam 
wrote:

> Thanks, Taher.
>
> Update the description in the ticket.
>
> Thanks & Regards
> --
> Deepak Nigam
> HotWax Systems Pvt. Ltd.
>
>
> On Fri, Aug 24, 2018 at 12:04 PM Taher Alkhateeb <
> slidingfilame...@gmail.com> wrote:
>
>> Or alternatively, perhaps update the description to propose that the date
>> _should_ be updated
>>
>> On Fri, Aug 24, 2018, 9:32 AM Taher Alkhateeb > >
>> wrote:
>>
>> > Hi Deepak,
>> >
>> > I could be wrong but the JIRA seems to more like a question, not a bug
>> > report.
>> >
>> > Perhaps it would be better to issue a JIRA when:
>> > - you have identified and confirmed a bug
>> > - you can provide an explanation for it.
>> > - you can provide _repeat_ steps for others to replicate.
>> >
>> > On Fri, Aug 24, 2018, 9:24 AM deepak nigam 
>> > wrote:
>> >
>> >> Here is the JIRA ticket for addressing this issue:
>> >>
>> >> https://issues.apache.org/jira/browse/OFBIZ-10538
>> >>
>> >> Thanks & Regards
>> >> --
>> >> Deepak Nigam
>> >> HotWax Systems Pvt. Ltd.
>> >>
>> >>
>> >> On Wed, Aug 8, 2018 at 9:42 PM Jacques Le Roux <
>> >> jacques.le.r...@les7arts.com>
>> >> wrote:
>> >>
>> >> > Hi Suraj, Deepak,
>> >> >
>> >> > I agree, I see no reasons why it would be created and not update.
>> >> > While at it, using currentPromisedDate in services seems also better
>> >> > indeed.
>> >> >
>> >> > Jacques
>> >> >
>> >> > Le 08/08/2018 à 11:17, Suraj Khurana a écrit :
>> >> > > Hello Deepak,
>> >> > >
>> >> > > This is interesting case. IMO, currentPromisedDate should also be
>> >> updated
>> >> > > after updating 'Ship Before Date'.
>> >> > > Also, in mentioned services, I propose we should use
>> >> currentPromisedDate
>> >> > > instead of promisedDateTime field.
>> >> > >
>> >> > > --
>> >> > > Best Regards,
>> >> > > Suraj Khurana | Omni-channel OMS Technical Expert
>> >> > > Cell phone: +91 96697-50002
>> >> > >
>> >> > >
>> >> > > On Tue, Aug 7, 2018 at 11:29 AM, deepak nigam <
>> >> > deepak.nigam1...@gmail.com>
>> >> > > wrote:
>> >> > >
>> >> > >> Hello Devs,
>> >> > >>
>> >> > >> While creating the sales order from the backend, if we set the
>> 'Ship
>> >> > Before
>> >> > >> Date' it will be stored in OrderItemShipGroup.shipByDate field and
>> >> same
>> >> > >> will be propagated to OrderItemShipGrpInvRes.promisedDateTime
>> >> > >> and OrderItemShipGrpInvRes.currentPromisedDate fields.
>> >> > >>
>> >> > >> On updating the 'Ship Before Date' from the order view page later,
>> >> the
>> >> > >> value gets updated in OrderItemShipGroup entity but remains the
>> same
>> >> in
>> >> > >> OrderItemShipGroupInvRes entity.
>> >> > >>
>> >> > >> Is this the expected behaviour or OrderItemShipGroupInvRes should
>> >> also
>> >> > get
>> >> > >> updated? OrderItemShipGrpInvRes.promisedDateTime &
>> >> > >> OrderItemShipGrpInvRes.currentPromisedDate is used in many
>> services
>> >> like
>> >> > >> 'getOrderItemShipGroupEstimatedShipDate',
>> >> 'getItemBackOrderedQuantity',
>> >> > >> 'reserveProductInventory' etc.
>> >> > >>
>> >> > >>
>> >> > >> Thanks & Regards
>> >> > >> --
>> >> > >> Deepak Nigam
>> >> > >>
>> >> >
>> >> >
>> >>
>> >
>>
>


Re: svn commit: r1838081 - in /ofbiz/ofbiz-framework/trunk/framework: base/src/main/java/org/apache/ofbiz/base/util/collections/ base/src/test/java/org/apache/ofbiz/base/collections/ webapp/config/ we

2018-08-28 Thread deepak nigam
Thanks, Jacques and Mathieu.

Verified the fix on the local machine, the system is working fine now.


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.

On Tue, Aug 28, 2018 at 9:51 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi,
>
> I confirm this issue which can easily be reproduced in trunk and locally.
>
> The problem is r1838081 prevents to serialise requests.
>
> Like in ordermgr/control/updateCheckoutOptions/quickcheckout where
> updateCheckoutOptions and quickcheckout are serialised to update the check
> out with
> updateCheckoutOptions and then get back to the screen with quickcheckout
>
> It's fixed at r1839451 using last Mathieu's patch in OFBIZ-10438
>
> Jacques
>
>
> Le 20/08/2018 à 06:25, deepak nigam a écrit :
> > Hi Shi/Rishi,
> >
> > I was using the trunk downloaded from GitHub (
> > https://github.com/apache/ofbiz-framework). I will reverify this issue
> on
> > SVN trunk and will let you know the details.
> >
> > On Mon, Aug 20, 2018 at 1:37 AM Shi Jinghai 
> wrote:
> >
> >> Hi Deepak,
> >>
> >> As Rishi suggested, could you please reopen OFBIZ-10438 or create a new
> >> jira for the bug you mentioned here?
> >>
> >> I cannot reproduce it in my local and online trunk demo environments, I
> >> guess my test case is not the same as yours.
> >>
> >> Thanks,
> >>
> >> Shi Jinghai
> >>
> >> -邮件原件-
> >> 发件人: Rishi Solanki [mailto:rishisolan...@gmail.com]
> >> 发送时间: 2018年8月17日 21:24
> >> 收件人: dev@ofbiz.apache.org
> >> 抄送: comm...@ofbiz.apache.org
> >> 主题: Re: svn commit: r1838081 - in
> /ofbiz/ofbiz-framework/trunk/framework:
> >> base/src/main/java/org/apache/ofbiz/base/util/collections/
> >> base/src/test/java/org/apache/ofbiz/base/collections/ webapp/config/
> >> webapp/dtd/ webapp/src/main/java/org/apache/ofbiz/weba...
> >>
> >> Deepak,
> >>
> >> Thanks for reporting the issue, can you please create Jira ticket and
> add
> >> details (images are not coming at mailing list) with logs if possible?
> >>
> >>
> >>
> >> Rishi Solanki
> >> Sr Manager, Enterprise Software Development
> >> HotWax Systems Pvt. Ltd.
> >> Direct: +91-9893287847
> >> http://www.hotwaxsystems.com
> >> www.hotwax.co
> >>
> >> On Fri, Aug 17, 2018 at 6:32 PM, deepak nigam <
> deepak.nigam1...@gmail.com>
> >> wrote:
> >>
> >>> I am using OFBiz trunk and on creating an order from backend and
> getting
> >>> error screens while adding an item to cart and selecting shipping
> >> methods.
> >>> Please find the attached images for your reference.
> >>>
> >>> On further investigation, I found that on reverting this commit things
> >> are
> >>> working fine. Can we verify this commit once more?
> >>>
> >>> On Wed, Aug 15, 2018 at 5:15 PM  wrote:
> >>>
> >>>> Author: shijh
> >>>> Date: Wed Aug 15 11:45:45 2018
> >>>> New Revision: 1838081
> >>>>
> >>>> URL: http://svn.apache.org/viewvc?rev=1838081=rev
> >>>> Log:
> >>>> Implemented: Add method attribute to request-map to controll a uri can
> >> be
> >>>> called GET or POST only
> >>>> OFBIZ-10438
> >>>>
> >>>> Thanks: Mathieu Lirzin for the contribution.
> >>>>
> >>>> Added:
> >>>>  ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/
> >>>> org/apache/ofbiz/base/util/collections/MultivaluedMapContext.java
> >>>>   (with props)
> >>>>  ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/
> >>>>
> org/apache/ofbiz/base/util/collections/MultivaluedMapContextAdapter.java
> >>>>   (with props)
> >>>>  ofbiz/ofbiz-framework/trunk/framework/base/src/test/java/
> >>>> org/apache/ofbiz/base/collections/
> >>>>  ofbiz/ofbiz-framework/trunk/framework/base/src/test/java/
> >>>>
> org/apache/ofbiz/base/collections/MultivaluedMapContextAdapterTests.java
> >>>>   (with props)
> >>>>  ofbiz/ofbiz-framework/trunk/framework/base/src/test/java/
> >>>> org/apache/ofbiz/base/collections/MultivaluedMapContextTests.java
> >>>>   (with props)
> >>>>  ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/
> &g

Re: [Proposal] Enhance the controller logic to accommodate HTTP methods and prepare for REST

2018-08-29 Thread deepak nigam
Hi Shi,

Verified the fix by Mathieu on the local machine, the system is working
fine now.

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.

On Wed, Aug 29, 2018 at 11:01 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Taher,
>
> Thank you for summarizing. I agree with this proposal
>
> After I have applied Mathieu's last OFBIZ-10438 at r1839451, I think we
> are ready to continue this work
>
> Jacques
>
> Le 09/08/2018 à 17:31, Taher Alkhateeb a écrit :
> > Hello Everyone,
> >
> > We want to make this formal with proper community consensus and I will
> > try to keep this short.
> >
> > In [1] Mathieu Lirzin is providing some (in my opinion) good work on
> > converting the Control Servlet logic to be able to handle the
> > different HTTP methods (GET, POST, etc ...) The purpose of the work in
> > this JIRA is simple. You should be able to call a request with a
> > different HTTP methods by using a format like  > method="post">. You can find a more detailed discussion in [2]. This
> > is the first step of a multi-step process to be able to integrate REST
> > API with OFBiz.
> >
> > So, this is a proposal to apply the following:
> > 1- Enhance the controller to be able to accommodate one-or-more HTTP
> > methods (method="GET,POST")
> > 2- Enhance the controller to further be able to get "patterns" that
> > can be mapped to REST APIs. So a request like
> > https://host/control/request/customer/orders/1/orderName can be
> > processed as a resource
> >
> > Please correct me if I was wrong on anything written here Mathieu, and
> > please everyone provide your feedback if you approve of moving forward
> > with this initiative.
> >
> > [1] https://issues.apache.org/jira/browse/OFBIZ-10438
> > [2] https://s.apache.org/ec2r
> >
>
>


Re: svn commit: r1838081 - in /ofbiz/ofbiz-framework/trunk/framework: base/src/main/java/org/apache/ofbiz/base/util/collections/ base/src/test/java/org/apache/ofbiz/base/collections/ webapp/config/ we

2018-08-19 Thread deepak nigam
Hi Shi/Rishi,

I was using the trunk downloaded from GitHub (
https://github.com/apache/ofbiz-framework). I will reverify this issue on
SVN trunk and will let you know the details.

On Mon, Aug 20, 2018 at 1:37 AM Shi Jinghai  wrote:

> Hi Deepak,
>
> As Rishi suggested, could you please reopen OFBIZ-10438 or create a new
> jira for the bug you mentioned here?
>
> I cannot reproduce it in my local and online trunk demo environments, I
> guess my test case is not the same as yours.
>
> Thanks,
>
> Shi Jinghai
>
> -邮件原件-
> 发件人: Rishi Solanki [mailto:rishisolan...@gmail.com]
> 发送时间: 2018年8月17日 21:24
> 收件人: dev@ofbiz.apache.org
> 抄送: comm...@ofbiz.apache.org
> 主题: Re: svn commit: r1838081 - in /ofbiz/ofbiz-framework/trunk/framework:
> base/src/main/java/org/apache/ofbiz/base/util/collections/
> base/src/test/java/org/apache/ofbiz/base/collections/ webapp/config/
> webapp/dtd/ webapp/src/main/java/org/apache/ofbiz/weba...
>
> Deepak,
>
> Thanks for reporting the issue, can you please create Jira ticket and add
> details (images are not coming at mailing list) with logs if possible?
>
>
>
> Rishi Solanki
> Sr Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
> www.hotwax.co
>
> On Fri, Aug 17, 2018 at 6:32 PM, deepak nigam 
> wrote:
>
> > I am using OFBiz trunk and on creating an order from backend and getting
> > error screens while adding an item to cart and selecting shipping
> methods.
> > Please find the attached images for your reference.
> >
> > On further investigation, I found that on reverting this commit things
> are
> > working fine. Can we verify this commit once more?
> >
> > On Wed, Aug 15, 2018 at 5:15 PM  wrote:
> >
> >> Author: shijh
> >> Date: Wed Aug 15 11:45:45 2018
> >> New Revision: 1838081
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1838081=rev
> >> Log:
> >> Implemented: Add method attribute to request-map to controll a uri can
> be
> >> called GET or POST only
> >> OFBIZ-10438
> >>
> >> Thanks: Mathieu Lirzin for the contribution.
> >>
> >> Added:
> >> ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/
> >> org/apache/ofbiz/base/util/collections/MultivaluedMapContext.java
> >>  (with props)
> >> ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/
> >> org/apache/ofbiz/base/util/collections/MultivaluedMapContextAdapter.java
> >>  (with props)
> >> ofbiz/ofbiz-framework/trunk/framework/base/src/test/java/
> >> org/apache/ofbiz/base/collections/
> >> ofbiz/ofbiz-framework/trunk/framework/base/src/test/java/
> >> org/apache/ofbiz/base/collections/MultivaluedMapContextAdapterTests.java
> >>  (with props)
> >> ofbiz/ofbiz-framework/trunk/framework/base/src/test/java/
> >> org/apache/ofbiz/base/collections/MultivaluedMapContextTests.java
> >>  (with props)
> >> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/
> >> java/org/apache/ofbiz/webapp/control/MethodNotAllowedException.java
> >>  (with props)
> >> ofbiz/ofbiz-framework/trunk/framework/webapp/src/test/
> >> java/org/apache/ofbiz/webapp/control/RequestHandlerTests.java   (with
> >> props)
> >> Modified:
> >> ofbiz/ofbiz-framework/trunk/framework/webapp/config/
> >> WebappUiLabels.xml
> >> ofbiz/ofbiz-framework/trunk/framework/webapp/dtd/site-conf.xsd
> >> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/
> >> java/org/apache/ofbiz/webapp/control/ConfigXMLReader.java
> >> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/
> >> java/org/apache/ofbiz/webapp/control/ControlServlet.java
> >> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/
> >> java/org/apache/ofbiz/webapp/control/RequestHandler.java
> >>
> >> Added: ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/
> >> org/apache/ofbiz/base/util/collections/MultivaluedMapContext.java
> >> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> >> framework/base/src/main/java/org/apache/ofbiz/base/util/collections/
> >> MultivaluedMapContext.java?rev=1838081=auto
> >> 
> >> ==
> >> --- ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/
> >> org/apache/ofbiz/base/util/collections/MultivaluedMapContext.java
> (added)
> >> +++ ofbiz/ofbiz-framework/trunk/framework/base/

Re: Inventory Allocation Planning

2018-08-20 Thread deepak nigam
Here is the JIRA ticket for the same:
https://issues.apache.org/jira/browse/OFBIZ-10518

I will provide the updated patch soon.

On Sat, Aug 18, 2018 at 5:51 PM Pierre Smits  wrote:

> Without a JIRA ticket providing the necessary business and use cases, et
> al, it is difficult to address this topic.
>
> One thing to keep in mind though, is that the (ultimate) gatekeeper
> regarding fulfilment of orders is the warehouse manager.
>
>
> Best regards,
>
> Pierre Smits
>
> Apache Trafodion <https://trafodion.apache.org>, Vice President
> Apache Directory <https://directory.apache.org>, PMC Member
> Apache Incubator <https://incubator.apache.org>, committer
> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
> since 2008*
> Apache Steve <https://steve.apache.org>, committer
>
> On Sat, Aug 18, 2018 at 9:01 AM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Hi Deepak,
> >
> > Will you later provide a patch in a Jira? It's easier for review.
> >
> > Jacques
> >
> >
> >
> > Le 17/08/2018 à 07:42, deepak nigam a écrit :
> >
> >> I have started some implementation regarding this. Here is the link for
> >> the
> >> reference,
> >>
> >> https://github.com/Deepak27021990/ofbiz-framework/tree/
> >> sales-allocation-plan
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Nigam
> >>
> >> On Thu, Aug 16, 2018 at 5:39 PM deepak nigam <
> deepak.nigam1...@gmail.com>
> >> wrote:
> >>
> >> Moving thread to the dev mailing list.
> >>>
> >>> On Thu, Aug 16, 2018 at 3:33 PM Jacques Le Roux <
> >>> jacques.le.r...@les7arts.com> wrote:
> >>>
> >>> Hi Deepak,
> >>>>
> >>>> Interesting proposition, this should be discussed in dev ML
> >>>>
> >>>> Thanks
> >>>>
> >>>> Jacques
> >>>>
> >>>>
> >>>> Le 16/08/2018 à 11:28, deepak nigam a écrit :
> >>>>
> >>>>> While creating orders from the backend, we have the option to set
> >>>>> parameters like 'Ship After Date' and 'Ship Before Date' to manage
> the
> >>>>> fulfilment cycle more efficiently. Inventory gets reserved for the
> >>>>>
> >>>> product
> >>>>
> >>>>> based on a FIFO basis. Sometimes the fulfilment time for the order is
> >>>>>
> >>>> high
> >>>>
> >>>>> and inventory unnecessarily gets locked for some time period.
> >>>>>
> >>>>> We can introduce a new parameter (at order item level) 'Reserve After
> >>>>>
> >>>> Date'
> >>>>
> >>>>> which will indicate the date only after which reservation can happen.
> >>>>> In
> >>>>> this way, we can manage the stock availability more efficiently.
> >>>>>
> >>>>> On Mon, Aug 13, 2018 at 10:35 AM deepak nigam <
> >>>>>
> >>>> deepak.nigam1...@gmail.com>
> >>>>
> >>>>> wrote:
> >>>>>
> >>>>> Thanks, James.
> >>>>>>
> >>>>>> Here is the JIRA ticket
> >>>>>> <https://issues.apache.org/jira/browse/OFBIZ-10518> for the same.
> >>>>>>
> >>>>> Soon I
> >>>>
> >>>>> will share detailed design notes here and in the ticker also.
> >>>>>>
> >>>>>>
> >>>>>> Thanks & Regards
> >>>>>> --
> >>>>>> Deepak Nigam
> >>>>>>
> >>>>>> On Mon, Aug 13, 2018 at 2:17 AM  wrote:
> >>>>>>
> >>>>>> Deepak - I did not see it in OFbiz but I did in Opentaps.  I can
> send
> >>>>>>> you a video of the functionality
> >>>>>>>
> >>>>>>>  Original Message 
> >>>>>>> Subject: Re: Inventory Allocation Planning
> >>>>>>> From: deepak nigam 
> >>>>>>> Date: Thu, August 09, 2018 2:24 am
> >>>>>>> To: u...@ofbiz.apache.org, ja...@productive1.com
> >>>>>>>
> >>>>>>> Hi James,
> &

Ship Before Date and Ship After Date are not getting updated on the OrderItem table

2018-08-22 Thread deepak nigam
Hello All,

On updating Ship Before Date and Ship After Date from order overview
screen, changes are getting reflected in the OrderItemShipGroup entity but
in the OrderItem entity values remains same. Is this a valid behaviour or
should be considered as a bug? Please let me know the business use cases if
it is a valid behaviour.

Thanks In Advance.

Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


Naming Convention: quickShipPurchaseOrder OR quickReceive PurchaseOrder

2018-09-11 Thread deepak nigam
We have the option of 'Quick Receive Purchase Order' from Order Overview
screen. In the feature, the request and service name is
'quickShipPurchaseOrder. Shouldn't be it like 'quickReceivePurchaseOrder'?
Am I missing something here?



Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


Re: Naming Convention: quickShipPurchaseOrder OR quickReceive PurchaseOrder

2018-09-11 Thread deepak nigam
Thanks, Pierre & Jacques.

Here is the Jira ticket <https://issues.apache.org/jira/browse/OFBIZ-10558>
for the same, I will provide the patch soon.


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


On Tue, Sep 11, 2018 at 3:34 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> +1
>
> Jacques
>
>
> Le 11/09/2018 à 10:59, Pierre Smits a écrit :
> > It may be as simple as a copy-paste action from 'quickShipSalesOrder'
> with
> > a replacement of 'Sales' by 'Purchase'. And yes, it should be corrected
> to
> > avoid confusion. Feel free to create a JIRA ticket and work on the
> > resolution thereof.
> >
> >
> > Best regards,
> >
> > Pierre Smits
> >
> > *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> > *Apache Directory <https://directory.apache.org>, PMC Member*
> > Apache Incubator <https://incubator.apache.org>, committer
> > *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
> privileges)
> > since 2008*
> > Apache Steve <https://steve.apache.org>, committer
> >
> > On Tue, Sep 11, 2018 at 10:53 AM, deepak nigam <
> deepak.nigam1...@gmail.com>
> > wrote:
> >
> >> We have the option of 'Quick Receive Purchase Order' from Order Overview
> >> screen. In the feature, the request and service name is
> >> 'quickShipPurchaseOrder. Shouldn't be it like
> 'quickReceivePurchaseOrder'?
> >> Am I missing something here?
> >>
> >>
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Nigam
> >> HotWax Systems Pvt. Ltd.
> >>
>
>


Missing Security Headers in CMS Events

2018-10-07 Thread Deepak Nigam
Hello All,

While rendering the view through the controller request we set the
important security headers like x-frame-options, strict-transport-security,
x-content-type-options, X-XSS-Protection and Referrer-Policy etc. in the
response object. (Please see the 'rendervView' method of RequestHandler
class.) But these security headers are missing in the pages rendered
through CMS. (Please visit the CmsEvents class).

These headers are very crucial for the security of the application as they
help to prevent various security threats like cross-site scripting,
cross-site request forgery, clickjacking etc.

IMO, we should add these security headers in the response object prepared
through the CMS also. WDYT?

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


Re: Missing Security Headers in CMS Events

2018-10-08 Thread Deepak Nigam
Thank you, all.

Here is the Jira ticket <https://issues.apache.org/jira/browse/OFBIZ-10597>
for the same. FYI, I have included cache related properties also in the
Jira ticket.

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.

On Mon, Oct 8, 2018 at 1:53 PM Deepak Dixit  wrote:

> In RequestHandler they are added to the renderView method,
> I think these should move to another place as if the controller uses
> any other type instead view these headers will not be added to the
> response.
>
> Also we can add a separate method in UtiHttp similar to
> setResponseBrowserProxyNoCache that will add these security headers.
>
> Thanks & Regards
> --
> Deepak Dixit
>
>
> On Mon, Oct 8, 2018 at 1:43 PM, jler...@apache.org 
> wrote:
>
> > They are put in in RequesHandler. There is a "Security header" block
> >
> > Jacques
> >
> >
> >
> > Le 08/10/2018 à 09:17, Taher Alkhateeb a écrit :
> >
> >> Hi Deepak,
> >>
> >> Sounds good. Are these headers applied everywhere except CMS? If no then
> >> why not apply them everywhere?
> >>
> >>
> >> On Mon, Oct 8, 2018, 9:03 AM Deepak Nigam 
> >> wrote:
> >>
> >> Hello All,
> >>>
> >>> While rendering the view through the controller request we set the
> >>> important security headers like x-frame-options,
> >>> strict-transport-security,
> >>> x-content-type-options, X-XSS-Protection and Referrer-Policy etc. in
> the
> >>> response object. (Please see the 'rendervView' method of RequestHandler
> >>> class.) But these security headers are missing in the pages rendered
> >>> through CMS. (Please visit the CmsEvents class).
> >>>
> >>> These headers are very crucial for the security of the application as
> >>> they
> >>> help to prevent various security threats like cross-site scripting,
> >>> cross-site request forgery, clickjacking etc.
> >>>
> >>> IMO, we should add these security headers in the response object
> prepared
> >>> through the CMS also. WDYT?
> >>>
> >>> Thanks & Regards
> >>> --
> >>> Deepak Nigam
> >>> HotWax Systems Pvt. Ltd.
> >>>
> >>>
>


Re: Cookie Consent In E-Coomerce

2018-11-01 Thread Deepak Nigam
Thanks, Benjamin, Jacques.

Definitely, we will move forward only after studying  OFBiz cookies in
depth. I just put initial thought came to my mind.



On Wed, Oct 31, 2018 at 9:03 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks Deepak, Benjamin,
>
> We are indeed only concerned by the ecommerce webapps (both ecommerce and
> ecomse). They are the sole to be public. The backend applications should
> not
> be concerned.
>
> Actually, in ecommerce webapps, we use technical cookies: JSSESSIONID,
> possibly cookie.domain and maybe jstree* ones. I believe they all fall in
> the
> exempt cases.
>
> With OFBIZ-10635 I'm currently working on autoUserLoginId cookies. While
> doing so I spotted that securedLoginId has the same duration (1 year) than
> autoUserLoginId. I have reduced it to the browser session so it also falls
> in the exempt cases. I'll commit that very soon.
>
> I have not read all the details but I believe the only ones we should
> think about are the autoUserLoginId and OFBiz.Visitor cookies. They
> inherently
> does not contain party data, but from the visitorId or userLoginId fields
> it's possible to get to the party data. Not sure it's an issue as is,
> because AFAIK we use only first‑party cookies[1] but the problem seems
> their durations: one year.
>
> [1]
> https://www.opentracker.net/article/third-party-cookies-vs-first-party-cookies
>
> Jacques
>
> Le 31/10/2018 à 14:05, Benjamin Jugl a écrit :
> > Hello all,
> >
> > just before you go in head over heels, please consider the following:
> >
> >"However, some cookies are exempt from this requirement. Consent is
> >not required if the cookie is:
> >
> >  * used for the sole purpose of carrying out the transmission of a
> >communication, and
> >  * strictly necessary in order for the provider of an information
> >society service explicitly required by the user to provide that
> >service.
> >
> >Cookies clearly exempt from consent according to the EU advisory
> >body on data protection- WP29pdf
> > <
> http://ec.europa.eu/justice/data-protection/article-29/documentation/opinion-recommendation/files/2012/wp194_en.pdf
> > include:
> >
> >  * *user‑input* cookies (session-id) such as first‑party cookies to
> >keep track of the user's input when filling online forms,
> >shopping carts, etc., for the duration of a session or
> >persistent cookies limited to a few hours in some cases
> >  * *authentication* cookies, to identify the user once he has
> >logged in, for the duration of a session
> >  * *user‑centric security* cookies, used to detect authentication
> >abuses, for a limited persistent duration
> >  * *multimedia content player* cookies, used to store technical
> >data to play back video or audio content, for the duration of a
> >session
> >  * *load‑balancing* cookies, for the duration of session
> >  * *user‑interface customisation* cookies such as language or font
> >preferences, for the duration of a session (or slightly longer)
> >  * *third‑party social plug‑in content‑sharing* cookies, for
> >logged‑in members of a social network."
> >
> > (http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm)
> >
> > Does OFBiz even set other cookies? If yes, for what are they needed?
> >
> > Kind regards, Benjamin Jugl
> >
> >
> >
> > On 31.10.18 13:11, Deepak Nigam wrote:
> >> Hello All,
> >>
> >> The Cookie Law is a piece of privacy legislation that requires websites
> to
> >> get consent from visitors to store or retrieve any information on their
> >> computer, smartphone or tablet. It was designed to protect online
> privacy,
> >> by making consumers aware of how information about them is collected and
> >> used online, and give them a choice to allow it or not.
> >>
> >> The EU Cookie Legislation began as a directive from the European Union.
> >> Some variation on the policy has since been adopted by all countries
> within
> >> the EU.
> >>
> >> The EU Cookie Legislation requires 4 actions from website owners who use
> >> cookies:
> >> 1. When someone visits your website, you need to let them know that your
> >> site uses cookies.
> >> 2. You need to provide detailed information regarding how that cookie
> data
> >> will be utilized.
> >> 3. You need to provide visitors with some means of accepting or refusing
> >

Cookie Consent In E-Coomerce

2018-10-31 Thread Deepak Nigam
Hello All,

The Cookie Law is a piece of privacy legislation that requires websites to
get consent from visitors to store or retrieve any information on their
computer, smartphone or tablet. It was designed to protect online privacy,
by making consumers aware of how information about them is collected and
used online, and give them a choice to allow it or not.

The EU Cookie Legislation began as a directive from the European Union.
Some variation on the policy has since been adopted by all countries within
the EU.

The EU Cookie Legislation requires 4 actions from website owners who use
cookies:
1. When someone visits your website, you need to let them know that your
site uses cookies.
2. You need to provide detailed information regarding how that cookie data
will be utilized.
3. You need to provide visitors with some means of accepting or refusing
the use of cookies in your site.
4. If they refuse, you need to ensure that cookies will not be placed on
their machine.

For more information about EU cookie policy, please visit here
<http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm>.

As this crucial feature is missing in OFBiz E-Commerce application, we
should work towards its implementation. There are numerous open-source
jQuery plugins available which we can use. Thoughts?


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


Google reCAPTCHA in E-Commerce

2018-11-05 Thread Deepak Nigam
Hello All,

Google reCAPTCHA is a security feature that protects websites forms from
spam entries while letting real people pass through with ease. It can be
used for login, registration, password recovery, comments, popular contact
forms, etc.
Users are required to confirm that they are not a robot before the form can
be submitted. It’s easy for people and hard for bots.

For more information about Google reCAPATCHA, please visit here
<https://developers.google.com/recaptcha/>.

I think this feature will be useful for OFBiz e-commerce also. Thoughts?


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd


Re: Google reCAPTCHA in E-Commerce

2018-11-08 Thread Deepak Nigam
Thanks, Richard & Rishi.

Yes, we can make it configurable at the store level. Here is the Jira ticket
<https://issues.apache.org/jira/browse/OFBIZ-10643> for further discussions
and implementation.



On Mon, Nov 5, 2018 at 6:24 PM Rishi Solanki 
wrote:

> Big +1 for adding this feature with accepted suggestions from Richard. We
> can have it store level configuration to enable and disable as per the
> store requirements.
>
> --
> Rishi Solanki
> Sr Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
> www.hotwax.co
>
>
> On Mon, Nov 5, 2018 at 4:15 PM Richard Siddall <
> richard.sidd...@elirion.net>
> wrote:
>
> > Make it optional.
> >
> > Taking a user experience point-of-view:  Google reCAPTCHA is a
> > technology for punishing internet users for visiting your site.  It
> > greatly increases the number of clicks users have to make to achieve a
> > goal and increases shopping cart abandonment.
> >
> > Definitely not something every site administrator is going to want
> > polluting their e-commerce site.
> >
> > Richard.
> >
> > Deepak Nigam wrote:
> > > Hello All,
> > >
> > > Google reCAPTCHA is a security feature that protects websites forms
> from
> > > spam entries while letting real people pass through with ease. It can
> be
> > > used for login, registration, password recovery, comments, popular
> > contact
> > > forms, etc.
> > > Users are required to confirm that they are not a robot before the form
> > can
> > > be submitted. It’s easy for people and hard for bots.
> > >
> > > For more information about Google reCAPATCHA, please visit here
> > > <https://developers.google.com/recaptcha/>.
> > >
> > > I think this feature will be useful for OFBiz e-commerce also.
> Thoughts?
> > >
> > >
> > > Thanks & Regards
> > > --
> > > Deepak Nigam
> > > HotWax Systems Pvt. Ltd
> > >
> >
> >
>


Re: Hard Coded Cookie Path

2018-11-14 Thread Deepak Nigam
Thanks Girish for the explanation.

What should be the best way to set cookie path for an e-commerce
application?

On Fri, Oct 5, 2018 at 10:48 AM Girish Vasmatkar <
girish.vasmat...@hotwaxsystems.com> wrote:

> Hi Deepak
>
> That largely depends on the use case whether to set cookie path as the root
> of the web server or not. Yes, generally, it is preferred to keep the
> cookies separate for the various web apps deployed on the server.
>
> In OFBiz case, various web applications are deployed on separate mount
> points and if you take, for example, the case of visitor cookie, then it
> makes sense to keep it's path as root because a visitor (same person)
> visiting order manager and accounting should be counted as a same and
> single visitor. You do not want server to create a new visitor cookie for
> order manager if the user has already visited accounting.
>
> Browser will send the visitor cookie as part of request to order manager
> that helps OFBiz identify the visitor.
>
> Often certain other use cases demand server session to be maintained across
> different web applications. Imagine a scenario where you log in to a parent
> web application and then a separate module is part of a different web
> application and you navigate to the sub module from the parent module. You
> would ideally want the session cookie to be "transferred" from parent web
> app to sub web app. Here you will have to make sure the session cookie
> created by the server has the path "/" set. If that is not the case, then
> navigating from parent web app to sub web app will result in session loss.
>
> So, all in all, it is mostly based on your scenario. I hope that makes
> sense.
>
> Thanks,
> Girish Vasmatkar
> HotWax Systems
>
>
> On Thu, Oct 4, 2018 at 4:57 PM Deepak Nigam 
> wrote:
>
> > Hello Folks,
> >
> > During the code walkthrough, I observed that everywhere the cookie path
> > attribute is hardcoded as root '/' using the setPath() method. This is
> not
> > the correct implementation because if the cookie path is set to the root
> > '/', then the cookie will be sent to all the application under the same
> > domain.
> >
> > Is there any best practice around this? Should it be configurable?
> > IMO, the cookie path should be set to '/users/' directory. WDYT?
> >
> >
> > Thanks!
> >
> > Deepak Nigam
> > HotWax Systems Pvt. Ltd
> >
>


Re: Google reCAPTCHA in E-Commerce

2018-11-15 Thread Deepak Nigam
On a side note, copying the content from
https://developers.google.com/recaptcha/docs/versions for more information
about user interaction in Google Recaptcha.

*reCAPTCHA v3:* reCAPTCHA v3 allows you to verify if an interaction is
legitimate without any user interaction. It is a purely JavaScript API
returns a score giving you the ability to take action in the context of
your site: for instance requiring additional factors of authentication,
sending a post to moderation, or throttling bots that may be scraping
content.


*Google reCAPTCHA v3 can be used in combination with a two-factor
authentication mechanism if the obtained score is less than the specified
threshold value.*

*Invisible reCAPTCHA:* The second option 'Invisible reCAPTCHA' does not
require the user to click on a checkbox, instead, it is invoked directly
when the user clicks on an existing button on your site or can be invoked
via a JavaScript API call. The integration requires a JavaScript callback
when reCAPTCHA verification is complete. By default, only the most
suspicious traffic will be prompted to solve a captcha. To alter this
behaviour edit your site security preference under advanced settings.


On Fri, Nov 9, 2018 at 10:08 AM Deepak Nigam 
wrote:

> Thanks, Richard & Rishi.
>
> Yes, we can make it configurable at the store level. Here is the Jira
> ticket <https://issues.apache.org/jira/browse/OFBIZ-10643> for further
> discussions and implementation.
>
>
>
> On Mon, Nov 5, 2018 at 6:24 PM Rishi Solanki 
> wrote:
>
>> Big +1 for adding this feature with accepted suggestions from Richard. We
>> can have it store level configuration to enable and disable as per the
>> store requirements.
>>
>> --
>> Rishi Solanki
>> Sr Manager, Enterprise Software Development
>> HotWax Systems Pvt. Ltd.
>> Direct: +91-9893287847
>> http://www.hotwaxsystems.com
>> www.hotwax.co
>>
>>
>> On Mon, Nov 5, 2018 at 4:15 PM Richard Siddall <
>> richard.sidd...@elirion.net>
>> wrote:
>>
>> > Make it optional.
>> >
>> > Taking a user experience point-of-view:  Google reCAPTCHA is a
>> > technology for punishing internet users for visiting your site.  It
>> > greatly increases the number of clicks users have to make to achieve a
>> > goal and increases shopping cart abandonment.
>> >
>> > Definitely not something every site administrator is going to want
>> > polluting their e-commerce site.
>> >
>> > Richard.
>> >
>> > Deepak Nigam wrote:
>> > > Hello All,
>> > >
>> > > Google reCAPTCHA is a security feature that protects websites forms
>> from
>> > > spam entries while letting real people pass through with ease. It can
>> be
>> > > used for login, registration, password recovery, comments, popular
>> > contact
>> > > forms, etc.
>> > > Users are required to confirm that they are not a robot before the
>> form
>> > can
>> > > be submitted. It’s easy for people and hard for bots.
>> > >
>> > > For more information about Google reCAPATCHA, please visit here
>> > > <https://developers.google.com/recaptcha/>.
>> > >
>> > > I think this feature will be useful for OFBiz e-commerce also.
>> Thoughts?
>> > >
>> > >
>> > > Thanks & Regards
>> > > --
>> > > Deepak Nigam
>> > > HotWax Systems Pvt. Ltd
>> > >
>> >
>> >
>>
>


Re: Cookie Consent In E-Coomerce

2018-11-04 Thread Deepak Nigam
FYI, here is the Jira ticket
<https://issues.apache.org/jira/browse/OFBIZ-10639> for further discussion
and research.

On Thu, Nov 1, 2018 at 3:02 PM Deepak Nigam 
wrote:

> Thanks, Benjamin, Jacques.
>
> Definitely, we will move forward only after studying  OFBiz cookies in
> depth. I just put initial thought came to my mind.
>
>
>
> On Wed, Oct 31, 2018 at 9:03 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
>> Thanks Deepak, Benjamin,
>>
>> We are indeed only concerned by the ecommerce webapps (both ecommerce and
>> ecomse). They are the sole to be public. The backend applications should
>> not
>> be concerned.
>>
>> Actually, in ecommerce webapps, we use technical cookies: JSSESSIONID,
>> possibly cookie.domain and maybe jstree* ones. I believe they all fall in
>> the
>> exempt cases.
>>
>> With OFBIZ-10635 I'm currently working on autoUserLoginId cookies. While
>> doing so I spotted that securedLoginId has the same duration (1 year) than
>> autoUserLoginId. I have reduced it to the browser session so it also
>> falls in the exempt cases. I'll commit that very soon.
>>
>> I have not read all the details but I believe the only ones we should
>> think about are the autoUserLoginId and OFBiz.Visitor cookies. They
>> inherently
>> does not contain party data, but from the visitorId or userLoginId fields
>> it's possible to get to the party data. Not sure it's an issue as is,
>> because AFAIK we use only first‑party cookies[1] but the problem seems
>> their durations: one year.
>>
>> [1]
>> https://www.opentracker.net/article/third-party-cookies-vs-first-party-cookies
>>
>> Jacques
>>
>> Le 31/10/2018 à 14:05, Benjamin Jugl a écrit :
>> > Hello all,
>> >
>> > just before you go in head over heels, please consider the following:
>> >
>> >"However, some cookies are exempt from this requirement. Consent is
>> >not required if the cookie is:
>> >
>> >  * used for the sole purpose of carrying out the transmission of a
>> >communication, and
>> >  * strictly necessary in order for the provider of an information
>> >society service explicitly required by the user to provide that
>> >service.
>> >
>> >Cookies clearly exempt from consent according to the EU advisory
>> >body on data protection- WP29pdf
>> > <
>> http://ec.europa.eu/justice/data-protection/article-29/documentation/opinion-recommendation/files/2012/wp194_en.pdf
>> > include:
>> >
>> >  * *user‑input* cookies (session-id) such as first‑party cookies to
>> >keep track of the user's input when filling online forms,
>> >shopping carts, etc., for the duration of a session or
>> >persistent cookies limited to a few hours in some cases
>> >  * *authentication* cookies, to identify the user once he has
>> >logged in, for the duration of a session
>> >  * *user‑centric security* cookies, used to detect authentication
>> >abuses, for a limited persistent duration
>> >  * *multimedia content player* cookies, used to store technical
>> >data to play back video or audio content, for the duration of a
>> >session
>> >  * *load‑balancing* cookies, for the duration of session
>> >  * *user‑interface customisation* cookies such as language or font
>> >preferences, for the duration of a session (or slightly longer)
>> >  * *third‑party social plug‑in content‑sharing* cookies, for
>> >logged‑in members of a social network."
>> >
>> > (http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm)
>> >
>> > Does OFBiz even set other cookies? If yes, for what are they needed?
>> >
>> > Kind regards, Benjamin Jugl
>> >
>> >
>> >
>> > On 31.10.18 13:11, Deepak Nigam wrote:
>> >> Hello All,
>> >>
>> >> The Cookie Law is a piece of privacy legislation that requires
>> websites to
>> >> get consent from visitors to store or retrieve any information on their
>> >> computer, smartphone or tablet. It was designed to protect online
>> privacy,
>> >> by making consumers aware of how information about them is collected
>> and
>> >> used online, and give them a choice to allow it or not.
>> >>
>> >> The EU Cookie Legislation began as a directive from the European Union

Missing Relation Between ProductStoreShipmentMeth and ProductStore

2018-10-09 Thread Deepak Nigam
Hello All,

In the definition of the entity 'ProductStoreShipmentMeth', no relation is
provided with the entity 'ProductStore'. Is this intentional? IMO, we
should provide the relation between the above two, with type="one", to
maintain the referential integrity. WDYT?


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


Re: Missing Relation Between ProductStoreShipmentMeth and ProductStore

2018-10-09 Thread Deepak Nigam
Thanks, Suraj.

I will create a child ticket for 'ProductStoreShipmentMeth' entity under
OFBIZ-9671 <https://issues.apache.org/jira/browse/OFBIZ-9671>.

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd

On Tue, Oct 9, 2018 at 1:28 PM Suraj Khurana <
suraj.khur...@hotwaxsystems.com> wrote:

> Hello Deepak,
>
> Here is the parent ticket for this effort.
> Ticket: https://issues.apache.org/jira/browse/OFBIZ-9671
>
> HTH.
> --
> Best Regards,
> Suraj Khurana
> Omnichannel OMS Technical Expert
> HotWax Systems
>
> On Tue, Oct 9, 2018 at 1:13 PM, Deepak Nigam 
> wrote:
>
> > Hello All,
> >
> > In the definition of the entity 'ProductStoreShipmentMeth', no relation
> is
> > provided with the entity 'ProductStore'. Is this intentional? IMO, we
> > should provide the relation between the above two, with type="one", to
> > maintain the referential integrity. WDYT?
> >
> >
> > Thanks & Regards
> > --
> > Deepak Nigam
> > HotWax Systems Pvt. Ltd.
> >
>


Plan for Releasing 17.12 branch

2018-10-11 Thread Deepak Nigam
Hello All,

Do we have a plan for releasing 17.12 branch of OFBiz? As it has been
almost a year since we cut the branch 17.12, we can start preparing for
this release.

Any thoughts?


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd


Re: "Not Secure" in the Google Chrome browser

2018-10-01 Thread Deepak Nigam
Hi All,

Verified 'https://ofbiz.apache.org', it is working fine.

Thanks & Regards
--
Deepak Nigam
HotWax System Pvt. Ltd



On Mon, Oct 1, 2018 at 2:35 PM Michael Brohl 
wrote:

> Thank you, Deepak!
>
> Regards,
>
> Michael
>
>
> Am 01.10.18 um 10:25 schrieb Deepak Dixit:
> > Thanks Michael,
> >
> > I just discuss this with our sysadmin, and he suggests the same as your
> > solution :)
> >
> > Let me commit this.
> >
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> >
> >
> > On Mon, Oct 1, 2018 at 1:45 PM, Michael Brohl 
> > wrote:
> >
> >> Hi Deepak,
> >>
> >> I would suggest
> >>
> >> ===
> >>
> >> RewriteCond %{HTTPS} off
> >> RewriteRule ^\/?(.*)$ https://%{HTTP_HOST}/$1 [R=301,L]
> >>
> >> ===
> >>
> >>
> >> 1st statement just checks if https is not active, independent of the
> ports
> >> used.
> >>
> >> 2nd statement does a 301 redirect telling Google that it is permanent.
> >>
> >> Regards,
> >>
> >> Michael
> >>
> >>
> >> Am 01.10.18 um 08:32 schrieb Deepak Dixit:
> >>
> >> Thanks Jacques,
> >>> Following rule should work.
> >>> =
> >>> RewriteCond %{SERVER_PORT} 80
> >>> RewriteRule ^(.*)$ https://ofbiz.apache.org/$1 [R,L]
> >>> =
> >>>
> >>> Please confirm if it looks good.
> >>>
> >>> Thanks & Regards
> >>> --
> >>> Deepak Dixit
> >>>
> >>>
> >>> On Mon, Oct 1, 2018 at 11:45 AM, Jacques Le Roux <
> >>> jacques.le.r...@les7arts.com> wrote:
> >>>
> >>> That's quite a  good idea Deepak
> >>>> Jacques
> >>>>
> >>>>
> >>>>
> >>>> Le 01/10/2018 à 07:30, Deepak Dixit a écrit :
> >>>>
> >>>> We have .htaccess file, we can write redirect rule in this file.
> >>>>> Thanks & Regards
> >>>>> --
> >>>>> Deepak Dixit
> >>>>>
> >>>>>
> >>>>> On Sun, Sep 30, 2018 at 3:51 PM, Ashish Vijaywargiya <
> >>>>> ashish.vijaywarg...@hotwaxsystems.com> wrote:
> >>>>>
> >>>>> Few important articles from Google's official security blog site:
> >>>>>
> >>>>>>
> https://security.googleblog.com/2014/08/https-as-ranking-signal_6.html
> >>>>>> https://security.googleblog.com/2015/12/indexing-https-
> >>>>>> pages-by-default.html
> >>>>>> https://security.googleblog.com/2017/04/next-steps-toward-
> >>>>>> more-connection.html
> >>>>>> https://security.googleblog.com/2018/02/a-secure-web-is-here
> >>>>>> -to-stay.html
> >>>>>>
> >>>>>> Kind Regards
> >>>>>> Ashish Vijaywargiya
> >>>>>> HotWax Systems - est. 1997 <http://www.hotwaxsystems.com/>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Sun, Sep 30, 2018 at 3:31 PM Ashish Vijaywargiya <
> >>>>>> ashish.vijaywarg...@hotwaxsystems.com> wrote:
> >>>>>>
> >>>>>> Thanks, Jacques, Please feel free to get it done and let me know if
> >>>>>> some
> >>>>>>
> >>>>>>> help is required from my side. Thanks!
> >>>>>>>
> >>>>>>> --
> >>>>>>> Kind Regards
> >>>>>>> Ashish Vijaywargiya
> >>>>>>> HotWax Systems - est. 1997 <http://www.hotwaxsystems.com/>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> On Sun, Sep 30, 2018 at 1:38 PM Jacques Le Roux <
> >>>>>>> jacques.le.r...@les7arts.com> wrote:
> >>>>>>>
> >>>>>>> We can handle it ourselves. It's puppetised. The file is
> >>>>>>>
> >>>>>>>> infrastructure-puppet\data\roles\tlpserver.yaml at
> >>>>>>>> https://github.com/apache/infrastructure-puppet.git in
> >>>>>>>>
> >>>>>>>> origin/deploy

Hard Coded Cookie Path

2018-10-04 Thread Deepak Nigam
Hello Folks,

During the code walkthrough, I observed that everywhere the cookie path
attribute is hardcoded as root '/' using the setPath() method. This is not
the correct implementation because if the cookie path is set to the root
'/', then the cookie will be sent to all the application under the same
domain.

Is there any best practice around this? Should it be configurable?
IMO, the cookie path should be set to '/users/' directory. WDYT?


Thanks!

Deepak Nigam
HotWax Systems Pvt. Ltd


Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread deepak nigam
+1.

Thanks for the putting this forward. Please count me in for this effort.


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


On Mon, Sep 3, 2018 at 2:06 PM Jacques Le Roux 
wrote:

> Hi,
>
> I have always found that not having dates cross-checks in OFBiz is a minus.
>
> For instance while creating/editing an order we can enter
>
>   * an anti-dated shipping date (eg 2018-08-1 entered today)
>   * The recently added reserved date can be after the shipping date
>   * etc. (not only dates but mostly)
>
> Should we not make an effort to check the consistency of fields values
> when they are entered?
>
> Because this is a simple question to see if we agree about making an
> effort on that, I don't get into more details yet
>
> Thanks for your opinions
>
> Jacques
>
>


Move SecurityPermission, SecurityGroup and SecurityGroupPermission Data to seed data files

2018-09-20 Thread Deepak Nigam
Hello All,

Currently, SecurityPermission, SecurityGroup and SecurityGroupPermission
data are mixed in demo and seed data files. Shouldn't these all data be
part of seed data files only?

Most of the SecurityPermission data is already part of seed data except the
files HumanresDemoData.xml and SecurityGroupDemoData.xml files, but there
is not any fixed pattern for the SecurityGroup and
SecurityGroupPermissionData.

A Jira ticket OFBIZ-10575
<https://issues.apache.org/jira/browse/OFBIZ-10575> is available for the
same.


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


Re: Move SecurityPermission, SecurityGroup and SecurityGroupPermission Data to seed data files

2018-09-21 Thread Deepak Nigam
Thank you all for your inputs.

*Conclusions*: 1) All the 'SecurityPermission' data should be in the seed
data files.
   2) All the 'SecurityGroup' and
'SecurityGroupPermission' data should be in the demo data files.

Apart from this, the 'SecurityGroup' and 'SecurityGroupPermission' data for
the groupId 'super' should remain the seed data files. I will upload the
patch in the ticket soon.


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.




On Fri, Sep 21, 2018 at 2:06 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> +1
>
> Jacques
>
>
> Le 21/09/2018 à 07:49, Arun Patidar a écrit :
> > Deepak,
> >
> > IMO,  'SecurityPermission' data should always be part of seed data. but
> > SecurityGroup and SecurityGroupPermission like a sample data so should be
> > part of demo data.
> >
> >
> >
> >
> > Kind Regards,
> >
> > Arun Patidar
> > Director of Information Systems
> >
> > *HotWax CommerceReal OmniChannel. Real Results.*
> > m: +91 9827353082
> > w: www.hotwax.co
> >
> >   <https://www.linkedin.com/company/hotwaxcommerce/>
> > <https://www.facebook.com/HotWaxCommerce/>
> > <https://twitter.com/hotwaxcommerce>
> >
> >
> >
> > On Fri, Sep 21, 2018 at 9:59 AM Deepak Nigam  >
> > wrote:
> >
> >> Hello All,
> >>
> >> Currently, SecurityPermission, SecurityGroup and SecurityGroupPermission
> >> data are mixed in demo and seed data files. Shouldn't these all data be
> >> part of seed data files only?
> >>
> >> Most of the SecurityPermission data is already part of seed data except
> the
> >> files HumanresDemoData.xml and SecurityGroupDemoData.xml files, but
> there
> >> is not any fixed pattern for the SecurityGroup and
> >> SecurityGroupPermissionData.
> >>
> >> A Jira ticket OFBIZ-10575
> >> <https://issues.apache.org/jira/browse/OFBIZ-10575> is available for
> the
> >> same.
> >>
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Nigam
> >> HotWax Systems Pvt. Ltd.
> >>
>
>


Relation type in SecurityGroupPermission entity

2018-09-22 Thread Deepak Nigam
Hi Folks,

In the definition of 'SecurityGroupPermission' entity, the relation type
with 'SecurityPermission' entity is 'one-nofk'. Hence the system is
allowing to use the permissions not defined anywhere. (ex.
ORDERMGR_CRQ_ADMIN/ORDERMGR_CRQ_UPDATE).
Do we have any use case for this type of relation?

IMO, here the relation type should be 'one' here to maintain
the referential integrity. WDYT?


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


Re: [VOTE] [RELEASE] Apache OFBiz 16.11.05

2018-09-23 Thread Deepak Nigam
+1


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.

On Sun, Sep 23, 2018 at 5:50 PM Taher Alkhateeb 
wrote:

> +1
>
> tests are good, smoke tests don't reveal anything out of the ordinary,
> and everything seems to be in proper order.
> On Sat, Sep 22, 2018 at 3:28 PM Michael Brohl 
> wrote:
> >
> > +1
> >
> > Everything is ok:
> >
> > $ ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-16.11.05.zip
> > sha check of file: apache-ofbiz-16.11.05.zip
> > Using sha file: apache-ofbiz-16.11.05.zip.sha512
> > apache-ofbiz-16.11.05.zip: 9D0C613C C3D88C37 A5A41F53 55F0D6A0 A465AB29
> > 00987DF6 5070BBA6 4DCA43B4 1C8C44DB E7A1BBA5 4528AE17 04B45DE8 722F702E
> > 9C13508A 0CD900A1 3F1D3B1B
> > apache-ofbiz-16.11.05.zip: 9D0C613C C3D88C37 A5A41F53 55F0D6A0 A465AB29
> > 00987DF6 5070BBA6 4DCA43B4 1C8C44DB E7A1BBA5 4528AE17 04B45DE8 722F702E
> > 9C13508A 0CD900A1 3F1D3B1B
> > sha checksum OK
> >
> > GPG verification output
> > gpg: Signature made Mon Sep 17 11:02:30 2018 CEST using RSA key ID
> 847AF9E0
> > gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY)
> > " [ultimate]
> >
> >
> > $ ./gradlew loadDefault testIntegration
> >
> > ...
> >
> > BUILD SUCCESSFUL
> >
> >
> > Thanks Jacopo,
> >
> > Michael
> >
> > Am 21.09.18 um 16:26 schrieb Jacopo Cappellato:
> > >   This is the vote thread to release a new bug fix release for the
> > > release16.11 branch. This new release, "Apache OFBiz 16.11.05" will
> > > supersede all the previous releases from the same branch.
> > >
> > > The release files can be downloaded from here:
> > >
> > > https://dist.apache.org/repos/dist/dev/ofbiz/
> > >
> > > and are:
> > >
> > > * apache-ofbiz-16.11.05.zip
> > > * KEYS: text file with keys
> > > * apache-ofbiz-16.11.05.zip.asc: the detached signature file
> > > * apache-ofbiz-16.11.05.zip.sha512: checksum file
> > >
> > > Please download and test the zip file and its signatures (for
> instructions
> > > on testing the signatures see
> http://www.apache.org/info/verification.html).
> > >
> > > Vote:
> > >
> > > [ +1] release as Apache OFBiz 16.11.05
> > > [ -1] do not release
> > >
> > > This vote will be open for at least 5 days.
> > >
> > > For more details about this process please read
> > > http://www.apache.org/foundation/voting.html
> > >
> > > Kind Regards,
> > >
> > > Jacopo
> > >
> >
> >
>


[CODE CLEANUP] Remove Debug.logError() used before ServiceUtil.returnError()

2018-09-28 Thread Deepak Nigam
Hello All,

We have the practice of placing an error log using the method
Debug.logError() before returning the error from a service using the method
ServiceUtil.returnError(). As we already have an error log statement inside
the method ServiceUtil.returnError() now, should we remove the debug
statement before it?

In this way, we can remove a few thousands of lines from the code. However,
we can leave the occurrences having a custom error message.

WDYT?

Thanks & Regards
--
Deepak Nigam


Re: svn commit: r1851076 - in /ofbiz/ofbiz-framework/branches/release17.12: ./ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java

2019-01-15 Thread Deepak Nigam
Hi Jacques,

There is a chance of getting Null Pointer Exception (while creating the
auto-login cookie & calling the method autoLoginCheck() inside the if
block) if the userLogin is null. IMO, the below condition


*if (userLogin != null && *

*(webappInfo != null &&
webappInfo.isAutologinCookieUsed())|| webappInfo == null) {
//
When using an empty mounpoint, ie using root as mounpoint. Beware:
works only for 1 webapp!*

can be improved as,


*if (userLogin != null && *

*((webappInfo != null &&
webappInfo.isAutologinCookieUsed())|| webappInfo == null))
{ //
When using an empty mounpoint, ie using root as mounpoint. Beware:
works only for 1 webapp!*


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd

On Fri, Jan 11, 2019 at 9:57 PM  wrote:

> Author: jleroux
> Date: Fri Jan 11 16:27:11 2019
> New Revision: 1851076
>
> URL: http://svn.apache.org/viewvc?rev=1851076=rev
> Log:
> "Applied fix from trunk for revision: 1851074  "
> 
> r1851074 | jleroux | 2019-01-11 17:26:13 +0100 (ven. 11 janv. 2019) | 17
> lignes
>
> Fixed: Correct behaviour of Autologin cookies
> (OFBIZ-10635)
>
> In the method to set the autoLogin cookie, LoginWorker::autoLoginSet,
> system fetches the webAppInfo by using the
> method ComponentConfig::getWebappInfo. In this method, serverId and
> applicationName are passed as arguments.
>
> *WebappInfo webappInfo = ComponentConfig.getWebappInfo((String)
> context.getAttribute("_serverId"), UtilHttp.getApplicationName(request));*
>
> If the mount-point of the web app is set as an empty string, then 'root'
> will be used as the application name, due to which the object webAppInfo
> will come null. If the webAppInfo is null then the autoLogin cookie will
> not be created and added to the response object by the system.
>
> Thanks: Aditya for report and Mathieu Lirzin for discussion
> 
>
> Modified:
> ofbiz/ofbiz-framework/branches/release17.12/   (props changed)
>
> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>
> Propchange: ofbiz/ofbiz-framework/branches/release17.12/
>
> --
> --- svn:mergeinfo (original)
> +++ svn:mergeinfo Fri Jan 11 16:27:11 2019
> @@ -10,4 +10,4 @@
>  /ofbiz/branches/json-integration-refactoring:1634077-1635900
>  /ofbiz/branches/multitenant20100310:921280-927264
>  /ofbiz/branches/release13.07:1547657
>
> -/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,1840189,1840199,1840828,1841657,1841662,1842372,1842921,1843225,1843893,1844943,1845418,1845420,1845466,1845544,1845552,1845558,1845933,1845995,1846097,1846107,1846214,1846594,1846632,1847398,1847478,1847670,1847715,
>
>  
> 1847890,1848263,1848336,1848386,1848398,1848441,1848444,1848447,1848449,1848467,1848469,1848745,1848849-1848850,1849021,1849191,1849193,1849275,1849467,1849528,1849540,1849567,1849693,1850015,1850023,1850530,1850647,1850685,1850694,1850918,1850948,1850953,1851006,1851068
>
> +/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,18

Re: svn commit: r1851203 - in /ofbiz/ofbiz-framework/branches/release17.12: ./ framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java framework/webapp/src/main/java/org/apache/ofbiz/web

2019-01-22 Thread Deepak Nigam
Hi Jacques,

When there is one web app with the empty mount point (i.e. deployed on
root), the auto-login cookie will not work for that particular webapp due
to the change in the path of the cookie from "/" to "/" + applicationName.
Because the system will try to find the cookie at the "/" but it is
actually at "/" + applicationName.

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd



On Sun, Jan 13, 2019 at 7:13 PM  wrote:

> Author: jleroux
> Date: Sun Jan 13 13:43:44 2019
> New Revision: 1851203
>
> URL: http://svn.apache.org/viewvc?rev=1851203=rev
> Log:
> "Applied fix from trunk for revision: 1851200"
> 
> r1851200 | jleroux | 2019-01-13 14:31:13 +0100 (dim. 13 janv. 2019) | 11
> lignes
>
> Reverted: Impossible secure and autologin cookie names when mountpoint
> contains
> a slash inside its name
> (OFBIZ-10766)
>
> In my previous commit I reverted the initial change. As I said in the Jira
> I had a second look and it's better to fix the problem at the root as I
> did
> initially.
>
> I wrote in my previous commit: "This method is used in other places where
> the
> name should not be changed." I checked there are no issues changing
> slashes to
> underscores in the cookies names anywhere.
> 
>
> Modified:
> ofbiz/ofbiz-framework/branches/release17.12/   (props changed)
>
> ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
>
> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>
> Propchange: ofbiz/ofbiz-framework/branches/release17.12/
>
> --
> --- svn:mergeinfo (original)
> +++ svn:mergeinfo Sun Jan 13 13:43:44 2019
> @@ -10,4 +10,4 @@
>  /ofbiz/branches/json-integration-refactoring:1634077-1635900
>  /ofbiz/branches/multitenant20100310:921280-927264
>  /ofbiz/branches/release13.07:1547657
>
> -/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,1840189,1840199,1840828,1841657,1841662,1842372,1842921,1843225,1843893,1844943,1845418,1845420,1845466,1845544,1845552,1845558,1845933,1845995,1846097,1846107,1846214,1846594,1846632,1847398,1847478,1847670,1847715,
>
>  
> 1847890,1848263,1848336,1848386,1848398,1848441,1848444,1848447,1848449,1848467,1848469,1848745,1848849-1848850,1849021,1849191,1849193,1849275,1849467,1849528,1849540,1849567,1849693,1850015,1850023,1850530,1850647,1850685,1850694,1850914,1850918,1850948,1850953,1851006,1851068,1851074,1851130,1851158,1851163
>
> +/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,1840189,1840199,1840828,1841657,1841662,1842372,1842921,1843225,1843893,1844943,1845418,1845420,1845466,1845544,1845552,1845558,1845933,1845995,1846097,1846107,1846214,1846594,1846632,1847398,1847478,1847670,1847715,
>
>  
> 1847890,1848263,1848336,1848386,1848398,1848441,1848444,1848447,1848449,1848467,1848469,1848745,1848849-1848850,1849021,1849191,1849193,1849275,1849467,1849528,1849540,1849567,1849693,1850015,1850023,1850530,1850647,1850685,1850694,1850914,1850918,1850948,1850953,1851006,1851068,1851074,1851130,1851158,1851163,1851200
>
> Modified

Unable to set the autoLogin Cookie when mount-point is set as an empty string

2019-01-10 Thread Deepak Nigam
Hello all,

In the method to set the autoLogin cookie, LoginWorker.autoLoginSet(),
system fetches the webAppInfo by using the
method ComponentConfig.getWebappInfo(). In this method, serverId and
applicationName are passed as the arguments.

*WebappInfo webappInfo = ComponentConfig.getWebappInfo((String)
context.getAttribute("_serverId"), UtilHttp.getApplicationName(request));*

If the mount-point of the web app is set as an empty string, then 'root'
will be used as the application name, due to which the object webAppInfo
will come null. If the webAppInfo is null then the autoLogin cookie will
not be created and added to the response object by the system.

Suggestions are welcomed to handle this scenario.


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd


Session timeout for webapps

2019-01-07 Thread Deepak Nigam
Hello all,

I tried to set the session timeout for the 'ecommerce' and the
'webtools' components using  of web.xml, but unable to do
so. Session for the logged-in user remains active even after the set time.

On further research, I found that we did some changes in this area in the
ticket OFBIZ-6655 <https://issues.apache.org/jira/browse/OFBIZ-6655>. We
have hard coded the session timeout (1 hr) in the sessionCreated() method
of ControlEventListner class. As per the comments in the Jira ticket,
session timeout declarations in web.xml have been removed by the use
of @WebListner annotation. This is to avoid duplicates things everywhere in
web.xml files. Since the web.xml files have precedence on annotations, the
setting can be easily overridden when necessary.

But the @WebListner is missing in the ControlEventListner class. Also, I am
unable to override the session timeout in web.xml even after putting the
@WebListner annotation in ControlEventListner class.

Please let me know if this is a real issue or I am doing something wrong?

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


Re: Session timeout for webapps

2019-01-10 Thread Deepak Nigam
Thanks, Jacques and Girish.

Yes, it makes sense to get back to web.xml for the session timeout value.

On Fri, Jan 11, 2019 at 11:13 AM Girish Vasmatkar <
girish.vasmat...@hotwaxsystems.com> wrote:

> Hi Jacques
>
> Yes, we should put back the session timeout declaration in web.xml. Given
> the fact that we can always mix web.xml and Annotation based configuration,
> it only makes sense to let web.xml decide the session timeout and even if
> we have the session listener (via web.xml declaration or Annotation), we
> should not programatically try to override the setting.
>
> Thanks and Regards,
> Girish
>
>
> On Thu, Jan 10, 2019 at 7:14 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Hi Deepak, Girish,
> >
> > I had a look at the issue. The specifications of Java Servlet
> > Specification 3.0 don't include an annotation to change the session time
> > out.
> >
> > https://www.baeldung.com/servlet-session-timeout
> >
> >
> https://stackoverflow.com/questions/20389833/session-timeout-config-with-no-web-xml-file
> >
> > I think the best solution is to put back what we had before, ie set it to
> > a value (it was 1 hour before) in all web.xml file and remove the
> >
> > session.setMaxInactiveInterval(60*60); //in seconds
> >
> > line in ControlEventListener::sessionCreated
> >
> > I thought about keeping this line if a check to null for the session
> > timeout value (from web.xml) was positive.
> > But by default Tomcat sets it to 30 min (so it's never null) and it's
> > possible but hard to change in OFBiz (eg to a known specific
> extraordinary
> > value
> > that could be checked instead of null as above)
> > So it could be confusing and anyway best practice is to prefer convention
> > over configuration, even if in this case it's much redundant.
> >
> > I think we can reopen OFBIZ-6655 and handle it there, with an
> explanation.
> >
> > Other ideas?
> >
> > Jacques
> >
> > Le 09/01/2019 à 10:11, Girish Vasmatkar a écrit :
> > > Hi Deepak
> > >
> > > By the time sessionCreated is called in an HttpSessionListener, the
> > session
> > > has already been created. I am sure if you try to get the HttpSession
> > from
> > > the HttpSessionEvent object, it will have what you defined in
> > >  tag.
> > >
> > > But the code is overriding the timeout using setMaxInactiveInterval to
> 1
> > > hour that is why it is looking like web.xml is not being given
> > > precedence over programmatic session configuration.
> > >
> > > Whether web.xml takes precedence over annotation does not apply in this
> > > case because anyway the session timeout value is being overridden by
> the
> > > code. The tomcat container definitely reads session-timeout from
> web.xml
> > > and assigns timeout for the session accordingly. But since a listener
> is
> > > configured for session lifecycle management, it invokes the method and
> > > there the session value is being overridden.
> > >
> > > Try to set 2 minutes session timeout in web.xml and remove
> > > session.setMaxInactiveInterval(60*60).
> > > I would say you will be logged out after 2 minutes. If that is not the
> > > case, pl let me know.
> > >
> > > I hope I understood your question and problem correctly.
> > >
> > > Best,
> > > Girish
> > >
> > >
> > >
> > > On Wed, Jan 9, 2019 at 1:53 PM Deepak Nigam <
> deepak.nigam1...@gmail.com>
> > > wrote:
> > >
> > >> Thanks, Jacques.
> > >>
> > >> Apart from the hardcoded thing, I am not able to override the session
> > >> timeout value using  tag in web.xml.
> > >>
> > >> On Tue, Jan 8, 2019 at 1:55 PM Jacques Le Roux <
> > >> jacques.le.r...@les7arts.com>
> > >> wrote:
> > >>
> > >>> Hi Deepak,
> > >>>
> > >>> You are right, it's hardcoded and should not. I have no time to go
> > >> further
> > >>> at the moment, but I'll ASAP
> > >>>
> > >>> Thanks
> > >>>
> > >>> Jacques
> > >>>
> > >>> Le 08/01/2019 à 06:10, Deepak Nigam a écrit :
> > >>>> Hello all,
> > >>>>
> > >>>> I tried to set the session timeout for the 'ecommerce' and the
> > >>>> 'webtools' components using  of web.xml,

Re: Unable to set the autoLogin Cookie when mount-point is set as an empty string

2019-01-10 Thread Deepak Nigam
Thank you, Jacques, for looking into it.

In my case, there is only one webapp with the empty mount point and I want
to use the autoLogin cookie. But the code is written in such a way that in
case of empty mount point 'webappInfo' object is coming null due to which
autoLogin cookie is not getting created and added in the response object.
UtilHttp.getApplicationName(request) method is returning the string 'root'
and ComponentConfig.getWebappInfo((String)
context.getAttribute("_serverId"), UtilHttp.getApplicationName(request)) is
trying to find the webapp using the mountpoint 'root' and hence unable to
find it.

Please refer the below code for more information:



// Set an autologin cookie for the webapp if it requests it
public static String autoLoginSet(HttpServletRequest request,
HttpServletResponse response) {
Delegator delegator = (Delegator) request.getAttribute("delegator");
HttpSession session = request.getSession();
GenericValue userLogin = (GenericValue) session.getAttribute("userLogin");
ServletContext context = request.getServletContext();
WebappInfo webappInfo = ComponentConfig.getWebappInfo((String)
context.getAttribute("_serverId"),
UtilHttp.getApplicationName(request));

if (userLogin != null && webappInfo != null &&
webappInfo.isAutologinCookieUsed()) {
Cookie autoLoginCookie = new
Cookie(getAutoLoginCookieName(request),
userLogin.getString("userLoginId"));
autoLoginCookie.setMaxAge(60 * 60 * 24 * 365);
autoLoginCookie.setDomain(EntityUtilProperties.getPropertyValue("url",
"cookie.domain", delegator));
autoLoginCookie.setPath("/" +
UtilHttp.getApplicationName(request).replaceAll("/","_"));
autoLoginCookie.setSecure(true);
autoLoginCookie.setHttpOnly(true);
response.addCookie(autoLoginCookie);
return autoLoginCheck(delegator, session,
userLogin.getString("userLoginId"));
} else {
return "success";
}
}

==

public static WebappInfo getWebappInfo(String serverName, String webAppName) {
WebappInfo webappInfo = null;
List webappsInfo = getAppBarWebInfos(serverName);
for(WebappInfo currApp : webappsInfo) {
String currWebAppName = currApp.getMountPoint().replace("/",
"").replace("*", "");
if (webAppName.equals(currWebAppName)) {
webappInfo = currApp;
break;
}
}
return webappInfo;
}

=


On Thu, Jan 10, 2019 at 7:31 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Deepak,
>
> It's not a problem if we create an autologin cookie even if it's not used,
> just unclean.
> So in this case we could force the same cookie values but the name and
> path to "root".
>
> But what happens if we have several empty mountpoints, is that a problem?
> I guess if we deploy on root there is only 1 webapp?
>
> It would be good to reuse OFBIZ-10635 to keep the information there,
> thanks.
>
> HTH
>
> Jacques
>
> Le 10/01/2019 à 09:26, Deepak Nigam a écrit :
> > Hello all,
> >
> > In the method to set the autoLogin cookie, LoginWorker.autoLoginSet(),
> > system fetches the webAppInfo by using the
> > method ComponentConfig.getWebappInfo(). In this method, serverId and
> > applicationName are passed as the arguments.
> >
> > *WebappInfo webappInfo = ComponentConfig.getWebappInfo((String)
> > context.getAttribute("_serverId"),
> UtilHttp.getApplicationName(request));*
> >
> > If the mount-point of the web app is set as an empty string, then 'root'
> > will be used as the application name, due to which the object webAppInfo
> > will come null. If the webAppInfo is null then the autoLogin cookie will
> > not be created and added to the response object by the system.
> >
> > Suggestions are welcomed to handle this scenario.
> >
> >
> > Thanks & Regards
> > --
> > Deepak Nigam
> > HotWax Systems Pvt. Ltd
> >
>


Re: Session timeout for webapps

2019-01-11 Thread Deepak Nigam
Hi Jacques,

On double checking, I found that
/applications/marketing/webapp/marketing/WEB-INF/web.xml and
/applications/party/webapp/partymgr/WEB-INF/web.xml files have been missed.
Apart from that, I think we need to work for web.xml of various plugins
also.

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd


On Fri, Jan 11, 2019 at 9:58 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Guys,
>
> Done, please double-check that I have not missed a web.xml files
>
> Thanks
>
> Jacques
>
> Le 11/01/2019 à 11:34, Jacques Le Roux a écrit :
> > Thanks Guys,
> >
> > I'll do this afternoon using OFBIZ-6655
> >
> > Jacques
> >
> > Le 11/01/2019 à 07:03, Deepak Nigam a écrit :
> >> Thanks, Jacques and Girish.
> >>
> >> Yes, it makes sense to get back to web.xml for the session timeout
> value.
> >>
> >> On Fri, Jan 11, 2019 at 11:13 AM Girish Vasmatkar <
> >> girish.vasmat...@hotwaxsystems.com> wrote:
> >>
> >>> Hi Jacques
> >>>
> >>> Yes, we should put back the session timeout declaration in web.xml.
> Given
> >>> the fact that we can always mix web.xml and Annotation based
> configuration,
> >>> it only makes sense to let web.xml decide the session timeout and even
> if
> >>> we have the session listener (via web.xml declaration or Annotation),
> we
> >>> should not programatically try to override the setting.
> >>>
> >>> Thanks and Regards,
> >>> Girish
> >>>
> >>>
> >>> On Thu, Jan 10, 2019 at 7:14 PM Jacques Le Roux <
> >>> jacques.le.r...@les7arts.com> wrote:
> >>>
> >>>> Hi Deepak, Girish,
> >>>>
> >>>> I had a look at the issue. The specifications of Java Servlet
> >>>> Specification 3.0 don't include an annotation to change the session
> time
> >>>> out.
> >>>>
> >>>>  https://www.baeldung.com/servlet-session-timeout
> >>>>
> >>>>
> >>>
> https://stackoverflow.com/questions/20389833/session-timeout-config-with-no-web-xml-file
> >>>> I think the best solution is to put back what we had before, ie set
> it to
> >>>> a value (it was 1 hour before) in all web.xml file and remove the
> >>>>
> >>>>  session.setMaxInactiveInterval(60*60); //in seconds
> >>>>
> >>>> line in ControlEventListener::sessionCreated
> >>>>
> >>>> I thought about keeping this line if a check to null for the session
> >>>> timeout value (from web.xml) was positive.
> >>>> But by default Tomcat sets it to 30 min (so it's never null) and it's
> >>>> possible but hard to change in OFBiz (eg to a known specific
> >>> extraordinary
> >>>> value
> >>>> that could be checked instead of null as above)
> >>>> So it could be confusing and anyway best practice is to prefer
> convention
> >>>> over configuration, even if in this case it's much redundant.
> >>>>
> >>>> I think we can reopen OFBIZ-6655 and handle it there, with an
> >>> explanation.
> >>>> Other ideas?
> >>>>
> >>>> Jacques
> >>>>
> >>>> Le 09/01/2019 à 10:11, Girish Vasmatkar a écrit :
> >>>>> Hi Deepak
> >>>>>
> >>>>> By the time sessionCreated is called in an HttpSessionListener, the
> >>>> session
> >>>>> has already been created. I am sure if you try to get the HttpSession
> >>>> from
> >>>>> the HttpSessionEvent object, it will have what you defined in
> >>>>>  tag.
> >>>>>
> >>>>> But the code is overriding the timeout using setMaxInactiveInterval
> to
> >>> 1
> >>>>> hour that is why it is looking like web.xml is not being given
> >>>>> precedence over programmatic session configuration.
> >>>>>
> >>>>> Whether web.xml takes precedence over annotation does not apply in
> this
> >>>>> case because anyway the session timeout value is being overridden by
> >>> the
> >>>>> code. The tomcat container definitely reads session-timeout from
> >>> web.xml
> >>>>> and assigns timeout for the session accordingly. But since a listener
> >>> is
> >>>&g

Re: git commit workflow for ofbiz

2019-01-13 Thread Deepak Nigam
+1 for Git.

Thanks & Regards
--
Deepak Nigam
HotWax Systems.Pvt. Ltd

On Mon, Jan 14, 2019 at 9:53 AM Yashwant Dhakad <
yashwant.dha...@hotwaxsystems.com> wrote:

> +1 for Git
>
> Thanks & Regards
> --
> Yashwant Dhakad
>
>
> On Sun, Jan 13, 2019 at 1:27 AM Taher Alkhateeb <
> slidingfilame...@gmail.com>
> wrote:
>
> > It's awesome to revive this discussion Michael. +1 of course.
> >
> > We need to think practically of our workflows though and whether we
> > want a linear vs non-linear history model. I prefer the latter to
> > allow proper decentralized workflows but it's up to everyone here to
> > decide. I think the overall process is described thoroughly and we can
> > adhere to it for the most part.
> >
> > On Sat, Jan 12, 2019 at 9:35 PM Deepak Dixit 
> > wrote:
> > >
> > > We are using git since long and it's a great tool for collaboration.
> > > It has distributed version control system so you don't need an internet
> > > connection to view history and branch switching.
> > >
> > > Thanks Taher for nicly describing it.
> > >
> > > +1 for Git.
> > >
> > > Thanks & Regards
> > > --
> > > Deepak Dixit
> > >
> > >
> > >
> > > On Sat, Jan 12, 2019 at 11:54 PM Aditya Sharma <
> > > aditya.sha...@hotwaxsystems.com> wrote:
> > >
> > > > +1 for Git
> > > >
> > > > Thanks and Regards,
> > > > Aditya Sharma
> > > >
> > > > On Sat, Jan 12, 2019, 9:06 PM Suraj Khurana  > > > wrote:
> > > >
> > > > > +1 to move from SVN to Git.
> > > > >
> > > > > --
> > > > > Best Regards,
> > > > > Suraj Khurana
> > > > > Technical Consultant
> > > > >
> > > > > On Sat, Jan 12, 2019 at 7:12 PM Mathieu Lirzin <
> > > > mathieu.lir...@nereide.fr>
> > > > > wrote:
> > > > >
> > > > > > Hello Michael,
> > > > > >
> > > > > > Michael Brohl  writes:
> > > > > >
> > > > > > > I'd like to revive this discussion again.
> > > > > >
> > > > > > Do we still need to discuss it?  If the response is not obviously
> > “yes
> > > > > > we should move to Git” now that Git has become ubiquitous and
> that
> > SVN
> > > > > > is a moribund tool, then this community has a serious problem.
> :-)
> > > > > >
> > > > > > Joke aside I think the question should rather be:
> > > > > >
> > > > > >Is there anyone here opposing to the move from SVN to Git?
> > > > > >
> > > > > > Thanks for reviving this topic!
> > > > > >
> > > > > > --
> > > > > > Mathieu Lirzin
> > > > > > GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
> > > > > >
> > > > >
> > > >
> >
>


Re: Session timeout for webapps

2019-01-09 Thread Deepak Nigam
Thanks, Jacques.

Apart from the hardcoded thing, I am not able to override the session
timeout value using  tag in web.xml.

On Tue, Jan 8, 2019 at 1:55 PM Jacques Le Roux 
wrote:

> Hi Deepak,
>
> You are right, it's hardcoded and should not. I have no time to go further
> at the moment, but I'll ASAP
>
> Thanks
>
> Jacques
>
> Le 08/01/2019 à 06:10, Deepak Nigam a écrit :
> > Hello all,
> >
> > I tried to set the session timeout for the 'ecommerce' and the
> > 'webtools' components using  of web.xml, but unable to do
> > so. Session for the logged-in user remains active even after the set
> time.
> >
> > On further research, I found that we did some changes in this area in the
> > ticket OFBIZ-6655 <https://issues.apache.org/jira/browse/OFBIZ-6655>. We
> > have hard coded the session timeout (1 hr) in the sessionCreated() method
> > of ControlEventListner class. As per the comments in the Jira ticket,
> > session timeout declarations in web.xml have been removed by the use
> > of @WebListner annotation. This is to avoid duplicates things everywhere
> in
> > web.xml files. Since the web.xml files have precedence on annotations,
> the
> > setting can be easily overridden when necessary.
> >
> > But the @WebListner is missing in the ControlEventListner class. Also, I
> am
> > unable to override the session timeout in web.xml even after putting the
> > @WebListner annotation in ControlEventListner class.
> >
> > Please let me know if this is a real issue or I am doing something wrong?
> >
> > Thanks & Regards
> > --
> > Deepak Nigam
> > HotWax Systems Pvt. Ltd.
> >
>


ProductFacility creation on 'Receive Inventory'

2018-09-19 Thread deepak nigam
Hello All,

We can directly receive inventory of a product into a facility by using the
option 'Facility' -> 'Receive Inventory'. Here we can select a product for
receiving which is not associated with the receiving facility (e.g. product
-> Purple Gizmo GZ-5005, facility -> WebS Store Warehouse).

After a successful receive also, the product is not getting associated with
the facility. Due to this, we can't find the newly received product under
the 'Inventory' section of the facility. Should the product be associated
with the facility after receiving?



Thanks & Regards
--
Deepak Nigam


Re: ProductFacility creation on 'Receive Inventory'

2018-09-19 Thread Deepak Nigam
Thanks, Suraj.

@All, as per the suggestions provided in the Jira ticket, should we
restrict the receiving of non-associated products and simply return an
error message? WDYT?

On Wed, Sep 19, 2018 at 2:45 PM Suraj Khurana <
suraj.khur...@hotwaxsystems.com> wrote:

> Hello Deepak,
>
> Please have a look.
> https://issues.apache.org/jira/browse/OFBIZ-7481
>
> HTH.
>
> --
> Thanks and Regards,
> Suraj Khurana
> Omnichannel OMS Technical Expert
> HotWax Systems
>
>
>
> On Wed, Sep 19, 2018 at 2:38 PM, deepak nigam 
> wrote:
>
> > Hello All,
> >
> > We can directly receive inventory of a product into a facility by using
> the
> > option 'Facility' -> 'Receive Inventory'. Here we can select a product
> for
> > receiving which is not associated with the receiving facility (e.g.
> product
> > -> Purple Gizmo GZ-5005, facility -> WebS Store Warehouse).
> >
> > After a successful receive also, the product is not getting associated
> with
> > the facility. Due to this, we can't find the newly received product under
> > the 'Inventory' section of the facility. Should the product be associated
> > with the facility after receiving?
> >
> >
> >
> > Thanks & Regards
> > --
> > Deepak Nigam
> >
>


Re: Ofbiz Security permission

2019-02-28 Thread Deepak Nigam
Hi Thanh,

The permissions you are looking for and corresponding security group are
already available OOTB. You only need to associate user login with
appropriate security groups. Following entities can be of your interest:

1) SecurityPermission
2) SecurityGroup
3) SecurityGroupPermission
4) UserLogin
4) UserLoginSecurityGroup

It can be also achieved via 'Party Manager' application. Just open the
profile of the party and you can add/remove him to any security group. This
feature is available under 'User Name(s)' section.

Thanks & Regards
--
Deepak Nigam


On Fri, Mar 1, 2019 at 2:58 AM Jacques Le Roux 
wrote:

> Hi Thanh,
>
> Your message has been moderated.
>
> Please subscribe to the user ML for such questions and then use your email
> client
> See also why here http://ofbiz.apache.org/mailing-lists.html
>
> You will get a better support , it's more fair to share with everybody
> and people can answer you directly on the ML rather than directly to you
> The wider the audience the better the answers you might get
>
> Also it's more work for moderators who have to accept your messages as
> long as you have not subscribed.
> I'll personally no longer accept them (other moderators still could)
>
> Thanks
>
> Jacques
>
> Le 28/02/2019 à 19:01, thanh a écrit :
> > Hi all,
> >
> > I am newbie in ofbiz,
> >
> > I want to create permission call "Salesman", which this permission, user
> can
> > create sale order, view and edit own sale order. Cannot update or view
> other
> > sale order which is not belong to themself.
> >
> > How can I do it, please show me.
> >
> > Thanks and best regards.
> > Thanh
> >
> >
> >
> > --
> > Sent from: http://ofbiz.135035.n4.nabble.com/OFBiz-Dev-f165671.html
> >
>


Re: Welcome to Mathieu Lirzin as new committer!

2019-02-19 Thread Deepak Nigam
Congratulations Mathieu!!

Thanks & Regards
--
Deepak Nigam

On Wed, Feb 20, 2019 at 10:32 AM Swapnil M Mane 
wrote:

> Many congratulations Mathieu, welcome aboard :-)
>
>
> - Best Regards,
> Swapnil M Mane,
> ofbiz.apache.org
>
>
>
> On Tue, Feb 19, 2019 at 10:46 PM Taher Alkhateeb  wrote:
>
> > The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
> > we are happy to announce that he has accepted this role.
> >
> > Some of the reasons for inviting Mathieu include:
> >
> > - He is invested in the OFBiz project and has delivered substantial
> > work to the code base.
> > - He has demonstrated solid technical skills.
> > - He adopts a professional attitude towards coding and software
> > development.
> > - He engages thoughtfully with others and likes to work with the
> community.
> >
> > Please join me in welcoming and congratulating Mathieu!
> >
> > Cheers,
> > Taher Alkhateeb
> >
>


Re: PMC wiki page update

2019-06-22 Thread Deepak Nigam
Hi Jacques,

I am not getting the option to edit the page. Getting the following message:
Access to add and change pages is restricted. See:
https://cwiki.apache.org/confluence/display/OFBIZ/Wiki+access

Thanks
--
Deepak Nigam

On Sat, Jun 22, 2019 at 7:26 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Swapnil, Pawan and Deepak (Nigam),
>
> @Swapnil, @Pawan, thank you for adding yourself at
>
>
> https://cwiki.apache.org/confluence/display/OFBIZ/Apache+OFBiz+PMC+Members+and+Committers
>
> As said in its titles, this page is not official, sot there is not
> obligation at all.
> So far we tried to keep an alphabetical order based on last name, please
> reorder your lines.
>
> @Deepak, you might want to add yourself there when you get a chance.
>
> Thanks and welcome again :)
>
> Jacques
>
>


Re: PMC wiki page update

2019-06-22 Thread Deepak Nigam
Thanks, Jacques.

It is working now.

On Sun, Jun 23, 2019 at 2:22 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Deepak,
>
> I think it's due to the fact that you have recently been elected as a
> committer and that now (it's also "recent"[1]) committers should use their
> committer name (aka ASF Id) for login in Confluence (not yet in Jira)
>
> You were registered as deepaknigam.1990 for Confluence contributions, I
> changed for deepaknigam and it should work now, welcome again :)
>
> [1] https://s.apache.org/IHiJ
>
> Jacques
>
> Le 22/06/2019 à 16:59, Jacques Le Roux a écrit :
> > Thanks for feedback Deepak,
> >
> > I'll have a look at it ASAP...
> >
> > Jacques
> >
> > Le 22/06/2019 à 16:08, Deepak Nigam a écrit :
> >> Hi Jacques,
> >>
> >> I am not getting the option to edit the page. Getting the following
> message:
> >> Access to add and change pages is restricted. See:
> https://cwiki.apache.org/confluence/display/OFBIZ/Wiki+access
> >>
> >> Thanks
> >> --
> >> Deepak Nigam
> >>
> >> On Sat, Jun 22, 2019 at 7:26 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com <mailto:jacques.le.r...@les7arts.com>> wrote:
> >>
> >> Hi Swapnil, Pawan and Deepak (Nigam),
> >>
> >> @Swapnil, @Pawan, thank you for adding yourself at
> >>
> >>
> https://cwiki.apache.org/confluence/display/OFBIZ/Apache+OFBiz+PMC+Members+and+Committers
> >>
> >> As said in its titles, this page is not official, sot there is not
> obligation at all.
> >> So far we tried to keep an alphabetical order based on last name,
> please reorder your lines.
> >>
> >> @Deepak, you might want to add yourself there when you get a chance.
> >>
> >> Thanks and welcome again :)
> >>
> >> Jacques
> >>
> >
>


Location of .wsdd file

2019-09-03 Thread Deepak Nigam
Hello all,

I am trying to integrate CyberSource with OFBiz using SOAP toolkit. We can
consume its web services using Apache Axis and WSS4J. I am following the
developer's guide [1] for it.

The last step in this guide is as follows:


*Run the sample as follows:*
*java -Daxis.ClientConfigFile=SampleDeploy.wsdd Sample*

It is providing axis.ClientConfigFile from the command line argument. Where
do I need to configure and put this file in OFBiz (or any web application)?

Thanks in advance!

[1]
http://apps.cybersource.com/library/documentation/dev_guides/SOAP_Toolkits/html/wwhelp/wwhimpl/js/html/wwhelp.htm#href=ApacheAxis.12.1.html

Regards,
Deepak Nigam


GMT Offset time format to timestamp

2019-08-27 Thread Deepak Nigam
Hello all,

I have a date in the format -mm-ddThh:mm:ss.nnn+time zone
(2019-07-28T00:00:00.000+05:30), I need to convert it to Timestamp object
so that I can store in one of the OFBiz entity. Is there any OOTB feature
available for this?

Thanks & Regards
--
Deepak Nigam


Re: Welcome Pranay Pandey as a new PMC member

2019-09-26 Thread Deepak Nigam
Many congratulations, Pranay.

Thanks & Regards
--
Deepak Nigam

On Thu, Sep 26, 2019 at 3:00 PM Nicola Mazzoni 
wrote:

> Congratulations Pranay!!!
> N
>
> Il giorno gio 26 set 2019 alle ore 08:50 Nicolas Malin <
> nicolas.ma...@nereide.fr> ha scritto:
>
> > Bienvenu,
> >
> > It will a pleasure to see you on board.
> >
> > Nicolas
> >
> > On 9/24/19 5:36 PM, Jacques Le Roux wrote:
> > > The OFBiz PMC has invited Pranay Pandey to become a new member of the
> > > committee and we are glad to announce that he has accepted the
> > > nomination.
> > >
> > > Welcome on board Pranay!
> > >
> > > Jacques (on behalf of the OFBiz PMC)
> > >
> > >
> >
>
>
> --
> Nicola Mazzoni
>
>
> *Mp Styl**e Srl*
> via Meucci, 37
> 41019 Limidi di Soliera (MO)
> T 059/684916
> M 347/9905529
>
> www.mpstyle.it
>


Re: svn commit: r1867663 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml

2019-09-29 Thread Deepak Nigam
Thanks, Swapnil and Pierre for your inputs. I'll do an SVN prop change.

Thanks & Regards
--
Deepak Nigam

On Sun, Sep 29, 2019 at 3:56 PM Pierre Smits  wrote:

> Fyi: improvement (tickets) get ‘implemented’, and bugs get ‘fixed’. As per
> established conventions.
>
> On Sat, 28 Sep 2019 at 15:50 Swapnil M Mane 
> wrote:
>
> > Hi Deepak,
> >
> > Happy to see your commits in action. :)
> > Just a minor suggestion, we put Jira ticket ID in separate line in commit
> > log.
> > Also, add colon ':' in Thanks statement.
> > And since the ticket type is 'Improvement', it seems to me, we should use
> > 'Improved' instead of 'Fixed'.
> >
> > Here is commit template for your quick reference
> >
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
> >
> > Following commit log template will help us in producing the monthly blog
> > development details.
> >
> > Thanks for your cooperation.
> >
> > Best regards,
> > Swapnil M Mane,
> > ofbiz.apache.org
> >
> >
> >
> > On Sat, Sep 28, 2019 at 3:56 PM  wrote:
> >
> > > Author: deepaknigam
> > > Date: Sat Sep 28 10:26:09 2019
> > > New Revision: 1867663
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1867663=rev
> > > Log:
> > > Fixed: Serbian CommonEntityLabels for geo entity. (OFBIZ-11209)
> > > Added missing entity label for Serbia.
> > > Thanks Ulrich Heidfeld for your contribution.
> > >
> > > Modified:
> > >
> > >
> >
> ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml
> > >
> > > Modified:
> > >
> >
> ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml?rev=1867663=1867662=1867663=diff
> > >
> > >
> >
> ==
> > > ---
> > >
> >
> ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml
> > > (original)
> > > +++
> > >
> >
> ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml
> > > Sat Sep 28 10:26:09 2019
> > > @@ -8011,6 +8011,10 @@
> > >  圣皮埃尔和密克隆群岛
> > >  è –çš®åŸƒçˆ¾å’Œå¯†å…‹éš†ç¾¤å³¶
> > >  
> > > +
> > > +Serbien
> > > +Serbia
> > > +
> > >  
> > >  سان تومي
> وبرينسيبي
> > >  Sao Tome und Principe
> > >
> > >
> > >
> >
> --
> Sent from my phone
>


Re: [VOTE] [RELEASE] Apache OFBiz 16.11.07

2020-02-03 Thread Deepak Nigam
+1

Thanks & Regards
--
Deepak Nigam

On Thu, Jan 30, 2020 at 7:43 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

>  This is the vote thread to release a new bug fix release for the
> release16.11 branch. This new release, "Apache OFBiz 16.11.07" will
> supersede all the previous releases from the same branch.
> Please consider that this may be the last release in the 16.11 series and
> in the future releases will be published from the newer series only.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-16.11.07.zip
> * KEYS: text file with keys
> * apache-ofbiz-16.11.07.zip.asc: the detached signature file
> * apache-ofbiz-16.11.07.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for instructions
> on testing the signatures see http://www.apache.org/info/verification.html
> ).
>
> Vote:
> [ +1] release as Apache OFBiz 16.11.07
> [ -1] do not release
>
> This vote will be open for 5 days.
> For more details about this process refer to
> http://www.apache.org/foundation/voting.html
>
> Kind Regards,
>
> Jacopo
>


Re: Welcome to Olivier Heintz as new committer!

2020-01-20 Thread Deepak Nigam
Congratulations Oliver!!!

Welcome aboard.


Thanks & Regards
--
Deepak Nigam

On Mon, Jan 20, 2020 at 11:43 AM Ashish Vijaywargiya <
vijaywargiya.ash...@gmail.com> wrote:

> Congratulations Oliver.
>
> Thanks,
> Ashish
>
> On Thu, Jan 16, 2020 at 7:53 PM Taher Alkhateeb  wrote:
>
> > The OFBiz PMC has invited Olivier Heintz to become a new committer and
> > we are happy to announce that he has accepted this role.
> >
> > Some of the reasons for inviting Olivier Heintz include:
> >
> > - He is invested in the OFBiz project and has been a member for many
> years
> > - He is taking an initiative towards improving the UI part of the system
> > - He has functional experience in various areas of the framework
> > - He enjoys working with the community and collaborating with others
> >
> > Please join me in welcoming and congratulating Olivier!
> >
> > Cheers,
> > Taher Alkhateeb
> >
>


Re: Welcome Swapnil M Mane as new PMC member

2020-04-28 Thread Deepak Nigam
Congratulations, Swapnil.

Regards
--
Deepak Nigam

On Mon, Apr 27, 2020, 11:02 AM Aditya Sharma 
wrote:

> Congratulations Swapnil!
>
> Thanks and Regards,
> Aditya Sharma
>
> On Sat, Apr 25, 2020 at 9:58 PM Mohammad Kathawala <
> mohammad.kathaw...@hotwaxsystems.com> wrote:
>
> > Many Congratulations Swapnil!
> > Kind Regards,
> > Mohammad Kathawala
> > Senior Technical Consultant
> > *HotWax Systems*
> > *Enterprise open source experts*
> > cell: +91-7772858789
> > office: 0731-409-3684
> > http://www.hotwaxsystems.com
> >
> >
> > On Sat, Apr 25, 2020 at 7:19 PM Pranay Pandey <
> > pranay.pan...@hotwaxsystems.com> wrote:
> >
> > > Swapnil M,
> > >
> > > Congratulations and welcome.
> > > Looking forward to a wonderful journey together.
> > >
> > > Best regards,
> > > Pranay Pandey
> > >
> > >
> > > On Thu, Apr 23, 2020 at 5:02 PM Jacques Le Roux <
> > > jacques.le.r...@les7arts.com> wrote:
> > >
> > > > The OFBiz PMC has invited Swapnil M Mane to become member of the
> > > committee
> > > > and we are glad to announce that he has accepted the nomination.
> > > >
> > > > On behalf of the OFBiz PMC, welcome on board!
> > > >
> > > >
> > >
> >
>


Re: Welcome Rishi Solanki as new PMC member

2020-04-28 Thread Deepak Nigam
Congratulations, Rishi!!

On Tue, Apr 28, 2020, 8:26 PM Pawan Verma 
wrote:

> Many congratulations Rishi!
>
> Best
> Pawan Verma
>


Re: Welcome to Vasmatkar as new committer!

2020-04-22 Thread Deepak Nigam
Congratulations Girish!!!

--
Deepak Nigam


On Wed, Apr 22, 2020, 3:31 PM Ankush Upadhyay <
ankush.upadh...@hotwaxsystems.com> wrote:

> Congratulations Girish!!
>
> Kind Regards,
> Ankush Upadhyay
> Senior Technical Consultant
>
> *HotWax Systems*
> *Enterprise open source experts*
> cell: +91-8109201285
> office: 0731-409-3684
> http://www.hotwaxsystems.com
>
>
> On Wed, Apr 22, 2020 at 3:26 PM Pawan Verma  wrote:
>
> > Congratulations Girish!
> > --
> > Thanks & Regards
> > Pawan Verma
> > ofbiz.apache.org
> >
> >
> > On Wed, Apr 22, 2020 at 3:16 PM Suraj Khurana 
> > wrote:
> >
> > > Congratulations Girish !!
> > >
> > > --
> > > Best Regards,
> > > Suraj Khurana
> > > Senior Technical Consultant
> > >
> > >
> > > On Wed, Apr 22, 2020 at 3:11 PM Ashish Vijaywargiya <
> > > ashish.vijaywarg...@hotwaxsystems.com> wrote:
> > >
> > > > Congrats Girish!
> > > >
> > > > --
> > > > Kind Regards,
> > > > Ashish Vijaywargiya
> > > > Vice President of Operations
> > > > *HotWax Systems*
> > > > *Enterprise open source experts*
> > > > cell: +91-9893479711
> > > > http://www.hotwaxsystems.com
> > > >
> > > >
> > > >
> > > > On Wed, Apr 22, 2020 at 3:09 PM Jacques Le Roux <
> > > > jacques.le.r...@les7arts.com> wrote:
> > > >
> > > > > The OFBiz PMC has invited Girish to become a new committer and we
> are
> > > > > pleased  to announce that he has accepted.
> > > > >
> > > > > Girish is part of the community for near 2 years and has proposed
> > > several
> > > > > smart propositions notably related to security and GraphQL, but not
> > > only.
> > > > >
> > > > > Please join me in welcoming and congratulating Girish.
> > > > >
> > > > > Jacques
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>


Re: Welcome James Young as new PMC member

2020-04-22 Thread Deepak Nigam
Congratulations James!!!

Regards
--
Deepak Nigam



On Wed, Apr 22, 2020, 3:25 PM Pawan Verma  wrote:

> Congratulations James!
> --
> Thanks & Regards
> Pawan Verma
> ofbiz.apache.org
>
>
> On Wed, Apr 22, 2020 at 3:16 PM Suraj Khurana 
> wrote:
>
> > Congratulations James !!
> >
> > --
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
> >
> >
> > On Wed, Apr 22, 2020 at 3:15 PM Ashish Vijaywargiya <
> > ashish.vijaywarg...@hotwaxsystems.com> wrote:
> >
> > > Congrats James!
> > >
> > > --
> > > Kind Regards,
> > > Ashish Vijaywargiya
> > > Vice President of Operations
> > > *HotWax Systems*
> > > *Enterprise open source experts*
> > > cell: +91-9893479711
> > > http://www.hotwaxsystems.com
> > >
> > >
> > >
> > > On Wed, Apr 22, 2020 at 2:08 PM Jacques Le Roux <
> > > jacques.le.r...@les7arts.com> wrote:
> > >
> > > > The OFBiz PMC has invited James Young to become member of the
> committee
> > > > and we are glad to announce that he has accepted the nomination.
> > > >
> > > > On behalf of the OFBiz PMC, welcome on board!
> > > >
> > > >
> > >
> >
>


Re: Have a README.TXT file in release package

2020-05-10 Thread Deepak Nigam
+1

Thanks & Regards
--
Deepak Nigam



On Sun, May 10, 2020, 10:15 PM Jacques Le Roux 
wrote:

> Hi,
>
> We often get questions from people not reading the basic documentation.
> Like not able to run Gradle because ignoring init-gradle-wrapper scripts.
>
> I know there will always people not reading the documentation. But maybe,
> to prevent most obvious questions and tempting RTFM answers, we could add a
> small README.TXT with basic information in OFBiz root.
>
> It would ultimately refer to README.adoc. Also saying that README.adoc can
> be read with a text reader tool. And it's easy to follow
>
> https://asciidoctor.org/docs/convert-documents/#converting-a-document-to-html
>
> What do you think?
>
> Jacques
>
>


Re: Welcome Pawan Verma as new PMC member

2020-07-29 Thread Deepak Nigam
Many congratulations, Pawan.


Thanks & Regards
--
Deepak Nigam

On Wed, Jul 29, 2020, 3:56 PM Ankush Upadhyay <
ankush.upadh...@hotwaxsystems.com> wrote:

> Many Congratulations Pawan!
>
> Kind Regards,
> Ankush Upadhyay
> Senior Technical Consultant
>
> *HotWax Systems*
> *Enterprise open source experts*
> cell: +91-8109201285
> office: 0731-409-3684
> http://www.hotwaxsystems.com
>
>
> On Wed, Jul 29, 2020 at 3:02 PM Arvind Singh Tomar <
> arvind.to...@hotwaxsystems.com> wrote:
>
> > Many congratulations Pawan!
> >
> > Kind regards
> > --
> > Arvind Singh Tomar
> >
> > On Tue, Jul 28, 2020 at 7:33 PM Mridul Pathak <
> > mridul.pat...@hotwaxsystems.com> wrote:
> >
> > > Many congratulations Pawan!!
> > >
> > > Thanks.
> > > --
> > > Mridul Pathak
> > >
> > > > On 28-Jul-2020, at 1:21 PM, Jacques Le Roux <
> > > jacques.le.r...@les7arts.com> wrote:
> > > >
> > > > The OFBiz PMC has invited Pawan Verma to become member of the
> committee
> > > and we are glad to announce that he has accepted the nomination.
> > > >
> > > > On behalf of the OFBiz PMC, welcome on board Pawan!
> > > >
> > >
> > >
> >
>


Re: Welcome to Priya Sharma as new committer!

2021-03-12 Thread Deepak Nigam
Many congratulations Priya!

Thanks & Regards
--
Deepak Nigam

On Fri, Mar 12, 2021 at 10:42 AM Devanshu Vyas 
wrote:

> Many Congratulations Priya!! Welcome onboard.
>
> Thanks & Regards,
> Devanshu Vyas.
>
>
> On Thu, Mar 11, 2021 at 6:31 PM Pawan Verma  wrote:
>
> > The OFBiz PMC has invited Priya to become a new committer and we are
> > pleased to announce that she has accepted the nomination.
> >
> > Welcome onboard Priya, more power to you!
> >
> >
> > Pawan
> >
>


[jira] [Commented] (OFBIZ-6236) Integration of OFBiz and Magento ecommerce for providing Order Management support

2016-06-18 Thread Deepak Nigam (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337585#comment-15337585
 ] 

Deepak Nigam commented on OFBIZ-6236:
-

As the directory structure of new versions of magento has been changed, this 
plugin will support only up to community editions 1.9.x. To make it compatible 
with new versions, a lot of code refactoring will be required. Should we 
committed this plugin and plan for magento 2.x versions later ?

> Integration of OFBiz and Magento ecommerce for providing Order Management 
> support
> -
>
> Key: OFBIZ-6236
> URL: https://issues.apache.org/jira/browse/OFBIZ-6236
> Project: OFBiz
>  Issue Type: New Feature
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Trivial
> Attachments: Magento-Setup-Guide.pdf, OFBIZ-6236.patch, 
> OFBiz_Connect-1.0.0.tgz
>
>
> Integration of OFBiz and Magento Ecommerce for providing Order Management 
> support.
> We can use OFBiz ERP system for handling Magento orders work-flow till 
> fulfilment.
> Featrures:
> This integration can be use to provide Order and Warehouse Management to the 
> orders placed via Magento E-commerce store.
> -- Imports store data and configuartion settings from Magento store
> -- Imports Shipping configuration
> -- Imports Categories
> -- Imports Products along with images path
> -- One time import inventory count of products
> -- Import pending orders from Magento
> -- Sync Cancel and Held orders between Magento and OFBiz
> -- Push shipment details and tracking code to Magento
> -- Refund amoung using CreditMemo feature of Magento
> Once the setup would be done, there are scheduled services that checks orders 
> in Magento every hour.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7439) Required field indicator (*) is missing on Project Manager -> My Task Screen

2016-06-18 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-7439:
---

 Summary: Required field indicator (*) is missing on Project 
Manager -> My Task Screen
 Key: OFBIZ-7439
 URL: https://issues.apache.org/jira/browse/OFBIZ-7439
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/projectmgr
Affects Versions: Trunk
Reporter: Deepak Nigam
Priority: Trivial


Required field indicator (*) is missing for field 'Parent Phase' on screen 
Project Manager -> My Task Screen -> Add a new task to one of my projects .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7469) No need to select mime type of content in E-commerce / Party Profile

2016-06-18 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-7469:
---

 Summary: No need to select mime type of content in E-commerce / 
Party Profile
 Key: OFBIZ-7469
 URL: https://issues.apache.org/jira/browse/OFBIZ-7469
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/ecommerce
Affects Versions: Trunk
Reporter: Deepak Nigam
Priority: Minor


There is no need to provide drop-down from selecting mime type of the content 
while uploading new file from ecommerce / view profile / file manager .
As this is an old pattern, now we have 'tika' library to identity mime type of 
a uploaded content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7469) No need to select mime type of content in E-commerce / Party Profile

2016-06-18 Thread Deepak Nigam (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-7469:

Attachment: MimeTypeSelection.png

> No need to select mime type of content in E-commerce / Party Profile
> 
>
> Key: OFBIZ-7469
> URL: https://issues.apache.org/jira/browse/OFBIZ-7469
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Priority: Minor
> Attachments: MimeTypeSelection.png
>
>
> There is no need to provide drop-down from selecting mime type of the content 
> while uploading new file from ecommerce / view profile / file manager .
> As this is an old pattern, now we have 'tika' library to identity mime type 
> of a uploaded content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7444) 'Data' suffix is missing in the name of some data files

2016-06-18 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-7444:
---

 Summary: 'Data' suffix is missing in the name of some data files 
 Key: OFBIZ-7444
 URL: https://issues.apache.org/jira/browse/OFBIZ-7444
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS
Affects Versions: Trunk
Reporter: Deepak Nigam
Priority: Minor


We have the pattern of using 'Data' suffix in name of data files throughout the 
project. But there are some files which do not have Data suffix in file name, 
and these files do not come into search results when we search by 'data' 
keyword. Following are some examples : 

applications/accounting/DemoGeneralChartOfAccounts.xml
applications/accounting/DemoPaymentsInvoices.xml
applications/accounting/DemoTaxAuthority.xml
applications/accounting/UsTaxAccountGroups.xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7462) Required Field Indicator (*) / Form Validation is missing on Create New Data Source Form

2016-06-18 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-7462:
---

 Summary: Required Field Indicator (*) / Form Validation is missing 
on Create New Data Source Form  
 Key: OFBIZ-7462
 URL: https://issues.apache.org/jira/browse/OFBIZ-7462
 Project: OFBiz
  Issue Type: Improvement
  Components: marketing
Affects Versions: Trunk
Reporter: Deepak Nigam
Priority: Trivial


Form Validation / Required Field Indicator (*) is missing on Create New Data 
Source Form . 
Marketing -> Data Source -> Create Data Source -> Data Source Id



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6929) DemoOrganisationData.xml doesn't load

2016-03-19 Thread Deepak Nigam (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202688#comment-15202688
 ] 

Deepak Nigam commented on OFBIZ-6929:
-

Hi [~pfm.smits] ,

I ran command ./ant load-demo and data of DemoOrganizationData.xml got 
successfully loaded. 

Following are the details of my local box : 
OFBiz Version : Trunk
Mysql version  : 5.6.27-0ubuntu0.14.04.1
Operating System : Ubuntu 14.04.3 LTS

> DemoOrganisationData.xml doesn't load
> -
>
> Key: OFBIZ-6929
> URL: https://issues.apache.org/jira/browse/OFBIZ-6929
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6929) DemoOrganisationData.xml doesn't load

2016-03-19 Thread Deepak Nigam (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202711#comment-15202711
 ] 

Deepak Nigam commented on OFBIZ-6929:
-

It is working for Derby database also.

> DemoOrganisationData.xml doesn't load
> -
>
> Key: OFBIZ-6929
> URL: https://issues.apache.org/jira/browse/OFBIZ-6929
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7852) Client side validation is missing at Create Ebay Account form

2016-07-16 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-7852:
---

 Summary: Client side validation is missing at Create Ebay Account 
form
 Key: OFBIZ-7852
 URL: https://issues.apache.org/jira/browse/OFBIZ-7852
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/ebay
Reporter: Deepak Nigam


Client side validation is missing at Create Ebay Account form for 'Current 
Password' and 'Current Password Verify' fields. On keeping these fields empty 
user is getting errors from service side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7833) Redundant options at select filter on find screens

2016-07-16 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-7833:
---

 Summary: Redundant options at select filter on find screens
 Key: OFBIZ-7833
 URL: https://issues.apache.org/jira/browse/OFBIZ-7833
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Reporter: Deepak Nigam
 Attachments: RedundantOptions.png

On some of the find screens, where we have select drop down as a search filter, 
there are two options : Blank (No Value) and Any. Functional meaning of these 
two options are same. We can remove blank option and use 'Any' option wherever 
applicable to avoid redundancy and for consistency throughout the application.

For more clarification please refer the attached screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7833) Redundant options at select filter on find screens

2016-07-16 Thread Deepak Nigam (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-7833:

Attachment: RedundantOptions.png

> Redundant options at select filter on find screens
> --
>
> Key: OFBIZ-7833
> URL: https://issues.apache.org/jira/browse/OFBIZ-7833
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>    Reporter: Deepak Nigam
> Attachments: RedundantOptions.png
>
>
> On some of the find screens, where we have select drop down as a search 
> filter, there are two options : Blank (No Value) and Any. Functional meaning 
> of these two options are same. We can remove blank option and use 'Any' 
> option wherever applicable to avoid redundancy and for consistency throughout 
> the application.
> For more clarification please refer the attached screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7842) Error on submitting Ebay Accounts

2016-07-16 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-7842:
---

 Summary: Error on submitting Ebay Accounts 
 Key: OFBIZ-7842
 URL: https://issues.apache.org/jira/browse/OFBIZ-7842
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/ebay
Reporter: Deepak Nigam


Go to Ebay Store, select any Ebay Account and click on Submit button. Following 
error is coming : 

ERROR rendering error page [/error/error.jsp], but here is the error text: 
org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
[component://ebaystore/widget/EbayAccountScreens.xml#EbayPersonalInformation]: 
org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
[component://ebaystore/widget/CommonScreens.xml#AccountDecorator]: 
org.ofbiz.entity.transaction.GenericTransactionException: The current 
transaction is marked for rollback, not beginning a new transaction and 
aborting current operation; the rollbackOnly was caused by: Error in Service 
[getEbayUser]: Auth token is hard expired, User needs to generate a new token 
for this application. (The current transaction is marked for rollback, not 
beginning a new transaction and aborting current operation; the rollbackOnly 
was caused by: Error in Service [getEbayUser]: Auth token is hard expired, User 
needs to generate a new token for this application.) (Error rendering screen 
[component://ebaystore/widget/CommonScreens.xml#AccountDecorator]: 
org.ofbiz.entity.transaction.GenericTransactionException: The current 
transaction is marked for rollback, not beginning a new transaction and 
aborting current operation; the rollbackOnly was caused by: Error in Service 
[getEbayUser]: Auth token is hard expired, User needs to generate a new token 
for this application. (The current transaction is marked for rollback, not 
beginning a new transaction and aborting current operation; the rollbackOnly 
was caused by: Error in Service [getEbayUser]: Auth token is hard expired, User 
needs to generate a new token for this application.)) 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7866) Client side validation is missing at Add Ebay Configuration form

2016-07-16 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-7866:
---

 Summary: Client side validation is missing at Add Ebay 
Configuration form
 Key: OFBIZ-7866
 URL: https://issues.apache.org/jira/browse/OFBIZ-7866
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/ebaystore
Reporter: Deepak Nigam
Priority: Minor


Client side validations are missing at 'Add Ebay Configuration' feature. Error 
from server side is being thrown if we do not provide the required fields.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7852) Client side validation is missing at Create Ebay Account form

2016-07-16 Thread Deepak Nigam (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-7852:

Component/s: (was: specialpurpose/ebay)
 specialpurpose/ebaystore

> Client side validation is missing at Create Ebay Account form
> -
>
> Key: OFBIZ-7852
> URL: https://issues.apache.org/jira/browse/OFBIZ-7852
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ebaystore
>    Reporter: Deepak Nigam
>
> Client side validation is missing at Create Ebay Account form for 'Current 
> Password' and 'Current Password Verify' fields. On keeping these fields empty 
> user is getting errors from service side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7694) Support of Internationlization by adding UI labels for error / success messages

2016-07-01 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-7694:
---

 Summary: Support of Internationlization by adding UI labels for 
error / success messages
 Key: OFBIZ-7694
 URL: https://issues.apache.org/jira/browse/OFBIZ-7694
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Deepak Nigam


At many places in the system we have hard-coded success / error messages, we 
can add UI lables for these so that user can see messages in corresponding 
language.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7695) Add UI labels for success / eror messages in java and groovy files

2016-07-01 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-7695:
---

 Summary: Add UI labels for success / eror messages in java and 
groovy files
 Key: OFBIZ-7695
 URL: https://issues.apache.org/jira/browse/OFBIZ-7695
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Deepak Nigam






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7697) Add UI labels for success / eror messages in ftl files

2016-07-01 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-7697:
---

 Summary: Add UI labels for success / eror messages in ftl files
 Key: OFBIZ-7697
 URL: https://issues.apache.org/jira/browse/OFBIZ-7697
 Project: OFBiz
  Issue Type: Improvement
Reporter: Deepak Nigam






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7696) Add UI labels for success / eror messages in XML files

2016-07-01 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-7696:
---

 Summary: Add UI labels for success / eror messages in XML files
 Key: OFBIZ-7696
 URL: https://issues.apache.org/jira/browse/OFBIZ-7696
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Deepak Nigam






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7698) Remove un-used variables from Java and Groovy files.

2016-07-01 Thread Deepak Nigam (JIRA)
Deepak Nigam created OFBIZ-7698:
---

 Summary: Remove un-used variables from Java and Groovy files.
 Key: OFBIZ-7698
 URL: https://issues.apache.org/jira/browse/OFBIZ-7698
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Reporter: Deepak Nigam


In many files we have some unused variables which are overhead for the system, 
we can remove these variables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)