Re: HTTP Compression not working for some files (JS and CSS)

2018-08-21 Thread girish . vasmatkar
s. > > > > > > > > All medium to large files (more than 50 KB or so) are not getting > > compressed. Has anyone else observed the same? I can definitely see that > > Content-Encoding:gzip response header is set for all the files that are > > compressed and the transfer size doe

Re: Old demo restarted

2018-08-23 Thread Girish Vasmatkar
and have not used it much but may be we can use it to send some notifications? Of course, it is applicable for graceful exits of JVM only and if you just happen to kill the process it won't be of much help. Hope it makes sense and correct me if I am wrong. Best regards, Girish Vasmatkar HotWax

Re: Old demo restarted

2018-08-24 Thread Girish Vasmatkar
Hi Taher Please see my reply below in-line. On Fri, Aug 24, 2018 at 12:22 PM Taher Alkhateeb wrote: > Hi Girish, inline... > > On Thu, Aug 23, 2018, 7:25 PM Girish Vasmatkar < > girish.vasmat...@hotwaxsystems.com> wrote: > > > I had earlier replied to this thread b

Re: Old demo restarted

2018-08-24 Thread Girish Vasmatkar
to allow for remote monitoring. Also, to enable further analysis of what went wrong, why JVM crashed etc, we should also dump heap as the JVM shuts down. Too many ways and too many options. Probably need to reach a unanimous decision, IMO. Thanks and Best regards, Girish Vasmatkar On Fri, Aug 24

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-25 Thread Girish Vasmatkar
approach, IMO. May be it is not a major issue but certainly worthy of having a dedicated JIRA for. Everybody, please chime in and provide your thoughts. Thanks and Best regards, Girish Vasmatkar HotWax Systems On Sat, Aug 25, 2018 at 8:03 PM Taher Alkhateeb wrote: > Okay, I understand this issue

Re: HTTP Compression not working for some files (JS and CSS)

2018-08-20 Thread girish . vasmatkar
> compressed and the transfer size does indicate they were compressed based > > on what size I see on the disk. > > > > > > Thanks, > > Girish Vasmatkar > > HotWax Systems > > > > > Hi Michael I can see the response headers in Chrome developers t

HTTP Compression not working for some files (JS and CSS)

2018-08-20 Thread girish . vasmatkar
can definitely see that Content-Encoding:gzip response header is set for all the files that are compressed and the transfer size does indicate they were compressed based on what size I see on the disk. Thanks, Girish Vasmatkar HotWax Systems

CSRF attack and prevention

2018-09-02 Thread girish . vasmatkar
with all details provided we have the necessary concord. Thanks and Best regards, Girish Vasmatkar HotWax Systems

Re: CSRF attack and prevention

2018-09-06 Thread Girish Vasmatkar
Hi Jacques, Thanks for your reply. I will certainly take a look at the JIRA and will also try to see we can successfully implement CSRF filter. I will provide my inputs on the JIRA as well. Best, Girish Vasmatkar HotWax Systems On Thu, Sep 6, 2018 at 7:19 PM Jacques Le Roux wrote: >

Re: How to deploy Microservice developed using Spring boot to ofbiz

2018-08-31 Thread girish . vasmatkar
n ofbiz ecosystem. It seems pretty daunting task and will require quite a bit of work. Thanks, Girish Vasmatkar HotWax Systems

Re: Hard Coded Cookie Path

2018-10-04 Thread Girish Vasmatkar
ion cookie created by the server has the path "/" set. If that is not the case, then navigating from parent web app to sub web app will result in session loss. So, all in all, it is mostly based on your scenario. I hope that makes sense. Thanks, Girish Vasmatkar HotWax Systems On Thu, Oc

Re: CSRF attack and prevention

2018-09-03 Thread Girish Vasmatkar
Thanks Jacques and Nicolas. I will take this further in the security group and will soon have updates there. My bad I didn't realise we need to take it up over there. Thanks and Best Regards, Girish Vasmatkar HotWax Systems On Mon, Sep 3, 2018 at 1:21 PM Jacques Le Roux wrote: > Hi Gir

Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread Girish Vasmatkar
I am all for having validations at the UI level, at least. Apart from Date, there are other fields that need some basic validations. Showing error/waring on tabbing out is one of the simplest forms for validation we can put on certain fields. +1 for this change. On Mon, Sep 3, 2018 at 10:24 PM

Re: POM relocation to an other version number is not fully supported in Gradle

2018-09-21 Thread Girish Vasmatkar
Hi Jacques It looks like every transitive dependency defined in our build.gradle to xml-apis is getting resolved to xml-apis:2.0.2. +--- xom:xom:1.2.5 ||+--- xml-apis:xml-apis:1.3.03 -> 2.0.2 +--- xml-apis:xml-apis:1.3.04 -> 2.0.2 org.apache.xmlrpc:xmlrpc-client:3.1.3 |\---

Re: Demo Trunk NPE

2018-09-22 Thread Girish Vasmatkar
ces.groovy]: java.lang.NullPointerException Caused by: java.lang.NullPointerException Best, Girish Vasmatkar HotWax Systems On Sat, Sep 22, 2018 at 3:02 PM Mohammad Kathawala < mohammad.kathaw...@hotwaxsystems.com> wrote: > Working for me. > Regards*,* > *Mohammad Kathawala* |

Re: [Discussion] Upgrading OFBiz to work with Java 11

2018-12-25 Thread Girish Vasmatkar
Hi Taher I haven't tried upgrading myself but I'm in for this effort. I think it only makes sense to do the upgrade. I'll also try Java 11 and see how it goes. Best, Girish On Wed, Dec 26, 2018 at 1:25 AM Taher Alkhateeb wrote: > Hi Folks, > > Now that we upgraded Gradle, I think we should

Re: [SUGGESTION] Common .derived file and AutoDeriv Eclipse plugin

2018-12-27 Thread Girish Vasmatkar
Hi Jacques Following two settings help me not facing the issue you're facing. I, too, ran into this issue when I initially set up OFBiz on eclipse. 1. Uncheck Show Derived Resources when you do CTRL+Shift+R, such that only Show Status Line is checked. I am sure you have it correctly, but

Re: Upgrading gradle to version 5.0

2018-11-28 Thread Girish Vasmatkar
Hi Taher I'm all for it. I have also updated the version and it seems to be working just fine in my workspace. Just a very minor caveat I noticed with the upgrade is that you don't see what all tasks gradle executed, while the earlier versions showed the executed tasks and their corresponding

Re: Session timeout for webapps

2019-01-10 Thread Girish Vasmatkar
ng and anyway best practice is to prefer convention > over configuration, even if in this case it's much redundant. > > I think we can reopen OFBIZ-6655 and handle it there, with an explanation. > > Other ideas? > > Jacques > > Le 09/01/2019 à 10:11, Girish Vasmatkar a écrit : &g

Re: Session timeout for webapps

2019-01-09 Thread Girish Vasmatkar
Hi Deepak By the time sessionCreated is called in an HttpSessionListener, the session has already been created. I am sure if you try to get the HttpSession from the HttpSessionEvent object, it will have what you defined in tag. But the code is overriding the timeout using setMaxInactiveInterval

Gradle eclipse task - classpath modification

2019-05-24 Thread Girish Vasmatkar
Hi All When you run eclipse task it removes all unnecessary classpath entries including the ones containing "config" and "dtd". This introduces a minor inconvenience, in turn, because you do need two entries below in order for OFBiz to start normally - /framework/base/config /framework/base/dtd

Re: Gradle eclipse task - classpath modification

2019-05-25 Thread Girish Vasmatkar
,128 |main |UtilXml |W| [UtilXml.LocalResolver.resolveEntity] could not find LOCAL DTD/Schema with pub Best, Girish On Sat, May 25, 2019 at 2:27 PM Mathieu Lirzin wrote: > Hello Girish, > > Girish Vasmatkar writes: > > > When you run eclipse task it remov

Re: Gradle eclipse task - classpath modification

2019-05-25 Thread Girish Vasmatkar
) at org.apache.ofbiz.base.start.StartupControlPanel.start( StartupControlPanel.java:71) at org.apache.ofbiz.base.start.Start.main(Start.java:85) Best, Girish On Sat, May 25, 2019 at 2:56 PM Girish Vasmatkar < girish.vasmat...@hotwaxsystems.com> wrote: > Hi Mathieu, > > With those entries missing from the classpath, you'd ge

Re: Gradle eclipse task - classpath modification

2019-05-25 Thread Girish Vasmatkar
application and you have OFBiz launched quickly. On Sat, May 25, 2019 at 7:23 PM Taher Alkhateeb wrote: > start how? what is the command? Are you trying to start _from_ eclipse. If > yes why? > > On Sat, May 25, 2019 at 2:26 PM Girish Vasmatkar < > girish.vasmat...@hotwax

Re: Gradle eclipse task - classpath modification

2019-05-25 Thread Girish Vasmatkar
if you can see the inline screenshot. Pl see below. [image: image.png] On Sat, May 25, 2019 at 4:49 PM Girish Vasmatkar < girish.vasmat...@hotwaxsystems.com> wrote: > There is a bit more to it ... > > When the system can't find cache.properties (as it's no more on the > cla

Re: Gradle eclipse task - classpath modification

2019-05-27 Thread Girish Vasmatkar
me in > the > > > past). It would also make a consistent experience to development team > > > regardless of the IDE and you won't have to alter the jar file to > > > accommodate an IDE. > > > > > > With that being said I don't think it's a big d

Re: Issue when debugging with Eclipse

2019-08-13 Thread Girish Vasmatkar
It is pretty much the same case with me as well. Not just this, I observe lag during DB operations as well. Did it use to be fast for you earlier? I would say first request always takes more time than the subsequent requests. My eclipse version - Version: Photon Release (4.8.0) Build id:

Re: OFBiz and Camel integration updated

2019-08-03 Thread Girish Vasmatkar
for considering such classes as part of test suite as well. We are using JUnit 4 but it is hardly being used except for being available on the classpath. Using JUnit 4 classes will make sure both mechanisms will be supported. Best, Girish On Fri, Jul 19, 2019 at 10:12 AM Girish Vasmatkar < girish.vas

Re: Issue when debugging with Eclipse

2019-08-14 Thread Girish Vasmatkar
Hi Jacques Hooking up OFBiz with a profiler should help as to which method (eventually leading to the dependency/API) is taking a lot of time helping narrowing down the cause. Not sure if you want to go down this road, but it may help. Best, Girish On Wed, Aug 14, 2019 at 3:56 PM Jacques Le

Fwd: OFBiz and Camel integration updated

2019-08-14 Thread Girish Vasmatkar
Moving it to DEV list. My apologies if it is a nuisance. I have attached plugin tar to the ticket for everybody to take a look at. Please review and try to run the plug-in and see if there is any issue with it. Best, Girish - Forwarded message - From: Girish Vasmatkar Date: Mon

Re: Location of .wsdd file

2019-09-04 Thread Girish Vasmatkar
If you just want to run the tutorial as it is, you need to place WSDD in the directory your code is getting executed from. Idea is it should be available in the classpath. Coming to OFBiz, you can place WSDD in any of the java packages (because they are on the classpath) and provide fully

Re: OFBiz and Camel integration updated

2019-07-18 Thread Girish Vasmatkar
Hi Bilgin I have created a pull request for *ofbiz-camel* component with the following additions and fixes. Please review and let me know what you think. Post review if you feel it is worth incorporating, we can add it as an ofbiz plugin. Here's the

Re: GraphQL API for OFBiz

2020-02-12 Thread Girish Vasmatkar
.org>, committer > Apache Steve <https://steve.apache.org>, committer > > > On Mon, Feb 10, 2020 at 11:40 AM Girish Vasmatkar < > girish.vasmat...@hotwaxsystems.com> wrote: > > > Hello > > > > I had been working on adding GraphQL support to OFBiz and

OFBiz Jersey Swagger plug in

2020-01-26 Thread Girish Vasmatkar
Hi All Just wanted to gauge the community's interest in having a JAX-RS component with swagger capabilities. I am fully aware of the fact that there are efforts undergoing on implementing a REST servlet. This can come handy for anyone comfortable with implementing JAX-RS or having experience

Re: OFBiz Jersey Swagger plug in

2020-01-26 Thread Girish Vasmatkar
Hi, Jacques. Thanks. I've created OFBIZ-11328 for the same. I'll attach details soon. Best, Girish On Sun, Jan 26, 2020 at 5:08 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 26/01/2020 à 10:57, Girish Vasmatkar a écrit : > > Hi All > > > > Just want

Re: OFBiz Jersey Swagger plug in

2020-01-29 Thread Girish Vasmatkar
nks and Regards > -- > Akash Jain > > On Sun, Jan 26, 2020 at 3:27 PM Girish Vasmatkar < > girish.vasmat...@hotwaxsystems.com> wrote: > > > Hi All > > > > Just wanted to gauge the community's interest in having a JAX-RS > component > > with swagger cap

Re: OFBiz Jersey Swagger plug in

2020-02-06 Thread Girish Vasmatkar
ersey ? > > Nicolas > > On 26/01/2020 10:57, Girish Vasmatkar wrote: > > Hi All > > > > Just wanted to gauge the community's interest in having a JAX-RS > component > > with swagger capabilities. I am fully aware of the fact that there are > > efforts under

GraphQL API for OFBiz

2020-02-10 Thread Girish Vasmatkar
Hello I had been working on adding GraphQL support to OFBiz and could come up with something that might be of interest to the community. Wanted to gauge community's interest on the same. Essentially, I have first tried to enable GraphQL support such that OFBiz is able to server GraphQL queries,

Re: [TEST] Test "POC for CSRF Token"

2020-03-09 Thread Girish Vasmatkar
Hi Jacques I tried to simulate the CSRF manually (and I plan to use Zap as well) and I got this error - Invalid or missing CSRF token to path '/EntitySQLProcessor' I logged in to OFBiz and then used an HTML form to perform the attack and the patch successfully prevented. So it looks good to

Re: GraphQL API for OFBiz

2020-03-26 Thread Girish Vasmatkar
Girish Vasmatkar On Wed, Feb 12, 2020 at 7:04 PM Girish Vasmatkar < girish.vasmat...@hotwaxsystems.com> wrote: > Thanks Pierre. > > Here's the ticket for the same. I'll keep posting updates to it. > > https://issues.apache.org/jira/browse/OFBIZ-11347 > > Best, > Girish

Re: GraphQL API for OFBiz

2020-04-02 Thread Girish Vasmatkar
- Operation Input Types - Nested GraphQLOutputType Best Regards, Girish On Sat, Mar 28, 2020 at 10:31 PM Girish Vasmatkar < girish.vasmat...@hotwaxsystems.com> wrote: > Hi Guys - > > I've attached video link of the demo held on 03/27 to the ticket > https://issues.apache.org

Re: GraphQL API for OFBiz

2020-03-28 Thread Girish Vasmatkar
t; > -- > > Deepak Dixit > > ofbiz.apache.org > > > > > > On Thu, Mar 26, 2020 at 9:18 PM Girish Vasmatkar < > > girish.vasmat...@hotwaxsystems.com> wrote: > > > > > Hi All > > > > > > I'm planning an introduction of the OFB

Re: [TEST] Test "POC for CSRF Token"

2020-03-28 Thread Girish Vasmatkar
Hi Jacques I second your points. However, I have the following question - Since you have explored and followed OWASP very extensively, do you think with the introduction of same-site attribute, the whole concept of CSRF token becomes somewhat redundant, provided almost every browser has the

Re: GraphQL API for OFBiz

2020-03-28 Thread Girish Vasmatkar
Hi Guys - I've attached video link of the demo held on 03/27 to the ticket https://issues.apache.org/jira/browse/OFBIZ-11347. Let me know should you have any questions. Best Regards, Girish On Sat, Mar 28, 2020 at 2:56 PM Girish Vasmatkar < girish.vasmat...@hotwaxsystems.com> wrote:

Re: Welcome Rishi Solanki as new PMC member

2020-04-28 Thread Girish Vasmatkar
Congratulations Rishi! Best, Girish On 28 Apr 2020 11:32 pm, "Akash Jain" wrote: > Many Congratulations Rishi!! > > Thanks and Regards > -- > Akash Jain > > On Tue, Apr 28, 2020 at 7:53 PM Jacopo Cappellato < > jacopo.cappell...@gmail.com> wrote: > > > The OFBiz PMC has invited Rishi Solanki to

Re: OFBiz-Shopify Integration

2020-04-26 Thread Girish Vasmatkar
Hi Ritesh - This is certainly going to be a great initiative. +1 Best, Girish On Sun, Apr 26, 2020 at 8:49 PM Suraj Khurana wrote: > +1 for creating a new plugin. > > -- > Best Regards, > Suraj Khurana > SENIOR TECHNICAL CONSULTANT > mobile: +91 9669750002 > email: suraj.khur...@hotwax.co

Re: Default constructors in JAVA classes

2020-04-22 Thread Girish Vasmatkar
Hi I am unsure if this needs to be extended or applied to the service classes because even though the service classes do not appear to maintain state, they conceptually relate to the business domain and hence are not a worthy candidate. Moreover they are executed within a context and don't

Re: Welcome to Girish Vasmatkar as new committer!

2020-04-22 Thread Girish Vasmatkar
Hi All Thanks for your continuous support in this journey. I am honoured and privileged to be part of this community. Sure, the committership comes with great responsibilities and I hope to back it up with even more commitment from my side. Thanks once again! Best, Girish On Wed, Apr 22, 2020

Re: Welcome Swapnil M Mane as new PMC member

2020-04-23 Thread Girish Vasmatkar
Congratulations, Swapnil. Best, Girish On Thu, Apr 23, 2020 at 6:48 PM Ankush Upadhyay < ankush.upadh...@hotwaxsystems.com> wrote: > Many Congratulations, Swapnil!!! > > Kind Regards, > Ankush Upadhyay > Senior Technical Consultant > > *HotWax Systems* > *Enterprise open source experts* > cell:

Re: getting started with ofbiz-rest-impl

2020-09-05 Thread Girish Vasmatkar
Hello Hans Thanks for giving it (REST Impl) a try and providing valuable feedback. The token's signature part and the payload part (that includes claims) does indeed change, while the header part is not expected to change. The token is revoked after it is expired (default is 1800 seconds based on

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-09-02 Thread Girish Vasmatkar
Hi Jacques/Akash - I have taken care of it with my latest commit - 310a2a58eff7cb203e4f7b25b78be23ea856aa79 Checkstyle count stays @ 2007 Best, Girish On Tue, Sep 1, 2020 at 10:20 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Akash, > > Please either fix the checkstyle issue

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-09-10 Thread Girish Vasmatkar
tu > > > > Build Reason: The AnyBranchScheduler scheduler named > 'onTrunkPluginsCommit' triggered this build > > Build Source Stamp: [branch trunk] > 42192da7d3cc8bd979711e72a47b104dda0c25a3 > > Blamelist: Girish Vasmatkar > > > > BUILD FAILED: failed check > > > > Sincerely, > > -The Buildbot > > > > > > >

Re: REST get no parameters

2020-09-09 Thread Girish Vasmatkar
Request", "errorMessage": "Missing Parameter: 'inParams'" } Best Regards, Girish Vasmatkar HotWax Systems On Thu, Sep 10, 2020 at 6:54 AM Hans Bakker wrote: > Sorry Girish me again, > > if i create a simple method service with action GET and no parameters ,

Re: public rest API

2020-09-09 Thread Girish Vasmatkar
that was applicable within internal execution. I may be wrong here, so please correct me. auth and login-required are not taken into account yet, but can certainly be, if some exportable services should be exposed as public APIs. Best Regards, Girish Vasmatkar HotWax Systems On Thu, Sep 10, 2020 at 5:55 AM

Re: public rest API

2020-09-10 Thread Girish Vasmatkar
Thanks Hans, I will plan to include this change for the exportable services as well. There is also OFBIZ-11995, where more RESTFul resources can be declared (development is undergoing) and bound to services where I had planned to include declarative authentication. Best Regards, Girish Vasmatkar

Re: getting started with ofbiz-rest-impl

2020-09-07 Thread Girish Vasmatkar
"Authorization: Bearer $token" --insecure > > I tried it also without the inner quotes but could not get his to work. > > i get: > { > "statusCode" : 500, > "statusDescription" : "Internal Server Error" > } > > can you help?

Re: getting started with ofbiz-rest-impl

2020-09-07 Thread Girish Vasmatkar
That being said, I should make the query param mandatory such that it returns 400 Bad Request "Missing Parameters" to let the client know of the error. I will make this improvement and commit soon. Best, Girish On Mon, Sep 7, 2020 at 11:59 AM Girish Vasmatkar <

Re: getting started with ofbiz-rest-impl

2020-09-07 Thread Girish Vasmatkar
"statusDescription" : "Internal Server Error", >"errorMessage" : "Required Field Missing : Party Id" > } > > any idea? > > Thanks in advance. > > Hans > > > just a quick question , does it also work with minilang? > &g

Re: buildbot exception in on ofbizTrunkFrameworkPlugins

2020-09-15 Thread Girish Vasmatkar
Hi Jacques Javadoc generated error. I have fixed it and it should be fine now. Best, Girish On Tue, Sep 15, 2020 at 2:34 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Girish, > > Could you please have a look? TIA > > Jacques > > Le 15/09/2020 à 10:22, build...@apache.org a

Re: REST upgrade not find services anymore....

2020-10-06 Thread Girish Vasmatkar
Hi Hans There's an error in your service definition file *services100.xml. *Please check *invoke* attribute below. Best Regards, Girish On Tue, Oct 6, 2020 at 6:58 PM Hans Bakker wrote: > Hi Girish, > > just upgraded the rest plugin and now services are not found anymore > > my log:

Re: netbeans development

2020-10-04 Thread Girish Vasmatkar
Hi Alex What version of NetBeans are you using? Your installation should have a gradle plugin installed that can get you started. Should be able to import OFBiz into NetBeans. Best Girish On Sun, Oct 4, 2020 at 6:28 PM Alex Bodnaru wrote: > hello friends, > > i wish to be able to deeper

Re: OFBiz REST implementation session #2 (10/07/2020)

2020-10-06 Thread Girish Vasmatkar
Sep 30, 2020 at 9:07 PM Girish Vasmatkar < girish.vasmat...@hotwaxsystems.com> wrote: > Hi Everyone! > > Please find details of the next session I am planning to hold on OFBiz > REST implementation. This will have some hands-on examples that will help > everyone using it. &g

Re: [OFBIZ-11976] svg files not removed on clean

2020-08-27 Thread Girish Vasmatkar
Hi Jacques - This explains it nicely - https://blog.softwaremill.com/my-task-whats-wrong-with-your-gradle-task-82312100c595 Turns out that gradle's configuration phase appears to be "running" the tasks. Best, Girish On Thu, Aug 27, 2020 at 3:12 PM Jacques Le Roux <

Re: [OFBIZ-11976] svg files not removed on clean

2020-08-27 Thread Girish Vasmatkar
Hi Jacques When you run "gradlew generateAllPluginsDocumentation", all "actions" defined in the task '"generateAllPluginsDocumentation" get executed as part of execution phase. doFirst and doLast are the actions defined hence they get executed. And when you run any other tasks, all tasks present

Re: REST, how about 'Login' map

2020-09-29 Thread Girish Vasmatkar
Hi Hans Since you specifically mentioned about groovy service, I would think it is true for other services as well. It would possibly be happening, if the service itself is declared with auth=false, so no token check is happening and hence userLogin is not retrieved from the token. Can you

Re: [PROPOSAL] Separate login service for API calls

2020-09-30 Thread Girish Vasmatkar
toring to pull these part out of the login event. > > > > Best regards, > > > > Michael Brohl > > > > ecomify GmbH - www.ecomify.de > > > > > > Am 29.09.20 um 09:43 schrieb Jacopo Cappellato: > > > +1 > > > > > > Jacopo &

OFBiz REST session

2020-09-30 Thread Girish Vasmatkar
Hi All We will be holding an introductory session on *ofbiz-rest-impl* plugin @ 4 PM IST, 10:30 AM GMT. Agenda for the same is as follows - 1. Introduction to ofbiz-rest-impl 2. Technology stack used 3. Q session Here's the meet URL for everybody's reference :

Re: OFBiz REST session

2020-09-30 Thread Girish Vasmatkar
pache Trafodion <https://trafodion.apache.org>, Vice President* > *Apache Directory <https://directory.apache.org>, PMC Member* > Apache Incubator <https://incubator.apache.org>, committer > Apache Steve <https://steve.apache.org>, committer > > > On Wed, Sep

OFBIZ-11995

2020-09-23 Thread Girish Vasmatkar
Hi All Continuing the efforts done on OFBIZ-11328, I have now added an XML based REST DSL that facilitates declarative resource bindings to OFBiz services (for now only OFBiz service). Various commits are pushed under OFBIZ-11995. It attempts to allow each component to define their own set of

[PROPOSAL] Separate login service for API calls

2020-09-25 Thread Girish Vasmatkar
Hi I am using userLogin service to authenticate users before generating auth tokens for REST API and GraphQL calls. However, I figured that a session is also getting created and returned in response which is defeating the purpose of having an API in place. Even though that session is not getting

Re: public rest API

2020-09-26 Thread Girish Vasmatkar
hu, Sep 10, 2020 at 5:46 PM Hans Bakker wrote: > Thank you Girish, > > look forward to your updates of this excellent and much needed addition to > OFBiz. > > Regars > > Hans > www.antwebsystems.com > On 9/10/20 3:27 PM, Girish Vasmatkar wrote: >

Re: [PROPOSAL] Separate login service for API calls

2020-09-26 Thread Girish Vasmatkar
onse. > > Besides, sessions are only problematic when a new session gets created > for > > each REST API request. You can prevent this by setting the cookie > SameSite > > property to "None". That way sessions and REST request can happily live > > togethe

Re: REST, how about 'Login' map

2020-09-30 Thread Girish Vasmatkar
; the login map need to be filled when the related token is available, what > is currently not the case. > > Not sure if this is directly related to the Auth=false parameter, you know > that better, > > Regards, Hans > On 9/29/20 4:20 PM, Girish Vasmatkar wrote: > > Hi Hans

Re: REST, how about 'Login' map

2020-10-01 Thread Girish Vasmatkar
rther i see you are working on the error messages? > would be nice to get the ofbiz error message together with the error code > 500? > > keep up the good work, it is getting better and better! > > Regards, > > Hans > On 10/1/20 10:49 AM, Girish Vasmatkar wrote: >

OFBiz REST implementation session #2 (10/07/2020)

2020-09-30 Thread Girish Vasmatkar
- HTTP 422 Unprocessable Entity - HTTP 405 Method Not Allowed - HTTP 406 Not Acceptable - HTTP 415 Unsupported Media Type 3. Content Negotiation (JSON) - Accept : application/json - Content-Type : application/json 4. Q session Best, Girish Vasmatkar

Re: REST, how about 'Login' map

2020-10-01 Thread Girish Vasmatkar
take a more closer look. Best, Girish On Fri, Oct 2, 2020 at 6:07 AM Hans Bakker wrote: > Hi Girish, > > thanks for the explanation, however if i create a last statement in a > groovy service: > return error("this is the error message") > > then i get an er

Re: REST input is a map?

2020-09-27 Thread Girish Vasmatkar
Hi Hans Maps and Lists work quite well. There is a difference in how you send the JSON to a service that's listed as GET vs (PUT, PATCH or POST). Yours is probably GET and you need to send the JSON urlencoded. Gets a product feature curl -G -X GET

Re: OFBIZ-11995

2020-10-24 Thread Girish Vasmatkar
zt2ozpGOGmQ" > --insecure > > Is there any specific reason behind this? Can we make it consistent? > > Kind Regards, > -- > Ravi Lodhi > > On Wed, Sep 23, 2020 at 7:09 PM Girish Vasmatkar < > girish.vasmat...@hotwaxsystems.com> wrote: > > > Hi

Re: REST implementation

2020-08-02 Thread Girish Vasmatkar
it : > >> Hi Girish, > >> > >> I'm just starting to review so I may miss things. Just a question for > now. We have an option at > >> > >> > https://demo-trunk.ofbiz.apache.org/webtools/control/ServiceList?sel_service_name=testScv > >> >

Re: REST implementation

2020-08-02 Thread Girish Vasmatkar
n't know how to > authenticate to get a JWT. > > Apologies if I missed the instructions elsewhere but please could you > advise on how to authenticate against the REST api? > > Thanks, > > Dan. > > On Fri, 31 Jul 2020 at 09:34, Girish Vasmatkar < > girish.vas

Re: REST implementation

2020-08-06 Thread Girish Vasmatkar
s://localhost:8443/. Notifying the client > code > of REST endpoints has been done by 'inappropriately reusing' other > configuration items. > > Looking forward to seeing what comes next. Perhaps we could create a new > ModelForm.RestLookupField to work similarly to ModelForm.LookupFie

Re: [PROPOSAL] Return json from database directly

2020-06-30 Thread Girish Vasmatkar
Hi Shi I am sorry but I am not following it. By results, did you mean the result of operations done on the View Entity or the definition of the View Entities in JSON format? Also, since you mentioned PostgreSQL, would it be database-agnostic and not limited to PostgreSQL? An example JSON

Re: JUnit 5?

2020-07-05 Thread Girish Vasmatkar
Hi All OFBiz integration tests are based on classes extending the TestCase class. Should we not allow for a hybrid way of writing integration test cases based on classes that do not extend TestCase while also allowing old ways (extending TestCase and test methods starting with test) of writing

Re: REST implementation

2020-07-08 Thread Girish Vasmatkar
Hi Folks I have added support for OpenApi Integration. The updated code can be found here : https://github.com/girishvasmatkar/ofbiz-rest-impl. Please go through the changes and test at your end and let me know your thoughts. I am planning to do some refactoring and then raise initial PR for the

Re: OFBiz - Eclipse: can't find ofbiz.jar

2020-07-06 Thread Girish Vasmatkar
Hi Carlos Did you first run the "gradlew build" command? That would make sure ofbiz.jar was created and placed in the directory you mentioned. You can then use it as a classpath entry and ofbiz should run from eclipse. Best, Girish On Mon, Jul 6, 2020 at 2:15 PM Carlos Navarro wrote: > Good

Re: checkNewPassword and ignoreCurrentPassword

2020-07-12 Thread Girish Vasmatkar
Hi Jacques I think the vulnerability does not exist if the CSRF defence is in place. If there is no defence in place, there is a possibility of using system account session to change the admin password. As for bypassing current password check if the user is admin, it won't hurt if the check was

Re: REST implementation

2020-07-09 Thread Girish Vasmatkar
8:45 PM Shi Jinghai wrote: > Hi Girish, > > Excellent. > > Only one suggestion from my quick view, when response code is 401, the > "WWW-Authenticate" header should be set to start with a word NOT “Bearer > …”, this can prevent web browser from poppin

Re: REST implementation

2020-06-17 Thread Girish Vasmatkar
Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Girish, > > I did not have time to look into details yet but your README is very > promising :) > > Jacques > > Le 15/06/2020 à 17:59, Girish Vasmatkar a écrit : > > Hi All > > >

Re: REST implementation

2020-06-17 Thread Girish Vasmatkar
t; OFBiz and that’s why I believe the OpenAPI integration should be going > along with REST implementation. > > Warm regards > > > Carsten > > > > Am 17.06.2020 um 08:38 schrieb Girish Vasmatkar < > girish.vasmat...@hotwaxsystems.com>: > > > >

Re: REST implementation

2020-06-15 Thread Girish Vasmatkar
- > Pritam Kute > > > On Fri, Jun 12, 2020 at 2:58 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > > > Hi Girish, > > > > Inline... > > > > Le 10/06/2020 à 17:42, Girish Vasmatkar a écrit : > > > Hi All

Re: OFBiz-GraphQL Webinar Recording on YouTube

2020-06-09 Thread Girish Vasmatkar
ct URL: https://youtu.be/VK0o0OBAS1I > > > > Best regards, > > Pranay Pandey > > > > > > On Fri, May 8, 2020 at 8:39 PM Pranay Pandey < > > pranay.pan...@hotwaxsystems.com> wrote: > > > >> Hello OFBiz Devs, Users > >> &

REST implementation

2020-06-10 Thread Girish Vasmatkar
Hi All I am again bringing up this discussion on having a REST implementation for OFBiz. I know we have had discussions before and I was looking at some of the past discussions about this topic and seems we are not there quite yet (correct me if I am wrong). I had developed a POC plug-in based

Nested attributes for Collection Types

2020-07-16 Thread Girish Vasmatkar
Hey Guys, While working on OpenApi integration as well as GraphQL implementation, I faced issues on how to automatically document request/response JSON structure for service attributes that were of Collection types (Map, List etc). For simple types, it is just plain easy but when it comes to

Re: A little bit of Lombok

2020-07-28 Thread Girish Vasmatkar
Hi I think we need to decide how much is the fair usage of lombok. I have used it previously and it does good job of taking care of removing boilerplate code. However, I feel care must also be taken to determine how much we use it because chances are that the code might not work (potentially) if

Re: Welcome Pawan Verma as new PMC member

2020-07-28 Thread Girish Vasmatkar
Many congratulations Pawan. Best, Girish On Tue, Jul 28, 2020 at 2:10 PM Devanshu Vyas wrote: > Many many Congratulations Pawan!! > > > Thanks & Regards, > Devanshu Vyas. > > > On Tue, Jul 28, 2020 at 1:53 PM Aditya Sharma > wrote: > > > Felicitation Pawan!! > > > > Thanks and Regards, > >

Re: Nested attributes for Collection Types

2020-07-20 Thread Girish Vasmatkar
re predictable in general. This > improvement could also be applied to existing service definitions to be > able to expose them as an API in a more sensible way. > > > > Thanks. > > -- > > Mridul Pathak > > > > > >> On 16-Jul-2020, at 5:20 PM, Giris

Re: REST implementation

2020-07-31 Thread Girish Vasmatkar
Authenticate", "Bearer realm=\"authentication > required\""); > > The popup is skipped and then react/vue/angular can handle the response: > setResponseHeader("WWW-Authenticate", "OFBiz realm=\"authentication > required\""); > &g

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.04 - Second Attempt

2020-07-05 Thread Girish Vasmatkar
Looks fine at my end - girish$ ./verify-ofbiz-release.sh apache-ofbiz-17.12.04.zip sha check of file: apache-ofbiz-17.12.04.zip Using sha file: apache-ofbiz-17.12.04.zip.sha512 apache-ofbiz-17.12.04.zip: 87FC62B2 8005BE59 FBB5AA69 6F0317C1 72273F02 EB39DD82 9738761C 694D644B F004C3A6 12E8DB41

Re: Getting Error when push code changes to GitHub

2020-12-26 Thread Girish Vasmatkar
Hello Yashwant pre-commit hook is getting kicked in which runs checkstyleMain gradle task to check code compliance with the rules defined in checkstyle configuration. The error count is 327, which is probably more than the threshold defined in the build.gradle. tasks.checkstyleMain.maxErrors

Re: Developing groovyScripts in the IDE

2021-01-18 Thread Girish Vasmatkar
Hi Daniel I am on Eclipse most of the time and use the gradle eclipse plug-in to just build the classpath. I have not faced this issue on Eclipse so can't speak to that. That said, I see no issues with selecting SDK or compiler for the Groovy files. I do it on eclipse and it works without

  1   2   >