Re: [VOTE] ASL2 header in README files?

2016-09-16 Thread Jacopo Cappellato
16, 2016 at 10:21 AM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > On Fri, Sep 16, 2016 at 9:43 AM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > >> Hi Devs, >> >> There are mixed opinions about putting or not the ASL2 hea

Re: [VOTE] ASL2 header in README files?

2016-09-16 Thread Jacopo Cappellato
On Fri, Sep 16, 2016 at 9:43 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Devs, > > There are mixed opinions about putting or not the ASL2 header in OFBiz > README files. > > One one hand we can read at http://www.apache.org/legal/sr > c-headers.html#faq-exceptions that README

Removing the ecomclone webapp from the ecommerce component

2016-09-15 Thread Jacopo Cappellato
In the "ecommerce" component there are two web applications: - ecommerce: the actual web application - ecomclone: a clone of the above, that leverages the controller's "include" feature to extend the main web application For what I know the ecomclone webapp has been initially created to to test

Re: Some questions on plugin system

2016-09-15 Thread Jacopo Cappellato
esting and sharing whatever is > on your mind. > > You will find the patch in https://issues.apache.org/ > jira/browse/OFBIZ-7972 > > Cheers, > > Taher Alkhateeb > > > > On Fri, Sep 9, 2016 at 12:55 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wr

Re: Ideas about OFBiz servlet filters

2016-09-14 Thread Jacopo Cappellato
icy for entrance. If put the ControlFilter 1st, it's a > strict control. If put it last, it's a loose control. Anyway, we need it. > > When you complete, I will try to change SEO and solr filters to follow > your update. > > Kind Regards, > > Shi Jinghai > > > -

Re: Groovy and semicolon at EOL

2016-09-13 Thread Jacopo Cappellato
can't tell you the details since I don't use it On Tue, Sep 13, 2016 at 5:16 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 13/09/2016 à 16:45, Jacopo Cappellato a écrit : > >> On Tue, Sep 13, 2016 at 4:36 PM, Jacques Le Roux < >> jacques.

Re: Groovy and semicolon at EOL

2016-09-13 Thread Jacopo Cappellato
On Tue, Sep 13, 2016 at 4:36 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > ... > Before applying a such change, I'd really like to know if everybody is > aware of what that means when it comes to svn annotations. I repeat: we > will then lose all the svn annotations history in all

Re: svn commit: r1760528 - /ofbiz/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control /ContextFilter.java

2016-09-13 Thread Jacopo Cappellato
ques Le Roux a écrit : > >> Works also locally here, I have forced a new build on BuildBot, could be >> a temporary error, happens rarely but happens. >> >> Jacques >> >> >> Le 13/09/2016 à 13:43, Jacopo Cappellato a écrit : >> >>> Yeah, th

Re: Groovy and semicolon at EOL

2016-09-13 Thread Jacopo Cappellato
I agree with Rishi's remarks: also, if we follow this approach then functional changes will be buried in a bunch of non-functional changes. This could work if the two are committed into two separate commits. Jacopo On Tue, Sep 13, 2016 at 2:45 PM, Rishi Solanki wrote:

Re: svn commit: r1760528 - /ofbiz/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control /ContextFilter.java

2016-09-13 Thread Jacopo Cappellato
Yeah, thanks for the notification, I also saw the automatic build failure email. Weird, local tests are successful and that service doesn't seem to be related to my last commit... but I am looking into it. Jacopo On Tue, Sep 13, 2016 at 1:15 PM, Jacques Le Roux < jacques.le.r...@les7arts.com>

Re: Fixing the way OFBiz deal with character encoding of http requests

2016-09-13 Thread Jacopo Cappellato
Committed in rev. 1760528 Jacopo On Fri, Sep 9, 2016 at 3:33 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > In ContextFilter, the character encoding (aka charset) of every http > *request* object is set using the WebAppUtil.setCharacterEncoding(...) >

Re: Limit the length of comments commits lines

2016-09-13 Thread Jacopo Cappellato
Jacques, do we all have to read your correspondence with TortoiseSvn? This list is reserved for discussions related to development of OFBiz. If you will get useful hints for OFBiz developers using your same tools you could always put the information in the Wiki. Jacopo On Tue, Sep 13, 2016 at

Re: Ideas about OFBiz servlet filters

2016-09-13 Thread Jacopo Cappellato
o separate the allowPaths and redirectPath > functions to a new filter. If ContextFilter be the 1st filter, the new > filter will be the last I guess. Between them, CatalogUrlFilter and etc. > will be there. > > Kind Regards, > > Shi Jinghai > > -邮件原件- > 发件人: Jacopo Capp

Re: Groovy and semicolon at EOL

2016-09-13 Thread Jacopo Cappellato
>> Thanks! >> >> -- >> Rishi >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Tue, Sep 13, 2016 at 11:46 AM, Jacopo Cappellat

Re: Groovy and semicolon at EOL

2016-09-13 Thread Jacopo Cappellato
I don't have a strong opinion. But it would be nice to agreed upon one style and then implement consistently. Jacopo On Mon, Sep 12, 2016 at 6:56 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi > > While committing r1760406 I wondered if I should really put semicolons at > end

Re: svn commit: r1760427 - /ofbiz/trunk/

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 8:29 PM, wrote: > Author: jleroux > Date: Mon Sep 12 18:29:38 2016 > New Revision: 1760427 > > URL: http://svn.apache.org/viewvc?rev=1760427=rev > Log: > Completes: Add the "Completes:" to my own personal selfish > tsvn:logtemplatecommit for when

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 8:06 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: ... > I another recent message, talking about myself, I said: "Only fools never > change their minds" > > Jacques > > Ok... so you are not a fool because you have changed your mind, right? :-) Jacopo

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 7:57 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > And while at it, to put a bit of sense in this thread, what would you put > for Tasks? I suggest Completes and not Does (see the "Proposal for a more > unified commit message format" thread for the

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 7:34 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > ... > Why? > > Jacques > Because it is the standard format that we agreed upon; when I say "we" I am also including you since you wrote (quoted): "I think it's a good idea to normalize our commits comments

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 6:47 PM, wrote: > Author: jleroux > Date: Mon Sep 12 16:47:53 2016 > New Revision: 1760406 > > URL: http://svn.apache.org/viewvc?rev=1760406=rev > Log: > Fixes: Display of State/Province for non US entities in the customer's > profile of ecommerce >

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacopo Cappellato
I am rather interested in knowing if other committers share similar concerns or resistance to comply with the template as it is defined in the Wiki at the moment. If this is not the case then I think that Jacques should step back and stop this endless thread that is not going anywhere. Jacopo

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 11:37 AM, wrote: > Author: jleroux > Date: Mon Sep 12 09:37:11 2016 > New Revision: 1760325 > > URL: http://svn.apache.org/viewvc?rev=1760325=rev > Log: > Fixes: a bug introduced with one of > (OFBIZ-8118)(OFBIZ-8122)(OFBIZ-8123)(OFBIZ-8124)(OFBIZ- >

Re: svn commit: r1760251 - /ofbiz/trunk/

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 10:25 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > > You are right, amended. It will take some time to get acquainted... > > Jacques > Oh thanks, but you didn't need to fix, as I said it was just a joke and I doubt that Michael will want to include this

Re: svn commit: r1760251 - /ofbiz/trunk/

2016-09-12 Thread Jacopo Cappellato
On Sun, Sep 11, 2016 at 4:45 PM, wrote: > Author: jleroux > Date: Sun Sep 11 14:45:32 2016 > New Revision: 1760251 > > URL: http://svn.apache.org/viewvc?rev=1760251=rev > Log: > No functional change, improves the tsvn:logtemplatecommit > > Only fools never change their minds:

Re: Proposal for a more unified commit message format

2016-09-10 Thread Jacopo Cappellato
t;>>>>> On Sep 10, 2016 12:19 PM, "Pierre Smits" <pierre.sm...@gmail.com> >>>>>> >>>>> wrote: >>>> >>>>> A rule - in general - implies, that, when not adhered to, there will >>>>>> >>>&g

Re: Proposal for a more unified commit message format

2016-09-09 Thread Jacopo Cappellato
On Fri, Sep 9, 2016 at 6:29 PM, Michael Brohl wrote: > ... > I've made my last commit using it and also saw that Jacopo (partly ;-) ) > applied this in his latest commits. > I have applied the new template to one commit and then I have forgotten to apply it to the

Request for review for OFBIZ-8179 and OFBIZ-8224

2016-09-09 Thread Jacopo Cappellato
Hi devs, I would like to commit sometime soon the patches I have created for: https://issues.apache.org/jira/browse/OFBIZ-8179 https://issues.apache.org/jira/browse/OFBIZ-8224 It would be great if you could have a look at them and let me know if you have concerns or comments; if you like, you

Fixing the way OFBiz deal with character encoding of http requests

2016-09-09 Thread Jacopo Cappellato
In ContextFilter, the character encoding (aka charset) of every http *request* object is set using the WebAppUtil.setCharacterEncoding(...) method (see its logic here [*]). It is wrong to override the character encoding if already specified by the http request: in fact it doesn't make any sense

Re: Ideas about OFBiz servlet filters

2016-09-09 Thread Jacopo Cappellato
ble items will materialise rather sooner > than later in our JIRA. > > Best regards, > > Pierre Smits > > ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace > http://oem.ofbizci.net/oci-2/ > > On Fri, Sep

Re: Some questions on plugin system

2016-09-09 Thread Jacopo Cappellato
On Thu, Sep 8, 2016 at 11:31 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > ... > So it would be easier for us (OFBiz team) and contributors to deliver (at > least free) plugins [...] The terms "us", "OFBiz team" and the distinction with "contributors" don't make much sense to me

Re: Ideas about OFBiz servlet filters

2016-09-09 Thread Jacopo Cappellato
is duplicated etc...) 3) identify the filters that "extends" the ContextFilter class and figure out how to refactor their code to work in a filter chain where the first filter is ContextFilter Jacopo On Fri, Sep 9, 2016 at 10:07 AM, Jacopo Cappellato < jacopo.cappell...@hotwaxsyste

Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/ specialpurpose/solr/conf/ specialpurpose/solr/config/ specialpurpose/solr/entitydef/ special

2016-09-09 Thread Jacopo Cappellato
. I'll work on them this weekend. > > -----邮件原件- > 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] > 发送时间: 2016年9月8日 21:14 > 收件人: dev@ofbiz.apache.org > 主题: Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ > specialpurpose/ speci

Ideas about OFBiz servlet filters

2016-09-09 Thread Jacopo Cappellato
A web application, in order to leverage the OFBiz framework, requires that a series of objects are in its contexts (servlet context, session and request) such as "delegator", "delegatorName", "dispatcher", "security" etc. etc... This setup is performed by the logic contained in the servlet filter

Re: Taking a decision on remaining Jars in OFBiz

2016-09-08 Thread Jacopo Cappellato
On Thu, Sep 8, 2016 at 5:01 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > But the topic is still there, hackers have all their time, and they will > bite again... Well, the above is too generic statement and I would prefer you to describe about specific attacks and weak points in

Re: Taking a decision on remaining Jars in OFBiz

2016-09-08 Thread Jacopo Cappellato
On Thu, Sep 8, 2016 at 2:54 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > ... > How do you expect to warn users about deserialization driven attacks? I > mean people can have a such risk w/o using RMI, deserialization driven > attacks are not only about RMI. In my opinion a

Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/ specialpurpose/solr/conf/ specialpurpose/solr/config/ specialpurpose/solr/entitydef/ special

2016-09-08 Thread Jacopo Cappellato
On Tue, Sep 6, 2016 at 12:10 PM, Shi Jinghai wrote: > Hi Jacopo, > > I cleaned OFBizSolrContextFilter.java and submitted in rev. 1759401. > Please check if it's required to do a further refactoring. > > Kind Regards, > > Shi Jinghai > > Thank you, Jinghai. I still see a lot

Re: Taking a decision on remaining Jars in OFBiz

2016-09-08 Thread Jacopo Cappellato
On Thu, Sep 8, 2016 at 12:04 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > ... > If we remove the jar and all the rest, I fear the notsoserial effort will > be definitely thrown away, exposing our "naive" users at the risk of using > RMI or a vulnerable external classes. >

Re: Proposal for a more unified commit message format

2016-09-08 Thread Jacopo Cappellato
What about the following slightly modified template? == [Implemented|Improved|Fix for|Documentation]: [Jira title|Free text] [(OFBIZ-)] [More detailed explanation of what has been done and what the fix achieves, sideeffects etc.] [Thanks:] [ for ... and for]

Re: Taking a decision on remaining Jars in OFBiz

2016-09-08 Thread Jacopo Cappellato
>> al/empty.txt", >>> - >>> "-Dnotsoserial.dryrun=${rootDir}/tools/security/notsoserial/ >>> is-deserialized.txt", >>> - >>> "-Dnotsoserial.trace=${rootDir}/tools/security/notsoserial/ >>> deserialize-trace.txt&quo

Re: Taking a decision on remaining Jars in OFBiz

2016-09-07 Thread Jacopo Cappellato
', '-Xmx1024M'] >> ext.ofbizMainClass = 'org.apache.ofbiz.base.start.Start' >> javadoc.failOnError = false >> sourceCompatibility = '1.8' >> >> On Wed, Sep 7, 2016 at 9:04 PM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >&g

Re: Taking a decision on remaining Jars in OFBiz

2016-09-07 Thread Jacopo Cappellato
) > > 2. Do what I said before AND change the Gradle "ofbizSecure" tasks > > > > Opinions? > > > > Jacques > > > > > > Le 07/09/2016 à 14:01, Jacques Le Roux a écrit : > > > >> Yes I see no problems with that. I just need to

Re: Taking a decision on remaining Jars in OFBiz

2016-09-07 Thread Jacopo Cappellato
On Sat, Aug 20, 2016 at 8:29 AM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > > On Sat, Aug 20, 2016 at 7:57 AM, jler...@apache.org <jler...@apache.org> > wrote: > >> ... >> IMO we can delete the cmssite component jars they are only used in

Re: Taking a decision on remaining Jars in OFBiz

2016-09-07 Thread Jacopo Cappellato
Jacques, any news from notsoserial? If not, I think we can proceed by (temporarily) removing the jars until they will publish the jar. Regards, Jacopo On Sat, Aug 20, 2016 at 11:12 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Yes that's what I proposed also, I will try that

Re: Taking a decision on remaining Jars in OFBiz

2016-09-07 Thread Jacopo Cappellato
On Sat, Aug 20, 2016 at 11:10 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 20/08/2016 à 08:28, Jacopo Cappellato a écrit : > >> On Sat, Aug 20, 2016 at 7:57 AM, jler...@apache.org <jler...@apache.org> >> wrote: >> >> ... >&

Creating a new release branch in preparation for the new release

2016-09-07 Thread Jacopo Cappellato
Hi all, I think it is the right time to create a new release branch out of the trunk. According to our naming conventions the release will be named "release16.09". Any objections or concerns? If not, I will create the branch later today/tomorrow. After that we will start, in a separate thread,

Re: svn commit: r1759457 - in /ofbiz/trunk/framework/webtools: config/webtools.properties src/main/java/org/apache/ofbiz/webtools/labelmanager/LabelReferences.java widget/LabelManagerScreens.xml

2016-09-07 Thread Jacopo Cappellato
On Wed, Sep 7, 2016 at 9:23 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > ... > 2. So I created a private static final String: private static final String > getResourceRegex = "ServiceUtil\\.getResource\\(\\)" >But this did not work. I got > >2016-09-07 08:27:32,489

Re: [Supplier-Product] - How can apply more than one price for a product and a supplier.

2016-09-06 Thread Jacopo Cappellato
Hi Thang , the SupplierProduct entity was designed to support multiple prices for the same product and supplier based on different ordered quantity or different currency; see the primary key: Unfortunately the design of the SupplierProduct entity is far from being clean and nice, and I am

Re: svn commit: r1759457 - in /ofbiz/trunk/framework/webtools: config/webtools.properties src/main/java/org/apache/ofbiz/webtools/labelmanager/LabelReferences.java widget/LabelManagerScreens.xml

2016-09-06 Thread Jacopo Cappellato
On Tue, Sep 6, 2016 at 6:38 PM, wrote: > Author: jleroux > Date: Tue Sep 6 16:38:14 2016 > New Revision: 1759457 > > URL: http://svn.apache.org/viewvc?rev=1759457=rev > Log: > ... > * Moreover the string can't be in the LabelReferences.java file, to avoid > side effects >

Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/ specialpurpose/solr/conf/ specialpurpose/solr/config/ specialpurpose/solr/entitydef/ special

2016-09-05 Thread Jacopo Cappellato
Hi Jinghai, I have noticed that when you have committed the Solr component you have created a class named OFBizSolrContextFilter.java that is mostly the copy of ContextFilter: as a consequence the logic implemented in its utility methods has been duplicated. I didn't check, but it is possible

Re: Question about transitive dependencies on different version of the same library

2016-09-03 Thread Jacopo Cappellato
hink about this topic. Regards, Jacopo > > Taher Alkhateeb > > On Sep 3, 2016 4:57 PM, "Jacopo Cappellato" < > jacopo.cappell...@hotwaxsystems.com> wrote: > > > Hi all, > > > > I have a general question about transitive dependencies. >

Question about transitive dependencies on different version of the same library

2016-09-03 Thread Jacopo Cappellato
Hi all, I have a general question about transitive dependencies. Here is an example use case: OFBiz depends on 2 external jars: jar1 and jar2 jar1 depends on log4j-version1 jar2 depends on log4j-version2 How should we manage the two versions of the same product (log4j in this exemple),

Re: svn propchange: r1759065 - svn:log

2016-09-03 Thread Jacopo Cappellato
Thank you Jacques Jacopo On Sat, Sep 3, 2016 at 12:27 PM, wrote: > Author: jleroux > Revision: 1759065 > Modified property: svn:log > > Modified: svn:log at Sat Sep 3 10:27:20 2016 > > -- > ---

Re: svn commit: r1536324 - in /ofbiz/trunk: applications/accounting/servicedef/ applications/content/servicedef/ applications/marketing/servicedef/ applications/order/servicedef/ applications/party/se

2016-09-03 Thread Jacopo Cappellato
I am resurrecting this old thread, because I think that Scott's remarks and concerns to Jacques' commit were valid and the response of Jacques was not satisfactory: in fact the two tickets Jacques mentioned have been resolved but the issues that Scott identified in Jacques' commit are still there.

Re: svn commit: r1758927 - in /ofbiz/trunk: applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdpart y/gosoftware/ applications/content/src/main/java/org/apache/ofbiz/content/survey

2016-09-02 Thread Jacopo Cappellato
On Fri, Sep 2, 2016 at 3:19 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 02/09/2016 à 12:30, Jacopo Cappellato a écrit : > >> ... > > 2) I suspect that you are closing the socket connection too early >> in PcChargeApi >> > > I see no

Re: svn commit: r1758927 - in /ofbiz/trunk: applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/gosoftware/ applications/content/src/main/java/org/apache/ofbiz/content/survey/

2016-09-02 Thread Jacopo Cappellato
Jacques, after a cursory review it seems to me that in your commit there are a few issues; for example: 1) you are adding a close statement to code that already had the close statement in the "finally" block; your modification actually introduces a code pattern that is not correct (if an

Re: svn commit: r1758774 - in /ofbiz/trunk: applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/dhl/ framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/ specialp

2016-09-01 Thread Jacopo Cappellato
Hi Jacques, you have committed some unwanted/unrelated changes in this commit. Jacopo On Thu, Sep 1, 2016 at 3:34 PM, wrote: > Author: jleroux > Date: Thu Sep 1 13:34:17 2016 > New Revision: 1758774 > > URL: http://svn.apache.org/viewvc?rev=1758774=rev > Log: > A patch

Re: svn commit: r1758700 - in /ofbiz/trunk: applications/accounting/ applications/accounting/lib/ applications/datamodel/ applications/manufacturing/ specialpurpose/assetmaint/ specialpurpose/birt/ sp

2016-09-01 Thread Jacopo Cappellato
ptions > > Do we really need a vote for that? > > Jacques > > > >> Jacopo >> >> >> Note that I have no strong opinion on putting the ASL2 header or not, I >>> want things to be consistent >>> >>> Jacques >>> >>> >&g

Re: svn commit: r1758700 - in /ofbiz/trunk: applications/accounting/ applications/accounting/lib/ applications/datamodel/ applications/manufacturing/ specialpurpose/assetmaint/ specialpurpose/birt/ sp

2016-09-01 Thread Jacopo Cappellato
ader or not, I > want things to be consistent > > Jacques > > > Le 01/09/2016 à 10:48, Jacopo Cappellato a écrit : > >> I still don't see where the consensus was reached: discussions in Jira are >> not the same as discussion on the dev list (which is mentioned by Jacq

Re: svn commit: r1758700 - in /ofbiz/trunk: applications/accounting/ applications/accounting/lib/ applications/datamodel/ applications/manufacturing/ specialpurpose/assetmaint/ specialpurpose/birt/ sp

2016-09-01 Thread Jacopo Cappellato
tion is that these files make it obvious which product they relate > > to.>> > > > > That seems OK with me > > > > Jacques > > > > > > > > Le 01/09/2016 à 08:36, Jacopo Cappellato a écrit : > > > >> On Thu, Sep 1, 2016 at

Re: svn commit: r1758700 - in /ofbiz/trunk: applications/accounting/ applications/accounting/lib/ applications/datamodel/ applications/manufacturing/ specialpurpose/assetmaint/ specialpurpose/birt/ sp

2016-09-01 Thread Jacopo Cappellato
On Thu, Sep 1, 2016 at 6:53 AM, wrote: > ... > Legal statements are not required in readme files, as per consensus in dev > mail thread with title 'Shorter ASL2 header in short files'. The mail > thread started here: http://ofbiz.markmail.org/message/pc5bzrsiupef7xjt > >

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

2016-08-30 Thread Jacopo Cappellato
On Tue, Aug 30, 2016 at 7:19 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Mmm, then who should fix it? > This is an opportunity for anyone reading your message to contribute. > Of course I could have fixed it myself, but I thought that by providing an > advice I'd help more.

Re: Shorter ASL2 header in short files

2016-08-30 Thread Jacopo Cappellato
In my opinion we should include the full header, that is important to comply with the ASF licenses policies, unless there is a strong reason for not doing so. BTW, the Q/A you have quoted doesn't apply very well to the scenario you are considering: the rule doesn't say "you can use the short

Re: Using Steve for OFBiz votes

2016-08-29 Thread Jacopo Cappellato
While it is always nice to experiment new tools, I don't see any advantage in using Steve for the usual votes we run in these lists. However we could consider it to run special votes that require features that a mailing list doesn't easily provide, like the recent vote we had about our logo. Just

Re: Offer of Snoot Analytic Services for OFBiz

2016-08-25 Thread Jacopo Cappellato
+1 Jacopo On Tue, Aug 23, 2016 at 1:57 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Sure, +1! > > Jacques > > > > Le 23/08/2016 à 11:34, Sharan Foga a écrit : > >> Hi Everyone >> >> The ASF is offering all projects the opportunity to get for analytic >> services. (from Snoot).

Re: Jars in LICENCE?

2016-08-24 Thread Jacopo Cappellato
A reminder: we should review in a similar way the LICENSE and NOTICE files under specialpurpose. Jacopo On Thu, Aug 25, 2016 at 6:37 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 24/08/2016 à 15:04, Jacques Le Roux a écrit : > >> 2 things I still wonder about are: >> >> 1. Why

Re: Jars in LICENCE?

2016-08-24 Thread Jacopo Cappellato
Thanks for the research, Jacques: your conclusions are inline with mine. Jacopo On Thu, Aug 25, 2016 at 6:37 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 24/08/2016 à 15:04, Jacques Le Roux a écrit : > >> 2 things I still wonder about are: >> >> 1. Why Ant does not document

Re: Should we do binary releases?

2016-08-24 Thread Jacopo Cappellato
A couple of comments: 1) a "release" at the ASF is a "source release". It would be better, to avoid any confusion in the future, if we name "binary packages" the (optional) files that we could produce from a release 2) my preference would be to not issue binary packages: focusing on publishing

Re: Jars in LICENCE?

2016-08-23 Thread Jacopo Cappellato
Specifically I have checked the binary release of Tomcat 8.5.4 Jacopo On Tue, Aug 23, 2016 at 11:22 AM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > Jacques, > > see my comments inline: > > On Tue, Aug 23, 2016 at 11:06 AM, Jacques Le Roux < > j

Re: Jars in LICENCE?

2016-08-23 Thread Jacopo Cappellato
Jacques, see my comments inline: On Tue, Aug 23, 2016 at 11:06 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > [...] So it should have been > > "Tomcat nothing on ecj jar (Eclipse.org) in binary release" same for JMeter > > Please double check: I have checked the binary release as

Re: Jars in LICENCE?

2016-08-23 Thread Jacopo Cappellato
Hi Jacques, please see my comment below: On Tue, Aug 23, 2016 at 9:31 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > ... 2. How other projects handle it. There is much diversity. Roughly: > ... Tomcat nothing on ecj jar (Eclipse.org) even in binary release > Just to check

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

2016-08-23 Thread Jacopo Cappellato
gCodeEvents.java are used in cmssite, > ecommerce and webpos. Should we not convert all to services? > > Best regards, > > Pierre Smits > > ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace > http://oem.ofbiz

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

2016-08-22 Thread Jacopo Cappellato
rre Smits > > ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace > http://oem.ofbizci.net/oci-2/ > > On Mon, Aug 22, 2016 at 12:43 PM, Jacopo Cappellato < > jacopo.cappell...@hotwaxsystems.com> wrote:

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

2016-08-22 Thread Jacopo Cappellato
This contribution seems completely wrong to me. Pierre and Jacques, have you performed proper tests and reviews before committing it? Jacopo On Mon, Aug 22, 2016 at 11:58 AM, wrote: > Author: jleroux > Date: Mon Aug 22 09:58:35 2016 > New Revision: 1757130 > > URL:

Re: Taking a decision on remaining Jars in OFBiz

2016-08-20 Thread Jacopo Cappellato
On Sat, Aug 20, 2016 at 7:57 AM, jler...@apache.org wrote: > ... > IMO we can delete the cmssite component jars they are only used in > extensions of Dockbook and AFAIK we don't use them > > +1 > > notsoserial-1.0-SNAPSHOT.jar we need to keep, maybe we could push it in >

Re: Taking a decision on remaining Jars in OFBiz

2016-08-20 Thread Jacopo Cappellato
On Sat, Aug 20, 2016 at 7:57 AM, jler...@apache.org wrote: > ... > ebaystore component we need to put in Attic? > Either attic or (quoting myself from a previous mail in this thread) "remove these jars, disable the component, add a README file to the component to explain how

Re: Refactoring our Wiki spaces

2016-08-17 Thread Jacopo Cappellato
1 PM", content is not a > problem because it's still in page history or space trash. The problem is > with comments and attachments, see my previous explanation and question. > > Maybe you implicitly agree about what I suggested about news, comments and > attachment? > > Jacques > >

Re: Refactoring our Wiki spaces

2016-08-17 Thread Jacopo Cappellato
I have not seen much deletion from contributors so it should not be > an issue. > > Jacques > > > > Le 17/08/2016 à 15:17, Jacopo Cappellato a écrit : > >> I am starting a new thread with a new subject in the dev list to discuss >> the interesting topic about Wiki space clea

Refactoring our Wiki spaces

2016-08-17 Thread Jacopo Cappellato
I am starting a new thread with a new subject in the dev list to discuss the interesting topic about Wiki space cleanup/refactoring that was started by Jacques as an off topic (going off-topic is a bad habit that we should try to limit). In my opinion we could just have one Wiki space (open to

Please subscribe to the new "notifications" mailing list

2016-08-16 Thread Jacopo Cappellato
Hi all, very soon all the Jira traffic email notifications currently forwarded to the dev list will be redirected to the newly created notificati...@ofbiz.apache.org mailing list. Please subscribe to this new list if you are interested in getting the notification traffic, by sending an empty

Re: [QUESTION] A "Thanks" page?

2016-08-16 Thread Jacopo Cappellato
On Mon, Aug 15, 2016 at 12:37 PM, Sharan Foga wrote: > > I think it would be good to have a 'Thanks' page (I'm surprised that we > don't have one already!). We are actually properly implementing, as a project, the ASF request (done a few years ago) to have a link to the

Re: Commits causing conflicts

2016-08-16 Thread Jacopo Cappellato
If the time it takes you to resolve the conflicts due to local changes to your build.gradle file is too much then you could automate your process by preparing a script to revert your local changes before updating the trunk and then re-applying them after the update: 1) revert local changes (the

Re: Removing debug task

2016-08-13 Thread Jacopo Cappellato
On Fri, Aug 12, 2016 at 1:58 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > ... Why? I prefer, it's more intuitive and I feel a continuity with "legacy", > to type start and stop rather than ofbiz and "ofbiz --shutdown" :p > > Jacques My preference is to design and implement a

Re: Taking a decision on remaining Jars in OFBiz

2016-08-06 Thread Jacopo Cappellato
On Sat, Aug 6, 2016 at 12:49 PM, Taher Alkhateeb wrote: > > [...} I suggest the following: > > - remove ofbizSecure and ofbizBackgroundSecure > - make all other server tasks secure by default (i.e. loading notsoserial > and all other jvm args which are currently used

Re: geronimo component alone?

2016-08-05 Thread Jacopo Cappellato
I think that making it part of the entity component would make sense. Jacopo On Fri, Aug 5, 2016 at 2:35 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > At I wrote I wonder if we should let the geronimo component alone with > only 2 classes, could we not put that in entity

Re: Taking a decision on remaining Jars in OFBiz

2016-08-05 Thread Jacopo Cappellato
On Fri, Jul 29, 2016 at 1:56 PM, Taher Alkhateeb wrote: > ... - ebaystore component > The jars in the ebaystore components are licensed under the CDDL licence, that is addressed by the following ASF licensing rules:

Re: Apache OFBiz Service Providers page

2016-08-02 Thread Jacopo Cappellato
While we wait for the new site we could: 0) add the page discalimer as suggested; additionally, as Jacques pointed out, this page is open to anyone who submits an ICLA and asks to be registered as OFBiz contributor: no one is really reviewing the data provided... we could mention this in the

Re: [VOTE] Create a "notifications" mailing list

2016-07-30 Thread Jacopo Cappellato
hanks > > Jacques > > Jacques > > Le 28/07/2016 à 16:34, Amardeep Singh Jhajj a écrit : > >> +1 >> >> Regards, >> -- >> Amardeep Singh Jhajj >> >> On Sun, Jul 24, 2016 at 6:29 PM, Jacopo Cappellato < >> jacopo.cappell...@hotwaxsy

[jira] [Commented] (OFBIZ-7937) Tine tune the sourcesets block

2016-07-29 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399108#comment-15399108 ] Jacopo Cappellato commented on OFBIZ-7937: -- [~jacques.le.roux], when creating a new ticket

[jira] [Commented] (OFBIZ-7767) Have gradle produce logs

2016-07-29 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399034#comment-15399034 ] Jacopo Cappellato commented on OFBIZ-7767: -- [~pfm.smits] are you sarcastic? I was trying to help

[jira] [Commented] (OFBIZ-7767) Have gradle produce logs

2016-07-29 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398989#comment-15398989 ] Jacopo Cappellato commented on OFBIZ-7767: -- Feel free to open such a conversation if you think

[jira] [Commented] (OFBIZ-7767) Have gradle produce logs

2016-07-29 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398966#comment-15398966 ] Jacopo Cappellato commented on OFBIZ-7767: -- I also agree with [~mbrohl] that this issue should

[jira] [Updated] (OFBIZ-7767) Have gradle produce logs

2016-07-29 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-7767: - Priority: Minor (was: Blocker) > Have gradle produce l

[VOTE][RESULT] Create a "notifications" mailing list

2016-07-27 Thread Jacopo Cappellato
The vote is successful with 14 positive (i.e. "+1") votes (of which 8 are binding votes), no negative votes. I will proceed with the request for the new mailing list to the ASF Infra. Thank you all. On Sun, Jul 24, 2016 at 2:59 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsyste

Re: [VOTE] Create a "notifications" mailing list

2016-07-27 Thread Jacopo Cappellato
+1 Jacopo On Sun, Jul 24, 2016 at 2:59 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > Rationale: Jira notifications are currently sent to the "dev" list, > causing a lot of traffic and sometimes distracting from actual > conversations; the cr

[VOTE][RESULT] Create the "security" mailing list for the OFBiz project

2016-07-27 Thread Jacopo Cappellato
The vote is successful with 15 positive (i.e. "+1") votes (of which 8 are binding votes), no negative votes. I will proceed with the request for the new mailing list to the ASF Infra. Thank you all. Jacopo On Sun, Jul 24, 2016 at 2:32 PM, Jacopo Cappellato < jacopo.cappell...@hotw

Re: [VOTE] Create the "security" mailing list for the OFBiz project

2016-07-27 Thread Jacopo Cappellato
+1 Jacopo On Sun, Jul 24, 2016 at 2:32 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > Rationale: every ASF project needs a private list to discuss product > vulnerabilities; for OFBiz the "private" list has been used for this > purpose until no

[jira] [Commented] (OFBIZ-7808) Add Gradle Interactive tasks

2016-07-27 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396926#comment-15396926 ] Jacopo Cappellato commented on OFBIZ-7808: -- Is there a need to re-ask this question? I have

Re: [DISCUSSION] Proposed Task List for Moving Forward with Gradle and the Trunk

2016-07-27 Thread Jacopo Cappellato
On Wed, Jul 27, 2016 at 3:47 PM, Pierre Smits wrote: > ... > But when code is already available in the OFBiz repo - and made available > through releases - such an enabler/disabler is as much overkill to an > adopter as a convenience script to download JDBC libraries (to

Re: [DISCUSSION] Proposed Task List for Moving Forward with Gradle and the Trunk

2016-07-27 Thread Jacopo Cappellato
n the framework. > > Taher Alkhateeb > > On Wed, Jul 27, 2016 at 4:01 PM, Jacopo Cappellato < > jacopo.cappell...@hotwaxsystems.com> wrote: > > > I think that the core reason for the failure is that most of the tests > need > > the demo data that is loaded wit

[jira] [Commented] (OFBIZ-7808) Add Gradle Interactive tasks

2016-07-27 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395793#comment-15395793 ] Jacopo Cappellato commented on OFBIZ-7808: -- I think that the approach proposed by Taher

<    1   2   3   4   5   6   7   8   9   10   >