Re: [Proposal] Make accounting entry configurable

2018-05-08 Thread Aman Agrawal
Hello,

In this, I have added one field 'enableAccounting' in the
PartyAcctgPreference entity. By this field added check whether accounting
is enable or not in the services used to create accounting transaction
entries.
I have uploaded patch for the same on OFBIZ-10391
<https://issues.apache.org/jira/browse/OFBIZ-10391>.

Thanks and regards,

*Aman Agrawal*
Sr. Enterprise Software Engineer
www.hotwaxsystems.com
www.hotwax.co

On Tue, May 8, 2018 at 2:31 PM, Rishi Solanki <rishisolan...@gmail.com>
wrote:

> Interesting!!
> Scott you are suggesting plugin or base component?
>
> Thanks!
>
>
> Rishi Solanki
> Sr Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
> www.hotwax.co
>
> On Mon, May 7, 2018 at 11:54 PM, Scott Gray <scott.g...@hotwaxsystems.com>
> wrote:
>
> > Another additional option we could consider at some point is to extract
> the
> > GL out to it's own component. It would simplify evaluation for people who
> > do want to use it, and removal for that don't or replacement for anyone
> who
> > wants to use something else.
> >
> > Regards
> > Scott
> >
> > On Thu, 3 May 2018, 18:12 Aman Agrawal, <aman.agra...@hotwaxsystems.com>
> > wrote:
> >
> > > Hello,
> > >
> > > In current flow, if we want to disable the accounting then we need to
> > > disable the set of seca's. We don't have any configurable setting to
> > > disable accounting.
> > > So, I have a proposal to make accounting transaction entries
> > configurable.
> > > We can manage this by adding a new field 'enableAccounting' in the
> > > 'PartyAcctgPreference' entity. Accounting transaction entries will be
> > > entertained accordingly.
> > >
> > > Thanks and regards,
> > > *Aman Agrawal*
> > > Sr. Enterprise Software Engineer
> > > www.hotwaxsystems.com
> > > www.hotwax.co
> > >
> >
>


Re: [Proposal] Make accounting entry configurable

2018-05-03 Thread Aman Agrawal
Thanks for your feedback. Here is the ticket id OFBIZ-10391
<https://issues.apache.org/jira/browse/OFBIZ-10391>.



Thanks

*Aman Agrawal*
Sr. Enterprise Software Engineer
www.hotwaxsystems.com
www.hotwax.co

On Thu, May 3, 2018 at 2:43 PM, Sharan Foga <sha...@apache.org> wrote:

>
>
> On 2018/05/03 06:40:43, Rishi Solanki <rishisolan...@gmail.com> wrote:
> > Hi Aman,
> > +1 for making it configurable.
> >
> > By PartyAcctgPreference.enableAccounting flag you mean for an OFBiz
> > instance if flag is enable then for that company/organization accounting
> > transactions recorded otherwise not. That also mean, for an instance we
> may
> > record the accounting transaction for one organization and do not record
> > accounting transaction for other organization.
> >
> > This is something I couldn't imagine in real world business scenario.
>
> Hi Rishi
>
> Something I've come across quite a few times is this.
>
> Imagine the case where you have several companies recording transactions
> then one stops trading temporarily or permanently, becomes insolvent or
> merges with another one, which means that from a specific date you don’t
> want it any new transactions recorded a against it.
>
> The existing transactions that have been processed are still valid in the
> previous company party and you will probably want to report on them from a
> historic perspective – but you would want to stop any new transactions
> being posted to that previous company.
>
> Thanks
> Sharan
>
> So
> > big +1 for making it configurable but not sure about weather we should go
> > for PartyAcctgPreference or may consider SystemProperty for that.
> >
> > Looking for others input, BTW, no objection on using PartyAcctgPreference
> > but thinking if it is useful to add checks/efforts for organizations over
> > same instance.
> >
> >
> >
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
> > On Thu, May 3, 2018 at 11:41 AM, Aman Agrawal <
> > aman.agra...@hotwaxsystems.com> wrote:
> >
> > > Hello,
> > >
> > > In current flow, if we want to disable the accounting then we need to
> > > disable the set of seca's. We don't have any configurable setting to
> > > disable accounting.
> > > So, I have a proposal to make accounting transaction entries
> configurable.
> > > We can manage this by adding a new field 'enableAccounting' in the
> > > 'PartyAcctgPreference' entity. Accounting transaction entries will be
> > > entertained accordingly.
> > >
> > > Thanks and regards,
> > > *Aman Agrawal*
> > > Sr. Enterprise Software Engineer
> > > www.hotwaxsystems.com
> > > www.hotwax.co
> > >
> >
>


[Proposal] Make accounting entry configurable

2018-05-03 Thread Aman Agrawal
Hello,

In current flow, if we want to disable the accounting then we need to
disable the set of seca's. We don't have any configurable setting to
disable accounting.
So, I have a proposal to make accounting transaction entries configurable.
We can manage this by adding a new field 'enableAccounting' in the
'PartyAcctgPreference' entity. Accounting transaction entries will be
entertained accordingly.

Thanks and regards,
*Aman Agrawal*
Sr. Enterprise Software Engineer
www.hotwaxsystems.com
www.hotwax.co


[jira] [Updated] (OFBIZ-7872) Clean up commented out code in Free Marker Template for Content

2016-07-18 Thread Aman Agrawal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Agrawal updated OFBIZ-7872:

Priority: Minor  (was: Major)

> Clean up commented out code in Free Marker Template for Content
> ---
>
> Key: OFBIZ-7872
> URL: https://issues.apache.org/jira/browse/OFBIZ-7872
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>    Assignee: Aman Agrawal
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7872_trunk.patch
>
>
> Clean up commented out code in Free Marker Template for Content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7894) Clean up commented out code in Free Marker Template for Manufacturing

2016-07-18 Thread Aman Agrawal (JIRA)
Aman Agrawal created OFBIZ-7894:
---

 Summary: Clean up commented out code in Free Marker Template for 
Manufacturing
 Key: OFBIZ-7894
 URL: https://issues.apache.org/jira/browse/OFBIZ-7894
 Project: OFBiz
  Issue Type: Sub-task
  Components: manufacturing
Affects Versions: Trunk
Reporter: Aman Agrawal
Assignee: Aman Agrawal
Priority: Minor


Clean up commented out code in Free Marker Template for Manufacturing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7872) Clean up commented out code in Free Marker Template for Content

2016-07-18 Thread Aman Agrawal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Agrawal updated OFBIZ-7872:

Attachment: OFBIZ-7872_trunk.patch

Patch provided.

> Clean up commented out code in Free Marker Template for Content
> ---
>
> Key: OFBIZ-7872
> URL: https://issues.apache.org/jira/browse/OFBIZ-7872
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>    Assignee: Aman Agrawal
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7872_trunk.patch
>
>
> Clean up commented out code in Free Marker Template for Content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7872) Clean up commented out code in Free Marker Template for Content

2016-07-16 Thread Aman Agrawal (JIRA)
Aman Agrawal created OFBIZ-7872:
---

 Summary: Clean up commented out code in Free Marker Template for 
Content
 Key: OFBIZ-7872
 URL: https://issues.apache.org/jira/browse/OFBIZ-7872
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: Trunk
Reporter: Aman Agrawal
Assignee: Aman Agrawal


Clean up commented out code in Free Marker Template for Content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7860) Clean up commented out code in Free Marker Template for Accounting

2016-07-16 Thread Aman Agrawal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Agrawal updated OFBIZ-7860:

Attachment: OFBIZ-7860-trunk.patch

Patch available for trunk.

> Clean up commented out code in Free Marker Template for Accounting
> --
>
> Key: OFBIZ-7860
> URL: https://issues.apache.org/jira/browse/OFBIZ-7860
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>    Assignee: Aman Agrawal
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7860-trunk.patch
>
>
> Clean up commented out code in Free Marker Template for Accounting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7860) Clean up commented out code in Free Marker Template for Accounting

2016-07-16 Thread Aman Agrawal (JIRA)
Aman Agrawal created OFBIZ-7860:
---

 Summary: Clean up commented out code in Free Marker Template for 
Accounting
 Key: OFBIZ-7860
 URL: https://issues.apache.org/jira/browse/OFBIZ-7860
 Project: OFBiz
  Issue Type: Sub-task
  Components: accounting
Affects Versions: Trunk
Reporter: Aman Agrawal
Assignee: Aman Agrawal
Priority: Minor


Clean up commented out code in Free Marker Template for Accounting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7358) Find Facility button doesn't work on first click

2016-06-16 Thread Aman Agrawal (JIRA)
Aman Agrawal created OFBIZ-7358:
---

 Summary: Find Facility button doesn't work on first click
 Key: OFBIZ-7358
 URL: https://issues.apache.org/jira/browse/OFBIZ-7358
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: Trunk
Reporter: Aman Agrawal
Assignee: Rahul bhammarker
Priority: Minor


Steps to generate:
Click on Facility --> Shipments --> find button doesn't works on single click.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7351) Missing UiLabel on Product Inventory Summary page

2016-06-15 Thread Aman Agrawal (JIRA)
Aman Agrawal created OFBIZ-7351:
---

 Summary: Missing UiLabel on Product Inventory Summary page
 Key: OFBIZ-7351
 URL: https://issues.apache.org/jira/browse/OFBIZ-7351
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: Trunk
Reporter: Aman Agrawal
Assignee: Aman Agrawal
Priority: Minor


Steps to regenerate:
Catalog --> Products --> Find Products --> Select any productId --> Inventory 
--> Select any productId --> Show all Facilities ui label is missing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)