Re: [VOTE] Apache OFBiz 18.12.10

2023-11-30 Thread Gil Portenseigne
+1 Thanks, Gil On 27/11/2023 11:48, Jacopo Cappellato wrote: This is the vote thread to publish "Apache OFBiz 18.12.10", tenth release from the release18.12 branch. The release files can be downloaded from here: https://dist.apache.org/repos/dist/dev/ofbiz/ and are: *

IDEA plugin contribution

2023-06-30 Thread Gil Portenseigne
Hello, I'm starting a new thread to get your opinion about contributing the OFBiz idea plugin. This intention was already done in the past in https://lists.apache.org/thread/03fr40tvhkv97pqrgt4nl78w4m6ml33w , but no conclusion was made. Gaëtan continued working on the plugin to provide

Re: OFBiz 22.01 - Eclipse - Issues on setting up a debugging environment.

2023-05-05 Thread Gil Portenseigne
Hello, Reading this i discussed with Gaëtan about somthing that could help control that every groovyScript reference in Screens/Forms/Services are effectively referencing an existing file. As you might know, Gaëtan is contributing an IDEA plugin dedicated to OFBiz [1]. The plugin already

Re: OFBiz 22.01 - Eclipse - Issues on setting up a debugging environment.

2023-05-05 Thread Gil Portenseigne
+1 Thanks, Gil Le 03/05/2023 à 16:39, Michael Brohl a écrit : +1 from my side. Best regards, Michael Am 03.05.23 um 09:45 schrieb Jacopo Cappellato: On Tue, May 2, 2023 at 9:17 AM Daniel Watford wrote: [...] I'll ask one more question (and then run for cover!): Rather than carry out

Re: [OFBIZ-12801] "Error at CommunicationEventServices.groovy:489"

2023-04-28 Thread Gil Portenseigne
::success ? Gil Le 26/04/2023 à 09:49, Gil Portenseigne a écrit : Hello, I like the idea that the developer do not have to sync about which method to use. If I understand well what Michael envision, i.e. to use for event a new GroovyBaseEvent class, and for services/scripts a GroovyBaseScript

Re: [jira] [Commented] (OFBIZ-12808) Eclipse build problems and proper dependency setup

2023-04-26 Thread Gil Portenseigne
+1 Gil Le 26/04/2023 à 16:36, Jacques Le Roux a écrit : +1 Jacques Le 26/04/2023 à 16:01, Jacopo Cappellato a écrit : +1 Jacopo On Wed, Apr 26, 2023 at 3:11 PM Michael Brohl wrote: Hi everyone, any objections against merging those pr's for framework/plugins in trunk/release22.01? I

Re: [OFBIZ-12801] "Error at CommunicationEventServices.groovy:489"

2023-04-26 Thread Gil Portenseigne
Hello, I like the idea that the developer do not have to sync about which method to use. If I understand well what Michael envision, i.e. to use for event a new GroovyBaseEvent class, and for services/scripts a GroovyBaseScript class, that both extends a common class for the common code,

Re: Codenarc integration process

2023-04-12 Thread Gil Portenseigne
me to fix that, i wanted to ask if it is allowed ? Gil Le 27/03/2023 à 16:46, Jacques Le Roux a écrit : Hi Guys, For those who have used a non "PASSED" lozenge in wiki and resolved a related conversation in GH please update the status in wiki TIA Jacques Le 28/01/2023 à 11:51, Gil

Re: [VOTE] Apache OFBiz 18.12.07

2023-04-04 Thread Gil Portenseigne
+1 Everything is fine from my side ! Thanks Gil Le 03/04/2023 à 09:47, Jacopo Cappellato a écrit : This is the vote thread to publish "Apache OFBiz 18.12.07", seventh and probably final release from the release18.12 branch. The release files can be downloaded from here:

Re: Codenarc integration process

2023-01-28 Thread Gil Portenseigne
Oh sorry indeed i overview the review approach section. The table is nice, thanks Dan ! 28 janv. 2023 09:37:50 Daniel Watford : > Hi Gil, > > I don't think a checklist is quite enough, assuming we want to track the > status of each file reviewed. > > From the review approach section: > > >  

Re: Codenarc integration process

2023-01-21 Thread Gil Portenseigne
he 455(!) files and > will rather call our CTR mode as I'm much confident in your (big) work :) > > +1 from my side > > Jacques > > > Le 21/01/2023 à 09:57, Gil Portenseigne a écrit : >> Yes, it is considered best practice to avoid gstring usage when not needed. >&

Re: Codenarc integration process

2023-01-21 Thread Gil Portenseigne
Yes, it is considered best practice to avoid gstring usage when not needed. Like for others, we can decide to not apply this rule. The detailed rule from codenarc documentation : *UnnecessaryGString** Rule* /Since //CodeNarc// 0.13/ String objects should be created with single quotes, and

Re: Welcome to Leila Mekika as new committer

2022-10-05 Thread Gil Portenseigne
Congratulations Leila ! Bravo ! Gil On 04/10/2022 09:30, MLeila wrote: Hello all, Thanks for your welcome! I am glad to join the team and be able to contribute more actively on the project Regards, Leila Le 04/10/2022 à 07:38, Devanshu Vyas a écrit : Many congratulations and welcome

Re: Codenarc integration, rules to use.

2022-08-01 Thread Gil Portenseigne
Hello Jacques, Thanks for your feedback, I'll go with that. Gil On Mon, Jul 25, 2022 at 10:08:20AM +0200, Jacques Le Roux wrote: > Hi Gil, > > Here are my preferences inline... > > Le 20/07/2022 à 23:49, Gil Portenseigne a écrit : > > Thanks All for the feedback. >

Re: Codenarc integration, rules to use.

2022-07-20 Thread Gil Portenseigne
as UnnecessaryGetter Thanks, Gil On 2022/07/04 15:24:43 Gil Portenseigne wrote: > Hello Devs, > > I would like to continue Codenarc integration in OFBiz (OFBIZ-11167). > > For those who are not aware, Codenarc is an analysis tools for Groovy > for defects, bad practices, inconsisten

Re: Codenarc integration, rules to use.

2022-07-12 Thread gil . portenseigne
. Thanks for the initiative, Michael Brohl ecomify GmbH - www.ecomify.de Am 04.07.22 um 17:24 schrieb Gil Portenseigne: > Hello Devs, > > I would like to continue Codenarc integration in OFBiz (OFBIZ-11167). > > For those who are not aware, Codenarc is an analysis tools for Groov

Re: Codenarc integration, rules to use.

2022-07-12 Thread Gil Portenseigne
Forgot the ref https://github.com/CodeNarc/CodeNarc/issues/331 Le 12 juillet 2022 21:11:13 GMT+02:00, Gil Portenseigne a écrit : >Hello, > >I agree with you, i find out here [1] that it is customisable. > >So we can agree upon this variation of the rule ! > >I have not

Re: Codenarc integration, rules to use.

2022-07-12 Thread Gil Portenseigne
out, my preference for >legibility has always been [someKey: someValue]. I find >[someKey:someValue] a bit too condensed and harder to differentiate key >from value. > >Regards >Scott > >On Mon, 4 Jul 2022 at 16:25, Gil Portenseigne >wrote: > >> Hello Devs, >> >

Codenarc integration, rules to use.

2022-07-04 Thread Gil Portenseigne
Hello Devs, I would like to continue Codenarc integration in OFBiz (OFBIZ-11167). For those who are not aware, Codenarc is an analysis tools for Groovy for defects, bad practices, inconsistencies, style issues and more. For this purpose we need to agree about the ruleset to put in place. I

Re: "New commiter first steps" wiki page proposal

2022-05-16 Thread Gil Portenseigne
Hello Giulio, I just went through the page, it's nice and clear ! Thanks Gil Le samedi 14 mai 2022 à 16:32 +0200, Giulio Speri - MpStyle Srl a écrit : > Hello Devs, > > I hope you are all doing well! > I finally had some time to write a little guide regarding the steps > to > perform as a

Re: [INFRA-22722] Restart the ofbiz-vm3 demos server

2022-03-24 Thread Gil Portenseigne
I do not remember doing such :) Gil On Wed, Mar 23, 2022 at 07:13:02PM +0100, Jacques Le Roux wrote: > Ah forgot, did you fix the warnings? > > Le 23/03/2022 à 19:09, Jacques Le Roux a écrit : > > Great, thanks Gil! > > > > Le 23/03/2022 à 18:15, Gil Portenseigne a

Re: [INFRA-22722] Restart the ofbiz-vm3 demos server

2022-03-23 Thread Gil Portenseigne
Hello Jacques, We have some production server based on 18.12, with java 11. It is working fine. Gil On Wed, Mar 23, 2022 at 05:58:25PM +0100, Jacques Le Roux wrote: > BTW, > > Is there someone who is already using Java 11 with 18.12? > > TIA > > Jacques > > Le 23/03/2022 à 16:24, Jacques

Re: Welcome to Nicola Mazzoni and Giulio Speri as new committers

2022-03-22 Thread Gil Portenseigne
Congratulations, Welcome ! Gil On Mon, Mar 21, 2022 at 09:26:16PM +0100, Jacopo Cappellato wrote: > The OFBiz PMC has invited Nicola Mazzoni and Giulio Speri as new > committers and we are glad to announce that they have accepted the > nomination. > > On behalf of the OFBiz PMC, welcome on

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Gil Portenseigne
+1, Verifying files... sha check of file: apache-ofbiz-18.12.05.zip Using sha file: apache-ofbiz-18.12.05.zip.sha512 apache-ofbiz-18.12.05.zip: F7952ED5 C794357F E730C7DE 404B0B8B 7A123A89 9DA7A1C1 4D0136ED 64D6FAA3 7645018E 9EDE93FB 88FC27A3 D718DA64 E8636541 334583ED 606F5516 6D653B2C

Re: [Conclusion] PartyRole usage in OFBiz

2021-11-19 Thread Gil Portenseigne
Hello Pierre, Inline, On Fri, Nov 19, 2021 at 06:48:40PM +0100, Pierre Smits wrote: > Hi Gil, All, > > My apologies, but I have to object to this and for the following reasoning: > Objections to pursuing improvements to the entity definition (for > PartyRole) and subsequent addressing front-end

[Conclusion] PartyRole usage in OFBiz

2021-11-19 Thread Gil Portenseigne
Hello, I will try to summarize the ongoing thread, to produce a conclusion or potential plan. Sorry in advance, if I forgot some points. About the improvement of adding lifespan in PartyRole entity, the "Won't do" seems to get the consensus, since this improvement do not follow logical purpose

Re: [VOTE] Apache OFBiz 18.12.02 (second attempt)

2021-11-19 Thread Gil Portenseigne
+1 Thanks On Tue, Nov 16, 2021 at 05:26:52PM +0100, Jacopo Cappellato wrote: > This is the second vote thread to publish "Apache OFBiz 18.12.02", the > second release from the release18.12 branch. > > The release files can be downloaded from here: > https://dist.apache.org/repos/dist/dev/ofbiz/

PartyRole usage in OFBiz

2021-11-12 Thread Gil Portenseigne
Hello, I'm starting a new thread to discuss with the community about an Improvement that has been submitted by Pierre Smits [1] This topic has already been discussed in the past [2] and was conclude by a lazy consensus not to implement PartyRole lifespan into OFBiz. Recently, this improvement

Re: [VOTE] Apache OFBiz 18.12.01

2021-10-27 Thread Gil Portenseigne
+1 Thanks, Gil On Sat, Oct 23, 2021 at 05:08:32PM +0200, Jacopo Cappellato wrote: > This is the vote thread to publish "Apache OFBiz 18.12.01", the first > release from the release17.12 branch. > > The release files can be downloaded from here: > https://dist.apache.org/repos/dist/dev/ofbiz/ >

Re: [apache/ofbiz-framework] Run failed: Java CI with Gradle - trunk (c0f8783)

2021-09-23 Thread Gil Portenseigne
Hello, I got a notification of CI that use jdk 1.8 for trunk. Is there any action that i can do to configure java 11 or more ? Thanks, Gil On Thu, Sep 23, 2021 at 06:03:33AM -0700, Gil Portenseigne wrote: > [apache/ofbiz-framework] Java CI with Gradle workflow run > > Repositor

Re: [DISCUSSION] Do we start the R18 publish process ?

2021-09-20 Thread Gil Portenseigne
+1 Thanks, Gil On Mon, Sep 20, 2021 at 10:13:04AM +0200, Nicolas Malin wrote: > The main is on the title :) > > At this time some issue are always present [1], so we have to decide > whether to launch and move them to the next. > > My feeling is after some time on it, we can go ahead and keep

Re: Freemarker auto-escaping

2021-09-08 Thread Gil Portenseigne
Hello, I used to define `<#ftl output_format="XML">` on top of ftl files for this purpose. But having this on file extension looks nice to me. Thanks Jacques for the head up. Gil On Wed, Sep 08, 2021 at 02:59:27PM +0200, Jacques Le Roux wrote: > Hi, > > Long ago we opened

Groovy integration tests

2021-09-08 Thread Gil Portenseigne
Hello, Currently using release 18.12 for some project we got the habit to develop using integration test while developing in groovy. For that usage we use mainly : groovy-test-suite That allow coding tests in groovy script that do not need to be compiled for their execution and executing

Re: Logical dependency tree for ofbiz components OFBIZ-12309

2021-09-08 Thread Gil Portenseigne
Hello Eugen, [...] > > I have on my mind to elaborate a framework-core an acceptable minimal > > circular dependencies and some other present as three dependency > > > >* core : common - base - start - entity - service - security - webapp > >* entityext : core > >* datafile: core >

Re: Next rather than old demo

2021-09-06 Thread Gil Portenseigne
Hello Jacques, I agree it's better to show the present and future. Thanks, Gil On Mon, Sep 06, 2021 at 11:47:18AM +0300, Eugen Stan wrote: > On 03.09.2021 20:00, Jacques Le Roux wrote: > > Hi, > > > > We have an old demo. It's the previous stable. I think we should rather > > think about the

Re: [VOTE] Apache OFBiz 17.12.08

2021-08-06 Thread Gil Portenseigne
+1 Checksum, signature and tests are OK Thanks, Gil On Mon, Aug 02, 2021 at 12:24:13PM +0200, Jacques Le Roux wrote: > +1 > > Back and front ends OK > > Checksums OK > > $ ./verify-ofbiz-release.sh apache-ofbiz-17.12.08.zip > sha check of file: apache-ofbiz-17.12.08.zip > Using sha file:

Re: I'm working on an OFBiz helm chart for kubernetes

2021-07-02 Thread Gil Portenseigne
Hello Eugen, and thanks Pierre for the reminder :) I just wanted to mention there was a previous effort to implement environment variable configuration [1]. This has not yet be pushed into trunk, but is used by our customer projects. You could check the patch and test if it helps you ease the

Re: Introduce a "Good First Issue" Jira Label

2021-05-10 Thread Gil Portenseigne
Hello, Good idea, To add some more about GoodForNewContributors, it seems well used in GitLab platform : https://gitlab.com/groups/gitlab-org/-/issues?label_name%5B%5D=good+for+new+contributors So sticking with it seems nice to me. Thanks Le 07/05/2021 à 15:53, Aditya Sharma a écrit : Hi

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.07

2021-04-14 Thread Gil Portenseigne
Hello, +1 Tests are OK, basic usage OK, SHA and signature OK Regards, Gil Le 13/04/2021 à 10:39, Jacopo Cappellato a écrit : This is the vote thread to release a new bug fix release for the release17.12 branch. This new release, "Apache OFBiz 17.12.07" will supersede all the previous

Re: Releasing 17.12.05, 18.12.01 and freezing R20

2020-12-22 Thread Gil Portenseigne
+1 for Michael ! Cheers On Mon, Dec 21, 2020 at 02:57:25PM +0100, Michael Brohl wrote: > +1 for the initial proposal > > with an additional idea: maybe better skip r20 and make a r21 right at the > beginning of the year with the chance to release also in 21. > > This would allow us to catch up

Chapter 3 : promoting decorator

2020-06-09 Thread Gil Portenseigne
Hello devs, This mail introduce the last Chapter of our story that describe in which context we created some new decorators. First, we want to recall the common-theme effort objectives : The common-theme component is the default theme that define every screens that are available for theme

Re: Chapter two: Rules to dynamize screen

2020-05-18 Thread Gil Portenseigne
tions should be decoupled from forms. > Shall we continue with Part 3? > > Regards, > James > > On 2020/01/10 17:58:59, Gil Portenseigne wrote: > > Hello ! > > > > In previous thread we focused on the process of how to define a dynamic > > workflow tha

Re: Adopting Github Workflow

2020-03-11 Thread Gil Portenseigne
Hi, On Wed, Mar 11, 2020 at 05:08:47PM +0100, Michael Brohl wrote: > > > > - Adopt Github Pull Request (PR) as the unique channel for code contribution > > -1 > > I don't see a reason why we should not allow patches also. It will make it > easier for people to contribute who are not able (or

Re: Git history problem

2020-03-11 Thread Gil Portenseigne
+1 IMO i prefer to rebase and check the commit i push in my local repo. Thanks Le 11 mars 2020 16:52:36 GMT+01:00, Mathieu Lirzin a écrit : >>> The simple solution to prevent this is to get into the habit of >>> linearizing history, meaning always rebasing and clean history >before >>>

Groovy Migration : createRequirementFromItemATP

2020-03-06 Thread Gil Portenseigne
Hello ! While migrating createRequirementFromItemATP, i stumbled upon a comment from David Jones : > NOTE DEJ20090902: this service is not called > anywhere, instead the createATPRequirementsForOrder service (written in > Java) is called; why this is the case I don't know... --> I investigate a

Re: buildbot failure in on ofbizTrunkFramework

2020-03-06 Thread Gil Portenseigne
Build Source Stamp: [branch trunk] 53a8b812607f9987a1063f18062a5318cafe444c > Blamelist: Gil Portenseigne > > BUILD FAILED: failed shell_2 > > Sincerely, > -The Buildbot > > > signature.asc Description: PGP signature

Re: Important Notice on Mailbox Account upgrade for notificati...@ofbiz.apache.org

2020-03-04 Thread Gil Portenseigne
Nope, same here. signature.asc Description: PGP signature

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Gil Portenseigne
+1 On Thu, Feb 27, 2020 at 06:09:34PM +0100, Michael Brohl wrote: > +1 > > ~/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01  > ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-17.12.01.zip > sha check of file: apache-ofbiz-17.12.01.zip > Using sha file: apache-ofbiz-17.12.01.zip.sha512 >

Re: Impersonation feature, was: Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Gil Portenseigne
> Michael Brohl > > ecomify GmbH - www.ecomify.de > > Am 28.02.20 um 08:49 schrieb Gil Portenseigne: > > Hello Pierre, > > > > If you are talking about impersonation feature, that is not in the 17.12 > > branch. > > > > In eith

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-27 Thread Gil Portenseigne
Hello Pierre, If you are talking about impersonation feature, that is not in the 17.12 branch. In either way, administrative tools, if we got access to it, allow what your are saying. But there is no security issue that grant these privilege we are aware of. If you do, please share to the

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #2

2020-02-25 Thread Gil Portenseigne
A bit late but +1 ! Thanks On Fri, Feb 21, 2020 at 09:24:02AM +0100, Jacopo Cappellato wrote: > This is the vote thread (2nd attempt) to release "Apache OFBiz 17.12.01": > this is the first release, containing the framework, applications and all > the plugins from the 17.12 release branches. >

Re: PMC/Committer resignation

2020-02-24 Thread Gil Portenseigne
I second Nicolas opinion. I hope that we will evolve and that will allow you to come back in the community in the future. Let me thank you again for your time and kind help. Gil On Sat, Feb 22, 2020 at 02:51:28PM +0100, Nicolas Malin wrote: > It's sad new that you sharing. > > This community

Re: checkstyle improvements

2020-02-14 Thread Gil Portenseigne
Inline, > > I'm kinda prefer the "opposite approach", but we need to discuss if this > > improvement is worth the history lost. > > > > In the example you chose, i see no issue capitalizing module, > > resource and other. Updating the rule offer the ability to write a > > constant like : MoDuLe

Re: checkstyle improvements

2020-02-14 Thread Gil Portenseigne
OFBiz > <https://ofbiz.apache.org/>, since 2008 > > *Apache Trafodion <https://trafodion.apache.org>, Vice President* > *Apache Directory <https://directory.apache.org>, PMC Member* > Apache Incubator <https://incubator.apache.org>, committer > Apach

Re: checkstyle improvements

2020-02-13 Thread Gil Portenseigne
Hello Michael, Adapting checkstyle configuration is less impacting to our codebase but make us stay different from the java standard. That is the easier path, that will not affect code history. But about getting nearer from the java standard is IMO a nice to have, to make pure java developer

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-02-12 Thread Gil Portenseigne
It's an error while cherry picking the bugFix from trunk. I will revert. On Wed, Feb 12, 2020 at 12:10:46PM +0100, Gil Portenseigne wrote: > Yes, i'm on it... > On Wed, Feb 12, 2020 at 11:56:14AM +0100, Jacques Le Roux wrote: > > It's OK, but we have now a compilation in R17

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-02-12 Thread Gil Portenseigne
Yes, i'm on it... On Wed, Feb 12, 2020 at 11:56:14AM +0100, Jacques Le Roux wrote: > It's OK, but we have now a compilation in R17: > https://ci.apache.org/builders/ofbizBranch17Framework > > Please Gil have a look > > Thanks > > Le 12/02/2020 à 09:00, Jacques Le Roux a écrit : > > Hi Michael,

Re: In preparation for the first release from 17.12

2020-02-11 Thread Gil Portenseigne
Yes, it is a good way to go. Thanks Jacopo On Tue, Feb 11, 2020 at 03:38:46PM +0100, Jacopo Cappellato wrote: > So far it seems that we are in favor of releasing the full version > (framework + plugins) named "Apache OFBiz 17.12.01" and then also the > version without the plugins. > If this is

Re: In preparation for the first release from 17.12

2020-02-10 Thread Gil Portenseigne
+1 Regards, Gil On Mon, Feb 10, 2020 at 05:02:18PM +0100, Nicolas Malin wrote: > Hi, > > I most in favor to propose two products like : > >     "Apache OFBiz Framework 17.12.01" (framework) > and >     "Apache OFBiz Full 17.12.01" (framework + plugins) > > For advanced user, they would use

Re: svn commit: r1828233 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/finaccount/FinAccountServices.java

2020-02-04 Thread Gil Portenseigne
+1 for the fix. On Tue, Feb 04, 2020 at 12:22:48PM +0100, Michael Brohl wrote: > During a migration I found that this bugfix was not backported to the 17.12 > release branch. > > Should I do it now? > > Regards, > > Michael Brohl > > ecomify GmbH - www.ecomify.de > > > Am 03.04.18 um 15:06

Re: Github & notifications

2020-02-03 Thread Gil Portenseigne
+1 If we do not decide of replacing Jira with Github or another BT, we must keep Jira for contribution tracking. There might be a jira integration in github for that ? Gil On Mon, Feb 03, 2020 at 12:16:11PM +0100, Michael Brohl wrote: > I'm automatically informed about the pull requests, I

Re: [PROPOSAL] Environment variable configuration

2020-02-02 Thread Gil Portenseigne
patch sets for different environments. > > > > > > > > > > We now use a staged configure mechanism which uses a base > > > > > build file, auto detected machine name and provided > > > > > parameters to decide which co

Re: Removing “base/config/component-load.xml”

2020-02-02 Thread Gil Portenseigne
I agree with Jacques, i tried several times to participate in the discussion but i am confused about the situation. About this situation, Michael, we get your point about the process of discuss things before modifying not trivial code and I do agree with that. But there can always be mistakes.

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.07

2020-01-30 Thread Gil Portenseigne
+1 Thanks On Fri, Jan 31, 2020 at 12:16:54AM +0530, Deepak Dixit wrote: > +1 > > Thanks & Regards > -- > Deepak Dixit > ofbiz.apache.org > > > On Thu, Jan 30, 2020 at 9:56 PM Nicolas Malin > wrote: > > > +1 > > > > Same result from my local > > > > Nicolas > > > > On 30/01/2020 16:06,

Re: [DISCUSSION] R16 and R17: email password issue and releases

2020-01-24 Thread Gil Portenseigne
I wonder if it is bad for the project to have 2 years between two releases, 16 => 18 => 20 WDYT ? Gil On Fri, Jan 24, 2020 at 05:31:14PM +0100, Jacques Le Roux wrote: > Le 24/01/2020 à 15:09, Nicolas Malin a écrit : > > On 24/01/2020 14:57, Jacques Le Roux wrote: > > > > > I must say I'm

Re: [VOTE] Do not release R17 and directly publish R18 instead.

2020-01-24 Thread Gil Portenseigne
+1 On Fri, Jan 24, 2020 at 11:27:15AM +0100, Jacques Le Roux wrote: > Hi, > > R16 is now an old distribution and has almost reached its end of support. We > can soon expect a last release but we need to think about the next to be > released package > > Some would prefer to release R17 before

Chapter two: Rules to dynamize screen

2020-01-10 Thread Gil Portenseigne
Hello ! In previous thread we focused on the process of how to define a dynamic workflow that raises some questions. Let's go back to our principles: we have to find simple things, limit the possibilities (do little but good) and remember that on the backoffice it's end-users who are focused on

Re: [DISCUSSION] Make Back-Office screens dynamic

2020-01-10 Thread Gil Portenseigne
Hello James, Thanks for the reference we will look into that. Regards, On Fri, Jan 10, 2020 at 03:50:23PM -, James Yong wrote: > Hi Gil, > > I wonder if this library helps for a start: > https://github.com/joshualjohnson/jquery.x > > Regards, > James > signature.asc Description: PGP

Re: [DISCUSSION] Make Back-Office screens dynamic

2019-12-17 Thread Gil Portenseigne
rse this > > > > is more work than what you're suggesting here. but if we continue with > > > > such small improvements, you might end up having lots of javascript > > > > (maybe that's already the case) which might increase the difficulty of > > > > adopting

Re: [DISCUSSION] Make Back-Office screens dynamic

2019-12-17 Thread Gil Portenseigne
ssarily have an > > answer to): > > > > Do you want an SPA framework now or in the future, or do you want to > > continue with status quo into the future? If you want an SPA > > framework, then we should minimize the usage of custom javascript > > everywhere and adop

Re: [DISCUSSION] Make Back-Office screens dynamic

2019-12-17 Thread Gil Portenseigne
proposition and any others in the future knowing > that an overhaul is not needed. > > Cheers, > > Taher Alkhateeb > > On Fri, Dec 13, 2019 at 6:52 PM Gil Portenseigne > wrote: > > > > Chapter One: How to manage the updating area > > > > Hello,

[DISCUSSION] Make Back-Office screens dynamic

2019-12-13 Thread Gil Portenseigne
Chapter One: How to manage the updating area Hello, After different discussions already listed by Taher [1-9], Leila, Nicolas and me tried another approach. Instead of analyzing how to implement different functionalities offered by modern js framework, we did analyzed how end user use, in

Re: Github PRs and Jira

2019-12-04 Thread Gil Portenseigne
Hello, > > > I guess that using existent Github should be ok for official pull > > request, if not, it's always ok to have and attached patch or > > other gitlab reference. > > You mean "Github reference" I guess ? > For this one a really mean gitlab reference like the nereide public gitlab

Re: Github PRs and Jira

2019-12-03 Thread Gil Portenseigne
+1 to use gitlab features to work around code, that will help collaboration. I don't know if there is an Apache alternative to get the features without Microsoft. But having two official tools to get contribution is not desired. I guess that using existent Github should be ok for official pull

Audit max-retry failure async job

2019-11-18 Thread Gil Portenseigne
Subject : Audit max-retry failure async job Hi all, While working for a customer, we need to send data to an external API. For this purpose we did trigger an Async service with a max-retry to 3, to be resilient with external API unavailability. The fact is that, with this implementation, we do

Re: Change commit message template?

2019-11-17 Thread Gil Portenseigne
Hello, When we first decided on the current template, i did understood that jira number was at the end of the first line, that was logical in my view. I was mistaken and did not discussed it by then. Setting Jira number at the end of the first line is fine for me. Gil Le 21:16 - dimanche 17

Re: [ofbiz-framework] 02/02: Fixed: Update the SvnCheckout Gradle task to used Github svn repo (OFBIZ-11276)

2019-11-08 Thread Gil Portenseigne
> can still use svn as before... > > I'll do one simple commit in ecommerce I need to do, to check this assertion. > > Jacques > > Le 08/11/2019 à 09:42, Gil Portenseigne a écrit : > > Hello Jacques, > > > > Could you provide a reference to the github feature you ment

Re: [ofbiz-framework] 02/02: Fixed: Update the SvnCheckout Gradle task to used Github svn repo (OFBIZ-11276)

2019-11-08 Thread Gil Portenseigne
Hello Jacques, Could you provide a reference to the github feature you mentionned ? Thanks Gil Le 19:02 - mercredi 06 nov., jler...@apache.org a écrit : > This is an automated email from the ASF dual-hosted git repository. > > jleroux pushed a commit to branch trunk > in repository

Re: Git repo for each ofbiz plugin

2019-11-07 Thread Gil Portenseigne
Hello Deepak, all, I do not have a strong opinion about separating plugins into independent git repositories but here are my thought : Plugins integration in OFBiz is intended to be used with a maven repository that hosts the plugin releases for the users. See as a reference the ‘OFBiz Plugins

Re: Upgrading Groovy 2.4.16 → 2.5.8

2019-10-29 Thread Gil Portenseigne
Hello Mathieu, I've test the upgrade and saw no issue, so +1. Gil Le 18:19 - dimanche 27 oct., Mathieu Lirzin a écrit : > Hello, > > I have open OFBIZ-11263 [1] to upgrade Groovy to its latest stable > release on ‘trunk’. > > I did not detect any issue with the upgrade so I intend to

Re: [DISCUSSION] R16 and R17: email password issue and releases

2019-10-04 Thread Gil Portenseigne
Hello, I think that the one year stabilisation period needed for a new branch to be released is not that far for R18 (less than two month), so I suppose that skipping R17 to avoid maintaining two release branches is a good call. Gil Le 13:29 - samedi 28 sept., Jacques Le Roux a écrit : > Hi, >

Refactoring ServiceSemaphore (OFBIZ-11204)

2019-10-04 Thread Gil Portenseigne
Hello, In one of our customer project, where we are using multiple OFBiz instances to run backend jobs, in which some are using service semaphore system. While these semaphore jobs are run quite intensively by several OFBiz process, we stumble upon a lot of 'Error' logs that are polluting other

Re: Avoiding to log Uel stacktraces (was: svn commit: r1867635 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/UelFunctions.java)

2019-09-27 Thread Gil Portenseigne
Hello Mathieu ! Done, thanks for your review, i hope it is more clear. Gil Le 16:23 - vendredi 27 sept., Mathieu Lirzin a écrit : > Hello Gil, > > p...@apache.org writes: > > > Author: pgil > > Date: Fri Sep 27 13:52:43 2019 > > New Revision: 1867635 > > > > URL:

Re: Default transaction timeout on screen widget

2019-09-20 Thread Gil Portenseigne
Same feeling here, i just see it as a smell to analyse, to detect bad design, system failure (disk access...) or regression. Regards Gil Le 20:45 - mardi 17 sept., Scott Gray a écrit : > Has anyone ever had a good experience with transaction timeouts? I feel > like they achieve nothing useful

Re: [DISCUSSION] Best of both Groovy worlds: compile and on the fly

2019-09-20 Thread Gil Portenseigne
Hello Jacques, I also discussed about it with Mathieu and i find it very interesting. The main advantage I see is, beside compilation, the integration in your IDE, that was not optimum, and the possibility to re-use methods from these script migrated to explicit classes. So +1 Gil Le 12:28 -

Re: svn commit: r1858243 - in /ofbiz/ofbiz-plugins/trunk: ecommerce/minilang/customer/CustomerEvents.xml example/template/reports/BarCode.fo.ftl

2019-04-27 Thread Gil Portenseigne
Hello Suraj, You commited something about maritalStatus id this commit. I guess its part of another JIRA. Regards Le 06:18 - samedi 27 avril, sur...@apache.org a écrit : > Author: surajk > Date: Sat Apr 27 06:18:17 2019 > New Revision: 1858243 > > URL:

Re: [PROPOSAL] DataModel - Improve Internal Fields injection

2019-04-26 Thread Gil Portenseigne
A big post for saying that the feature i just wanted to recall about do not fit your need :). I used it in the past for a critical audit, and was happy with it. Le 14:23 - vendredi 26 avril, Pierre Smits a écrit : > Gill, all, > > The entity_audit_log feature also sprung into my mind shortly

Re: [PROPOSAL] DataModel - Improve Internal Fields injection

2019-04-26 Thread Gil Portenseigne
Hello Pierre, If you have specific need of Auditing, after suspition of malicious users, you can enable entity_audit_log feature on the desired table. At a cost of performance loss. I do not understand why impersonation feature appears here, since it is a administrator specific feature. If an

Re: Send E-Mails

2019-03-26 Thread Gil Portenseigne
t; Apache Incubator <https://incubator.apache.org>, committer > > *Apache OFBiz <https://ofbiz.apache.org>, 10 years a contributor without > > privileges* > > Apache Steve <https://steve.apache.org>, committer > > > > > > On Tue, Mar 26, 20

Re: Send E-Mails

2019-03-26 Thread Gil Portenseigne
Thanks Jacques :) Le 09:21 - mardi 26 mars, Jacques Le Roux a écrit : > Hi Gil, > > Let me check > > Jacques > > Le 26/03/2019 à 08:56, Gil Portenseigne a écrit : > > Hello there, > > > > Do somes actions have been taken on documenting the existence

Re: Send E-Mails

2019-03-26 Thread Gil Portenseigne
Hello there, Do somes actions have been taken on documenting the existence of SystemProperty ? I like the idea of migrating documentation into embedded one. I just wanted to add a note into https://s.apache.org/BPJ5 that alert about SystemProperty, but i seem to miss the modification

Re: Welcome to Mathieu Lirzin as new committer!

2019-02-19 Thread Gil Portenseigne
Welcome Mathieu, and Congratulations ! Gil Le 20:15 - mardi 19 févr., Taher Alkhateeb a écrit : > The OFBiz PMC has invited Mathieu Lirzin to become a new committer and > we are happy to announce that he has accepted this role. > > Some of the reasons for inviting Mathieu include: > > - He is

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2018-12-29 Thread Gil Portenseigne
Hello, I just checked again with ‘./gradlew cleanAll loadAll testIntegration’, A got build successful... no failure. Gil Le 20:11 - vendredi 28 déc., Jacques Le Roux a écrit : > Hi Gil, > > Are we sure there is not a test issue with this commit? > > Locally I can't reproduce the same but I

OFBIZ-10691 Refactoring ‘EntityCondition’

2018-12-28 Thread Gil Portenseigne
Hello, There is a very nice contribution from Mathieu Lirzin about refactoring EntityCondition class hierarchy, to make it more legit and understandable. It is well documented and validated against integration test and basic usage This lies in OFBIZ-10691 Jira, if you want to have a look, i

Re: [DISCUSSION] Checking debug levels in Java and Groovy files

2018-12-11 Thread Gil Portenseigne
Hello, The difference with the documentation and Mathieu's example is the presence of String concatenation. Here lies the performance improvment. If there a simple String is used, the if is uneeded :) Regards Gil Le 19:58 - mardi 11 déc., Taher Alkhateeb a écrit : > The official documentation

Re: svn commit: r1845086 [2/2] - in /ofbiz/ofbiz-framework/trunk/applications: accounting/webapp/accounting/WEB-INF/ content/webapp/content/WEB-INF/ order/webapp/ordermgr/WEB-INF/ party/webapp/partymg

2018-10-29 Thread Gil Portenseigne
Hello Suraj, Is there a reason to keep empty path for service event ? Regards Gil Le lundi 29 oct. 2018 à 08:14:55 (-), sur...@apache.org a écrit : > Modified: > ofbiz/ofbiz-framework/trunk/applications/workeffort/webapp/workeffort/WEB-INF/controller.xml > URL: >

Re: Pursuing the “120 chars max” guideline (was: svn commit: r1844729 - in /ofbiz/ofbiz-framework/trunk/framework/webapp: dtd/site-conf.xsd src/main/java/org/apache/ofbiz/webapp/control/RequestHandler

2018-10-26 Thread Gil Portenseigne
Hello, +1 to follow the 120char guideline for any commit that the purpose it not to refactor line length :). Gil Le vendredi 26 oct. 2018 à 11:13:48 (+0200), Mathieu Lirzin a écrit : > Hello Jacques, > > Jacques Le Roux writes: > > > Yes you are right, the whole file should be reformatted.

Re: Groovy DSL runService Exception Management ?

2018-10-23 Thread Gil Portenseigne
the service engine itself. In that way, there won't be needed systematic test against service return in groovy and that is a good thing. Gil Le dimanche 21 oct. 2018 à 08:02:35 (+0200), Jacopo Cappellato a écrit : > On Thu, Oct 18, 2018 at 10:45 AM Gil Portenseigne < > gil.portensei...@nereide.

Groovy DSL runService Exception Management ?

2018-10-18 Thread Gil Portenseigne
Hello ! While we are working on Groovy migration at Nereide, we figured out that using ‘run service’ DSL method instead of returning the errorMap, a ‘ExecutionServiceException’ is thrown : if (ServiceUtil.isError(result)) { throw new

Re: svn commit: r1843780 - in /ofbiz/ofbiz-framework/trunk/framework/entity/src: main/java/org/apache/ofbiz/entity/condition/ test/java/org/apache/ofbiz/entity/

2018-10-15 Thread Gil Portenseigne
Hello, I think that is an incompatibiliy with Windows newline char (\n vs \r\n). Thanks for the feedback, I'll improve that soon. Gil Le lundi 15 oct. 2018 à 18:09:30 (+0200), Jacques Le Roux a écrit : > Hi Gil, > > Not yet sure it's only me (Windows) but I get this locally > >

  1   2   3   4   5   >