Re: Welcome to Pawan Verma as new committer!

2019-06-14 Thread Rishi Solanki
Congratulations Pawan!!
Welcome Aboard!!

Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Fri, Jun 14, 2019 at 12:33 AM Swapnil Shah <
swapnil.s...@hotwaxsystems.com> wrote:

> Welcome Pawan and many congratulations !!
>
> Thanks,
> Swapnil
>
> -Original Message-
> From: Jacques Le Roux 
> Sent: 13 June 2019 11:18
> To: dev@ofbiz.apache.org
> Subject: Welcome to Pawan Verma as new committer!
>
> The OFBiz PMC has invited Pawan to become a new committer and we are
> pleased
> to announce that he has accepted.
>
> Pawan is part of the community for 2 years and has being quite active and
> proficient, notably these last times with several smart propositions.
>
> He also helps a lot of Jiras and answers properly on MLs.
>
> Please join me in welcoming and congratulating Pawan.
>
> Jacques
>


Re: Welcome to Deepak Nigam as new committer!

2019-06-14 Thread Rishi Solanki
Congratulations Deepak!!
Welcome Aboard!!

Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Thu, Jun 13, 2019 at 5:12 PM Sanjay Yadav 
wrote:

> Many Congratulations, Deepak N.
>
> Thanks.
> --
> Sanjay Yadav
> Manager, Enterprise Quality Assurance
> *HotWax Systems*
> *Enterprise open source experts*
> cell: +91-787.918.8830
> http://www.hotwaxsystems.com
>
>
> On Thu, Jun 13, 2019 at 11:20 AM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > The OFBiz PMC has invited Deepak to become a new committer and we are
> > pleased  to announce that he has accepted.
> >
> > Deepak  is part of the community since January 2016 and has proved to be
> > committed since.
> >
> > He notably made a great work for OFBIZ-10518 "Inventory (Supply)
> > Allocation Planning "
> >
> > He not only worked in Jira,  but also answered accurately on MLs where he
> > supported our users.
> >
> > Please join me in welcoming and congratulating Deepak.
> >
> > Jacques
> >
> >
>


Re: [PROPOSAL] DataModel - Improve entities using fromPartyId & toPartyId

2019-05-21 Thread Rishi Solanki
Thanks everyone for valuable inputs.

+1 for Scott's proposal to go with Role entity. Thanks for the details
added around it.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Mon, May 20, 2019 at 3:17 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Pierre,
>
> In the DMRB, Silverstein mentions from and to party fields for PARTY
> RELATIONSHIPS, SHIPMENTs, FIXED ASSET ASSIGNMENTs, and PAYMENT ACCTG TRANSs
> entities
>
> In the "Logical Data Model Entities and Attributes Listing" section there
> is actually from and to party fields for the following entities:
>
> AGREEMENT
> CUSTOMER RELATIONSHIP
> EMPLOYMENT
> ORGANIZATION CONTACT RELATIONSHIP
> PARTY RELATIONSHIP
> PAY HISTORY
>
>
> --
>
> In OFBiz we have from and to party fields for the following entities:
>
> Invoice
> InvoiceItemAssoc
> Payment
> Employment
> PartyBenefit
> PayHistory
> UnemploymentClaim
> Agreement
> AgreementEmploymentAppl
> CommunicationEvent
> PartyInvitation
> PartyRelationship
> Shipment
> PartyRelationship
> PartyInvitation
>
> Each entity in OFBiz which has from and to party fields has also
> roleTypeIdFrom and roleTypeIdTo.
>
> You lastly wrote:
>
> However there are a (quite a) few entities that defy these 1-on-1
> relationships (between internal party and the object, and the external
> party and the object), like:
>
> - OrderHeader: neither partyIdFrom nor partyIdTo
> - Quote: neither partyIdFrom nor partyIdTo but having a partyId
> field
> - CustRequest: only having fromPartyid (plus its role
> - Subscription: having originatedFromPartyId (plus the role) and
> partyId
> - ReorderGuideline: having partyId (plus the role)
>
> And I am confident I am missing a few.
>
> In order to simplify processes for capturing the main parties in
> various
> entity records I propose to realign these (master) entities to ensure
> that
> both the primary internal and external parties (and their primary
> roles)
> are captured.
>
> In OFBiz we have also 29 '*role" entities (I let you check searching for
> '/
> accounting-entitymodel.xml (5 matches)
> 218:  419:  package-name="org.apache.ofbiz.accounting.finaccount" title="Financial
> Account Role">
> 1?498:  2?281:  2?692:  content-entitymodel.xml (3 matches)
> 631:  921:  1?599:  package-name="org.apache.ofbiz.party.party" title="WebSite Role
> Association">
> marketing-entitymodel.xml (3 matches)
> 125:  359:  728:  order-entitymodel.xml (4 matches)
> 855:  1?164:  1?553:  2?254:  party-entitymodel.xml (4 matches)
> 343:  910:  1?325:  2?536:  product-entitymodel.xml (6 matches)
> 121:  429:  1?230:  package-name="org.apache.ofbiz.product.facility" title="Facility Group
> Role">
> 3?007:  4?127:  4?269:  shipment-entitymodel.xml (3 matches)
> 128:  278:  408:  workeffort-entitymodel.xml
> 102: 
> This is more than what Silverstein proposes in the "Logical Data Model
> Entities and Attributes Listing" section (19).
>
> Note that both models don't intersect (eg CASE ROLE, ORGANIZATION ROLE,
> PERSON ROLE - redundant with PARTY ROLE IMO-, REQUEST ROLE - did not find
> CustRequestRole mentioned by Rishi -, "misses" in OFBiz data model)
>
> AGREEMENT ROLE
> BILLING ACCOUNT ROLE
> BUDGET ROLE
> CASE ROLE
> COMMUNICATION EVENT ROLE
> FINANCIAL ACCOUNT ROLE
> INVOICE ROLE
> ITEM ISSUANCE ROLE
> ORDER ITEM ROLE
> ORDER ROLE
> ORGANIZATION ROLE
> PARTY ROLE
> PERSON ROLE
> QUOTE ROLE
> REQUEST ROLE
> REQUIREMENT ROLE
> SHIPMENT RECEIPT ROLE
> TIMESHEET ROLE
> VALID CONTACT MECHANISM ROLE
>
> I think we should consider Scott's proposition:
>
> I'd prefer to see us move in the other
> direction and remove top-level entitiy from/to fields if there is an
> existing *Role entity in order to simplify the datamodel while
> maintaining
> flexibility.
>
> Even if I don't think it's a priority task as it also implies a lot of
> changes and work
>
> My 2 cts
>
> Jacques
>
> Le 20/05/2019 à 10:27, Scott Gray a écrit :
> > In my experience very few things in the business world are immutable.
> > Dated *Role entities enhance flexibility and provide a decent audit trail

Re: OFBiz Statistics in monthly blog entries

2019-05-21 Thread Rishi Solanki
This is great Pierre, thank you for your effort.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Mon, May 20, 2019 at 12:24 PM Pierre Smits 
wrote:

> I have corrected the settings on the 'Average Time in Status' chart.
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
> since 2008*
> Apache Steve <https://steve.apache.org>, committer
>
>
> On Mon, May 20, 2019 at 8:27 AM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > That's quite interesting thanks Pierre.
> >
> > Should we not get rid of "Average Time in Status: OFBiz"? Seems useless,
> > no data there.
> >
> > Jacques
> >
> > Le 20/05/2019 à 08:16, Aditya Sharma a écrit :
> > > Indeed! Looks Great. Thanks Pierre for your efforts. We will see to it
> if
> > > we can utilize some information from it.
> > >
> > > Thanks and Regards,
> > > *Aditya Sharma* | Enterprise Software Engineer
> > > HotWax Systems <http://www.hotwaxsystems.com/>
> > > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> > Indore,
> > > M.P 452010
> > > Linkedin: *Aditya Sharma* <
> https://www.linkedin.com/in/aditya-p-sharma/>
> > >
> > >
> > >
> > > On Mon, May 20, 2019 at 10:30 AM Pritam Kute <
> > pritam.k...@hotwaxsystems.com>
> > > wrote:
> > >
> > >> That's cool Pierre. Thanks for your efforts.
> > >>
> > >> Kind Regards,
> > >> --
> > >> Pritam Kute
> > >>
> > >>
> > >> On Sat, May 18, 2019 at 12:37 PM Pierre Smits  >
> > >> wrote:
> > >>
> > >>> Hi all,
> > >>>
> > >>> I finally got an OFBiz dashboard working. See
> > >>>
> > >>
> >
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12310603
> > >>> Best regards,
> > >>>
> > >>> Pierre Smits
> > >>>
> > >>> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> > >>> *Apache Directory <https://directory.apache.org>, PMC Member*
> > >>> Apache Incubator <https://incubator.apache.org>, committer
> > >>> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
> > >> privileges)
> > >>> since 2008*
> > >>> Apache Steve <https://steve.apache.org>, committer
> > >>>
> > >>>
> > >>> On Mon, May 6, 2019 at 9:22 AM Aditya Sharma <
> adityasha...@apache.org>
> > >>> wrote:
> > >>>
> > >>>> Thank you Suraj for your input!
> > >>>>
> > >>>> Thank you Jacques for sharing the insights.
> > >>>>
> > >>>> Thank you Pierre for your inputs. Initially, we will be adding basic
> > >>>> statistics (just like February 2018 blog) but definitely, we will
> look
> > >>> into
> > >>>> the possibility of enriching it with more useful information.
> > >>>>
> > >>>> Thank you Sharan for your inputs. We will definitely ensure that it
> > >>> doesn't
> > >>>> get into that direction. Thank you for your efforts in Kibble.
> Indeed,
> > >>> It's
> > >>>> an amazing tool.
> > >>>>
> > >>>> --
> > >>>> Thanks and Regards,
> > >>>> Aditya Sharma
> > >>>>
> > >>>> On Sun, May 5, 2019 at 4:57 PM Pierre Smits  >
> > >>>> wrote:
> > >>>>
> > >>>>> I truly appreciate initiatives like kibble, the various reporter
> > >>>> functions
> > >>>>> and other stuff that work towards showing the health of projects.
> > >>>>> Unfortunately these initiatives still have miles to go towards
> > >>> providing
> > >>>>> more meaning. Showing number of tickets opened and 

Re: [PROPOSAL] DataModel - Improve entities using fromPartyId & toPartyId

2019-05-17 Thread Rishi Solanki
Dear Pierre,
I agree on the point that the AgreementRole entity is not good example for
the point I would like to put. But yes I was on the similar lines that we
have role entities which allows multiple party to be in same role with
respect to any transaction.

@Michael Brohi, The invoice role entity also uses sales rep and bill from
vendor roles for the same invoice for different parties. Also in case of
reconciliation and settlement these roles can be enhanced as per business
requirement. So giving flexibility in data model seems fine to me.

I'm okay with from/to party concept for the cases where large amount of
data may exists for those entities like order, invoice and other. It is
denormalised data form but requires in case of large amount of data where
two direct (primary) parties involve. And secondary parties linked thru
role entities.

My basic idea is to think on each entity before considering it for this
improvement or considering for role entity extension, on the basis of
following questions;
- Is it core entity which may have large amount of data?
- Are two primary parties can be identified for that entity?
- Are secondary parties can be identified for that entity?
- Possible business cases if possible.

I just wanted to suggest go slow for these changes as these are core
changes. We can list all entities and I would be happy to help list
entities and research around it. So that we will be confident to proceed
with. Side note Any change requires entity, service and other business call
changes as well.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Fri, May 17, 2019 at 1:55 AM Michael Brohl 
wrote:

> Hi Pierre,
>
> I think there are more sophisticated concepts for some of the mentioned
> entities, for example
>
> - OrderRole for orders allows to connect an unlimited number of parties
> with different roles
>
> - CustRequestParty, QuoteRole, CustRequestRole - same principle
>
> For these, introducing from/toPartyId would be no improvement IMO. *If*
> we would want to make a change, I would tend more to implementing the
> ...Role principle where it is missing and get rid of the from/toPartyId
> pattern. But this would be a big change...
>
> I'm not sure why we have these in some entities which also have the
> ...Role entities, such as Invoice.
>
> Maybe others can give more insights?
>
> Regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 13.05.19 um 13:41 schrieb Pierre Smits:
> > Hi All,
> >
> > Currently several entities capture the (contractual) parties in fields
> like
> > fromPartyId and toPartyId. These parties commonly represent the internal
> > (accounting) organisation and the external party (the customer, supplier,
> > contact, account, carrier etc).
> >
> > Such entities are:
> >
> > - Agreement (in party)
> > - Employment (in humanres)
> > - Invoice (in accounting
> > - OrderReportPurchasesGroupByProduct
> > - PartyBenefit (in humanres)
> > - Payment (in accounting)
> > - PayHistory (in humanres)
> > - ReturnHeader (in Order)
> > - UnemploymentClaim (in humanres
> >
> >
> > However there are a (quite a) few entities that defy these 1-on-1
> > relationships (between internal party and the object, and the external
> > party and the object), like:
> >
> > - OrderHeader: neither partyIdFrom nor partyIdTo
> > - Quote: neither partyIdFrom nor partyIdTo but having a partyId field
> > - CustRequest: only having fromPartyid (plus its role
> > - Subscription: having originatedFromPartyId (plus the role) and
> partyId
> > - ReorderGuideline: having partyId (plus the role)
> >
> > And I am confident I am missing a few.
> >
> > In oder to simplify processes for capturing the main parties in various
> > entity records I propose to realign these (master) entities to ensure
> that
> > both the primary internal and external parties (and their primary roles)
> > are captured.
> >
> > What are your thoughts?
> >
> > Best regards,
> >
> > Pierre Smits
> >
> > *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> > *Apache Directory <https://directory.apache.org>, PMC Member*
> > Apache Incubator <https://incubator.apache.org>, committer
> > *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
> privileges)
> > since 2008*
> > Apache Steve <https://steve.apache.org>, committer
> >
>
>


Re: Code Improvement for Groovy

2019-05-15 Thread Rishi Solanki
+1

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Wed, May 15, 2019 at 8:33 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Pawan,
>
> Sure, we use that from start a lot. But some don't it seems. A Jira fits
> with me
>
> Le 15/05/2019 à 14:29, Pawan Verma a écrit :
> > Hello Devs,
> >
> > As we all know, Groovy is a powerful language with great built-in
> > functions. Groovy Truth[1] is one of them, which is not used properly in
> > our code base. We have used UtilValidate Class to validate arguments for
> > Empty or NotEmpty, which can easily be done in groovy with built-in
> > functionality.
> >
> > Current Code: if (UtilValidate.isNotEmpty(locations)) { ... }
> >
> > Groovy Built-in Code: if (locations) { ... }
> >
> > IMO, We should use this Groovy Truth feature instead of UtilValidate
> Class.
> > Please let me know your thoughts on this. Thanks!
> > [1] - http://groovy-lang.org/semantics.html#Groovy-Truth
> >
> > --
> > Kind Regards
> > Pawan Verma
> > Technical Consultant
> > *HotWax Systems*
> >
>


Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-05-14 Thread Rishi Solanki
Below are the test cases failure list on running "cleanAll loadAll
testIntegration"
1) [JUNIT (failure)] - production-run-tests.testCreateProductionRunForOrder
: Assertion failed: ( NOT empty[originalOrderItemShipGrpInvRes=null])
2) [JUNIT (failure)] -
invoice-per-shipment-tests.testInvoicePerShipmentSetFalse : No inventory
reservations available; cannot pack this item! [101]
3) [JUNIT (failure)] - productRentalOrder-test : Warning: no shipments
created; could not find anything ready and needing to be shipped.
4) [JUNIT (failure)] - productServiceOrder-test : Warning: no shipments
created; could not find anything ready and needing to be shipped.
5) [JUNIT (failure)] - configurableServiceOrder-test : Warning: no
shipments created; could not find anything ready and needing to be shipped.
6) [JUNIT (failure)] - production-run-tests.testCreateProductionRunForOrder
: Assertion failed: ( NOT empty[originalOrderItemShipGrpInvRes=null])
7) [JUNIT (failure)] -
invoice-per-shipment-tests.testInvoicePerShipmentSetFalse : No inventory
reservations available; cannot pack this item! [101]

Are these are somehow related to message component?

Looking more if data in the message component loaded or not. If found
something then will come back.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Tue, May 14, 2019 at 2:15 PM Rishi Solanki 
wrote:

> Jacques,
> I have completed my in hand items and closed the ticket -
> https://issues.apache.org/jira/browse/OFBIZ-10457
>
> Nothing is pending in my knowledge also sms settings are disabled by
> default. I'll check the tests in case something is not working due to
> message component then I will fix that. If you have something handy to fix
> then please share, I will look into it.
>
> I will get back on this soon. Thanks!
>
> Best Regards,
> --
> *Rishi Solanki* | Sr Manager, Enterprise Software Development
> HotWax Systems <http://www.hotwaxsystems.com/>
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore, M.P 452010
> Linkedin: *Rishi Solanki*
> <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> Direct: +91-9893287847
>
>
> On Mon, May 13, 2019 at 12:56 PM Suraj Khurana 
> wrote:
>
>> Thanks, Jacques for details and findings.
>> I think this thread is now concluded. :)
>>
>> --
>> Best Regards,
>> Suraj Khurana
>> Technical Consultant
>>
>>
>>
>>
>>
>> On Mon, May 13, 2019 at 12:48 PM Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> > Oh, rather better refer to
>> > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins
>> >
>> > So it's at
>> > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/769
>> and
>> > the msggateway component
>> >
>> > We know Rishi is working on it
>> >
>> > Le 13/05/2019 à 06:35, Jacques Le Roux a écrit :
>> > > At least I can say that it was before March 30:
>> > >
>> > > https://ci.apache.org/builders/ofbizTrunkFramework?numbuilds=100
>> > >
>> > > Le 13/05/2019 à 06:28, Jacques Le Roux a écrit :
>> > >> Thanks Suraj,
>> > >>
>> > >> Unfortunately since another issue came in and it's now harder to
>> > detect.:
>> > >>
>> > >><> [101]>>
>> > >>
>> > >> Have you an idea?
>> > >>
>> > >> Thanks
>> > >>
>> > >> Jacques
>> > >>
>> > >> Le 11/05/2019 à 13:59, Suraj Khurana a écrit :
>> > >>> Hello,
>> > >>>
>> > >>> Done at rev #1859111
>> > >>>
>> > >>> --
>> > >>> Best Regards,
>> > >>> Suraj Khurana
>> > >>> Technical Consultant
>> > >>>
>> > >>>
>> > >>>
>> > >>>
>> > >>>
>> > >>> On Fri, May 10, 2019 at 11:24 AM Suraj Khurana <
>> > suraj.khur...@hotwax.co>
>> > >>> wrote:
>> > >>>
>> > >>>> Sure Jacques,
>> > >>>>
>> > >>>> I will get this done by the weekend. Please proceed in case of any
>> > blocker
>> > >>>> or urgency. I am also inclined with your thoughts.
>> > >>>> Thanks in advance !!
>&g

Re: [PROPOSAL] DataModel - Improve entities using fromPartyId & toPartyId

2019-05-14 Thread Rishi Solanki
Dear Pierre,
Few inputs for thoughts;

One agreement from company to multiple parties may exists. For example;
>From Company if sale is more than $10,000 then company may credit/discount
10% of sale to its suppliers. Then it will be applicable to more than one
supplier, then AgreementRole entity is suitable in that case.

To be clarify I'm not against this proposal because other entities in the
list are good candidate for this. Also following common pattern is good
reason to go with this, may be we can add or filter some entities.

But I will be able to say yes/no for the proposal after some more inputs
come from community.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Mon, May 13, 2019 at 5:11 PM Pierre Smits  wrote:

> Hi All,
>
> Currently several entities capture the (contractual) parties in fields like
> fromPartyId and toPartyId. These parties commonly represent the internal
> (accounting) organisation and the external party (the customer, supplier,
> contact, account, carrier etc).
>
> Such entities are:
>
>- Agreement (in party)
>- Employment (in humanres)
>- Invoice (in accounting
>- OrderReportPurchasesGroupByProduct
>- PartyBenefit (in humanres)
>- Payment (in accounting)
>- PayHistory (in humanres)
>- ReturnHeader (in Order)
>- UnemploymentClaim (in humanres
>
>
> However there are a (quite a) few entities that defy these 1-on-1
> relationships (between internal party and the object, and the external
> party and the object), like:
>
>- OrderHeader: neither partyIdFrom nor partyIdTo
>- Quote: neither partyIdFrom nor partyIdTo but having a partyId field
>- CustRequest: only having fromPartyid (plus its role
>- Subscription: having originatedFromPartyId (plus the role) and partyId
>- ReorderGuideline: having partyId (plus the role)
>
> And I am confident I am missing a few.
>
> In oder to simplify processes for capturing the main parties in various
> entity records I propose to realign these (master) entities to ensure that
> both the primary internal and external parties (and their primary roles)
> are captured.
>
> What are your thoughts?
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
> since 2008*
> Apache Steve <https://steve.apache.org>, committer
>


Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-05-14 Thread Rishi Solanki
Jacques,
I have completed my in hand items and closed the ticket -
https://issues.apache.org/jira/browse/OFBIZ-10457

Nothing is pending in my knowledge also sms settings are disabled by
default. I'll check the tests in case something is not working due to
message component then I will fix that. If you have something handy to fix
then please share, I will look into it.

I will get back on this soon. Thanks!

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Mon, May 13, 2019 at 12:56 PM Suraj Khurana 
wrote:

> Thanks, Jacques for details and findings.
> I think this thread is now concluded. :)
>
> --
> Best Regards,
> Suraj Khurana
> Technical Consultant
>
>
>
>
>
> On Mon, May 13, 2019 at 12:48 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Oh, rather better refer to
> > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins
> >
> > So it's at
> > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/769 and
> > the msggateway component
> >
> > We know Rishi is working on it
> >
> > Le 13/05/2019 à 06:35, Jacques Le Roux a écrit :
> > > At least I can say that it was before March 30:
> > >
> > > https://ci.apache.org/builders/ofbizTrunkFramework?numbuilds=100
> > >
> > > Le 13/05/2019 à 06:28, Jacques Le Roux a écrit :
> > >> Thanks Suraj,
> > >>
> > >> Unfortunately since another issue came in and it's now harder to
> > detect.:
> > >>
> > >>< [101]>>
> > >>
> > >> Have you an idea?
> > >>
> > >> Thanks
> > >>
> > >> Jacques
> > >>
> > >> Le 11/05/2019 à 13:59, Suraj Khurana a écrit :
> > >>> Hello,
> > >>>
> > >>> Done at rev #1859111
> > >>>
> > >>> --
> > >>> Best Regards,
> > >>> Suraj Khurana
> > >>> Technical Consultant
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>> On Fri, May 10, 2019 at 11:24 AM Suraj Khurana <
> > suraj.khur...@hotwax.co>
> > >>> wrote:
> > >>>
> > >>>> Sure Jacques,
> > >>>>
> > >>>> I will get this done by the weekend. Please proceed in case of any
> > blocker
> > >>>> or urgency. I am also inclined with your thoughts.
> > >>>> Thanks in advance !!
> > >>>>
> > >>>> --
> > >>>> Best Regards,
> > >>>> Suraj Khurana
> > >>>> Technical Consultant
> > >>>>
> > >>>> *HotWax Systems Pvt. Ltd*
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>> On Thu, May 9, 2019 at 3:17 PM Jacques Le Roux <
> > >>>> jacques.le.r...@les7arts.com> wrote:
> > >>>>
> > >>>>> Hi Suraj,
> > >>>>>
> > >>>>> Any chances? I don't mind duplicated data as I mentioned answering
> to
> > >>>>> Pierre
> > >>>>>
> > >>>>> Thanks
> > >>>>>
> > >>>>> Jacques
> > >>>>>
> > >>>>> Le 27/04/2019 à 15:36, Jacques Le Roux a écrit :
> > >>>>>> Thanks Suraj,
> > >>>>>>
> > >>>>>> Can't we avoid the duplicated data?
> > >>>>>>
> > >>>>>> Jacques
> > >>>>>>
> > >>>>>> Le 27/04/2019 à 15:17, Suraj Khurana a écrit :
> > >>>>>>> Hello team,
> > >>>>>>>
> > >>>>>>> I have checked and found that there is a data dependency of
> > >>>>>>> workEffortId=9000 in the test case which is available in
> > >>>>> plugins/projectmgr
> > >>>>>>> component.
> > >>>>>>>
> > >>>>>>> This was the main reason testIntegration was failing without
> having
> > >>>>> plugins
> > >>&

Re: ExternalId support in relevant entities

2019-05-03 Thread Rishi Solanki
Hello Scott, Jacques,
IMO this kind of requirement requires only for few entities not all. So
creating a generic pattern like EntityAuditLog or SequenceValueItem which
is in general applicable to most of the entity as per requirement may give
signal or OFBiz user that this is something which is globally work with
OFBiz data model. May lead OFBiz user to apply it on wrong entities.
While migrating the data from legacy system or integrating data from some
third party system causes such type of requirement. In general, it requires
only one externalId and if more requires then we use other fields of the
entity if possible or simply use Attributes entity. And these patterns are
already adopted, so I think we should think on already adopted pattern once
more.
May be we can filter the entity list from the proposal or we can choose to
ad more identification entities (5 to 10 in range) or externalId. But we
should try to go with existing pattern. And yes brainstorming on each
entity to be include must be there in process of finalizing this thread.

Also agree on all downsides mentioned by Scott. My vote is for having
identification entity pattern like GoodIdentification, PartyIdentification
or externalId after discussion on minimum set of entities. We should have
some use cases which is not specific to resolve only one problem then we
can finalize the solution.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Fri, May 3, 2019 at 11:59 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks Scott,
>
> I think that if it's well documented the EntityIdentification could be a
> good solution to this problem
>
> Jacques
>
> Le 02/05/2019 à 22:24, Scott Gray a écrit :
> > I'd tend to agree with Pierre here, following the {entity}Identification
> > pattern is probably a better approach long term simply because the
> > externalId pattern breaks as soon as you need more than one identifier.
> If
> > the likelihood of multiple IDs is low, then the {entity}Attribute pattern
> > might be a better approach.
> >
> > But with that said, when customizing a system I'll typically just throw
> an
> > additional field on the entity and be done with it.  It doesn't take long
> > to write a helper method get{Entity}ByExternalId(String) to hook it up.
> > Because there's very little business logic that OFBiz can attach to these
> > fields, the amount of time we can save developers by having these fields
> > available in advance is very small.  That changes with the Identification
> > pattern because we can provide from/thru dating, enforce unique
> constraints
> > and regex patterns etc. which will save developers more time.
> >
> > Regarding Facility, it's useful to have an external identifier when
> you're
> > integrating/syncing with a 3PL system or in general if you don't own the
> > facility that you're using.  But that could be said of almost any table
> in
> > the system when you need to keep it in sync with another.
> >
> > I almost wonder if a generic entity (EntityIdentification) would be a
> > better approach that contains something like:
> > - entityName
> > - entityId
> > - fromDate
> > - thruDate
> > - idType
> > - value
> > We could then provide a set of generic helper methods/services to perform
> > lookups and update values e.g. GenericValue facility =
> > getEntityById("Facility", "3PL", "123").  The CRUD services could use
> > another table (EntityIdentificationType) to help with enforcing
> contraints:
> > - entityName
> > - idType
> > - requireUnique
> > - validationRegex
> >
> > The main downsides would be:
> > - Duplication with the current Identification pattern (confusion)
> > - Lack of foreign keys back to the entities being identified
> > - Largely unused pattern in general currently (I think only
> EntityAuditLog
> > is similar)
> >
> > Regards
> > Scott
> >
> > On Fri, 3 May 2019 at 00:33, Pierre Smits 
> wrote:
> >
> >> Current methodology of having the externalId field in the various
> tables is
> >> limiting the capabilities of OFBiz. With this an object can have only 1
> >> externalId value. However, it is quite feasible that an object can be
> >> associated with various external systems with each having a different
> >> externalId value. This is particularly true for the party entity.
> >>
> >> I wonder whether this is necessary for a facility. If a supplier has 

Re: Applicable Promo Recommendations

2019-05-02 Thread Rishi Solanki
Dear Swapnil,
Got the point, thanks for the details and clarifying it. As per current
flow, system creates exchange/replacement orders. And in
exchange/replacement order it applies promotion from promo engine as new
exchange/replacement order created. For the refund/adjustment net amount
calculation it uses the original order calculation. For new order it uses
promo engine, so return amount calculation and new order amount calculation
treated differently.

I would say it is very good concern and should be taken care (test and then
fix if any issue found) of handling returns against each order. And I think
we can separate that work from weather the promo applying automatically or
manually on original order. Also return policy differ business to business
and promo apply accordingly on return exchange order.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Thu, May 2, 2019 at 12:14 AM Swapnil Shah 
wrote:

> Actually my (and possibly Pierre's) concern was bit different. Many a times
> system needs to allow exchanging the originally ordered item with a
> different item. In such cases if it starts auto-inheriting the adjustments
> then customer can start gaming the system by purchasing the discounted
> items
> and exchanging it with full priced or lesser discounted items.
>
> For example, customer originally purchases $100 item at 20% discount
> (doesn't matter whether default or overridden from eligible set of active
> promotion). Now returns it and get it exchanged with another $100 item
> which
> doesn't have any active applicable promotions and is currently being sold
> at
> fully price. If system always inherit and auto-apply the adjustments from
> originally ordered item then my store would end up actually selling a
> non-discounted item at 20% discount.
>
> A possible solution could be that while exchanging the item, system can
> check whether the exchanged item is eligible for same promotion as that of
> returned item or not. If yes inherit and apply the same adjustments else
> not. Here again authorized user with desired permissions can be allow to
> manually override it later if required.
>
> Thanks,
> Swapnil
>
> -Original Message-
> From: Rishi Solanki 
> Sent: Wednesday, May 01, 2019 6:49 PM
> To: dev@ofbiz.apache.org
> Subject: Re: Applicable Promo Recommendations
>
> Some addition details I could think of, thanks for raising this point.
> One use case to be consider as per Swapnil comment, but it is not
> implemented in OFBiz. If business take returns of Non Order Items (Items
> purchased but Order does not exists in the system). In this case depending
> upon the business requirement system may need to identify the applicable
> promotion on return. For now it is handle with manual adjustment in current
> flow.
> Right now non order item return not supported in current process flow. But
> we should surely take care of this corner case, when we think of
> implementing non order item return.
>
> Best Regards,
> --
> *Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax
> Systems
> <http://www.hotwaxsystems.com/> Plot no. 80, Scheme no. 78 Part 2, Near
> Brilliant Convention Center, Indore, M.P 452010
> Linkedin: *Rishi Solanki*
> <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> Direct: +91-9893287847
>
>
> On Wed, May 1, 2019 at 6:13 PM Rishi Solanki 
> wrote:
>
> > Dear Swapnil/Pierre,
> > Thanks for more thoughts on the subject. The return
> > (refund/replacement/exchange) always use original order adjustments
> > for return. No promo engine or price rule engine run in that case.
> > This is because return adjustments always depends on the order
> > adjustment. The only flexibility OFBiz workflow provides to add manual
> > adjustments in case of conflict.
> >
> > IMO we are good to go with proposal. As return never use the promo
> > engine to apply promo and it is only work for order as per the current
> > flow.
> >
> > Best Regards,
> > --
> > *Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax
> > Systems <http://www.hotwaxsystems.com/> Plot no. 80, Scheme no. 78
> > Part 2, Near Brilliant Convention Center, Indore, M.P 452010
> > Linkedin: *Rishi Solanki*
> > <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> > Direct: +91-9893287847
> >
> >
> > On Wed, May 1, 2019 at 1:42 PM Pierre Smits 
> > wrote:
> >
> >> Thanks

Re: Applicable Promo Recommendations

2019-05-01 Thread Rishi Solanki
Some addition details I could think of, thanks for raising this point.
One use case to be consider as per Swapnil comment, but it is not
implemented in OFBiz. If business take returns of Non Order Items (Items
purchased but Order does not exists in the system). In this case depending
upon the business requirement system may need to identify the applicable
promotion on return. For now it is handle with manual adjustment in current
flow.
Right now non order item return not supported in current process flow. But
we should surely take care of this corner case, when we think of
implementing non order item return.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Wed, May 1, 2019 at 6:13 PM Rishi Solanki 
wrote:

> Dear Swapnil/Pierre,
> Thanks for more thoughts on the subject. The return
> (refund/replacement/exchange) always use original order adjustments for
> return. No promo engine or price rule engine run in that case. This is
> because return adjustments always depends on the order adjustment. The only
> flexibility OFBiz workflow provides to add manual adjustments in case of
> conflict.
>
> IMO we are good to go with proposal. As return never use the promo engine
> to apply promo and it is only work for order as per the current flow.
>
> Best Regards,
> --
> *Rishi Solanki* | Sr Manager, Enterprise Software Development
> HotWax Systems <http://www.hotwaxsystems.com/>
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore, M.P 452010
> Linkedin: *Rishi Solanki*
> <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> Direct: +91-9893287847
>
>
> On Wed, May 1, 2019 at 1:42 PM Pierre Smits 
> wrote:
>
>> Thanks Swapnil, for your posting as it triggered a thought about gaming
>> the
>> promotions by e-commerce customer.
>>
>> The though was: is this not opening up the whole for nefarious e-commerce
>> customers to game the functionalities in their favour (and to the
>> disadvantage of the adopter and its other customers) regarding ordering
>> and
>> returning goods as such?
>>
>> I don't have that full picture yet, so it may be a non-issue. But on the
>> other hand better safe than sorry, right?
>>
>> Best regards,
>>
>> Pierre Smits
>>
>> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
>> *Apache Directory <https://directory.apache.org>, PMC Member*
>> Apache Incubator <https://incubator.apache.org>, committer
>> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
>> privileges)
>> since 2008*
>> Apache Steve <https://steve.apache.org>, committer
>>
>>
>> On Wed, May 1, 2019 at 9:49 AM Swapnil Shah <
>> swapnil.s...@hotwaxsystems.com>
>> wrote:
>>
>> > I am not sure if it might require an add-on handling or not but can
>> someone
>> > please test or make sure that exchange orders against the originally
>> > ordered
>> > style/assortment inherit the order adjustments from original order
>> (instead
>> > of auto applying the default promo again) or at least provide the same
>> > manual overriding options so as to make sure that exchange invoices are
>> in
>> > coherence with the original order invoice.
>> >
>> > Thanks,
>> > Swapnil
>> >
>> > -Original Message-
>> > From: Rishi Solanki 
>> > Sent: Sunday, April 28, 2019 4:09 AM
>> > To: dev@ofbiz.apache.org
>> > Subject: Applicable Promo Recommendations
>> >
>> > Devs,
>> > I would like to propose the user selection ability for promotion. That
>> > means
>> > user can select her own choice of promotion from the list of promotion
>> > applicable to current cart. Right now promotion engine based on
>> algorithm
>> > implemented decide which promotion will be apply to cart from the list
>> of
>> > promotion. For example, if promotion engine find 3 promotion applicable
>> for
>> > the current cart then based on algorithm implemented it apply the
>> maximum
>> > amount value promotion to the cart.
>> >
>> > Coming back to proposal with some use cases;
>> >
>> > Use Case 1: Promotion engine find three promotions applicable to cart or
>> > item as P1, P2 and P3. And as per algorithm promo engine deci

Re: Applicable Promo Recommendations

2019-05-01 Thread Rishi Solanki
Dear Swapnil/Pierre,
Thanks for more thoughts on the subject. The return
(refund/replacement/exchange) always use original order adjustments for
return. No promo engine or price rule engine run in that case. This is
because return adjustments always depends on the order adjustment. The only
flexibility OFBiz workflow provides to add manual adjustments in case of
conflict.

IMO we are good to go with proposal. As return never use the promo engine
to apply promo and it is only work for order as per the current flow.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Wed, May 1, 2019 at 1:42 PM Pierre Smits  wrote:

> Thanks Swapnil, for your posting as it triggered a thought about gaming the
> promotions by e-commerce customer.
>
> The though was: is this not opening up the whole for nefarious e-commerce
> customers to game the functionalities in their favour (and to the
> disadvantage of the adopter and its other customers) regarding ordering and
> returning goods as such?
>
> I don't have that full picture yet, so it may be a non-issue. But on the
> other hand better safe than sorry, right?
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
> since 2008*
> Apache Steve <https://steve.apache.org>, committer
>
>
> On Wed, May 1, 2019 at 9:49 AM Swapnil Shah <
> swapnil.s...@hotwaxsystems.com>
> wrote:
>
> > I am not sure if it might require an add-on handling or not but can
> someone
> > please test or make sure that exchange orders against the originally
> > ordered
> > style/assortment inherit the order adjustments from original order
> (instead
> > of auto applying the default promo again) or at least provide the same
> > manual overriding options so as to make sure that exchange invoices are
> in
> > coherence with the original order invoice.
> >
> > Thanks,
> > Swapnil
> >
> > -Original Message-
> > From: Rishi Solanki 
> > Sent: Sunday, April 28, 2019 4:09 AM
> > To: dev@ofbiz.apache.org
> > Subject: Applicable Promo Recommendations
> >
> > Devs,
> > I would like to propose the user selection ability for promotion. That
> > means
> > user can select her own choice of promotion from the list of promotion
> > applicable to current cart. Right now promotion engine based on algorithm
> > implemented decide which promotion will be apply to cart from the list of
> > promotion. For example, if promotion engine find 3 promotion applicable
> for
> > the current cart then based on algorithm implemented it apply the maximum
> > amount value promotion to the cart.
> >
> > Coming back to proposal with some use cases;
> >
> > Use Case 1: Promotion engine find three promotions applicable to cart or
> > item as P1, P2 and P3. And as per algorithm promo engine decide to apply
> > P1.
> > Now if user want to go with P2 or P3 then she can do that.
> >
> > Use Case 2: In #1 user can also choose to not take any promotion, remove
> > the
> > P1 and submit the order without promotion.
> >
> > Use Case 3: Item1 and item2 will have two promotions common as P1 and P2.
> > Now user can opt which promotion should applicable to which item. That
> > means
> > user can apply P1 or P2 on item1 or item2 based on her preference.
> >
> > Use Case 4: In #3 if user wants then she can opt to select promotion for
> > one
> > item and can remove promo from other.
> >
> >
> > Looking forward for valuable feedback on proposal and suggestion on
> design
> > from community. Also please feel free to ask for more details on each use
> > case or on proposal itself.
> >
> >
> > Thanks!
> >
> > Best Regards,
> > --
> > *Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax
> > Systems
> > <http://www.hotwaxsystems.com/> Plot no. 80, Scheme no. 78 Part 2, Near
> > Brilliant Convention Center, Indore, M.P 452010
> > Linkedin: *Rishi Solanki*
> > <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> > Direct: +91-9893287847
> >
>


Re: Manufacturer Support In Promotion Engine

2019-05-01 Thread Rishi Solanki
Thank you all for your help and suggestions, below is the Jira ticket for
the same;
- https://issues.apache.org/jira/browse/OFBIZ-11002

Best Regards

*--*
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Tue, Apr 30, 2019 at 10:37 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> I can't see a problem with optional promotions
>
> Jacques
>
> Le 29/04/2019 à 15:44, Rishi Solanki a écrit :
> > Swapnil/Pierre,
> > Thanks for your inputs. We can go with both promotion and price rules. I
> > mean we can add support at both level, and depending upon the business
> > requirement users can decide the solutions to go with.
> >
> > In case no one objects then will file Jira for this new feature
> enhancement
> > and propose design for it.
> >
> > Best Regards,
> > --
> > *Rishi Solanki* | Sr Manager, Enterprise Software Development
> > HotWax Systems <http://www.hotwaxsystems.com/>
> > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore,
> > M.P 452010
> > Linkedin: *Rishi Solanki*
> > <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> > Direct: +91-9893287847
> >
> >
> > On Sun, Apr 28, 2019 at 6:57 PM Pierre Smits 
> wrote:
> >
> >> I would consider to talk about supplier promotions, because it can also
> >> involve wholesale suppliers.
> >>
> >> I am inclined to agree with the latest posting by Swapnil.
> >>
> >> Whether a supplier promotion is passed to customers is a commercial (
> >> decision, and may be subject to the agreement between the internal party
> >> and the supplier. But they are always intended to drive sales (from the
> >> supplier to the customer, meaning purchases from the internal party to
> the
> >> supplier).
> >>
> >> When the supplier promotion involves an internal runner (a product that
> >> sells well), then the supplier promotion is often not passed down to the
> >> customer.
> >>
> >> Best regards,
> >>
> >> Pierre Smits
> >>
> >> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> >> *Apache Directory <https://directory.apache.org>, PMC Member*
> >> Apache Incubator <https://incubator.apache.org>, committer
> >> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
> privileges)
> >> since 2008*
> >> Apache Steve <https://steve.apache.org>, committer
> >>
> >>
> >> On Sun, Apr 28, 2019 at 2:43 PM Swapnil Shah <
> >> swapnil.s...@hotwaxsystems.com>
> >> wrote:
> >>
> >>> It should be nice add. However i would have more more liked to have it
> >>> supported in the form of Price Rule as well (if it isn't already).
> Many a
> >>> times the mark down or mark up by manufacturers are not necessarily
> meant
> >>> to be propogated as adjustment on top of the existing price to the end
> >>> customer. Instead it should be directly billed at the revised prices
> from
> >>> the manufacturer.
> >>>
> >>> Thanks,
> >>> Swapnil
> >>>
> >>> On Sat, Apr 27, 2019 at 6:32 PM Rishi Solanki  >
> >>> wrote:
> >>>
> >>>> Devs,
> >>>> Currently promotion engine support all the discount based on party,
> >>>> category, party role, party classification, shipping etc.. And
> >> promotion
> >>>> engine based on the condition decide that the promotion will apply for
> >>>> customer purchase over the cart or cart item depending upon the
> action.
> >>>>
> >>>> I would like to propose to add support in promotion engine, so that ,
> >> we
> >>>> can add promotion against manufacturing party and should apply to all
> >> the
> >>>> products manufactured by that party.
> >>>>
> >>>> For example;
> >>>> M1, M2 are two manufacturers.
> >>>> M1P1 and M1P2 are products manufactured by M1.
> >>>> M2P1 and M2P2 are products manufactured by M2.
> >>>>
> >>>> Now M1 gives 10% discount on all products M1, and if customer purchase
> >>> all
> >>>> products with quantity ONE.
> >>>>
> >>>> Assuming all items price is $100. Then CartTotal will be $400 and
> >>> discount
> >>>> amount will be $20. As discount is on M1 products only.
> >>>>
> >>>> Best Regards,
> >>>> --
> >>>> *Rishi Solanki* | Sr Manager, Enterprise Software Development
> >>>> HotWax Systems <http://www.hotwaxsystems.com/>
> >>>> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> >>>> Indore,
> >>>> M.P 452010
> >>>> Linkedin: *Rishi Solanki*
> >>>> <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> >>>> Direct: +91-9893287847
> >>>>
>


Re: Applicable Promo Recommendations

2019-04-30 Thread Rishi Solanki
Thank you all for your help and suggestions, below is the Jira ticket for
the same;
- https://issues.apache.org/jira/browse/OFBIZ-11001

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Wed, May 1, 2019 at 10:55 AM Sanjay Yadav 
wrote:

> +1 for all use cases. Thanks, Rishi.
>
> Best Regards,
>
> *Sanjay Yadav* | Manager, QA
> HotWax Systems <http://www.hotwaxsystems.com/>
> 80, Scheme No. 78, Indore, M.P. 452010, India
> Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
> <https://www.linkedin.com/in/sanjay-yadav/>
>
>
> On Sun, Apr 28, 2019 at 4:33 AM Rishi Solanki 
> wrote:
>
> > Devs,
> > I would like to propose the user selection ability for promotion. That
> > means user can select her own choice of promotion from the list of
> > promotion applicable to current cart. Right now promotion engine based on
> > algorithm implemented decide which promotion will be apply to cart from
> the
> > list of promotion. For example, if promotion engine find 3 promotion
> > applicable for the current cart then based on algorithm implemented it
> > apply the maximum amount value promotion to the cart.
> >
> > Coming back to proposal with some use cases;
> >
> > Use Case 1: Promotion engine find three promotions applicable to cart or
> > item as P1, P2 and P3. And as per algorithm promo engine decide to apply
> > P1. Now if user want to go with P2 or P3 then she can do that.
> >
> > Use Case 2: In #1 user can also choose to not take any promotion, remove
> > the P1 and submit the order without promotion.
> >
> > Use Case 3: Item1 and item2 will have two promotions common as P1 and P2.
> > Now user can opt which promotion should applicable to which item. That
> > means user can apply P1 or P2 on item1 or item2 based on her preference.
> >
> > Use Case 4: In #3 if user wants then she can opt to select promotion for
> > one item and can remove promo from other.
> >
> >
> > Looking forward for valuable feedback on proposal and suggestion on
> design
> > from community. Also please feel free to ask for more details on each use
> > case or on proposal itself.
> >
> >
> > Thanks!
> >
> > Best Regards,
> > --
> > *Rishi Solanki* | Sr Manager, Enterprise Software Development
> > HotWax Systems <http://www.hotwaxsystems.com/>
> > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> > Indore,
> > M.P 452010
> > Linkedin: *Rishi Solanki*
> > <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> > Direct: +91-9893287847
> >
>


Re: Applicable Promo Recommendations

2019-04-30 Thread Rishi Solanki
Devanshu,
Thanks for your reply and help offered. The feature will not be
configurable but the promotions could be, that means from the applicable
list of promotions to cart user will opt. It will be generic at cart level.
Below are applicability base idea, but for sure we can think of
configuration while designing this feature;
- User add an item to cart.
- Promo engine runs and identify 3 promos can be apply to cart. And as per
algorithm it apply one promo.
- Now user have the flexibility to change the default promo or remove it.
Right now I could not think of reason to make it configurable, but we will
discuss and rethink.
- On the whole feature is not to override the existing behavior, it just
give flexibility to user to choice.

Thanks again for putting more thought into this, it really helps.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Tue, Apr 30, 2019 at 11:39 AM Devanshu Vyas 
wrote:

> Such support in e-commerce sites is very common these days. So a +1 from my
> side.
>
> So what I understand from your proposal:
> * We will be modifying the promotion engine to not set any promotion on the
> cart
> * Let the user pick which promotion to be applied on the cart
>
> My initial thoughts(I may be going ahead of the discussion here, but bear
> with me :) )
> * All promotions applicable on the cart should be listed with the
> benefits(in terms of money value) so that the user can decide accordingly.
> * If one desires, it can be turned off. I mean, this feature should be
> configurable.
> * Let the user know if he/she forgets to set a promotion before checkout.
>
> I would like to extend my help in implementing this feature with you.
>
> Thanks & Regards,
> Devanshu Vyas.
>
>
> On Tue, Apr 30, 2019 at 11:02 AM Rishi Solanki 
> wrote:
>
> > Dear Pritam,
> > Thank you for your inputs, idea is to give flexibility to customer of
> > ecommerce site to apply or remove promotions of depending upon her
> > preferences.
> > The point raised for #3 and #4, is if an promotion has limit to apply per
> > customer as 1. Then customer may secure her promotion for next planned
> > order. It is kind of similar case when customer have promo code and she
> can
> > use once. The change behavior is customer do not have the promo code to
> use
> > instead have capability to remove or add promo of her own choice.
> >
> > I hope this clarifies the concern raised. Thanks!
> >
> > Best Regards,
> > --
> > *Rishi Solanki* | Sr Manager, Enterprise Software Development
> > HotWax Systems <http://www.hotwaxsystems.com/>
> > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> > Indore,
> > M.P 452010
> > Linkedin: *Rishi Solanki*
> > <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> > Direct: +91-9893287847
> >
> >
> > On Tue, Apr 30, 2019 at 10:20 AM Pritam Kute <
> > pritam.k...@hotwaxsystems.com>
> > wrote:
> >
> > > Hello Rishi,
> > >
> > > +1. This proposal looks good to me. Use Case 1 and 2 are very common
> > > nowadays on the various popular ecommerce sites. For use case 3 & 4, I
> > > never came across such a scenario in any e-commerce site but IMO, it is
> > > good to have feature.
> > >
> > > Let me know if you need any help from my side!
> > >
> > > Kind Regards,
> > > --
> > > Pritam Kute
> > >
> > >
> > > On Sun, Apr 28, 2019 at 4:33 AM Rishi Solanki  >
> > > wrote:
> > >
> > > > Devs,
> > > > I would like to propose the user selection ability for promotion.
> That
> > > > means user can select her own choice of promotion from the list of
> > > > promotion applicable to current cart. Right now promotion engine
> based
> > on
> > > > algorithm implemented decide which promotion will be apply to cart
> from
> > > the
> > > > list of promotion. For example, if promotion engine find 3 promotion
> > > > applicable for the current cart then based on algorithm implemented
> it
> > > > apply the maximum amount value promotion to the cart.
> > > >
> > > > Coming back to proposal with some use cases;
> > > >
> > > > Use Case 1: Promotion engine find three promotions applicable to cart
> > or
> > > > item as 

Re: Applicable Promo Recommendations

2019-04-29 Thread Rishi Solanki
Dear Pritam,
Thank you for your inputs, idea is to give flexibility to customer of
ecommerce site to apply or remove promotions of depending upon her
preferences.
The point raised for #3 and #4, is if an promotion has limit to apply per
customer as 1. Then customer may secure her promotion for next planned
order. It is kind of similar case when customer have promo code and she can
use once. The change behavior is customer do not have the promo code to use
instead have capability to remove or add promo of her own choice.

I hope this clarifies the concern raised. Thanks!

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Tue, Apr 30, 2019 at 10:20 AM Pritam Kute 
wrote:

> Hello Rishi,
>
> +1. This proposal looks good to me. Use Case 1 and 2 are very common
> nowadays on the various popular ecommerce sites. For use case 3 & 4, I
> never came across such a scenario in any e-commerce site but IMO, it is
> good to have feature.
>
> Let me know if you need any help from my side!
>
> Kind Regards,
> --
> Pritam Kute
>
>
> On Sun, Apr 28, 2019 at 4:33 AM Rishi Solanki 
> wrote:
>
> > Devs,
> > I would like to propose the user selection ability for promotion. That
> > means user can select her own choice of promotion from the list of
> > promotion applicable to current cart. Right now promotion engine based on
> > algorithm implemented decide which promotion will be apply to cart from
> the
> > list of promotion. For example, if promotion engine find 3 promotion
> > applicable for the current cart then based on algorithm implemented it
> > apply the maximum amount value promotion to the cart.
> >
> > Coming back to proposal with some use cases;
> >
> > Use Case 1: Promotion engine find three promotions applicable to cart or
> > item as P1, P2 and P3. And as per algorithm promo engine decide to apply
> > P1. Now if user want to go with P2 or P3 then she can do that.
> >
> > Use Case 2: In #1 user can also choose to not take any promotion, remove
> > the P1 and submit the order without promotion.
> >
> > Use Case 3: Item1 and item2 will have two promotions common as P1 and P2.
> > Now user can opt which promotion should applicable to which item. That
> > means user can apply P1 or P2 on item1 or item2 based on her preference.
> >
> > Use Case 4: In #3 if user wants then she can opt to select promotion for
> > one item and can remove promo from other.
> >
> >
> > Looking forward for valuable feedback on proposal and suggestion on
> design
> > from community. Also please feel free to ask for more details on each use
> > case or on proposal itself.
> >
> >
> > Thanks!
> >
> > Best Regards,
> > --
> > *Rishi Solanki* | Sr Manager, Enterprise Software Development
> > HotWax Systems <http://www.hotwaxsystems.com/>
> > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> > Indore,
> > M.P 452010
> > Linkedin: *Rishi Solanki*
> > <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> > Direct: +91-9893287847
> >
>


Re: Manufacturer Support In Promotion Engine

2019-04-29 Thread Rishi Solanki
Swapnil/Pierre,
Thanks for your inputs. We can go with both promotion and price rules. I
mean we can add support at both level, and depending upon the business
requirement users can decide the solutions to go with.

In case no one objects then will file Jira for this new feature enhancement
and propose design for it.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Sun, Apr 28, 2019 at 6:57 PM Pierre Smits  wrote:

> I would consider to talk about supplier promotions, because it can also
> involve wholesale suppliers.
>
> I am inclined to agree with the latest posting by Swapnil.
>
> Whether a supplier promotion is passed to customers is a commercial (
> decision, and may be subject to the agreement between the internal party
> and the supplier. But they are always intended to drive sales (from the
> supplier to the customer, meaning purchases from the internal party to the
> supplier).
>
> When the supplier promotion involves an internal runner (a product that
> sells well), then the supplier promotion is often not passed down to the
> customer.
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
> since 2008*
> Apache Steve <https://steve.apache.org>, committer
>
>
> On Sun, Apr 28, 2019 at 2:43 PM Swapnil Shah <
> swapnil.s...@hotwaxsystems.com>
> wrote:
>
> > It should be nice add. However i would have more more liked to have it
> > supported in the form of Price Rule as well (if it isn't already). Many a
> > times the mark down or mark up by manufacturers are not necessarily meant
> > to be propogated as adjustment on top of the existing price to the end
> > customer. Instead it should be directly billed at the revised prices from
> > the manufacturer.
> >
> > Thanks,
> > Swapnil
> >
> > On Sat, Apr 27, 2019 at 6:32 PM Rishi Solanki 
> > wrote:
> >
> > > Devs,
> > > Currently promotion engine support all the discount based on party,
> > > category, party role, party classification, shipping etc.. And
> promotion
> > > engine based on the condition decide that the promotion will apply for
> > > customer purchase over the cart or cart item depending upon the action.
> > >
> > > I would like to propose to add support in promotion engine, so that ,
> we
> > > can add promotion against manufacturing party and should apply to all
> the
> > > products manufactured by that party.
> > >
> > > For example;
> > > M1, M2 are two manufacturers.
> > > M1P1 and M1P2 are products manufactured by M1.
> > > M2P1 and M2P2 are products manufactured by M2.
> > >
> > > Now M1 gives 10% discount on all products M1, and if customer purchase
> > all
> > > products with quantity ONE.
> > >
> > > Assuming all items price is $100. Then CartTotal will be $400 and
> > discount
> > > amount will be $20. As discount is on M1 products only.
> > >
> > > Best Regards,
> > > --
> > > *Rishi Solanki* | Sr Manager, Enterprise Software Development
> > > HotWax Systems <http://www.hotwaxsystems.com/>
> > > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> > > Indore,
> > > M.P 452010
> > > Linkedin: *Rishi Solanki*
> > > <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> > > Direct: +91-9893287847
> > >
> >
>


Applicable Promo Recommendations

2019-04-27 Thread Rishi Solanki
Devs,
I would like to propose the user selection ability for promotion. That
means user can select her own choice of promotion from the list of
promotion applicable to current cart. Right now promotion engine based on
algorithm implemented decide which promotion will be apply to cart from the
list of promotion. For example, if promotion engine find 3 promotion
applicable for the current cart then based on algorithm implemented it
apply the maximum amount value promotion to the cart.

Coming back to proposal with some use cases;

Use Case 1: Promotion engine find three promotions applicable to cart or
item as P1, P2 and P3. And as per algorithm promo engine decide to apply
P1. Now if user want to go with P2 or P3 then she can do that.

Use Case 2: In #1 user can also choose to not take any promotion, remove
the P1 and submit the order without promotion.

Use Case 3: Item1 and item2 will have two promotions common as P1 and P2.
Now user can opt which promotion should applicable to which item. That
means user can apply P1 or P2 on item1 or item2 based on her preference.

Use Case 4: In #3 if user wants then she can opt to select promotion for
one item and can remove promo from other.


Looking forward for valuable feedback on proposal and suggestion on design
from community. Also please feel free to ask for more details on each use
case or on proposal itself.


Thanks!

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2019-04-27 Thread Rishi Solanki
I see below JUNIT failure as;
- shipment-tests.testPackingServices : Error trying to begin transaction,
could not process method: The current transaction is marked for rollback,
not beginning a new transaction and aborting current operation; the
rollbackOnly was caused by: Error in Service
[completeAllocationPlanItemByOrderItem]: ERROR : Allocation plan is not
available.: [DEMO10090:1]
- production-run-tests.testCreateProductionRunForOrder : Assertion failed:
( NOT empty[originalOrderItemShipGrpInvRes=null]
-
auto-accounting-transaction-tests-sales.testAcctgTransForSalesOrderShipments
: Error trying to begin transaction, could not process method: The current
transaction is marked for rollback, not beginning a new transaction and
aborting current operation; the rollbackOnly was caused by: Error in
Service [completeAllocationPlanItemByOrderItem]: ERROR : Allocation plan is
not available.: [DEMO10090:1]
- productRentalOrder-test : Warning: no shipments created; could not find
anything ready and needing to be shipped.

These are not related to my commit, will check more and see if can fix
them. Thanks!

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Sun, Apr 28, 2019 at 1:49 AM Rishi Solanki 
wrote:

> Jacques,
> I'm looking into this, thanks!
>
> Best Regards,
> --
> *Rishi Solanki* | Sr Manager, Enterprise Software Development
> HotWax Systems <http://www.hotwaxsystems.com/>
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore, M.P 452010
> Linkedin: *Rishi Solanki*
> <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> Direct: +91-9893287847
>
>
> On Sun, Apr 28, 2019 at 12:38 AM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
>> Hi Rishi,
>>
>> I reproduce locally but I don't understand why we have this problem (the
>> concerned data have no relation with the changed component)
>>
>> https://ci.apache.org/projects/ofbiz/logs/trunk/plugins/html/
>>
>> Also I still get the issue when I remove the plugin
>>
>> Thanks
>>
>> Jacques
>>
>> Le 27/04/2019 à 16:26, build...@apache.org a écrit :
>> > The Buildbot has detected a new failure on builder
>> ofbizTrunkFrameworkPlugins while building . Full details are available at:
>> >
>> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/769
>> >
>> > Buildbot URL: https://ci.apache.org/
>> >
>> > Buildslave for this Build: silvanus_ubuntu
>> >
>> > Build Reason: The AnyBranchScheduler scheduler named
>> 'onTrunkPluginsCommit' triggered this build
>> > Build Source Stamp: [branch ofbiz/ofbiz-plugins/trunk] 1858279
>> > Blamelist: rishi
>> >
>> > BUILD FAILED: failed shell_4
>> >
>> > Sincerely,
>> >   -The Buildbot
>> >
>> >
>> >
>> >
>>
>


Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2019-04-27 Thread Rishi Solanki
Jacques,
I'm looking into this, thanks!

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Sun, Apr 28, 2019 at 12:38 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Rishi,
>
> I reproduce locally but I don't understand why we have this problem (the
> concerned data have no relation with the changed component)
>
> https://ci.apache.org/projects/ofbiz/logs/trunk/plugins/html/
>
> Also I still get the issue when I remove the plugin
>
> Thanks
>
> Jacques
>
> Le 27/04/2019 à 16:26, build...@apache.org a écrit :
> > The Buildbot has detected a new failure on builder
> ofbizTrunkFrameworkPlugins while building . Full details are available at:
> >
> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/769
> >
> > Buildbot URL: https://ci.apache.org/
> >
> > Buildslave for this Build: silvanus_ubuntu
> >
> > Build Reason: The AnyBranchScheduler scheduler named
> 'onTrunkPluginsCommit' triggered this build
> > Build Source Stamp: [branch ofbiz/ofbiz-plugins/trunk] 1858279
> > Blamelist: rishi
> >
> > BUILD FAILED: failed shell_4
> >
> > Sincerely,
> >   -The Buildbot
> >
> >
> >
> >
>


Re: Confusing implementation of the quickAdd feature of e-commerce

2019-04-27 Thread Rishi Solanki
Dear Pawan,
In general template should be change. So that we can reuse the data
preparation logic. In case quick add is not working due to some
parameters/context missing then we can think of separate groovy for
ecommerce.
But first we try to reuse the base component logics in plugin component.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Sat, Apr 27, 2019 at 8:44 PM Pawan Verma 
wrote:

> Hello Devs,
>
> While looking into OFBIZ-10978, I found the implementation of the quickAdd
> feature of e-commerce confusing.
>
> What I found under the quickadd screen of ecommerce/CatalogScreens.xml is
> that the UI and data preparation layers are in no sync to each other.
> The QuickAdd.groovy file has the correct implementation of the QuickAdd
> feature (as per the ordermgr component) and the FTL has been designed as
> per e-commerce.
>
> I think we need to take a decision here about the quickadd screen.
>
> Should we make this feature same as quickadd feature of ordermgr?
> OR
> Should we write separate data preparation logic for quickadd feature of
> e-commerce?
>
> Suggestions are most welcome. Thanks!
>
> --
> Kind Regards,
> *Pawan Verma* | Technical Consultant
> HotWax Systems <http://www.hotwaxsystems.com/>
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore,
> M.P. 452010
> Linkedin: *Pawan Verma <https://www.linkedin.com/in/pawan--verma>*
>


Re: Adding fromDate and thruDate in GoodIdentification Entity

2019-04-27 Thread Rishi Solanki
-1 for the proposal.
For a product identification code will be one of one type. The universal
data model book by Len Silverston suggested the same.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Sat, Apr 27, 2019 at 4:03 PM Michael Brohl 
wrote:

> Hi Aishwary,
>
> can you elaborate a bit more why a history of GoodIdentification is needed?
>
> It is used for identification numbers as ISBN, EAN etc.. Those numbers
> are rarely subject to change for the same product.
>
> I don't see any use case for history tracking so I would appreciate some
> examples.
>
> Thanks,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 27.04.19 um 09:11 schrieb Aishwary Shrivastava:
> > Hello, Devs
> >
> > We should add support of fromDate and thruDate in the GoodIdentification
> > entity for tracking and history purpose.
> >
> > As of now, if we need to update any Good Identification record for a
> > product, then we have to replace its value and this history isn't
> > maintained.
> > It will also enable the user to maintain multiple goodIdentifications of
> a
> > product.
> >
> > Best,
> > *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/>
> >
>
>


Manufacturer Support In Promotion Engine

2019-04-27 Thread Rishi Solanki
Devs,
Currently promotion engine support all the discount based on party,
category, party role, party classification, shipping etc.. And promotion
engine based on the condition decide that the promotion will apply for
customer purchase over the cart or cart item depending upon the action.

I would like to propose to add support in promotion engine, so that , we
can add promotion against manufacturing party and should apply to all the
products manufactured by that party.

For example;
M1, M2 are two manufacturers.
M1P1 and M1P2 are products manufactured by M1.
M2P1 and M2P2 are products manufactured by M2.

Now M1 gives 10% discount on all products M1, and if customer purchase all
products with quantity ONE.

Assuming all items price is $100. Then CartTotal will be $400 and discount
amount will be $20. As discount is on M1 products only.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


Re: ReturnContactMech is not used

2019-04-27 Thread Rishi Solanki
+1.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Sat, Apr 27, 2019 at 1:19 PM Pawan Verma 
wrote:

> Yes, We should add a workflow to add associated parties of return in
> ReturnContactMech entity.
>
> --
> Kind Regards,
> *Pawan Verma* | Technical Consultant
> HotWax Systems <http://www.hotwaxsystems.com/>
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore,
> M.P. 452010
> Linkedin: *Pawan Verma <https://www.linkedin.com/in/pawan--verma>*
>
>
> On Sat, Apr 27, 2019 at 12:55 PM Suraj Khurana 
> wrote:
>
> > +1.
> > This could be a nice improvement to have.
> >
> > --
> > Best Regards,
> > Suraj Khurana
> >
> >
> >
> >
> >
> >
> >
> > On Sat, Apr 27, 2019 at 12:33 PM Vaibhav Jain <
> > vaibhav.j...@hotwaxsystems.com> wrote:
> >
> > > *Bottom line:*
> > > ReturnContactMech entity is not used in OFBiz
> > >
> > > *Story:*
> > > ContactMech of parties involved in an order is captured in
> > OrderContactMech
> > > entity.
> > > ContactMech of parties involved in the return is not captured in
> > > ReturnContactMech entity.
> > >
> > > Kind Regards,
> > > *Vaibhav Jain* | Senior Enterprise Software Engineer
> > > HotWax Systems <http://www.hotwaxsystems.com/>
> > > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> > > Indore,
> > > M.P 452010
> > > Linkedin: *Vaibhav Jain* <
> > https://www.linkedin.com/in/vaibhav-jain-170793/
> > > >
> > >
> > > [image: Mailtrack]
> > > <
> > >
> >
> https://mailtrack.io?utm_source=gmail_medium=signature_campaign=signaturevirality5;
> > > >
> > > Sender
> > > notified by
> > > Mailtrack
> > > <
> > >
> >
> https://mailtrack.io?utm_source=gmail_medium=signature_campaign=signaturevirality5;
> > > >
> > > 04/27/19,
> > > 12:23:48 PM
> > >
> >
>


Re: [PROPOSAL] DataModel - Improve Internal Fields injection

2019-04-24 Thread Rishi Solanki
Michael,
Thank you for details, all makes sense.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Wed, Apr 24, 2019 at 4:37 PM Michael Brohl 
wrote:

> I have not time to elaborate in-depth right now, but just a quick food
> for thought:
>
> Having these fields in every entity *by default* allows detailed
> tracking of users which might be unwanted. I know that this is a
> sensible topic in companies and affects privacy protection.
>
> I am not sure how the selection of entities with these fields was done,
> maybe others can add insights.
>
> Regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 24.04.19 um 12:40 schrieb Pierre Smits:
> > Thanks Michael,
> >
> > So we should keep those *TxStamp fields.
> >
> > But what about the second suggestion about having the
> 'createdByUserLogin'
> > and 'lastModifiedByUserLogin'  fields added to the internal fields set?
> >
> > Best regards,
> >
> > Pierre Smits
> >
> > *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> > *Apache Directory <https://directory.apache.org>, PMC Member*
> > Apache Incubator <https://incubator.apache.org>, committer
> > *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
> privileges)
> > since 2008*
> > Apache Steve <https://steve.apache.org>, committer
> >
> >
> > On Wed, Apr 24, 2019 at 12:20 PM Michael Brohl  >
> > wrote:
> >
> >> These fields are not the same, they can differ. The TX fields mark the
> >> transaction timestamp while the non TX fields mark the "real" update
> >> time. You can see it when you watch closely in the database. All changes
> >> made within an transaction have the same tx timestamp.
> >>
> >> Regards,
> >>
> >> Michael Brohl
> >>
> >> ecomify GmbH - www.ecomify.de
> >>
> >>
> >> Am 24.04.19 um 09:48 schrieb Pierre Smits:
> >>> Hi All,
> >>>
> >>> Currently our functions inject following internal fields into the model
> >> of
> >>> each entity:
> >>>
> >>>  - createdStamp
> >>>  - createdTxStamp
> >>>  - lastUpdatedStamp
> >>>  - lastUpdatedTxStamp
> >>>
> >>> All of the fields above are of the field type definition 'date-time',
> >>> giving for java: java.sql.Timestamp, and for sql: TIMESTAMP. This means
> >>> that the createdTxStamp is the same as createdStamp  and
> >> lastUpdatedTxStamp
> >>> is the same as lastUpdatedStamp.
> >>>
> >>> Should we get rid of the redundant fields?
> >>>
> >>> Also, a lot of entity definitions in the various models have the
> >>> 'createdByUserLogin' and 'lastModifiedByUserLogin' added.
> >>>
> >>> Should we have these fields added to the internal fields set so that
> >> these
> >>> are always injected into the model of each entity, and always filled?
> >>>
> >>> Best regards,
> >>>
> >>> Pierre Smits
> >>>
> >>> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> >>> *Apache Directory <https://directory.apache.org>, PMC Member*
> >>> Apache Incubator <https://incubator.apache.org>, committer
> >>> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
> >> privileges)
> >>> since 2008*
> >>> Apache Steve <https://steve.apache.org>, committer
> >>>
> >>
>
>


Re: [PROPOSAL] DataModel - Improve Internal Fields injection

2019-04-24 Thread Rishi Solanki
Dear Pierre,
I'm not aware of history of this duplicate entries. I agree with you on
removing duplicate fields. Also agree with adding created user and updated
user fields as default.

Few points for open discussion for community;
- There are many entities already have user fields, so do we need to remove
them. Point to discuss. IMO we can live with both.
- There are certain entries like dimension, search etc which does not
require user information.
- From community if someone have information on Tx fields then we can
rethink of not removing.

Lastly, this thread should take time to conclude after all inputs.

Thanks for interesting proposal!

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Wed, Apr 24, 2019 at 1:19 PM Pierre Smits  wrote:

> Hi All,
>
> Currently our functions inject following internal fields into the model of
> each entity:
>
>- createdStamp
>- createdTxStamp
>- lastUpdatedStamp
>- lastUpdatedTxStamp
>
> All of the fields above are of the field type definition 'date-time',
> giving for java: java.sql.Timestamp, and for sql: TIMESTAMP. This means
> that the createdTxStamp is the same as createdStamp  and lastUpdatedTxStamp
> is the same as lastUpdatedStamp.
>
> Should we get rid of the redundant fields?
>
> Also, a lot of entity definitions in the various models have the
> 'createdByUserLogin' and 'lastModifiedByUserLogin' added.
>
> Should we have these fields added to the internal fields set so that these
> are always injected into the model of each entity, and always filled?
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
> since 2008*
> Apache Steve <https://steve.apache.org>, committer
>


Re: svn commit: r1856618 - in /ofbiz/ofbiz-plugins/trunk/msg91: ./ config/ data/ data/helpdata/ documents/ entitydef/ servicedef/ src/ src/main/ src/main/java/ src/main/java/org/ src/main/java/org/apa

2019-04-12 Thread Rishi Solanki
Jacques,
Thanks for pointing this, I made code changes before committing this as
plugin. And as we uses free services from them (by mentioning OFBiz as open
source apache software) so didn't give a thought to name of component and
mentioning of commercial services.

I'm completely agree with you on this, I will change the component name and
all occurrences in the code. Please let me know if we are good if we do so,
or something else needs to be done. Thanks!

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Thu, Apr 11, 2019 at 11:02 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Rishi,
>
> In understand that this component currently uses "msg91 services to send
> sms".
>
> But could we not have another name, more explicit, for this component,
> like sms or sendsms for instance?
>
> Services tend to disappear or change (Google is the best example). So I'd
> not associate the name of an open source component to a commercial services
> provider (with a free SMS quota option). Even if hopefully it will stay as
> is...
>
> Thanks
>
> Jacques
>
> Le 30/03/2019 à 13:43, ri...@apache.org a écrit :
> > Author: rishi
> > Date: Sat Mar 30 12:43:46 2019
> > New Revision: 1856618
> >
> > URL: http://svn.apache.org/viewvc?rev=1856618=rev
> > Log:
> > [Implemented] Short Messaging Service(SMS) Gateway Integration. Added
> msg91 component to plugins. It uses msg91 services to send sms. An example
> to demonstrate how to use SMS gateway integration with OFBiz.
> > (OFBIZ-10457)
> > Thanks to Pritam Kute for your contribution and Michael Brohi for review
> and feedback.
> >
> > Added:
> >  ofbiz/ofbiz-plugins/trunk/msg91/
> >  ofbiz/ofbiz-plugins/trunk/msg91/config/
> >  ofbiz/ofbiz-plugins/trunk/msg91/config/Msg91UiLabels.xml   (with
> props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/data/
> >  ofbiz/ofbiz-plugins/trunk/msg91/data/Msg91DemoData.xml   (with
> props)
> >
> ofbiz/ofbiz-plugins/trunk/msg91/data/Msg91SecurityGroupDemoData.xml   (with
> props)
> >
> ofbiz/ofbiz-plugins/trunk/msg91/data/Msg91SecurityPermissionSeedData.xml
>  (with props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/data/helpdata/
> >  ofbiz/ofbiz-plugins/trunk/msg91/data/helpdata/HELP_Msg91.xml
>  (with props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/documents/
> >  ofbiz/ofbiz-plugins/trunk/msg91/documents/Msg91.xml   (with props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/entitydef/
> >  ofbiz/ofbiz-plugins/trunk/msg91/entitydef/entitymodel.xml   (with
> props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/ofbiz-component.xml   (with props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/servicedef/
> >  ofbiz/ofbiz-plugins/trunk/msg91/servicedef/services.xml   (with
> props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/src/
> >  ofbiz/ofbiz-plugins/trunk/msg91/src/main/
> >  ofbiz/ofbiz-plugins/trunk/msg91/src/main/java/
> >  ofbiz/ofbiz-plugins/trunk/msg91/src/main/java/org/
> >  ofbiz/ofbiz-plugins/trunk/msg91/src/main/java/org/apache/
> >  ofbiz/ofbiz-plugins/trunk/msg91/src/main/java/org/apache/ofbiz/
> >
> ofbiz/ofbiz-plugins/trunk/msg91/src/main/java/org/apache/ofbiz/msg91/
> >
> ofbiz/ofbiz-plugins/trunk/msg91/src/main/java/org/apache/ofbiz/msg91/Msg91Services.java
>  (with props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/webapp/
> >  ofbiz/ofbiz-plugins/trunk/msg91/webapp/msg91/
> >  ofbiz/ofbiz-plugins/trunk/msg91/webapp/msg91/WEB-INF/
> >  ofbiz/ofbiz-plugins/trunk/msg91/webapp/msg91/WEB-INF/actions/
> >
> ofbiz/ofbiz-plugins/trunk/msg91/webapp/msg91/WEB-INF/controller.xml   (with
> props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/webapp/msg91/WEB-INF/web.xml
>  (with props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/webapp/msg91/error/
> >  ofbiz/ofbiz-plugins/trunk/msg91/webapp/msg91/error/error.jsp
>  (with props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/webapp/msg91/index.jsp   (with
> props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/widget/
> >  ofbiz/ofbiz-plugins/trunk/msg91/widget/CommonScreens.xml   (with
> props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/widget/Msg91Menus.xml   (with props)
> >  ofbiz/ofbiz-plugins/trunk/msg91/widget/Msg91Screens.xml   (with
> props)
> >
> > Added: ofbiz/ofbiz-plugins/trunk/msg91/config/Msg91UiLabels.xml
&

Re: ***UNCHECKED*** Marital Status not managed properly in Person entity

2019-04-09 Thread Rishi Solanki
+1.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Tue, Apr 9, 2019 at 4:46 PM Jacques Le Roux 
wrote:

> +1
>
> Jacques
>
> Le 09/04/2019 à 10:59, Suraj Khurana a écrit :
> > +1.
> >
> > Technically, as per Pierre, we should also mark this field as encrypted
> in
> > the entity definition.
> >
> > --
> > Best Regards,
> > Suraj Khurana
> > TECHNICAL CONSULTANT
> > mobile: +91 9669750002
> > email: suraj.khur...@hotwax.co
> > *www.hotwax.co <http://www.hotwax.co/>*
> >
> >
> >
> >
> >
> >
> > On Tue, Apr 9, 2019 at 2:08 PM Pierre Smits 
> wrote:
> >
> >> Although I am inclined to agree with having the options come from
> >> appropriate records/values in the Enumeration entity, I must caution
> about
> >> how the final solution will be implemented in our code base. We all know
> >> that this falls in the category of sensitive data which has come under a
> >> tighter scrutiny due to GDPR and security breaches.
> >>
> >> Such privacy sensitive element should be implemented in tighter
> permissions
> >> applied than we generally apply to screens/forms/fields etc.
> >>
> >> Best regards,
> >>
> >> Pierre Smits
> >>
> >> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> >> *Apache Directory <https://directory.apache.org>, PMC Member*
> >> Apache Incubator <https://incubator.apache.org>, committer
> >> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
> privileges)
> >> since 2008*
> >> Apache Steve <https://steve.apache.org>, committer
> >>
> >>
> >> On Tue, Apr 9, 2019 at 10:19 AM Aditya Sharma 
> >> wrote:
> >>
> >>> +1
> >>>
> >>> Best Regards,
> >>> Aditya Sharma,
> >>> http://ofbiz.apache.org
> >>>
> >>>
> >>> On Tue, Apr 9, 2019 at 1:09 PM Swapnil M Mane  >
> >>> wrote:
> >>>
> >>>> +1
> >>>>
> >>>>
> >>>> - Best Regards,
> >>>> Swapnil M Mane,
> >>>> ofbiz.apache.org
> >>>>
> >>>>
> >>>>
> >>>> On Tue, Apr 9, 2019 at 12:51 PM Suraj Khurana <
> suraj.khur...@hotwax.co
> >>>> wrote:
> >>>>
> >>>>> Hello,
> >>>>>
> >>>>> Currently, *maritalStatus* is managed as an indicator (Y/N) in
> >> *Person*
> >>>>> entity. I think we can enhance it and make it derived from
> >>> *Enumeration*
> >>>>> pattern.
> >>>>>
> >>>>> *Classification of legal marital status*
> >>>>>
> >>>>> - 1 - Married (and not separated) ...
> >>>>> - 2 - Widowed (including living common law) ...
> >>>>> - 3 - Separated (and not Divorced) ...
> >>>>> - 4 - Divorced (including living common law) ...
> >>>>> - 5 - Single (including living common law)
> >>>>>
> >>>>> Please share your thoughts.
> >>>>>
> >>>>> --
> >>>>> Best regards,
> >>>>> Suraj Khurana
> >>>>> TECHNICAL CONSULTANT
> >>>>> mobile: +91 9669750002
> >>>>> email: suraj.khur...@hotwax.co
> >>>>> *www.hotwax.co <http://www.hotwax.co/>*
> >>>>>
>


Re: use blokchain in ofbiz

2019-04-04 Thread Rishi Solanki
Laxman,
Could you please elaborate what you want to do or what you would like to
gain by this integration. Theoretically it is possible, but no working
example withing OFBiz.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Thu, Apr 4, 2019 at 11:53 AM Deepak Dixit  wrote:

> Hi User,
>
> Your message has been moderated.
>
> Please subscribe to the user ML for such questions and then use your email
> client
> See also why here http://ofbiz.apache.org/mailing-lists.html
>
> You will get a better support , it's more fair to share with everybody  and
> people can answer you on the ML rather than directly to you
> The wider the audience the better the answers you might get
>
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Thu, Apr 4, 2019 at 11:44 AM lax...@akeo.no  wrote:
>
> > Hi
> > can we  integrate  blockchain  with ofbiz
> >
>


Re: [Discussion] Username should allow space/special characters?

2019-03-30 Thread Rishi Solanki
Hi Ayushi,
Thanks for your concern and reporting. In OFBiz we use email address as
user name. So all the characters allowed in email address should be allowed
in user name.
In your case it seems you are not using email address as user name, in that
case as well I would say email address practices should follow. As it is
globally accepted and known to general users.

If community agree on some point to allow other characters in user name
then we should look for the practices adaption at global level and then we
can decide how should we proceed. Again my vote is to go with email address
practice which is already accepted at [1].

[1] https://en.wikipedia.org/wiki/Email_address

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Sat, Mar 30, 2019 at 1:00 PM Ayushi Rathod 
wrote:

> Hello All,
>
> While exploring e-commerce I found that when I register as a new customer
> with a space in the username field, a weird server side error is shown on
> the UI.
>
> The question arrives here, whether space or any other characters should be
> allowed in the username or not.
>
> In my opinion, space should not be allowed in the username and the possible
> way to handle is that we can add client and server side validations to
> check if the username matches the regex.
>
> This issue has been reported under OFBIZ-10671. Please let me know your
> view on it so that we can fix the issue.
>
> Thanks in advance!!
>
> Kind Regards,
> *Ayushi Rathod*
> HotWax Systems <http://www.hotwaxsystems.com/>
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore,
> M.P 452010
> Linkedin: *Ayushi  Rathod*
> <https://www.linkedin.com/in/ayushi-rathod-0b7505b6/>
>


Re: [PROPOSAL] Using code128 instead of code39 for barcode generation

2019-03-30 Thread Rishi Solanki
+1

Best,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Sat, Mar 30, 2019 at 12:19 PM Pawan Verma 
wrote:

> Hello All,
>
> While researching on OFBIZ-10743, I have found that currently, we are using
> code39 to generate barcodes but there are some limitations of code39 as it
> only able to encrypt letters from A to Z, digits from 0 to 9 and an
> additional set of special characters – “. $ % + – / *”.
>
> To enhance the support for more characters in barcode I would suggest using
> code128 instead of code39.
>
> Below are some of the advantages of code128:
>
>1. code128 supports all the 128 ASCII symbols.
>2. code128 standard is more concise and space-efficient. It also
>provides its users with higher degrees of data security.
>
>
> Thank You *Pritam Kute* for suggesting code128.
>
> Everyone, Please share your thoughts on this. Thanks!
>
> --
> Kind Regards,
> *Pawan Verma* | Technical Consultant
> HotWax Systems <http://www.hotwaxsystems.com/>
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore,
> M.P. 452010
> Linkedin: *Pawan Verma <https://www.linkedin.com/in/pawan-verma-aa1053a2/
> >*
>


Re: JobSandbox temporal expression timezone

2019-03-19 Thread Rishi Solanki
Hello Scott,
Can we think of using JobSandbox.runAsUser='myuser' and UserPreference.



Also it should be fine to use RunTime data, as of now I could not see no
issues with that. The only thing is not possible is if system requires to
run a service always on specific time zone values and runtime could have
different values. So having value in database makes sense to me, and okay
with #1 of having it on JobSandbox level.

I proposed UserPreference so that no field added with possible solution and
we can achieve it. Could not think of any side effect as of now if we use
it only for schedule, in case the same can be use for different purpose
while log in, then it may have several side effects.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: +91-9893287847


On Tue, Mar 19, 2019 at 10:56 AM Scott Gray 
wrote:

> Hi all,
>
> Trying to decide on the best way to define a temporal expression for a
> recurring job where the temporal expression should be evaluated using a
> timezone other than whatever the default timezone is for the system.
>
> Use case is having a system that runs on UTC time, but needs to send a
> report at 5pm Pacific Time everyday regardless of whether or not daylight
> savings is in effect.
>
> I see two options:
> 1. Add a field to JobSandbox such as tempExprTzId (or better name!)
> 2. Use whatever timezone is available in the RunTime data service context
>
> #2 seems simplest but I'm not sure if there's scenarios where the service
> should be run with one timezone while the recurrence should be scheduled
> based on another?  I can't think of any.
>
> Regards
> Scott
>


Re: Buy one get one promotion improvement

2019-03-11 Thread Rishi Solanki
+1 Devanshu, and for the specific buy one get one maintaining the
OrderItemAssoc not making sense. We can use OrderItem.isPromo,
OrderAdjustment, ProductPromoUse and ProductPromo relationship to identify
the free product. And if we are not able to identify the free product then
we should go for some custom development.

Best Regards,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sun, Mar 10, 2019 at 4:07 PM Devanshu Vyas 
wrote:

> Hello Suraj,
>
> You have presented a good solution but IMHO maintaining OrderItemAssoc
> records wouldn't work in all the cases. I mean what would happen if there
> is a Buy 3 Get 1 promotion?
>
> I would recommend to Prorate the discount while order creation and the same
> discounted amount should be credited when an item is returned.
> More thoughts are welcome here!
>
> Thanks & Regards,
> Devanshu Vyas.
>
>
> On Wed, Feb 27, 2019 at 7:24 PM Suraj Khurana 
> wrote:
>
> > Hello,
> >
> > While applying any BOGOF promo in OOTB, free item is added into order
> item
> > with field isPromo set to Y.
> > It might be possible that there are other items in the order as well.
> > IMO, we need to have order item assoc maintained as well, in this case,
> to
> > find out this free item is available with which other order items.
> >
> > I think this is not maintained yet in any other form as well, please let
> me
> > know am I missing something?
> > Any thoughts are welcome in this direction !!
> >
> > Thanks in advance.
> >
> > --
> > Best Regards,
> > Suraj Khurana
> > TECHNICAL CONSULTANT
> > mobile: +91 9669750002
> > email: suraj.khur...@hotwax.co
> > www.hotwax.co
> >
>


Re: Create return till ...

2019-03-11 Thread Rishi Solanki
I agree with the approach what Pierre suggested to go with
ProductCategoryAttribute and ProductAttribute. Because for range of
products we may need different default values. Also agree with Scott on the
point there must be flexibility at CSR end to override the rule based on
the reason of return and relationship with customer. That means, we should
not stop CSR to create return if days passed, and simply can popup the
message that number of days have been passed and if she still wants to
continue then she should be able to do that.

After inputs from all, my suggestion is to go for ProductCategoryAttribute
and ProductAttribute configuration but it should not stop CSR to
place/accept return. And simply inform her that number of days has been
passed.

Best Regards,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Mon, Mar 11, 2019 at 11:49 AM Suraj Khurana 
wrote:

> Hello Scott,
>
> Thank you so much for your response. Yes, this is the exact way it is been
> managed currently.
>
> Thing is, we need to improve customer experience and reduce customer
> service reps work. The current approach is working but it totally depends
> on business to business. Some of them may leave it on CSR, on the other
> hand, some must be looking for a date (timespan) which can be used to not
> allow returns for any specific order (ex returns are not allowed in stock
> clearance).
>
> Not making current flow as totally obsolete, but I guess we should have
> something to support this as well OOTB.
>
> --
> Best Regards,
> Suraj Khurana
> TECHNICAL CONSULTANT
> mobile: +91 9669750002
> email: suraj.khur...@hotwax.co
> *www.hotwax.co <http://www.hotwax.co/>*
>
>
>
>
>
>
> On Mon, Mar 11, 2019 at 7:31 AM Scott Gray 
> wrote:
>
> > The ability to create a return doesn't necessarily mean that return will
> be
> > accepted.  IMO this is a business process where human intervention is
> > required in order to maintain good customer relations.
> Approving/declining
> > RMAs depend on a number of factors including:
> > - the reason for return
> > - length of time since purchase
> > - value of the purchase
> > - COGS
> > - lifetime value of the customer
> >
> > A hard time limit can make sense when a customer simply changes their
> mind
> > about the purchase and wishes to return it but I don't think any other
> type
> > of return should be constrained by the system without input from customer
> > service reps.
> >
> > IMO a better system would be to have information critical to the RMA
> > process (such as the items listed above) easily accessible to the CSR so
> > they can quick make a decision.  Having the system prevent customers from
> > even creating a return request because X number of days have passed could
> > well be a bad user experience for the customer.
> >
> > If the implementation does proceed, I don't think ProductFacility would
> be
> > a good place to store the information.  Multiple stores with different
> > rules could well be fulfilling the same products out of the same
> warehouse
> > (particularly for international distribution).
> >
> > Regards
> > Scott
> >
> > On Sat, 9 Mar 2019 at 20:50, Suraj Khurana 
> > wrote:
> >
> > > Hello,
> > >
> > > In OFBiz, we can create a return for order without checking when that
> > order
> > > is placed, it might be years long.
> > > IMO, we should have a field something like daysToReturn at product
> store
> > > level to allow creating return till after that much days of order
> > > completion.
> > >
> > > I could not find anything else relevant to this and this is a very
> common
> > > e-commerce scenario for any business.
> > >
> > > Am I missing something?
> > > Please share your thoughts on the same.
> > >
> > > --
> > > Best Regards
> > > Suraj Khurana
> > > TECHNICAL CONSULTANT
> > > mobile: +91 9669750002
> > > email: suraj.khur...@hotwax.co
> > > www.hotwax.co
> > >
> >
>


Re: Create return till ...

2019-03-09 Thread Rishi Solanki
+1 for having this. The only thing I would like to add go for global
setting which should be overridden by product level setting. For example; A
site may deal in industry  which may require different number of days for
the different products.
Also agree with Pierre on point we should be aware of the fact that
unnecessary data model extension should be avoided.

Question: how should we manage if we would like to have two store and for
both stores we want to have different number of days limit for return.
My Answer: While configuring the store the System property should be
configured against prefix/suffix of store id.

Please feel free to add more details or alternative way for handling this.

Best Regards,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sat, Mar 9, 2019 at 1:20 PM Suraj Khurana 
wrote:

> Hello,
>
> In OFBiz, we can create a return for order without checking when that order
> is placed, it might be years long.
> IMO, we should have a field something like daysToReturn at product store
> level to allow creating return till after that much days of order
> completion.
>
> I could not find anything else relevant to this and this is a very common
> e-commerce scenario for any business.
>
> Am I missing something?
> Please share your thoughts on the same.
>
> --
> Best Regards
> Suraj Khurana
> TECHNICAL CONSULTANT
> mobile: +91 9669750002
> email: suraj.khur...@hotwax.co
> www.hotwax.co
>


Re: storeOrder Service

2019-03-09 Thread Rishi Solanki
Thank you all for your inputs. We will be addressing the issue under -
https://issues.apache.org/jira/browse/OFBIZ-10855
<https://www.google.com/url?q=https://issues.apache.org/jira/browse/OFBIZ-10855=D=hangouts=1552211567783000=AFQjCNH8QA2mEITWPpldKVF10aN-ny_LdA>



Best Regards,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Tue, Mar 5, 2019 at 9:16 AM Swapnil M Mane 
wrote:

> +1
>
>
> - Best Regards,
> Swapnil M Mane
>
>
> On Fri, Mar 1, 2019 at 3:22 PM Rishi Solanki 
> wrote:
>
> > Dear All,
> > While working with storeOrder service, I observe that few order header
> > level values not passed and stored in that service. Also no code support
> > exists for those order header fields. Below are the fields which is not
> > taken care by the service code, please let me know if we can add
> > conditional support for these field, that means if the value comes in
> > parameter then it will be stored otherwise not.
> > - priority
> > - isRushOrder
> >
> > These values can be reset after creating order by using updateOrderHeader
> > service, but I think this should be fine to have these and other missing
> > values of header level as IN parameters and handled by the service.
> >
> > Please let me know in case of any objections, I would like to commit the
> > proposed changes.
> >
> > Best Regards,
> > --
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
>


Re: Welcome to Mathieu Lirzin as new committer!

2019-03-05 Thread Rishi Solanki
Many Congratulations Mathieu.
Welcome Aboard.

Best,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Tue, Mar 5, 2019 at 9:39 AM Divesh Dutta 
wrote:

> Congratulations Mathieu. Welcome aboard.
>
> Thanks
> --
> Divesh Dutta
>
>
> On Tue, 26 Feb 2019 at 1:48 AM, Mathieu Lirzin 
> wrote:
>
> > Hello,
> >
> > Taher Alkhateeb  writes:
> >
> > > The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
> > > we are happy to announce that he has accepted this role.
> >
> > Thanks everybody for the congratulations and welcoming me as a committer
> > in this project.
> >
> > --
> > Mathieu Lirzin
> > GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
> >
>


Re: Ofbiz Security permission

2019-03-05 Thread Rishi Solanki
HI,
Yes you can use the permission service to add check at service, script, UI
and inline UI etc. You just need to call the relevant service as per your
business needs. Please refer PartyPermissionServices.xml give you good idea
how to implement and its occurrence gives idea on how to use that.

Best Regards,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sun, Mar 3, 2019 at 3:02 PM vanthanh020...@gmail.com <
vanthanh020...@gmail.com> wrote:

> Hi Rishi Solanki ,
>
> "1) SecurityPermission
> 2) SecurityGroup
> 3) SecurityGroupPermission
> 4) UserLogin
> 4) UserLoginSecurityGroup"
> =>There is a basic service which checks the weather an user will have
> permission to access some UI, process or not.
>
> I know, so how can I get get permission of user who are login from java
> code. if I can get permission from java code, I can append query some thing
> like: select * from order_header where (CREATED_BY = USER_LOGIN_ID )
>
> Thanks & Regards
>
>
> On 2019/03/01 09:13:50, Rishi Solanki  wrote:
> > Rajesh,
> > There is a basic service which checks the weather an user will have
> > permission to access some UI, process or not. Which can be override as
> per
> > the business need. Please take a look into the
> PartyPermissionServices.xml.
> > Here you can see examples with fact service always returns true or false.
> > Also it overrides the default behavior and returns true for userLoing
> based
> > on partyId check.
> >
> > Note that all permission services implements permissionInterface, all the
> > code in these service is around what data model Deepak Nigam suggested.
> >
> > HTH!
> >
> > --
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
> >
> > On Fri, Mar 1, 2019 at 2:01 PM Rajesh Mallah 
> > wrote:
> >
> > > Hello Mr Deepak / List ,
> > >
> > > can you also elaborate to what extent OOTB handles the isolation of
> > > view  between resource owners. Eg below the person asks viewing
> > > his *own* resource but not others.
> > >
> > >
> > > > > create sale order, view and edit own sale order. Cannot update or
> view
> > > > other sale order which is not belong to themself.
> > >
> > > regds
> > > mallah.
> > >
> > > On Fri, Mar 1, 2019 at 9:53 AM Deepak Nigam <
> deepak.nigam1...@gmail.com>
> > > wrote:
> > >
> > > > Hi Thanh,
> > > >
> > > > The permissions you are looking for and corresponding security group
> are
> > > > already available OOTB. You only need to associate user login with
> > > > appropriate security groups. Following entities can be of your
> interest:
> > > >
> > > > 1) SecurityPermission
> > > > 2) SecurityGroup
> > > > 3) SecurityGroupPermission
> > > > 4) UserLogin
> > > > 4) UserLoginSecurityGroup
> > > >
> > > > It can be also achieved via 'Party Manager' application. Just open
> the
> > > > profile of the party and you can add/remove him to any security
> group.
> > > This
> > > > feature is available under 'User Name(s)' section.
> > > >
> > > > Thanks & Regards
> > > > --
> > > > Deepak Nigam
> > > >
> > > >
> > > > On Fri, Mar 1, 2019 at 2:58 AM Jacques Le Roux <
> > > > jacques.le.r...@les7arts.com>
> > > > wrote:
> > > >
> > > > > Hi Thanh,
> > > > >
> > > > > Your message has been moderated.
> > > > >
> > > > > Please subscribe to the user ML for such questions and then use
> your
> > > > email
> > > > > client
> > > > > See also why here http://ofbiz.apache.org/mailing-lists.html
> > > > >
> > > > > You will get a better support , it's more fair to share with
> everybody
> > > > > and people can answer you directly on the ML rather than directly
> to
> > > you
> > > > > The wider the audience the better the answers you might get
> > > > >
> > > > > Also it's more work for moderators who have to accept your
> messages as
> > > > > long as you have not subscribed.
> > > > > I'll personally no longer accept them (other moderators still
> could)
> > > > >
> > > > > Thanks
> > > > >
> > > > > Jacques
> > > > >
> > > > > Le 28/02/2019 à 19:01, thanh a écrit :
> > > > > > Hi all,
> > > > > >
> > > > > > I am newbie in ofbiz,
> > > > > >
> > > > > > I want to create permission call "Salesman", which this
> permission,
> > > > user
> > > > > can
> > > > > > create sale order, view and edit own sale order. Cannot update or
> > > view
> > > > > other
> > > > > > sale order which is not belong to themself.
> > > > > >
> > > > > > How can I do it, please show me.
> > > > > >
> > > > > > Thanks and best regards.
> > > > > > Thanh
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Sent from:
> http://ofbiz.135035.n4.nabble.com/OFBiz-Dev-f165671.html
> > > > > >
> > > > >
> > > >
> > >
> >
>


storeOrder Service

2019-03-01 Thread Rishi Solanki
Dear All,
While working with storeOrder service, I observe that few order header
level values not passed and stored in that service. Also no code support
exists for those order header fields. Below are the fields which is not
taken care by the service code, please let me know if we can add
conditional support for these field, that means if the value comes in
parameter then it will be stored otherwise not.
- priority
- isRushOrder

These values can be reset after creating order by using updateOrderHeader
service, but I think this should be fine to have these and other missing
values of header level as IN parameters and handled by the service.

Please let me know in case of any objections, I would like to commit the
proposed changes.

Best Regards,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


Re: Ofbiz Security permission

2019-03-01 Thread Rishi Solanki
Rajesh,
There is a basic service which checks the weather an user will have
permission to access some UI, process or not. Which can be override as per
the business need. Please take a look into the PartyPermissionServices.xml.
Here you can see examples with fact service always returns true or false.
Also it overrides the default behavior and returns true for userLoing based
on partyId check.

Note that all permission services implements permissionInterface, all the
code in these service is around what data model Deepak Nigam suggested.

HTH!

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Fri, Mar 1, 2019 at 2:01 PM Rajesh Mallah 
wrote:

> Hello Mr Deepak / List ,
>
> can you also elaborate to what extent OOTB handles the isolation of
> view  between resource owners. Eg below the person asks viewing
> his *own* resource but not others.
>
>
> > > create sale order, view and edit own sale order. Cannot update or view
> > other sale order which is not belong to themself.
>
> regds
> mallah.
>
> On Fri, Mar 1, 2019 at 9:53 AM Deepak Nigam 
> wrote:
>
> > Hi Thanh,
> >
> > The permissions you are looking for and corresponding security group are
> > already available OOTB. You only need to associate user login with
> > appropriate security groups. Following entities can be of your interest:
> >
> > 1) SecurityPermission
> > 2) SecurityGroup
> > 3) SecurityGroupPermission
> > 4) UserLogin
> > 4) UserLoginSecurityGroup
> >
> > It can be also achieved via 'Party Manager' application. Just open the
> > profile of the party and you can add/remove him to any security group.
> This
> > feature is available under 'User Name(s)' section.
> >
> > Thanks & Regards
> > --
> > Deepak Nigam
> >
> >
> > On Fri, Mar 1, 2019 at 2:58 AM Jacques Le Roux <
> > jacques.le.r...@les7arts.com>
> > wrote:
> >
> > > Hi Thanh,
> > >
> > > Your message has been moderated.
> > >
> > > Please subscribe to the user ML for such questions and then use your
> > email
> > > client
> > > See also why here http://ofbiz.apache.org/mailing-lists.html
> > >
> > > You will get a better support , it's more fair to share with everybody
> > > and people can answer you directly on the ML rather than directly to
> you
> > > The wider the audience the better the answers you might get
> > >
> > > Also it's more work for moderators who have to accept your messages as
> > > long as you have not subscribed.
> > > I'll personally no longer accept them (other moderators still could)
> > >
> > > Thanks
> > >
> > > Jacques
> > >
> > > Le 28/02/2019 à 19:01, thanh a écrit :
> > > > Hi all,
> > > >
> > > > I am newbie in ofbiz,
> > > >
> > > > I want to create permission call "Salesman", which this permission,
> > user
> > > can
> > > > create sale order, view and edit own sale order. Cannot update or
> view
> > > other
> > > > sale order which is not belong to themself.
> > > >
> > > > How can I do it, please show me.
> > > >
> > > > Thanks and best regards.
> > > > Thanh
> > > >
> > > >
> > > >
> > > > --
> > > > Sent from: http://ofbiz.135035.n4.nabble.com/OFBiz-Dev-f165671.html
> > > >
> > >
> >
>


Re: [DISCUSSION]: Promotion behaviour on highest amount discount

2018-12-13 Thread Rishi Solanki
Hi Arun,
I remember it is maintain thru ProctStorePromoAppl, ProductPromoCond, and
ProductPromoAction sequence field. Based on the sequence system should
decide which promotions needs to be apply. If this is not happening then
system should do in that way, changing sequence will change the
applicability of promotion.

Discount Amount is not right candidate to decide which promotion should
apply, because system should be flexible enough to address both business
requirements.

Best Regards,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Thu, Dec 13, 2018 at 2:46 PM Arun Patidar 
wrote:

> Hello team,
>
> Wanted to confirm the OOTB promotion behaviour of setting highest amount
> from all available discounts. Is this correct to give highest amount on
> discount.
>
> Generally, when there are 2 or more cart items on discounts and we have to
> give discount on limited then higher items will be invoiced and lower items
> will be on discount.
>
> So, what should be the expected behaviour for this case.
>
> Thanks & Regards
> ---
> Arun Patidar
> Director of Information SystemsHotWax Commerce <http://www.hotwax.co>
>


Re: [DOCUMENTATION] TOCs level and numbers

2018-12-08 Thread Rishi Solanki
+1.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Fri, Dec 7, 2018 at 8:59 PM Jacques Le Roux 
wrote:

> Thanks guys,
>
> I see a majority and a trend so I'll simply change the toclevels from 5 to
> 3 in 3 days, if nobody disagree
>
> Jacques
>
>
> Le 07/12/2018 à 07:08, Taher Alkhateeb a écrit :
> > Section numbers are nice and we use them in all our documents. They help
> > you keep track of where you are and in large documents this becomes very
> > helpful.
> >
> > So I would prefer keeping them.
> >
> > On Fri, Dec 7, 2018, 12:09 AM Michael Brohl  wrote:
> >
> >> I‘m also in favour of keeping the section numbers.
> >>
> >> Thanks,
> >> Michael
> >>
> >> --
> >> Michael Brohl
> >> Geschäftsführer
> >>
> >> Fon   +49 521 448 157-91
> >> Fax   +49 521 448 157-99
> >> Mobil +49 160 3664918
> >>
> >> Company and Management Headquarters:
> >> ecomify GmbH, Gustav-Winkler-Straße 22, 33699 Bielefeld, Deutschland
> >> Fon: +49 521 448157-90, Fax: +49 521 448157-99, www.ecomify.de
> >>
> >> Court Registration: Amtsgericht Bielefeld HRB 41683
> >> Chief Executive Officer: Martin Becker, Michael Brohl
> >>
> >>> Am 06.12.2018 um 18:30 schrieb Jacques Le Roux <
> >> jacques.le.r...@les7arts.com>:
> >>>> Le 03/12/2018 à 22:46, Jacques Le Roux a écrit :
> >>>>> Le 02/12/2018 à 13:49, Mathieu Lirzin a écrit :
> >>>>> Hello Jacques,
> >>>>>
> >>>>> Jacques Le Roux  writes:
> >>>>>
> >>>>>> I did not get any attention so far. So, in build.gradle, I suggest
> to
> >> set :
> >>>>>> 'toclevels': '3'
> >>>>>> :!sectnums:
> >>>>> I agree with limiting the table of content level to 3, However I
> >>>>> strongly disagree with the removal of section numbers which IME helps
> >>>>> both in understanding the structure of the manual and in making
> >>>>> references to a specific section.
> >>>>>
> >>>> Hi Mathieu,
> >>>>
> >>>> I did abuse of section numbers myself, and I now don't see what they
> >> bring. Can't we refer to the section itself? So we need a cluttering
> number
> >> for
> >>>> that, and why? What does it had? Is it not cargo cult?
> >>>>
> >>>> Jacques
> >>>>
> >>>>
> >>> No other opinions?
> >>>
> >>> Jacques
> >>>
>


Re: OFBiz as Marketplace

2018-12-08 Thread Rishi Solanki
Thank you Ratnesh for nicely summarizing all the details. And yes we can go
with this plan and will change it as we move forward.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Fri, Dec 7, 2018 at 6:27 PM Ratnesh Upadhyay 
wrote:

> Hi Devs,
>
> Thanks everyone for such a valuable discussion and inputs. Before we start
> on user stories I would like to share the basic plan based upon inputs on
> this thread. Ideally we should have three main actors Customers, Sellers
> and Marketplace Operators in system and now we can define the user stories
> on the basis these actors.Here are features/workflows that we are targeting
> to implement for all these three actors :
>
> 1) Marketplace For Customers:
>
>- Customer should be able to see different sellers selling same product
>and prices offered.
>- Customer should be able to purchase product from range of sellers.
>- Customer should be able to see all offers and promotions by sellers
>and best offer with lower price or promoted seller on marketplace
> should be
>on top.
>- Customer should be able to see shipping rates and return policy of the
>seller.
>- Customer can see seller profile with following information.
>   - Launch date
>   - Return and Warranties
>   - Shipping
>   - Policies
>   - Rating
>   - Products (Other products sale by seller)
>- Customer can purchase products from different sellers in single order.
>
> 2) Marketplace For Seller:
>
>- Seller profile registration.
>- Seller profile approval or listing process,
>- Seller can add other users to access account like catalog manager,
>order manager etc by permission.
>- User permission management.
>- Manage Seller Profile
>- Product Management
>   - Add product new/existing.
>   - Inventory management.
>   - Price management for product.
>   - Activate and Deactivate product listing.
>   - Add promotion to products.
>- Manage Order
>   - Approve
>   - Cancel
>- Shipment Management
>   - Ship by marketplace flow
>   - Ship by seller flow
>- Inventory Mangement
>   - By marketplace
>   - By seller
>- Manage Return
>   - Issue refund for the cancel order by customer. That means get
>   shipped product back if not accepted at customer end due to some
> reason.
>   - Receive item and issue refund amount. On receiving the item tell
>   marketplace to issue refund.
>
> 3) Marketplace Operator:
>
>- Manage Sellers Listing Approval process.
>- Manage Global Catalog
>- Manage seller performance.
>- Marketing Campaign
>- Manage commission setup etc
>- More items needs to be identified.
>
> Additionally we need to consider the service industry for marketplace. For
> that we need to consider the payment term, product setting and other
> service industry related things differently. Will come up with more
> thoughts while working on user stories.
>
> Thanks Rishi for discussion and finalising the plan. I think we are good to
> proceed with user stories as per aforementioned plan.
>
> Regards,
> Ratnesh Upadhyay
> HotWax Systems | www,hotwaxsystems.com
>
> On Tue, Dec 4, 2018 at 2:22 PM Rishi Solanki 
> wrote:
>
> > Thanks Jacques for the interesting article. And yes we should consider
> the
> > service industry as well for marketplace.
> >
> > --
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
> >
> > On Thu, Nov 29, 2018 at 2:56 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> > > Somehow related I stumbled upon this article recently
> > >
> > >
> >
> https://andrewchen.co/how-marketplaces-will-reinvent-the-service-economy/
> > >
> > > Jacques
> > >
> > >
> > > Le 22/11/2018 à 06:43, Rishi Solanki a écrit :
> > > > Thank you all for your votes and I think now most of us agree with
> the
> > > > idea. So I'll proceed with the plan and start preparing user stories
> > > around
> > > > it. Thank you very much Michael for clarifying the understanding.
> > > >
> > > > @Taher, I really tried very hard to connect both ideas and wanted to
> > run
> > > > them in parallel :-). Please feel free to include me in your idea
> where
> > > you
>

Re: OFBiz as Marketplace

2018-12-04 Thread Rishi Solanki
Thanks Jacques for the interesting article. And yes we should consider the
service industry as well for marketplace.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Thu, Nov 29, 2018 at 2:56 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Somehow related I stumbled upon this article recently
>
> https://andrewchen.co/how-marketplaces-will-reinvent-the-service-economy/
>
> Jacques
>
>
> Le 22/11/2018 à 06:43, Rishi Solanki a écrit :
> > Thank you all for your votes and I think now most of us agree with the
> > idea. So I'll proceed with the plan and start preparing user stories
> around
> > it. Thank you very much Michael for clarifying the understanding.
> >
> > @Taher, I really tried very hard to connect both ideas and wanted to run
> > them in parallel :-). Please feel free to include me in your idea where
> you
> > feel I can help and you can use.
> >
> > +1 from my side for plugin marketplace, I would be happy to be part of
> that
> > effort.
> >
> >
> > --
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
> >
> > On Thu, Nov 22, 2018 at 10:29 AM Aditya Sharma <
> > aditya.sha...@hotwaxsystems.com> wrote:
> >
> >> Nice initiative.
> >>
> >> +1 for the marketplace as a new OFBiz plugin
> >>
> >> Thanks and Regards,
> >>
> >> *Aditya Sharma* | Enterprise Software Engineer
> >> HotWax Commerce <http://www.hotwax.co/> by HotWax Systems
> >> <http://www.hotwaxsystems.com/>
> >> [image: https://www.linkedin.com/in/aditya-p-sharma/]
> >> <https://www.linkedin.com/in/aditya-p-sharma/>
> >>
> >>
> >> On Wed, Nov 21, 2018 at 5:02 PM Taher Alkhateeb <
> >> slidingfilame...@gmail.com>
> >> wrote:
> >>
> >>> Oh, I guess I am probably completely mistaken if what you explained is
> >>> correct. My bad :)
> >>> On Wed, Nov 21, 2018 at 1:03 AM Michael Brohl <
> michael.br...@ecomify.de>
> >>> wrote:
> >>>> Hi Taher,
> >>>>
> >>>> I only read the thread briefly but I have the feeling that there is a
> >>>> fundamental misunderstanding with the term "marketplace".
> >>>>
> >>>> I guess that Rishi is talking about a marketplace for selling goods by
> >>>> several independent merchants (like Amazon) while you are talking
> about
> >>>> a plugin marketplace.
> >>>>
> >>>> Am I right or is it a misunderstanding on my side?
> >>>>
> >>>> Best regards,
> >>>>
> >>>> Michael
> >>>>
> >>>>
> >>>> Am 20.11.18 um 13:50 schrieb Taher Alkhateeb:
> >>>>> Hi Rishi,
> >>>>>
> >>>>> The plugin APIs would dominate and drive how we can use and publish
> >>>>> plugins, and therefore, dominate how you design the plugin market
> >>>>> place. So I think it might be a bit difficult to write something
> >>>>> without knowing how it works. Take these as an example:
> >>>>>
> >>>>> - Can I push to a remote maven repository? Can I pull from a remote
> >>>>> maven repository? Is it only one official repository (apache) or can
> >> I
> >>>>> pass a command in the command line to change the repo.
> >>>>> - Can I protect some plugins from downloads with a username and
> >>>>> password (I want to sell plugins and after that you get access to my
> >>>>> repo)
> >>>>> - Should I make plugins depend on other plugins? How should that
> >> work,
> >>>>> manually or automatically?
> >>>>> - Who / how can plugins be published? What versioning scheme do we
> >>>>> use? How can we _upgrade_ plugins?
> >>>>> - What are the coding conventions for plugins? What kind of usual
> >>>>> install / uninstall steps are necessary
> >>>>>
> >>>>> These questions and some others are affected by the technology
> >> itself.
> >>>>> The technology could hinder your stories if does not have the
> >> capacity
> >>>>&

Re: Upgrading gradle to version 5.0

2018-12-04 Thread Rishi Solanki
Thanks Taher!

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Mon, Dec 3, 2018 at 10:08 PM Taher Alkhateeb 
wrote:

> upgraded in r1848062 and referenced in OFBIZ-9972. Thank you all folks
> On Thu, Nov 29, 2018 at 11:52 AM Deepak Dixit 
> wrote:
> >
> > +1,
> > After applying patch its working fine.
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> >
> >
> >
> > On Thu, Nov 29, 2018 at 1:53 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> > > Thanks for the tip Girish!
> > >
> > > Jacques
> > >
> > >
> > > Le 29/11/2018 à 07:34, Girish Vasmatkar a écrit :
> > > > Hi Taher
> > > >
> > > > I'm all for it. I have also updated the version and it seems to be
> > > working
> > > > just fine in my workspace.
> > > >
> > > > Just a very minor caveat I noticed with the upgrade is that you
> don't see
> > > > what all tasks gradle executed, while the earlier versions showed the
> > > > executed tasks and their corresponding output.
> > > >
> > > > With the newer version you see -  Build Successful on the terminal.
> More
> > > > often than not we are not going to be bothered by this, but having it
> > > > display the executed tasks helps debugging, I feel.
> > > >
> > > > Here's
> > > > <
> > >
> https://stackoverflow.com/questions/45883963/gradle-4-0-does-not-display-executed-tasks-in-command-line
> > > >
> > > > the
> > > > solution that worked for me.
> > > >
> > > > Best,
> > > > Girish
> > > >
> > > > On Wed, Nov 28, 2018 at 11:26 PM Taher Alkhateeb <
> > > slidingfilame...@gmail.com>
> > > > wrote:
> > > >
> > > >> Hello Everyone,
> > > >>
> > > >> I just received some good news from Mathieu Lirzin (Thank you
> Mathieu)
> > > >> on the state of Gradle. Essentially, we were worried about gradle
> > > >> deprecating spaces used in task names which led to problems in
> issuing
> > > >> our standard server commands [1]. Thankfully, it seems this issue is
> > > >> resolved, the gradle folks seem to have changed their minds and we
> can
> > > >> continue as usual.
> > > >>
> > > >> Therefore, I recommend we upgrade gradle to version 5. It is a lot
> > > >> faster for loading (it runs parallel processes for downloading
> > > >> dependencies) and it is also more compatible with newer versions of
> > > >> Java.
> > > >>
> > > >> https://issues.apache.org/jira/browse/OFBIZ-9972
> > > >>
> > >
> > >
>


Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration

2018-11-24 Thread Rishi Solanki
Thanks Pritam!!

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sat, Nov 24, 2018 at 3:08 PM Pritam Kute 
wrote:

> Thanks all for your inputs.
>
> I have updated the first pass of the implementation on the ticket [1].
>
> Request all to have a look and provide feedback.
>
> [1]: https://issues.apache.org/jira/browse/OFBIZ-10457
>
> Thanks
> --
> Pritam Kute
>
> On Fri, Aug 24, 2018 at 2:12 AM Nicolas Malin 
> wrote:
>
> > Hello Pritam,
> >
> > Maybe I arrived after the war still I wish sharing my opinion :)
> >
> > General term Sms seems to be too specific, I would've oriented on
> > TelecomGateway
> >
> > * ProductStoreTelecomGatewaySetting (too long :))
> > * TelecomGatewayConfig
> > * TelecomGatewayConfigType, and so on
> >
> > For the attributes :
> > * configId is too generic and already use on productConfig entity. It's
> > preferable to have unique name in OFBiz as primaryKey (same for
> settingId)
> > * parentSmsConfigTypeId need to rename on parentTypeId if you want to
> > follow EntityType pattern.
> >
> > Why set the purpose (smsTypeId) on SmsTemplateSetting instead of on
> > ProductStoreSmsSetting where the template application will be done ?
> >
> > What do you imagine behind the CustomMethod linked to SmsTemplateSetting
> ?
> >
> > That's all I'll stop bothering you :)
> >
> > Cheers,
> >
> > Nicolas
> >
> > On 02/07/2018 11:22, Pritam Kute wrote:
> > > Hello Devs,
> > >
> > > Sorry for such a long delay.
> > >
> > > Thanks, Michael for your inputs. I have added design proposal for the
> SMS
> > > gateway integration and can be accessed here
> > > <https://cwiki.apache.org/confluence/x/Zgo0BQ>:
> > > https://cwiki.apache.org/confluence/x/Zgo0BQ
> > >
> > > Please go through the design and let me know if there are any
> questions,
> > > suggestions or improvements which we can do.
> > >
> > > Thanks to Devanshu Vyas and Aishwary Shrivastava for helping me with
> the
> > > design and documentation.
> > >
> > > Thanks and Regards
> > > --
> > > Pritam Kute
> > >
> > > On Sun, Sep 10, 2017 at 4:33 PM Michael Brohl <
> michael.br...@ecomify.de>
> > > wrote:
> > >
> > >> +1
> > >>
> > >> Looking forward to the design proposal.
> > >>
> > >> You can use the wiki with a new page under
> > >>
> > >>
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Requirements+and+Design+Proposals
> > >> to provide the details and support collaboration.
> > >>
> > >> Thanks,
> > >>
> > >> Michael
> > >>
> > >> Am 26.08.17 um 13:31 schrieb Pritam Kute:
> > >>> Hi Devs,
> > >>>
> > >>> Many e-commerce businesses (especially operating in Asian countries)
> > >>> nowadays use short messaging service (SMS) in mobile phones to notify
> > and
> > >>> update customers about order details, shipment statuses etc.
> > >>>
> > >>> I would like to propose an SMS Gateway Integration in Ofbiz. I will
> > share
> > >>> proposed design details with you all soon. Till then, I would like to
> > >> know
> > >>> your thoughts on this idea.
> > >>>
> > >>> Thanks and Regards
> > >>> --
> > >>> Pritam Kute
> > >>>
> > >>
> > >>
> >
> >
>


Re: OFBiz as Marketplace

2018-11-24 Thread Rishi Solanki
Thanks Shi Jinghai adding more information on the topic. Now with all these
information and details in my mind, I would be starting documentation
around it by adding user stories.
I'm thinking to add documents at OFBiz wiki at -

Home >> Documentation >> Proposal (or New Proposed Features) >> Marketplace
OR
Home >> Documentation >> OFBiz Features >> Proposal (or New Proposed
Features) >> Marketplace

Until we finalize the document location, will prepare it on google docs.
Please let me know how community would like to proceed further on it.  Also
in case any one have any other location where we can put this proposal.

Thanks to all for your help and suggestions.

Best Regards,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Fri, Nov 23, 2018 at 3:44 PM Shi Jinghai  wrote:

> +1
>
> Current OFBiz ecommerce is for single product store running the website, a
> market place website is a product store delegates many stores. So the whole
> set of ShoppingList/Item, OrderHeader/Item, OrderAssoc, Shipment,
> Return/Refund has to be changed accordingly.
>
> In China, a typical procedure is:
> 1. Customer adds products from stores into shopping list
> 2. Customer selects shopping list items to check out
> 3. Marketplace generates an original order and splits the order to a set
> of orders for each store to reduce the QOH/QTP or lock the inventory if
> necessary
> 4. Customer pays the original order to the market place
> 5. Marketplace changes the whole set of orders to approved status
> 6. Each store ships its own orders separately
> 7. Return:
>   7.1 Customer returns a product to the store directly
>   7.2 Store approves the return
>   7.3 Maketplace refunds the customer
>   * For VIP customer, 7.3 would be 7.2, 7.2 be 7.3
> 8. The payment from marketplace to store may have a term
> 9. The marketplace commission is from 0% to 15%
>
> Kind Regards,
>
> Shi Jinghai
>
>
> -邮件原件-
> 发件人: Rishi Solanki [mailto:rishisolan...@gmail.com]
> 发送时间: 2018年11月13日 20:36
> 收件人: dev@ofbiz.apache.org
> 主题: OFBiz as Marketplace
>
> Devs,
> While shopping with different marketplaces like amazon the idea came into
> my mind that, what are the things required to have an marketplace plugin
> within the OFBiz same as we have ecommerce.
>
> Which behaves same as ecommerce but also offers sellers to sale their
> products on marketplace. I could think of following workflow;
>
> 1) Sellers can upload their product, images, prices with all the required
> details.
> 2) The same product can be sale by other sellers as well.
> 3) An customer can purchase the product from any listed sellers at
> ecommerce side.
> 4) Manage the product inventory by sellers.
> 5) Shipment tracking.
> 6) Manage/Create seller profile.
> 7) Commission Engine marketplace run and payment made to sellers.
> 8) Manage product details as per seller preferences.
> 9) Seller specific reports and other tasks.
> 10) Manage Orders, Returns and related reports etc.
> 11) Marketing Campaign setup.
>
> Here I'm sharing the idea what comes in my mind, and it would be great to
> have this as plugin in OFBiz which support the marketplace business problem
> and increase the OFBiz acceptance in market.
>
> Any suggestion and help in designing, structuring, modeling, coding,
> architecture is greatly appreciated. I wonder if anyone already implemented
> one using OFBiz.
>
> If all are agree to have this, then I'll start documentation around it and
> move from there.
>
> Thanks!
>
> Best Regards,
> --
> Rishi Solanki
> Sr Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
> www.hotwax.co
>


Re: OFBiz as Marketplace

2018-11-21 Thread Rishi Solanki
Thank you all for your votes and I think now most of us agree with the
idea. So I'll proceed with the plan and start preparing user stories around
it. Thank you very much Michael for clarifying the understanding.

@Taher, I really tried very hard to connect both ideas and wanted to run
them in parallel :-). Please feel free to include me in your idea where you
feel I can help and you can use.

+1 from my side for plugin marketplace, I would be happy to be part of that
effort.


--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Thu, Nov 22, 2018 at 10:29 AM Aditya Sharma <
aditya.sha...@hotwaxsystems.com> wrote:

> Nice initiative.
>
> +1 for the marketplace as a new OFBiz plugin
>
> Thanks and Regards,
>
> *Aditya Sharma* | Enterprise Software Engineer
> HotWax Commerce <http://www.hotwax.co/> by HotWax Systems
> <http://www.hotwaxsystems.com/>
> [image: https://www.linkedin.com/in/aditya-p-sharma/]
> <https://www.linkedin.com/in/aditya-p-sharma/>
>
>
> On Wed, Nov 21, 2018 at 5:02 PM Taher Alkhateeb <
> slidingfilame...@gmail.com>
> wrote:
>
> > Oh, I guess I am probably completely mistaken if what you explained is
> > correct. My bad :)
> > On Wed, Nov 21, 2018 at 1:03 AM Michael Brohl 
> > wrote:
> > >
> > > Hi Taher,
> > >
> > > I only read the thread briefly but I have the feeling that there is a
> > > fundamental misunderstanding with the term "marketplace".
> > >
> > > I guess that Rishi is talking about a marketplace for selling goods by
> > > several independent merchants (like Amazon) while you are talking about
> > > a plugin marketplace.
> > >
> > > Am I right or is it a misunderstanding on my side?
> > >
> > > Best regards,
> > >
> > > Michael
> > >
> > >
> > > Am 20.11.18 um 13:50 schrieb Taher Alkhateeb:
> > > > Hi Rishi,
> > > >
> > > > The plugin APIs would dominate and drive how we can use and publish
> > > > plugins, and therefore, dominate how you design the plugin market
> > > > place. So I think it might be a bit difficult to write something
> > > > without knowing how it works. Take these as an example:
> > > >
> > > > - Can I push to a remote maven repository? Can I pull from a remote
> > > > maven repository? Is it only one official repository (apache) or can
> I
> > > > pass a command in the command line to change the repo.
> > > > - Can I protect some plugins from downloads with a username and
> > > > password (I want to sell plugins and after that you get access to my
> > > > repo)
> > > > - Should I make plugins depend on other plugins? How should that
> work,
> > > > manually or automatically?
> > > > - Who / how can plugins be published? What versioning scheme do we
> > > > use? How can we _upgrade_ plugins?
> > > > - What are the coding conventions for plugins? What kind of usual
> > > > install / uninstall steps are necessary
> > > >
> > > > These questions and some others are affected by the technology
> itself.
> > > > The technology could hinder your stories if does not have the
> capacity
> > > > to do this or that. That's why I suggested thinking about this
> process
> > > > through the APIs.
> > > >
> > > > I wrote the below tasks for plugins management a while ago. But they
> > > > are still not complete and require reviews and improvements to
> satisfy
> > > > all the stories. But this is where our starting point is:
> > > >
> > > > createPlugin - create a new plugin component based on specified
> > templates
> > > > installPlugin - executes plugin install task if it exists
> > > > pullAllPluginsSource - Download and install all plugins from source
> > > > control. Warning! deletes existing plugins
> > > > pullPlugin - Download and install a plugin with all dependencies
> > > > pullPluginSource - Download and install a plugin from source control
> > > > pushPlugin - push an existing plugin to local maven repository
> > > > removePlugin - Uninstall a plugin and delete its files
> > > > uninstallPlugin - executes plugin uninstall task if it exists
> > > >
> > > > The pull and push are currently hardcoded, so we need to parameterize
> > > > the maven repository to accommodate diff

Re: OFBiz as Marketplace

2018-11-19 Thread Rishi Solanki
Thanks Jacopo for your suggestion, so we will go with new plugin for
marketplace and will name it marketplace. I hope all are agree with name.

Taher, we would require at least one month (may be more) to spend on user
stories for marketplace, before writing single line of code for it. I would
be happy if I could help to complete the plugins api and deploying on maven
nexus repository. Please let me know how to proceed further and how I can
be useful. In the mean time we will proceed with user stories for
marketplace. I'm considering both as independent work can go parallel.

Please raise flag in case I misunderstood something and requires hold on
marketplace work. Thanks!

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sat, Nov 17, 2018 at 3:05 PM Taher Alkhateeb 
wrote:

> It's been a while since we worked on this, but the most important
> thing to do in my opinion is the following:
> 1- complete the plugin API (currently written as gradle tasks) to
> pull, push, and handle plugins
> 2- complete the work around deploying our official plugins on maven
> nexus repository belonging to apache.
>
> If anyone is willing to help, I'd love to give you an update on
> everything I've done so far. But I think without having a solid plugin
> API for managing plugins then adoption and a market place would be a
> more challenging.
> On Fri, Nov 16, 2018 at 1:50 PM Jacopo Cappellato
>  wrote:
> >
> > +1 to the plugin option!
> >
> > Jacopo
> >
> > On Fri, Nov 16, 2018 at 3:51 PM Rishi Solanki 
> > wrote:
> >
> > > Thank you Jacopo for detailed reply. It is like roadmap for
> implementation
> > > with questions may come during implementation.
> > > Thanks Pritam, Devanshu for help offer.
> > >
> > > I have similar line of items in my mind before proceeding with the idea
> > > with some additional concerns on how to proceed below;
> > >
> > > - We have two options to go with, add marketplace operator features to
> > > ordermgr, seller profiles to partymgr and customer facing to ecommerce.
> > > Alternatively, I preferred to add separate plugin which extends these
> > > applications and have its own functionality. Which also take care of
> any
> > > impact on base applications.
> > > - By adding separate plugin we will have free hand to incorporate the
> > > marketplace specific features. Like you said that, drop ship flow is
> near
> > > to what marketplace requires. But in my experience I see marketplace
> > > optionally owns the shipment from sellers to customers using third
> party
> > > support.
> > >
> > > On the whole I would like to propose separate plugin and once we are
> okay
> > > with separate plugin or inject features in existing ordermgr, partymgr
> and
> > > ecommerce application then we can start writing user stories to take
> > > community feedback. I completely agree on the fact we have gaps but we
> have
> > > most building blocks in place to achieve this.
> > >
> > > Please let me know your opinion on having separate plugin. Also looking
> > > forward to see opinion from community, so that we can move with better
> plan
> > > to execute.
> > >
> > > Best Regards,
> > > --
> > > Rishi Solanki
> > > Sr Manager, Enterprise Software Development
> > > HotWax Systems Pvt. Ltd.
> > > Direct: +91-9893287847
> > > http://www.hotwaxsystems.com
> > > www.hotwax.co
> > >
> > >
> > > On Thu, Nov 15, 2018 at 5:52 PM Jacopo Cappellato <
> > > jacopo.cappell...@hotwaxsystems.com> wrote:
> > >
> > > > Hi Rishi,
> > > >
> > > > this is an interesting initiative, thank you.
> > > > There are various types of online marketplaces, each with unique and
> > > > significant requirements, but if we focus on the ones like Amazon
> (since
> > > > you have mentioned it) then we the following notes may apply pretty
> well.
> > > >
> > > > Main actors:
> > > > * the marketplace operator: it owns the site (e.g. Amazon)
> > > > * consumers: browse the content of the site and place (sales) orders
> to
> > > the
> > > > marketplace operator
> > > > * retailers/wholesalers/sellers: define price (and cost to the
> > > marketplace
> > > > operator), shipping options and shipping cost
> > > >
> > > > Main transactions (drop shipment scenario):
> &

Re: OFBiz as Marketplace

2018-11-16 Thread Rishi Solanki
Thank you Jacopo for detailed reply. It is like roadmap for implementation
with questions may come during implementation.
Thanks Pritam, Devanshu for help offer.

I have similar line of items in my mind before proceeding with the idea
with some additional concerns on how to proceed below;

- We have two options to go with, add marketplace operator features to
ordermgr, seller profiles to partymgr and customer facing to ecommerce.
Alternatively, I preferred to add separate plugin which extends these
applications and have its own functionality. Which also take care of any
impact on base applications.
- By adding separate plugin we will have free hand to incorporate the
marketplace specific features. Like you said that, drop ship flow is near
to what marketplace requires. But in my experience I see marketplace
optionally owns the shipment from sellers to customers using third party
support.

On the whole I would like to propose separate plugin and once we are okay
with separate plugin or inject features in existing ordermgr, partymgr and
ecommerce application then we can start writing user stories to take
community feedback. I completely agree on the fact we have gaps but we have
most building blocks in place to achieve this.

Please let me know your opinion on having separate plugin. Also looking
forward to see opinion from community, so that we can move with better plan
to execute.

Best Regards,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Thu, Nov 15, 2018 at 5:52 PM Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

> Hi Rishi,
>
> this is an interesting initiative, thank you.
> There are various types of online marketplaces, each with unique and
> significant requirements, but if we focus on the ones like Amazon (since
> you have mentioned it) then we the following notes may apply pretty well.
>
> Main actors:
> * the marketplace operator: it owns the site (e.g. Amazon)
> * consumers: browse the content of the site and place (sales) orders to the
> marketplace operator
> * retailers/wholesalers/sellers: define price (and cost to the marketplace
> operator), shipping options and shipping cost
>
> Main transactions (drop shipment scenario):
> 0) seller publishes product price with shipping costs (for the consumer)
> and product cost (for the
> 1) consumers orders product (from the retailer) to the marketplace operator
> 2) marketplace operator orders product to the retailer
> 3) retailer fulfills the order (#2) that is shipped to the consumer
> 4) marketplace operator invoices the order (#1) to the consumer
> 5) consumer pays the invoice (#4)
> 6) retailer invoices the order (#2) to the marketplace operator
> 7) marketplace operator pays the invoice (#6)
>
> These online marketplaces often have one global product catalog and global
> products, to which the retailers' specific prices and shipping options are
> attached.
>
> In OFBiz the "drop shipment" workflow is probably the one that most closely
> covers the scenario described above.
>
> As regards the data model:
> * Product, ProductContent, ProductCategory etc..: global products and the
> global catalog
> * ProductPrice, SupplierProduct: the price for the consumer and the cost
> for the marketplace operator
> * PartyRole: "end user customer" (for the consumer), "supplier" (for the
> retailer), "internal organization" (for the marketplace operator)
>
> There are gaps that needs to be implemented (both in the data model and in
> the business logic) and there are many more requirements and nuances to be
> discovered but we have most of the building blocks in place.
> Some of the outstanding gaps are for example: how to apply the right sales
> price when the consumer selects a product from one of its many retailers;
> how to specify the retailer in the sales order; how to reserve the
> inventory of the retailer.
>
> Kind regards,
>
> Jacopo
>
> On Tue, Nov 13, 2018 at 6:06 PM Rishi Solanki 
> wrote:
>
> > Devs,
> > While shopping with different marketplaces like amazon the idea came into
> > my mind that, what are the things required to have an marketplace plugin
> > within the OFBiz same as we have ecommerce.
> >
> > Which behaves same as ecommerce but also offers sellers to sale their
> > products on marketplace. I could think of following workflow;
> >
> > 1) Sellers can upload their product, images, prices with all the required
> > details.
> > 2) The same product can be sale by other sellers as well.
> > 3) An customer can purchase the product from any listed sellers at
> > ecommerce side.
> > 4) Manage the product inventory by seller

Re: AsciiDoc generated online documentation and releases

2018-11-16 Thread Rishi Solanki
+1 for backport.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Thu, Nov 15, 2018 at 10:56 PM Pierre Smits 
wrote:

> Hi Jacques,
>
> I support the suggestion made by Sharan. It should not be too difficult,
> when a release has been made available (this should be part of the release
> activities), to generate the 'release' related documents and hook it into
> the website. Our (potential) adopters will benefit.
>
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
> since 2008*
> Apache Steve <https://steve.apache.org>, committer
>
>
> On Thu, Nov 15, 2018 at 12:59 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > At
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/Draft+Documentation+Roadmap
> >
> > Sharan already suggested to "Backport to releases where possible"
> >
> > I think we should do that and not way R18 to use the AsciiDoc generation
> > even if it's not complete
> >
> > Opinions before I get ahead?
> >
> > Jacques
> >
> >
> > Le 14/11/2018 à 08:41, Jacques Le Roux a écrit :
> > > Hi,
> > >
> > > So start this discussion, currently our main documents in docs\asciidoc
> > refer to the R17 release. But those document don't exist in R17 branch.
> > >
> > > I think it's not too late to backport them, but do we want to do so?
> > >
> > > Also I suggested to have an easy access to the documentation from the
> > site documentation page.
> > >
> > > Do we also want to use the AsciiDoc generated documentation as we did
> to
> > provide an online help from the applications?
> > >
> > > Do we want to provide something like
> > https://demo-trunk.ofbiz.apache.org/cmssite/cms/APACHE_OFBIZ_HTML?
> > >
> > > For me the answers to these questions is NO! We should have a sole
> entry
> > point for the documentation and it should be from the site documentation
> > > page. It's then easy to provide links from there (using anchors going
> to
> > automatically generated IDs sections)
> > >
> > > What are your opinions? (I know I should re-read this thread
> > https://markmail.org/message/35ak34fpzlyjiopt and I started...)
> > >
> > > Jacques
> > >
> > >
> >
> >
>


Re: OFBiz as Marketplace

2018-11-13 Thread Rishi Solanki
Thanks Swapnil and Sanjay for your inputs.

@Swapnil Yes I see users are asking for suggestions and many are trying to
implement their own custom projects using OFBiz. This is the reason I would
like to have basic architecture which can be used to further customization
in framework. Thanks for bringing it.

Best Regards,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Wed, Nov 14, 2018 at 10:25 AM Sanjay Yadav <
sanjay.ya...@hotwaxsystems.com> wrote:

> Nice initiative. +1 from my side.
>
> Best Regards,
>
> *Sanjay Yadav* | Manager, Enterprise Quality Assurance
> HotWax Commerce <http://www.hotwax.co/> by HotWax Systems
> <http://www.hotwaxsystems.com/>
> 80, Scheme No. 78, Indore, M.P. 452010, India
> Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
> <https://www.linkedin.com/in/sanjay-yadav/>
>
>
> On Tue, Nov 13, 2018 at 6:06 PM Rishi Solanki 
> wrote:
>
> > Devs,
> > While shopping with different marketplaces like amazon the idea came into
> > my mind that, what are the things required to have an marketplace plugin
> > within the OFBiz same as we have ecommerce.
> >
> > Which behaves same as ecommerce but also offers sellers to sale their
> > products on marketplace. I could think of following workflow;
> >
> > 1) Sellers can upload their product, images, prices with all the required
> > details.
> > 2) The same product can be sale by other sellers as well.
> > 3) An customer can purchase the product from any listed sellers at
> > ecommerce side.
> > 4) Manage the product inventory by sellers.
> > 5) Shipment tracking.
> > 6) Manage/Create seller profile.
> > 7) Commission Engine marketplace run and payment made to sellers.
> > 8) Manage product details as per seller preferences.
> > 9) Seller specific reports and other tasks.
> > 10) Manage Orders, Returns and related reports etc.
> > 11) Marketing Campaign setup.
> >
> > Here I'm sharing the idea what comes in my mind, and it would be great to
> > have this as plugin in OFBiz which support the marketplace business
> problem
> > and increase the OFBiz acceptance in market.
> >
> > Any suggestion and help in designing, structuring, modeling, coding,
> > architecture is greatly appreciated. I wonder if anyone already
> implemented
> > one using OFBiz.
> >
> > If all are agree to have this, then I'll start documentation around it
> and
> > move from there.
> >
> > Thanks!
> >
> > Best Regards,
> > --
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
>


OFBiz as Marketplace

2018-11-13 Thread Rishi Solanki
Devs,
While shopping with different marketplaces like amazon the idea came into
my mind that, what are the things required to have an marketplace plugin
within the OFBiz same as we have ecommerce.

Which behaves same as ecommerce but also offers sellers to sale their
products on marketplace. I could think of following workflow;

1) Sellers can upload their product, images, prices with all the required
details.
2) The same product can be sale by other sellers as well.
3) An customer can purchase the product from any listed sellers at
ecommerce side.
4) Manage the product inventory by sellers.
5) Shipment tracking.
6) Manage/Create seller profile.
7) Commission Engine marketplace run and payment made to sellers.
8) Manage product details as per seller preferences.
9) Seller specific reports and other tasks.
10) Manage Orders, Returns and related reports etc.
11) Marketing Campaign setup.

Here I'm sharing the idea what comes in my mind, and it would be great to
have this as plugin in OFBiz which support the marketplace business problem
and increase the OFBiz acceptance in market.

Any suggestion and help in designing, structuring, modeling, coding,
architecture is greatly appreciated. I wonder if anyone already implemented
one using OFBiz.

If all are agree to have this, then I'll start documentation around it and
move from there.

Thanks!

Best Regards,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


Re: svn commit: r1845572 - in /ofbiz/ofbiz-framework/trunk/framework/webtools: config/ src/main/java/org/apache/ofbiz/webtools/ webapp/webtools/WEB-INF/ widget/

2018-11-10 Thread Rishi Solanki
Done at revision 1846298. Thanks!

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sat, Nov 10, 2018 at 2:15 PM Rishi Solanki 
wrote:

> Thanks Aditya for review and feedback. Will take care of it soon.
>
> --
> Rishi Solanki
> Sr Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
> www.hotwax.co
>
>
> On Sat, Nov 10, 2018 at 10:24 AM Aditya Sharma <
> aditya.sha...@hotwaxsystems.com> wrote:
>
>> Hi Rishi,
>>
>> I think you missed the import with a wildcard in UtilCacheEvents.java.
>>
>> >+import java.util.*;
>>
>> Though I think it may have been slipped in due to IDE. Using the wildcard
>> may clutter local namespace with all the classes of util package.
>>
>> Thanks and Regards,
>>
>> *Aditya Sharma* | Enterprise Software Engineer
>> HotWax Commerce <http://www.hotwax.co/> by HotWax Systems
>> <http://www.hotwaxsystems.com/>
>> [image: https://www.linkedin.com/in/aditya-p-sharma/]
>> <https://www.linkedin.com/in/aditya-p-sharma/>
>>
>>
>> On Fri, Nov 2, 2018 at 4:48 PM  wrote:
>>
>> > Author: rishi
>> > Date: Fri Nov  2 11:18:52 2018
>> > New Revision: 1845572
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1845572=rev
>> > Log:
>> > Improved: Introduce ability to clear specific cache from cache
>> > maintenance. After this user can bulk select the caches and clear them.
>> > Single clear and all clear caches works as is.
>> > (OFBIZ-10402)
>> > Thanks to Yogesh Naroliya for providing the patch and Suraj Khurana for
>> > reporting the ticket.
>> >
>> > Modified:
>> >
>> >
>> ofbiz/ofbiz-framework/trunk/framework/webtools/config/WebtoolsUiLabels.xml
>> >
>> >
>> ofbiz/ofbiz-framework/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/UtilCacheEvents.java
>> >
>> >
>> ofbiz/ofbiz-framework/trunk/framework/webtools/webapp/webtools/WEB-INF/controller.xml
>> > ofbiz/ofbiz-framework/trunk/framework/webtools/widget/CacheForms.xml
>> >
>>  ofbiz/ofbiz-framework/trunk/framework/webtools/widget/CacheScreens.xml
>> > ofbiz/ofbiz-framework/trunk/framework/webtools/widget/Menus.xml
>> >
>> > Modified:
>> >
>> ofbiz/ofbiz-framework/trunk/framework/webtools/config/WebtoolsUiLabels.xml
>> > URL:
>> >
>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webtools/config/WebtoolsUiLabels.xml?rev=1845572=1845571=1845572=diff
>> >
>> >
>> ==
>> > ---
>> >
>> ofbiz/ofbiz-framework/trunk/framework/webtools/config/WebtoolsUiLabels.xml
>> > (original)
>> > +++
>> >
>> ofbiz/ofbiz-framework/trunk/framework/webtools/config/WebtoolsUiLabels.xml
>> > Fri Nov  2 11:18:52 2018
>> > @@ -1150,6 +1150,9 @@
>> >  清除这个缓存
>> >  æ¸…é™¤é€™å€‹å¿«å –
>> >  
>> > +
>> > +Clear Selected Caches
>> > +
>> >  
>> >  OFBiz: Web Tools
>> >  OFBiz: Web Tools
>> >
>> > Modified:
>> >
>> ofbiz/ofbiz-framework/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/UtilCacheEvents.java
>> > URL:
>> >
>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/UtilCacheEvents.java?rev=1845572=1845571=1845572=diff
>> >
>> >
>> ==
>> > ---
>> >
>> ofbiz/ofbiz-framework/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/UtilCacheEvents.java
>> > (original)
>> > +++
>> >
>> ofbiz/ofbiz-framework/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/UtilCacheEvents.java
>> > Fri Nov  2 11:18:52 2018
>> > @@ -17,10 +17,7 @@
>> >   * under the License.
>> >
>> >
>> ***/
>> >  package org.apache.ofbiz.webtools;
>> > -
>> > -import java.util.Iterator;
>> > -import java.util.Locale;
>> > -
>> > +import java.util.*;
>> >  import javax.servlet.http.HttpServletRequest;
>&

Re: svn commit: r1845572 - in /ofbiz/ofbiz-framework/trunk/framework/webtools: config/ src/main/java/org/apache/ofbiz/webtools/ webapp/webtools/WEB-INF/ widget/

2018-11-10 Thread Rishi Solanki
Thanks Aditya for review and feedback. Will take care of it soon.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sat, Nov 10, 2018 at 10:24 AM Aditya Sharma <
aditya.sha...@hotwaxsystems.com> wrote:

> Hi Rishi,
>
> I think you missed the import with a wildcard in UtilCacheEvents.java.
>
> >+import java.util.*;
>
> Though I think it may have been slipped in due to IDE. Using the wildcard
> may clutter local namespace with all the classes of util package.
>
> Thanks and Regards,
>
> *Aditya Sharma* | Enterprise Software Engineer
> HotWax Commerce <http://www.hotwax.co/> by HotWax Systems
> <http://www.hotwaxsystems.com/>
> [image: https://www.linkedin.com/in/aditya-p-sharma/]
> <https://www.linkedin.com/in/aditya-p-sharma/>
>
>
> On Fri, Nov 2, 2018 at 4:48 PM  wrote:
>
> > Author: rishi
> > Date: Fri Nov  2 11:18:52 2018
> > New Revision: 1845572
> >
> > URL: http://svn.apache.org/viewvc?rev=1845572=rev
> > Log:
> > Improved: Introduce ability to clear specific cache from cache
> > maintenance. After this user can bulk select the caches and clear them.
> > Single clear and all clear caches works as is.
> > (OFBIZ-10402)
> > Thanks to Yogesh Naroliya for providing the patch and Suraj Khurana for
> > reporting the ticket.
> >
> > Modified:
> >
> >
> ofbiz/ofbiz-framework/trunk/framework/webtools/config/WebtoolsUiLabels.xml
> >
> >
> ofbiz/ofbiz-framework/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/UtilCacheEvents.java
> >
> >
> ofbiz/ofbiz-framework/trunk/framework/webtools/webapp/webtools/WEB-INF/controller.xml
> > ofbiz/ofbiz-framework/trunk/framework/webtools/widget/CacheForms.xml
> >
>  ofbiz/ofbiz-framework/trunk/framework/webtools/widget/CacheScreens.xml
> > ofbiz/ofbiz-framework/trunk/framework/webtools/widget/Menus.xml
> >
> > Modified:
> >
> ofbiz/ofbiz-framework/trunk/framework/webtools/config/WebtoolsUiLabels.xml
> > URL:
> >
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webtools/config/WebtoolsUiLabels.xml?rev=1845572=1845571=1845572=diff
> >
> >
> ==
> > ---
> >
> ofbiz/ofbiz-framework/trunk/framework/webtools/config/WebtoolsUiLabels.xml
> > (original)
> > +++
> >
> ofbiz/ofbiz-framework/trunk/framework/webtools/config/WebtoolsUiLabels.xml
> > Fri Nov  2 11:18:52 2018
> > @@ -1150,6 +1150,9 @@
> >  清除这个缓存
> >  æ¸…é™¤é€™å€‹å¿«å –
> >  
> > +
> > +Clear Selected Caches
> > +
> >  
> >  OFBiz: Web Tools
> >  OFBiz: Web Tools
> >
> > Modified:
> >
> ofbiz/ofbiz-framework/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/UtilCacheEvents.java
> > URL:
> >
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/UtilCacheEvents.java?rev=1845572=1845571=1845572=diff
> >
> >
> ==
> > ---
> >
> ofbiz/ofbiz-framework/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/UtilCacheEvents.java
> > (original)
> > +++
> >
> ofbiz/ofbiz-framework/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/UtilCacheEvents.java
> > Fri Nov  2 11:18:52 2018
> > @@ -17,10 +17,7 @@
> >   * under the License.
> >
> >
> ***/
> >  package org.apache.ofbiz.webtools;
> > -
> > -import java.util.Iterator;
> > -import java.util.Locale;
> > -
> > +import java.util.*;
> >  import javax.servlet.http.HttpServletRequest;
> >  import javax.servlet.http.HttpServletResponse;
> >
> > @@ -170,6 +167,56 @@ public final class UtilCacheEvents {
> >  request.setAttribute("_EVENT_MESSAGE_", errMsg + " (" +
> > UtilDateTime.nowDateString("-MM-dd HH:mm:ss")  + ").");
> >  return "success";
> >  }
> > +
> > +/** An HTTP WebEvent handler that clears the selected caches
> > + * @param request The HTTP request object for the current JSP or
> > Servlet request.
> > + * @param response The HTTP response object for the current JSP or
> > Servlet request.
> > + 

Re: Google reCAPTCHA in E-Commerce

2018-11-05 Thread Rishi Solanki
Big +1 for adding this feature with accepted suggestions from Richard. We
can have it store level configuration to enable and disable as per the
store requirements.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Mon, Nov 5, 2018 at 4:15 PM Richard Siddall 
wrote:

> Make it optional.
>
> Taking a user experience point-of-view:  Google reCAPTCHA is a
> technology for punishing internet users for visiting your site.  It
> greatly increases the number of clicks users have to make to achieve a
> goal and increases shopping cart abandonment.
>
> Definitely not something every site administrator is going to want
> polluting their e-commerce site.
>
> Richard.
>
> Deepak Nigam wrote:
> > Hello All,
> >
> > Google reCAPTCHA is a security feature that protects websites forms from
> > spam entries while letting real people pass through with ease. It can be
> > used for login, registration, password recovery, comments, popular
> contact
> > forms, etc.
> > Users are required to confirm that they are not a robot before the form
> can
> > be submitted. It’s easy for people and hard for bots.
> >
> > For more information about Google reCAPATCHA, please visit here
> > <https://developers.google.com/recaptcha/>.
> >
> > I think this feature will be useful for OFBiz e-commerce also. Thoughts?
> >
> >
> > Thanks & Regards
> > --
> > Deepak Nigam
> > HotWax Systems Pvt. Ltd
> >
>
>


Re: Missing Relation Between ProductStoreShipmentMeth and ProductStore

2018-10-09 Thread Rishi Solanki
+1

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Tue, Oct 9, 2018 at 6:40 PM Deepak Nigam 
wrote:

> Thanks, Suraj.
>
> I will create a child ticket for 'ProductStoreShipmentMeth' entity under
> OFBIZ-9671 <https://issues.apache.org/jira/browse/OFBIZ-9671>.
>
> Thanks & Regards
> --
> Deepak Nigam
> HotWax Systems Pvt. Ltd
>
> On Tue, Oct 9, 2018 at 1:28 PM Suraj Khurana <
> suraj.khur...@hotwaxsystems.com> wrote:
>
> > Hello Deepak,
> >
> > Here is the parent ticket for this effort.
> > Ticket: https://issues.apache.org/jira/browse/OFBIZ-9671
> >
> > HTH.
> > --
> > Best Regards,
> > Suraj Khurana
> > Omnichannel OMS Technical Expert
> > HotWax Systems
> >
> > On Tue, Oct 9, 2018 at 1:13 PM, Deepak Nigam  >
> > wrote:
> >
> > > Hello All,
> > >
> > > In the definition of the entity 'ProductStoreShipmentMeth', no relation
> > is
> > > provided with the entity 'ProductStore'. Is this intentional? IMO, we
> > > should provide the relation between the above two, with type="one", to
> > > maintain the referential integrity. WDYT?
> > >
> > >
> > > Thanks & Regards
> > > --
> > > Deepak Nigam
> > > HotWax Systems Pvt. Ltd.
> > >
> >
>


Re: Shipping data duplicated

2018-10-08 Thread Rishi Solanki
Thanks Jacques for your reply and Jira ticket. I'll take care of it asap.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Mon, Oct 8, 2018 at 2:49 PM jler...@apache.org 
wrote:

> Hi Rishi,
>
> Inline...
>
>
> Le 22/09/2018 à 12:34, Rishi Solanki a écrit :
> > Jacques,
> > Thanks for more insights.
> > IMO, we should rename the files as you suggested and also add some
> > description in the file so that we won't confuse by this in future. And
> > also we should keep the duplicate data as well, because when ofbizsetup
> app
> > set the data for store I assume we don't load the demo data.
> > About the ofbizsetup app uses, right now I could not think of it. But
> will
> > get back on it soon with details and get the inputs from community. For
> now
> > my understanding is to rename the setup files and let duplicate data
> exists
> > in the setup files.
> > Let me know if we can proceed with the above plan then will rename the
> > files and do the needful changes in the setup code.
> Agreed, I created OFBIZ-10598 for that
>
> > On ofbizsetup app we
> > will discuss once I come with more details.
> Yes no hurry, I think it needs a bit more review, love and
> documentation/information
> Maybe starting by completing
> https://cwiki.apache.org/confluence/display/OFBENDUSER/How+to+Install+OFBiz+without+the+Demo+Data
> ?
>
> Jacques
>
> >
> > Thanks!
> >
> > --
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
> >
> > On Sat, Sep 22, 2018 at 2:10 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> Hi Rishi,
> >>
> >> Thanks for your feedback.
> >>
> >> Looking closely at history, ShippingData.xml was put in 9 years ago with
> >> http://svn.apache.org/viewvc?view=revision=816083, so for the
> >> ofbizsetup app, which is a bit weirdo in OFBiz.
> >>
> >> Then was modified with OFBIZ-5890 and OFBIZ-7673
> >>
> >> Rest inline...
> >>
> >>
> >> Le 22/09/2018 à 09:27, Rishi Solanki a écrit :
> >>> Hi Jacques,
> >>> I dig into it today and found that the data exists in the
> >>> "applications/datamodel/data/demo/OrderDemoData.xml" was moved from
> >>> "applications/order/data/DemoShipping.xml"
> >>> Also the data claimed as duplicate in
> >>> "applications/commonext/data/ShippingData.xml" is similar but not exact
> >>> matches with OrderDemoData.xml.
> >> Yes, I was only speaking about "Shipping data", ie:
> >> ShipmentMethodType
> >> CarrierShipmentMethod
> >> QuantityBreak
> >> ShipmentBoxType
> >>
> >> Those are real duplicate
> >>> The ShippingData.xml  file has no entry in
> >>> any ofbiz-component.xml.
> >> Indeed, they are only used by the setup app. In SetupEvents.xml there is
> >>
> >>  
> >>   >>
> value="${sys:getProperty('ofbiz.home')}/applications/commonext/data/ShippingData.xml"/>
> >>
> >> Reading that, now I think we should not only keep the "Shipping data" in
> >> ShippingData.xml but also the file. I would rather rename this file and
> >> other ofbizsetup related files (at least data files) with a Setup prefix
> >> to clearly signal they are  part of this app.
> >> But I also wonder if the ofbizsetup app is still alive, maintained and
> >> used by users. Last time I tried I crossed issues (not biggie IIRW). I
> >> found
> >> this https://issues.apache.org/jira/issues/?filter=12344840
> >>
> >> What do you think?
> >>
> >> Jacques
> >>> So here we can decide weather we should keep that data in
> >> ShippingData.xml
> >>> (if someone introduce the file intentionally) or we can remove it from
> >>> trunk. In case no objection I would like to remove it as most data is
> >>> duplicate.
> >>>
> >>> --
> >>> Rishi Solanki
> >>> Sr Manager, Enterprise Software Development
> >>> HotWax Systems Pvt. Ltd.
> >>> Direct: +91-9893287847
> >>> http://www.hotwaxsystems.com
> >>> www.hotwax.co
> >>>
> >>>
> >>> On Sat

Re: Demo Trunk NPE

2018-09-23 Thread Rishi Solanki
Thank you Girish and Swapnil for logs and ticket id It helps. Further will
discuss over ticket shared by Swapnil.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sat, Sep 22, 2018 at 4:06 PM Swapnil Mane 
wrote:

> Hi team,
>
> We have already Jira for this [1].
>
> [1] https://issues.apache.org/jira/browse/OFBIZ-10342
>
>
> - Best Regards,
> Swapnil M Mane
>
> On Sat, Sep 22, 2018 at 3:48 PM Girish Vasmatkar <
> girish.vasmat...@hotwaxsystems.com> wrote:
>
> > Hi Rishi/Mohammad
> >
> > This looks an intermittent issue as I could not reproduce it. However, in
> > webtools, under Fetch Logs, I tried searching for "NullPointer" in the
> > error.log file and it did return some instances of NullPointerException.
> >
> > java.lang.IllegalArgumentException: Error running script at location
> > [component://webtools/groovyScripts/service/Services.groovy]:
> > java.lang.NullPointerException
> > Caused by: java.lang.NullPointerException
> > java.lang.IllegalArgumentException: Error running script at location
> > [component://webtools/groovyScripts/service/Services.groovy]:
> > java.lang.NullPointerException
> > Caused by: java.lang.NullPointerException
> > java.lang.IllegalArgumentException: Error running script at location
> > [component://webtools/groovyScripts/service/Services.groovy]:
> > java.lang.NullPointerException
> > Caused by: java.lang.NullPointerException
> > java.lang.IllegalArgumentException: Error running script at location
> > [component://webtools/groovyScripts/service/Services.groovy]:
> > java.lang.NullPointerException
> > Caused by: java.lang.NullPointerException
> > java.lang.IllegalArgumentException: Error running script at location
> > [component://webtools/groovyScripts/service/Services.groovy]:
> > java.lang.NullPointerException
> > Caused by: java.lang.NullPointerException
> > java.lang.IllegalArgumentException: Error running script at location
> > [component://webtools/groovyScripts/service/Services.groovy]:
> > java.lang.NullPointerException
> > Caused by: java.lang.NullPointerException
> > java.lang.IllegalArgumentException: Error running script at location
> > [component://webtools/groovyScripts/service/Services.groovy]:
> > java.lang.NullPointerException
> > Caused by: java.lang.NullPointerException
> > java.lang.IllegalArgumentException: Error running script at location
> > [component://webtools/groovyScripts/service/Services.groovy]:
> > java.lang.NullPointerException
> > Caused by: java.lang.NullPointerException
> >
> > Best,
> > Girish Vasmatkar
> > HotWax Systems
> >
> > On Sat, Sep 22, 2018 at 3:02 PM Mohammad Kathawala <
> > mohammad.kathaw...@hotwaxsystems.com> wrote:
> >
> > > Working for me.
> > > Regards*,*
> > > *Mohammad Kathawala* | Sr. Technical Consultant
> > > *HotWax Commerce* by *HotWax Systems*
> > > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> > > Indore,
> > > M.P 452010
> > > Cell phone: 7772858789
> > >
> > > HotWax Systems recently received 8 mentions in *The Gartner Digital
> > > Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
> > > research and advisory company. Learn more about our research here
> > > <
> > >
> >
> https://www.gartner.com/technology/media-products/newsletters/HotWax/1-2UVLP6M/index.html
> > > >
> > > .
> > >
> > >
> > > On Sat, Sep 22, 2018 at 2:19 PM Rishi Solanki  >
> > > wrote:
> > >
> > > > Hello Team,
> > > > Browse to Webtools >> Logging >> Service Log on demo trunk returns
> NPE.
> > > >
> > > > Quick Reference:
> > > > https://demo-trunk.ofbiz.apache.org/webtools/control/ServiceLog
> > > >
> > > > Not able to replicate it on local setup, anyone face the same issue
> > then
> > > > please revert back. Will log Jira Ticket for that.
> > > >
> > > > Regards,
> > > > --
> > > > Rishi Solanki
> > > > Sr Manager, Enterprise Software Development
> > > > HotWax Systems Pvt. Ltd.
> > > > Direct: +91-9893287847
> > > > http://www.hotwaxsystems.com
> > > > www.hotwax.co
> > > >
> > >
> >
>


Re: [VOTE] [RELEASE] Apache OFBiz 16.11.05

2018-09-22 Thread Rishi Solanki
+1

Thanks!
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sat, Sep 22, 2018 at 4:01 PM Swapnil Mane 
wrote:

> +1
>
>
> - Best Regards,
> Swapnil M Mane
>
> On Fri, Sep 21, 2018 at 7:56 PM Jacopo Cappellato <
> jacopo.cappell...@hotwaxsystems.com> wrote:
>
> >  This is the vote thread to release a new bug fix release for the
> > release16.11 branch. This new release, "Apache OFBiz 16.11.05" will
> > supersede all the previous releases from the same branch.
> >
> > The release files can be downloaded from here:
> >
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> >
> > and are:
> >
> > * apache-ofbiz-16.11.05.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-16.11.05.zip.asc: the detached signature file
> > * apache-ofbiz-16.11.05.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see
> http://www.apache.org/info/verification.html
> > ).
> >
> > Vote:
> >
> > [ +1] release as Apache OFBiz 16.11.05
> > [ -1] do not release
> >
> > This vote will be open for at least 5 days.
> >
> > For more details about this process please read
> > http://www.apache.org/foundation/voting.html
> >
> > Kind Regards,
> >
> > Jacopo
> >
>


Re: Shipping data duplicated

2018-09-22 Thread Rishi Solanki
Jacques,
Thanks for more insights.
IMO, we should rename the files as you suggested and also add some
description in the file so that we won't confuse by this in future. And
also we should keep the duplicate data as well, because when ofbizsetup app
set the data for store I assume we don't load the demo data.
About the ofbizsetup app uses, right now I could not think of it. But will
get back on it soon with details and get the inputs from community. For now
my understanding is to rename the setup files and let duplicate data exists
in the setup files.
Let me know if we can proceed with the above plan then will rename the
files and do the needful changes in the setup code. On ofbizsetup app we
will discuss once I come with more details.

Thanks!

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sat, Sep 22, 2018 at 2:10 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Rishi,
>
> Thanks for your feedback.
>
> Looking closely at history, ShippingData.xml was put in 9 years ago with
> http://svn.apache.org/viewvc?view=revision=816083, so for the
> ofbizsetup app, which is a bit weirdo in OFBiz.
>
> Then was modified with OFBIZ-5890 and OFBIZ-7673
>
> Rest inline...
>
>
> Le 22/09/2018 à 09:27, Rishi Solanki a écrit :
> > Hi Jacques,
> > I dig into it today and found that the data exists in the
> > "applications/datamodel/data/demo/OrderDemoData.xml" was moved from
> > "applications/order/data/DemoShipping.xml"
> > Also the data claimed as duplicate in
> > "applications/commonext/data/ShippingData.xml" is similar but not exact
> > matches with OrderDemoData.xml.
> Yes, I was only speaking about "Shipping data", ie:
> ShipmentMethodType
> CarrierShipmentMethod
> QuantityBreak
> ShipmentBoxType
>
> Those are real duplicate
> > The ShippingData.xml  file has no entry in
> > any ofbiz-component.xml.
> Indeed, they are only used by the setup app. In SetupEvents.xml there is
>
> 
>  value="${sys:getProperty('ofbiz.home')}/applications/commonext/data/ShippingData.xml"/>
>
> Reading that, now I think we should not only keep the "Shipping data" in
> ShippingData.xml but also the file. I would rather rename this file and
> other ofbizsetup related files (at least data files) with a Setup prefix
> to clearly signal they are  part of this app.
> But I also wonder if the ofbizsetup app is still alive, maintained and
> used by users. Last time I tried I crossed issues (not biggie IIRW). I
> found
> this https://issues.apache.org/jira/issues/?filter=12344840
>
> What do you think?
>
> Jacques
> >
> > So here we can decide weather we should keep that data in
> ShippingData.xml
> > (if someone introduce the file intentionally) or we can remove it from
> > trunk. In case no objection I would like to remove it as most data is
> > duplicate.
> >
> > --
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
> >
> > On Sat, Aug 18, 2018 at 1:17 AM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> Thanks Rishi!
> >>
> >> Jacques
> >>
> >>
> >> Le 17/08/2018 à 15:19, Rishi Solanki a écrit :
> >>> This should be part of effort when we were moving all the seed, ext,
> demo
> >>> data to datamodel component. I see there is no entry to load the
> >>> ShippingData.xml.
> >>> I will check this in next week and fix the duplicate data exists in the
> >>> system, or share the the reason of having this.
> >>>
> >>> Probably, data moved but not removed from commonext. But I'll confirm
> and
> >>> get back.
> >>>
> >>> Thanks!
> >>>
> >>>
> >>>
> >>> Rishi Solanki
> >>> Sr Manager, Enterprise Software Development
> >>> HotWax Systems Pvt. Ltd.
> >>> Direct: +91-9893287847
> >>> http://www.hotwaxsystems.com
> >>> www.hotwax.co
> >>>
> >>> On Wed, Aug 15, 2018 at 10:10 PM, Jacques Le Roux <
> >>> jacques.le.r...@les7arts.com> wrote:
> >>>
> >>>> Hi,
> >>>>
> >>>> Is there a reason why Shipping data are now duplicated in trunk at
> >>>>
> >>>>   applications/commonext/data/ShippingData.xml
> >>>>
> >>>> and
> >>>>
> >>>>   /applications/datamodel/data/demo/OrderDemoData.xml
> >>>>
> >>>> This is not the case with current stable
> >>>>
> >>>> Jacques
> >>>>
> >>>>
> >>
>
>


Demo Trunk NPE

2018-09-22 Thread Rishi Solanki
Hello Team,
Browse to Webtools >> Logging >> Service Log on demo trunk returns NPE.

Quick Reference:
https://demo-trunk.ofbiz.apache.org/webtools/control/ServiceLog

Not able to replicate it on local setup, anyone face the same issue then
please revert back. Will log Jira Ticket for that.

Regards,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


Re: Shipping data duplicated

2018-09-22 Thread Rishi Solanki
Hi Jacques,
I dig into it today and found that the data exists in the
"applications/datamodel/data/demo/OrderDemoData.xml" was moved from
"applications/order/data/DemoShipping.xml"
Also the data claimed as duplicate in
"applications/commonext/data/ShippingData.xml" is similar but not exact
matches with OrderDemoData.xml. The ShippingData.xml  file has no entry in
any ofbiz-component.xml.

So here we can decide weather we should keep that data in ShippingData.xml
(if someone introduce the file intentionally) or we can remove it from
trunk. In case no objection I would like to remove it as most data is
duplicate.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sat, Aug 18, 2018 at 1:17 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks Rishi!
>
> Jacques
>
>
> Le 17/08/2018 à 15:19, Rishi Solanki a écrit :
> > This should be part of effort when we were moving all the seed, ext, demo
> > data to datamodel component. I see there is no entry to load the
> > ShippingData.xml.
> > I will check this in next week and fix the duplicate data exists in the
> > system, or share the the reason of having this.
> >
> > Probably, data moved but not removed from commonext. But I'll confirm and
> > get back.
> >
> > Thanks!
> >
> >
> >
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
> > On Wed, Aug 15, 2018 at 10:10 PM, Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> Hi,
> >>
> >> Is there a reason why Shipping data are now duplicated in trunk at
> >>
> >>  applications/commonext/data/ShippingData.xml
> >>
> >> and
> >>
> >>  /applications/datamodel/data/demo/OrderDemoData.xml
> >>
> >> This is not the case with current stable
> >>
> >> Jacques
> >>
> >>
>
>


Re: Preparing the new release 16.11.05

2018-09-22 Thread Rishi Solanki
+1.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Fri, Sep 21, 2018 at 7:52 PM Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

> No feedback so far; I will proceed with the release preparation.
>
> Jacopo
>
> On Mon, Sep 17, 2018 at 11:09 AM Jacopo Cappellato <
> jacopo.cappell...@hotwaxsystems.com> wrote:
>
> > I am ready to prepare the release files and start a vote but before I do
> I
> > would like to double check about OFBIZ-4361: if people think that it
> should
> > be considered blocker then we could disable the link/feature in the
> release
> > branch and proceed with the release process; when we will have a
> > stable/tested/agreed upon refactoring of this "reset password" feature we
> > could re-enable the link.
> >
> > Jacopo
> >
> > On Fri, Sep 14, 2018 at 11:48 AM Taher Alkhateeb <
> > slidingfilame...@gmail.com> wrote:
> >
> >> I don't think this issue is a blocker for a new release, nor does it
> >> necessarily warrant a release just for that. It can just be part of a
> >> batch
> >> as usual.
> >>
> >> On Fri, Sep 14, 2018, 12:09 PM Jacopo Cappellato <
> >> jacopo.cappell...@hotwaxsystems.com> wrote:
> >>
> >> > On Mon, Sep 10, 2018 at 2:47 PM Pierre Smits 
> >> > wrote:
> >> >
> >> > > Should OFBIZ-4361 not get resolved for this?
> >> >
> >> >
> >> > It makes sense, thank you.
> >> > I have posted a comment in the ticket and hopefully we will come up
> >> with a
> >> > quick resolution.
> >> > Should we wait a few more days to see if we can commit and test that
> >> work
> >> > before we start the release voting process? However I wouldn't delay
> the
> >> > release preparation more than a few days and I would rather issue this
> >> > release and then issue another one in a few weeks.
> >> >
> >> > Regards,
> >> >
> >> > Jacopo
> >> >
> >>
> >
>


Re: Move SecurityPermission, SecurityGroup and SecurityGroupPermission Data to seed data files

2018-09-21 Thread Rishi Solanki
+1 for Arun's thought on considering SecurityPermission as seed and
SecurityGroup and SecurityGroupPermission as demo.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Fri, Sep 21, 2018 at 12:53 PM Gil Portenseigne <
gil.portensei...@nereide.fr> wrote:

> +1
>
> Le vendredi 21 sept. 2018 à 11:19:39 (+0530), Arun Patidar a écrit :
> > Deepak,
> >
> > IMO,  'SecurityPermission' data should always be part of seed data. but
> > SecurityGroup and SecurityGroupPermission like a sample data so should be
> > part of demo data.
> >
> >
> >
> >
> > Kind Regards,
> >
> > Arun Patidar
> > Director of Information Systems
> >
> > *HotWax CommerceReal OmniChannel. Real Results.*
> > m: +91 9827353082
> > w: www.hotwax.co
> >
> >  <https://www.linkedin.com/company/hotwaxcommerce/>
> > <https://www.facebook.com/HotWaxCommerce/>
> > <https://twitter.com/hotwaxcommerce>
> >
> >
> >
> > On Fri, Sep 21, 2018 at 9:59 AM Deepak Nigam  >
> > wrote:
> >
> > > Hello All,
> > >
> > > Currently, SecurityPermission, SecurityGroup and
> SecurityGroupPermission
> > > data are mixed in demo and seed data files. Shouldn't these all data be
> > > part of seed data files only?
> > >
> > > Most of the SecurityPermission data is already part of seed data
> except the
> > > files HumanresDemoData.xml and SecurityGroupDemoData.xml files, but
> there
> > > is not any fixed pattern for the SecurityGroup and
> > > SecurityGroupPermissionData.
> > >
> > > A Jira ticket OFBIZ-10575
> > > <https://issues.apache.org/jira/browse/OFBIZ-10575> is available for
> the
> > > same.
> > >
> > >
> > > Thanks & Regards
> > > --
> > > Deepak Nigam
> > > HotWax Systems Pvt. Ltd.
> > >
>


Re: Async persist service on error restart indefinitely by default

2018-09-10 Thread Rishi Solanki
+1 Nicolas, let the developer decide how she would like to manage it.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Mon, Sep 10, 2018 at 2:55 PM Suraj Khurana <
suraj.khur...@hotwaxsystems.com> wrote:

> Hi Nicolas,
>
> +1 for this proposal to set 0 as default value irrespective of its mode
> (sync or async).
>
> --
> Best Regards,
> Suraj Khurana
> Omnichannel OMS Technical Expert
> HotWax Systems
> m: +91 96697-50002
>
>
>
> On Mon, Sep 10, 2018 at 2:33 PM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Maybe we could consider if it's a sync or async service and have 2
> > different default settings?
> >
> > Just an idea from the top of my head, no more thinking ;)
> >
> > Jacques
> >
> >
> >
> > Le 10/09/2018 à 09:17, Nicolas Malin a écrit :
> >
> >> On 08/09/2018 18:43, Taher Alkhateeb wrote:
> >>
> >>> I could be wrong, but, wouldn't it make sense that if your service is
> >>> failing continuously then perhaps something is wrong with the service?
> >>> I would imagine that perhaps resilience in the design of the service
> >>> might be the better route?
> >>>
> >> Yeah sure Taher, reanalyze each reason to improve these services is also
> >> a solution :) but not exactly ma question.
> >> At the beginning theses services has been called on sync to keep the
> rest
> >> api error contacted and work fine. But when we moved it on async and use
> >> parallelism process through the job manager the service error has been
> >> translate as restart the service.
> >> So yes I can redefine them but *by default* is it logical to restart
> >> indefinitely a async service that failed ?
> >>
> >> Nicolas
> >>
> >>> On Fri, Sep 7, 2018 at 6:22 PM Nicolas Malin  >
> >>> wrote:
> >>>
> >>>> Hi,
> >>>>
> >>>> On a customer site, we have huge services that call different rest api
> >>>> to collect information
> >>>> To increase the velocity we run all them by persistence asynchrone
> then
> >>>> the job pooler manage them with available resources.
> >>>>
> >>>> The problem is, when a call failed and the service threw an error, the
> >>>> service engine reschedule it, ... and it failed, rescheduled, failed,
> >>>> rescheduled, failed ... with beautiful result to overload your pool
> with
> >>>> zombie services.
> >>>>
> >>>> The solution is easy, set on your service definition attribute
> max-retry
> >>>> to 0 (or 1, if you want one retry) but I didn't understand why we have
> >>>> this configuration to reschedule indefinitely a service if it is in
> >>>> error.
> >>>>
> >>>> This configuration exists before apache migration so I'd happy to have
> >>>> your vision about this.
> >>>>   From my view, I'm in favor to set max retry to 0 by default and left
> >>>> the developer set him self when he wants that a service restart after
> a
> >>>> failure.
> >>>>
> >>>> Easy change  :
> >>>> Index:
> >>>> framework/service/src/main/java/org/apache/ofbiz/service/job
> >>>> /PersistedServiceJob.java
> >>>>
> >>>> @@ -80,7 +80,7 @@
> >>>>this.jobValue = jobValue;
> >>>>Timestamp storedDate = jobValue.getTimestamp("runTime");
> >>>>this.startTime = storedDate.getTime();
> >>>> -this.maxRetry = jobValue.get("maxRetry") != null ?
> >>>> jobValue.getLong("maxRetry") : -1;
> >>>> +this.maxRetry = jobValue.get("maxRetry") != null ?
> >>>> jobValue.getLong("maxRetry") : 0;
> >>>>
> >>>> Nicolas
> >>>>
> >>>> --
> >>>> logoNrd <https://nereide.fr/>
> >>>>  Nicolas Malin
> >>>> The apache way <http://theapacheway.com/> : *Charity* Apache’s
> mission
> >>>> is providing software for the public good.
> >>>> informat...@nereide.fr
> >>>> 8 rue des Déportés 37000 TOURS, 02 47 50 30 54
> >>>>
> >>>> Apache OFBiz <http://ofbiz.apache.org/>|The Apache Way
> >>>> <http://theapacheway.com/>|réseau LE <
> http://www.libre-entreprise.org/>
> >>>>
> >>>
> >>
> >>
> >
>


Re: Move accounting ap and ar to plugin ?

2018-09-03 Thread Rishi Solanki
+1 for moving AR/AP to plugins. And big +1 for Jacopo remarks.


--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Mon, Sep 3, 2018 at 7:15 PM Taher Alkhateeb 
wrote:

> Sounds good to me then. +1
>
> On Mon, Sep 3, 2018, 4:32 PM Nicolas Malin 
> wrote:
>
> > Yeah thanks all for your constructive return :)
> >
> > I saw two specific features: commission invoicing and batch payment. As
> > Sharan spot it, all functional process are present on the accounting
> > component, I have the feeling that we are all agree on this idea with a
> > attention to doesn't lost important part possibly hidden on AP/AR.
> >
> > Taher, I have two reasons to don't just delete them:
> > * The code current works and seem to be easy to maintain
> > * Load in official plugins an example on business screen who simplify
> > generic screen with potential problem that can be raise by the split :)
> >
> > I will try to split it.
> > Thanks
> >
> > Nicolas
> >
> >
> > On 03/09/2018 13:07, Taher Alkhateeb wrote:
> > > Very interesting thoughts Sharan, Jacopo and everyone.
> > >
> > > Thinking about this some more, and given that -- as I understood it --
> > > the AP and AR are really nothing more than specialized filtration
> > > screens of the general purpose screens in the accounting webapp, then
> > > why not delete them? Are people depending on these screens? Is it
> > > worth writing and maintaining a plugin for it?
> > > On Mon, Sep 3, 2018 at 12:27 PM Sharan Foga  wrote:
> > >>
> > >>
> > >> On 2018/09/03 08:11:26, Jacopo Cappellato <
> > jacopo.cappell...@hotwaxsystems.com> wrote:
> > >>> On Sat, Sep 1, 2018 at 2:09 PM Nicolas Malin <
> nicolas.ma...@nereide.fr
> > >
> > >>> wrote:
> > >>>
> > >>>> Hello,
> > >>>>
> > >>>> After analyze the webapp accounting AR and accounting AP, I didn't
> see
> > >>>> any logic to keep them on the functional framework. The main webapp
> is
> > >>>> accounting, AP/AR are a business orientation that we can load at
> > demand
> > >>>> through plugins.
> > >>>>
> > >>>> Your opinion ?
> > >>>>
> > >>> As far as I remember, the AP/AR web applications were created as a
> > >>> specialized versions of the user interfaces for some business
> processes
> > >>> (account receivables and account payables related tasks) that were
> > already
> > >>> available in the more general "accounting" web application. I like
> the
> > idea
> > >>> to move them to plugins but, as mentioned by Taher, we should also
> > verify
> > >>> if there are specific features that are available only in the AP/AR
> > version
> > >>> and not in the "accounting" application: if we find some, then we
> > should
> > >>> migrate the basic artifacts to the main "accounting" app and then
> move
> > the
> > >>> specialized screens to plugins. I think such cases will be rare but
> one
> > >>> possible candidate is the "batch payment" functionality of the AR
> app.
> > >> I thought the batch payment was one of the options for the Payment
> > Group which is on the main accounting menu so any processing can be done
> > from there too.
> > >>
> > >> Thanks
> > >> Sharan
> > >>
> > >>>
> > >>>> PS: In the same idea we can move on separate plugin all thirdparty
> > >>>> accounting element to slimdown the accounting component and must
> > harness
> > >>>> the plugin system :)
> > >>>>
> > >>> +1
> > >>>
> > >>> Jacopo
> > >>>
> > >>>
> > >>>> Nicolas
> > >>>>
> > >>>>
> >
> >
>


Re: Ship Before Date and Ship After Date are not getting updated on the OrderItem table

2018-08-22 Thread Rishi Solanki
System should always use the OrderItemShipGroup for checking the ship
before and ship after dates. And if edit updated these dates then it should
be okay, initially system may offer 3 days delivery and then update it due
to any availability or technical reason.
Also it would be good data at item level and then OISG level to see the
difference on first promised date and then changed promised date.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Wed, Aug 22, 2018 at 4:35 PM deepak nigam 
wrote:

> Hello All,
>
> On updating Ship Before Date and Ship After Date from order overview
> screen, changes are getting reflected in the OrderItemShipGroup entity but
> in the OrderItem entity values remains same. Is this a valid behaviour or
> should be considered as a bug? Please let me know the business use cases if
> it is a valid behaviour.
>
> Thanks In Advance.
>
> Regards
> --
> Deepak Nigam
> HotWax Systems Pvt. Ltd.
>


Re: svn commit: r1838081 - in /ofbiz/ofbiz-framework/trunk/framework: base/src/main/java/org/apache/ofbiz/base/util/collections/ base/src/test/java/org/apache/ofbiz/base/collections/ webapp/config/ we

2018-08-17 Thread Rishi Solanki
Deepak,

Thanks for reporting the issue, can you please create Jira ticket and add
details (images are not coming at mailing list) with logs if possible?



Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Fri, Aug 17, 2018 at 6:32 PM, deepak nigam 
wrote:

> I am using OFBiz trunk and on creating an order from backend and getting
> error screens while adding an item to cart and selecting shipping methods.
> Please find the attached images for your reference.
>
> On further investigation, I found that on reverting this commit things are
> working fine. Can we verify this commit once more?
>
> On Wed, Aug 15, 2018 at 5:15 PM  wrote:
>
>> Author: shijh
>> Date: Wed Aug 15 11:45:45 2018
>> New Revision: 1838081
>>
>> URL: http://svn.apache.org/viewvc?rev=1838081=rev
>> Log:
>> Implemented: Add method attribute to request-map to controll a uri can be
>> called GET or POST only
>> OFBIZ-10438
>>
>> Thanks: Mathieu Lirzin for the contribution.
>>
>> Added:
>> ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/
>> org/apache/ofbiz/base/util/collections/MultivaluedMapContext.java
>>  (with props)
>> ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/
>> org/apache/ofbiz/base/util/collections/MultivaluedMapContextAdapter.java
>>  (with props)
>> ofbiz/ofbiz-framework/trunk/framework/base/src/test/java/
>> org/apache/ofbiz/base/collections/
>> ofbiz/ofbiz-framework/trunk/framework/base/src/test/java/
>> org/apache/ofbiz/base/collections/MultivaluedMapContextAdapterTests.java
>>  (with props)
>> ofbiz/ofbiz-framework/trunk/framework/base/src/test/java/
>> org/apache/ofbiz/base/collections/MultivaluedMapContextTests.java
>>  (with props)
>> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/
>> java/org/apache/ofbiz/webapp/control/MethodNotAllowedException.java
>>  (with props)
>> ofbiz/ofbiz-framework/trunk/framework/webapp/src/test/
>> java/org/apache/ofbiz/webapp/control/RequestHandlerTests.java   (with
>> props)
>> Modified:
>> ofbiz/ofbiz-framework/trunk/framework/webapp/config/
>> WebappUiLabels.xml
>> ofbiz/ofbiz-framework/trunk/framework/webapp/dtd/site-conf.xsd
>> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/
>> java/org/apache/ofbiz/webapp/control/ConfigXMLReader.java
>> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/
>> java/org/apache/ofbiz/webapp/control/ControlServlet.java
>> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/
>> java/org/apache/ofbiz/webapp/control/RequestHandler.java
>>
>> Added: ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/
>> org/apache/ofbiz/base/util/collections/MultivaluedMapContext.java
>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
>> framework/base/src/main/java/org/apache/ofbiz/base/util/collections/
>> MultivaluedMapContext.java?rev=1838081=auto
>> 
>> ==
>> --- ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/
>> org/apache/ofbiz/base/util/collections/MultivaluedMapContext.java (added)
>> +++ ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/
>> org/apache/ofbiz/base/util/collections/MultivaluedMapContext.java Wed
>> Aug 15 11:45:45 2018
>> @@ -0,0 +1,87 @@
>> +/**
>> *
>> + * Licensed to the Apache Software Foundation (ASF) under one
>> + * or more contributor license agreements.  See the NOTICE file
>> + * distributed with this work for additional information
>> + * regarding copyright ownership.  The ASF licenses this file
>> + * to you under the Apache License, Version 2.0 (the
>> + * "License"); you may not use this file except in compliance
>> + * with the License.  You may obtain a copy of the License at
>> + *
>> + * http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing,
>> + * software distributed under the License is distributed on an
>> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
>> + * KIND, either express or implied.  See the License for the
>> + * specific language governing permissions and limitations
>> + * under the License.
>> + 
>> ***/
>> +package org.apache.ofbiz.base.util.collections;
>> +
>> +import jav

Re: Shipping data duplicated

2018-08-17 Thread Rishi Solanki
This should be part of effort when we were moving all the seed, ext, demo
data to datamodel component. I see there is no entry to load the
ShippingData.xml.
I will check this in next week and fix the duplicate data exists in the
system, or share the the reason of having this.

Probably, data moved but not removed from commonext. But I'll confirm and
get back.

Thanks!



Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Wed, Aug 15, 2018 at 10:10 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi,
>
> Is there a reason why Shipping data are now duplicated in trunk at
>
> applications/commonext/data/ShippingData.xml
>
> and
>
> /applications/datamodel/data/demo/OrderDemoData.xml
>
> This is not the case with current stable
>
> Jacques
>
>


Re: Blocker issues and releases

2018-07-04 Thread Rishi Solanki
Thanks Jacques!!



Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Wed, Jul 4, 2018 at 12:56 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi committers,
>
> I have added a line at https://cwiki.apache.org/confl
> uence/display/OFBIZ/Release+Management+Guide+for+OFBiz "Things to check
> before a release":
>
> "Check that no open blocker Jira issues are still pending" with a Jira
> filter
>
> The idea is that when you spot an issue which should block a release you
> set its priority as blocker
>
> This is also explained at https://s.apache.org/PLDd
>
> The blocking idea is that you can't release w/o fixing a specific issue
>
> Thanks
>
> Jacques
>
>


Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration

2018-07-03 Thread Rishi Solanki
Pritam,

Your proposal looks good to go with, only one point to discuss here;
Like ProductStoreEmailSetting have all the configuration
ProductStoreSmsSetting will have the settingId and all configuration goes
into the SmsTemplateSetting. This looks okay to me, no objection. Do we
have any recommendation to adopt such configuration so that not right now
but in future we may opt one type setting for both Email and SMS.

In that way we will have consistent design for both, and devs/users can
easily grab such setting for their use.




Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Mon, Jul 2, 2018 at 2:52 PM, Pritam Kute 
wrote:

> Hello Devs,
>
> Sorry for such a long delay.
>
> Thanks, Michael for your inputs. I have added design proposal for the SMS
> gateway integration and can be accessed here
> <https://cwiki.apache.org/confluence/x/Zgo0BQ>:
> https://cwiki.apache.org/confluence/x/Zgo0BQ
>
> Please go through the design and let me know if there are any questions,
> suggestions or improvements which we can do.
>
> Thanks to Devanshu Vyas and Aishwary Shrivastava for helping me with the
> design and documentation.
>
> Thanks and Regards
> --
> Pritam Kute
>
> On Sun, Sep 10, 2017 at 4:33 PM Michael Brohl 
> wrote:
>
> > +1
> >
> > Looking forward to the design proposal.
> >
> > You can use the wiki with a new page under
> >
> > https://cwiki.apache.org/confluence/display/OFBIZ/
> OFBiz+Requirements+and+Design+Proposals
> > to provide the details and support collaboration.
> >
> > Thanks,
> >
> > Michael
> >
> > Am 26.08.17 um 13:31 schrieb Pritam Kute:
> > > Hi Devs,
> > >
> > > Many e-commerce businesses (especially operating in Asian countries)
> > > nowadays use short messaging service (SMS) in mobile phones to notify
> and
> > > update customers about order details, shipment statuses etc.
> > >
> > > I would like to propose an SMS Gateway Integration in Ofbiz. I will
> share
> > > proposed design details with you all soon. Till then, I would like to
> > know
> > > your thoughts on this idea.
> > >
> > > Thanks and Regards
> > > --
> > > Pritam Kute
> > >
> >
> >
> >
>


Re: Welcome to Swapnil M. Mane as new committer!

2018-06-27 Thread Rishi Solanki
Congratulations Swapnil!! :-)

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Wed, Jun 27, 2018 at 10:55 AM, Ankit Joshi  wrote:

> Many congratulations Swapnil !!
>
> Thanks & Regards,
> Ankit Joshi
>
>
> On Wed, Jun 27, 2018 at 1:30 AM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > The OFBiz PMC has invited Swapnil to become a new committer and we
> > arepleased  to announce that he has accepted.
> >
> > Swapnil has a high level of commitment for Apache OFBiz and consistently
> > works with the community.
> >
> > He is one of the most advanced contributors (including committers) in the
> > functional domain.
> >  Please join me in welcoming and congratulating Swapnil.
> >
> > Jacques
> >
> >
>


Re: Welcome to Suraj Khurana as new committer!

2018-06-27 Thread Rishi Solanki
Congratulations Suraj!! ;-)

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Wed, Jun 27, 2018 at 10:53 AM, Ankit Joshi  wrote:

> Many congratulations Suraj !!
>
>
> Thanks & Regards,
> Ankit Joshi
>
>
> On Wed, Jun 27, 2018 at 1:30 AM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > The OFBiz PMC has invited Suraj to become a new committer and we
> > arepleased  to announce that he has accepted.
> >
> > Suraj has proved to be committed for a long time now and is doing a very
> > good work as a contributor.
> >
> > He helped in a lot of Jiras, answered properly on MLs and proposed a few
> > quite interesting subjects.
> >
> > Please join me in welcoming and congratulating Suraj.
> >
> > Jacques
> >
> >
>


Re: Welcome to Aditya Sharma as new committer!

2018-06-27 Thread Rishi Solanki
Congratulations Aditya!! ;-)


Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Wed, Jun 27, 2018 at 10:56 AM, Ankit Joshi  wrote:

> Many congratulations Aditya !!
>
> Thanks & Regards,
> Ankit Joshi
>
>
> On Wed, Jun 27, 2018 at 1:29 AM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > The OFBiz PMC has invited Aditya to become a new committer and we
> > arepleased  to announce that he has accepted.
> >
> > Aditya has proved to be committed and doing a very good work as a
> > contributor.
> >
> > He notably coordinated the work around the refactoring of the data model
> > documents, helped in a lot of Jiras and answered appropriately on MLs.
> >
> > Please join me in welcoming and congratulating Aditya.
> >
> > Jacques
> >
> >
>


Re: svn commit: r1833231 - in /ofbiz/ofbiz-framework/trunk: framework/widget/dtd/ framework/widget/src/main/java/org/apache/ofbiz/widget/model/ framework/widget/src/main/java/org/apache/ofbiz/widget/r

2018-06-11 Thread Rishi Solanki
Taher, Gil, Jacques,

I've created the Jira ticket for the same:
https://issues.apache.org/jira/browse/OFBIZ-10432

Will soon have someone to take care, thanks again for your help!


Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Mon, Jun 11, 2018 at 3:15 PM, Taher Alkhateeb  wrote:

> Yeah I apologize for making too much noise in this thread, perhaps it
> would have been better discussed in JIRA.
>
> The reason I open these subjects up from time to time is to generally
> try to unify code. Whenever I see an opportunity to unify the way
> stuff works around the framework I cannot resist the temptation to at
> least mention it. What you mentioned makes sense with respect to
> combinations of "when" combined with either "text" or "display".
> However it would be nice to do it also perhaps for interactive forms
> with things like "container" fields or "include-form" directives
> triggered by update events.
>
> In any case, I don't see a problem working with this for now as we
> figure out better options. I just hope we don't get a lot of code
> deployed on top of that before / if we decide to change it.
>
> On Mon, Jun 11, 2018 at 12:26 PM, Rishi Solanki 
> wrote:
> > Thanks Taher, Gil, Jacques for you feedback.
> >
> > I'll get back and take your inputs into consideration and all seems
> > acceptable to me. For Taher's point I remember we have use when and read
> > only (display field) checks and ignored tag to make the field non
> editable
> > and non parameterized. This is only for brainstorming on the proposal.
> And
> > I tend to agree to apply this on all fields but for checkboxes we often
> use
> > disabled feature which is not applicable to all other type of inputs.
> >
> > I hope this would be fine, if we discuss this and slowly take care of
> > suggestions after that. For Gil's suggestion I would change it asap.
> >
> > Thanks again for your help!
> >
> >
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
> > On Sun, Jun 10, 2018 at 1:37 PM, Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> +1 Gil
> >>
> >> Jacques
> >>
> >>
> >>
> >> Le 10/06/2018 à 08:34, Gil Portenseigne a écrit :
> >>
> >>> Hi Rishi,
> >>>
> >>> In the xsd it's better to use xs:boolean type, instead of enumeration
> >>> type.
> >>>
> >>> Regards,
> >>>
> >>> Gil
> >>>
> >>>
> >>> Le 9 juin 2018 14:34:49 GMT+02:00, ri...@apache.org a écrit :
> >>>
> >>>> Author: rishi
> >>>> Date: Sat Jun  9 12:34:49 2018
> >>>> New Revision: 1833231
> >>>>
> >>>> URL: http://svn.apache.org/viewvc?rev=1833231=rev
> >>>> Log:
> >>>> Improved: Add Support for Disable attribute in CheckBox Form Widget.
> >>>> Disabled attrivute can be used as
> >>>>
> >>>> 
> >>>>
> >>>> and default value for attribute will be false.
> >>>> (OFBIZ-10367)
> >>>> Thanks Pawan Verma for reporting the improvement and providing patch
> >>>> for that.
> >>>> Thanks James Yong for testing the work.
> >>>>
> >>>> Modified:
> >>>> ofbiz/ofbiz-framework/trunk/framework/widget/dtd/widget-form.xsd
> >>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/
> >>>> org/apache/ofbiz/widget/model/ModelFormField.java
> >>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/
> >>>> org/apache/ofbiz/widget/model/XmlWidgetFieldVisitor.java
> >>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/
> >>>> org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
> >>>> ofbiz/ofbiz-framework/trunk/themes/common-theme/template/mac
> >>>> ro/CsvFormMacroLibrary.ftl
> >>>> ofbiz/ofbiz-framework/trunk/themes/common-theme/template/mac
> >>>> ro/FoFormMacroLibrary.ftl
> >>>> ofbiz/ofbiz-framework/trunk/themes/common-theme/template/mac
> &

Re: svn commit: r1833231 - in /ofbiz/ofbiz-framework/trunk: framework/widget/dtd/ framework/widget/src/main/java/org/apache/ofbiz/widget/model/ framework/widget/src/main/java/org/apache/ofbiz/widget/r

2018-06-11 Thread Rishi Solanki
Thanks Taher, Gil, Jacques for you feedback.

I'll get back and take your inputs into consideration and all seems
acceptable to me. For Taher's point I remember we have use when and read
only (display field) checks and ignored tag to make the field non editable
and non parameterized. This is only for brainstorming on the proposal. And
I tend to agree to apply this on all fields but for checkboxes we often use
disabled feature which is not applicable to all other type of inputs.

I hope this would be fine, if we discuss this and slowly take care of
suggestions after that. For Gil's suggestion I would change it asap.

Thanks again for your help!


Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Sun, Jun 10, 2018 at 1:37 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> +1 Gil
>
> Jacques
>
>
>
> Le 10/06/2018 à 08:34, Gil Portenseigne a écrit :
>
>> Hi Rishi,
>>
>> In the xsd it's better to use xs:boolean type, instead of enumeration
>> type.
>>
>> Regards,
>>
>> Gil
>>
>>
>> Le 9 juin 2018 14:34:49 GMT+02:00, ri...@apache.org a écrit :
>>
>>> Author: rishi
>>> Date: Sat Jun  9 12:34:49 2018
>>> New Revision: 1833231
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1833231=rev
>>> Log:
>>> Improved: Add Support for Disable attribute in CheckBox Form Widget.
>>> Disabled attrivute can be used as
>>>
>>> 
>>>
>>> and default value for attribute will be false.
>>> (OFBIZ-10367)
>>> Thanks Pawan Verma for reporting the improvement and providing patch
>>> for that.
>>> Thanks James Yong for testing the work.
>>>
>>> Modified:
>>> ofbiz/ofbiz-framework/trunk/framework/widget/dtd/widget-form.xsd
>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/
>>> org/apache/ofbiz/widget/model/ModelFormField.java
>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/
>>> org/apache/ofbiz/widget/model/XmlWidgetFieldVisitor.java
>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/
>>> org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
>>> ofbiz/ofbiz-framework/trunk/themes/common-theme/template/mac
>>> ro/CsvFormMacroLibrary.ftl
>>> ofbiz/ofbiz-framework/trunk/themes/common-theme/template/mac
>>> ro/FoFormMacroLibrary.ftl
>>> ofbiz/ofbiz-framework/trunk/themes/common-theme/template/mac
>>> ro/HtmlFormMacroLibrary.ftl
>>> ofbiz/ofbiz-framework/trunk/themes/common-theme/template/mac
>>> ro/TextFormMacroLibrary.ftl
>>> ofbiz/ofbiz-framework/trunk/themes/common-theme/template/mac
>>> ro/XlsFormMacroLibrary.ftl
>>> ofbiz/ofbiz-framework/trunk/themes/common-theme/template/mac
>>> ro/XmlFormMacroLibrary.ftl
>>>
>>> Modified:
>>> ofbiz/ofbiz-framework/trunk/framework/widget/dtd/widget-form.xsd
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/fra
>>> mework/widget/dtd/widget-form.xsd?rev=1833231=1833230=
>>> 1833231=diff
>>> 
>>> ==
>>> --- ofbiz/ofbiz-framework/trunk/framework/widget/dtd/widget-form.xsd
>>> (original)
>>> +++ ofbiz/ofbiz-framework/trunk/framework/widget/dtd/widget-form.xsd
>>> Sat Jun  9 12:34:49 2018
>>> @@ -956,6 +956,14 @@ under the License.
>>>  
>>>  
>>>  
>>> +
>>> +
>>> +
>>> +
>>> +
>>> +
>>> +
>>> +
>>>  
>>>  
>>>  
>>>
>>> Modified:
>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/
>>> org/apache/ofbiz/widget/model/ModelFormField.java
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/fra
>>> mework/widget/src/main/java/org/apache/ofbiz/widget/model/
>>> ModelFormField.java?rev=1833231=1833230=1833231=diff
>>> 
>>> ==
>>> ---
>>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/
>>> org/apache/ofbiz/widget/model/ModelFormField.java
>>> (original)
>>> +++
>>> ofbiz/ofbiz-framework/t

Re: Document association with FixedAssets

2018-05-18 Thread Rishi Solanki
Rajesh,

You may consider the FixedAsset.instanceOfProductId,
FixedAsset.acquireOrderId, and FixedAsset.partyId. And ProductContent,
OrderContent and PartyContent based on the purpose of content.
With respect to your shared documents it seems to be go with
ProductContent. May be with some specific type.


Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Thu, May 17, 2018 at 3:55 PM, Rajesh Mallah <mallah.raj...@gmail.com>
wrote:

> Also will such feature be of generic usage ?
>
> -- Ccing/Moving to Dev.
>
> On Thu, May 17, 2018 at 3:53 PM, Rajesh Mallah <mallah.raj...@gmail.com>
> wrote:
>
> > Thanks Deepak .
> >
> > and can extend data
> >> model to associate FixedAsset with Content.
> >>
> >
> > You mean adding a new Relation into the OFBiz system ?
> > In case you meant that shall i open a JIRA ?
> >
> > Also can you point me to a past commit or documentation that
> > would help me understand the protocols involved in making
> > such a change.
> >
> > regds
> > mallah.
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > On Thu, May 17, 2018 at 2:49 PM, Deepak Dixit
> <deepak.dixit@hotwaxsystems.
> > com> wrote:
> >
> >> Hi Rajes,
> >>
> >> You can use Content data model to manage the documents, and can extend
> >> data
> >> model to associate FixedAsset with Content.
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Dixit
> >> www.hotwax.co
> >>
> >> On Thu, May 17, 2018 at 2:27 PM, Rajesh Mallah <mallah.raj...@gmail.com
> >
> >> wrote:
> >>
> >> > Hello List ,
> >> >
> >> > I was exploring the FixedAssets Feature  in OFBiz .
> >> > I found it quite usable for my use case. Only thing i am missing
> >> > at this moment is associating documents with FixedAssets.
> >> >
> >> > Eg in case of a Vehicle type FixedAsset the documents can be
> >> >
> >> > (1) Insurance Docs (Multipage)
> >> > (2) Pollution Certificate
> >> > (3) Transport Permit by State / Central Govt.
> >> >
> >> > I plan to store the docs in an external object store eg(AWS S3)
> >> > and store the urls of the docs in OFBiz.
> >> >
> >> > Any ideas how it can be accomplished in current features
> >> > of OFBiz.
> >> >
> >> >
> >> > Regds
> >> > Mallah.
> >> >
> >>
> >
> >
>


Re: svn commit: r1831467 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/requirement/RequirementServices.xml servicedef/services_requirement.xml

2018-05-12 Thread Rishi Solanki
Thanks Jacques, you are fast just completed my testing to commit it. :-)

Thanks again!

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Sat, May 12, 2018 at 7:25 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Done at r1831480, Jira updated
>
>
>
> Le 12/05/2018 à 15:40, Jacques Le Roux a écrit :
>
>> Thanks Suraj, Rishi,
>>
>> Sorry got an issue running tests locally (I had one of the documentation
>> PDF file generated open and did not notice the tests failed until I got
>> there)
>>
>> I agree about adding and will do so
>>
>> Jacques
>>
>>
>> Le 12/05/2018 à 14:41, Rishi Solanki a écrit :
>>
>>> I would add the *custRequestId* and *custRequestItemSeqId* as IN
>>> parameter
>>> in createRequirement service. The idea behind the ticket is to not to do
>>> functional changes and just to convert the services to entity-auto.
>>>
>>> Rishi Solanki
>>> Sr Manager, Enterprise Software Development
>>> HotWax Systems Pvt. Ltd.
>>> Direct: +91-9893287847
>>> http://www.hotwaxsystems.com
>>> www.hotwax.co
>>>
>>> On Sat, May 12, 2018 at 5:57 PM, Suraj Khurana <
>>> suraj.khur...@hotwaxsystems.com> wrote:
>>>
>>> Thanks Jacques,
>>>>
>>>> I was checking *testIntegration* and *createRequirement* service is
>>>> failing
>>>> due to missing *custRequestId* in it.
>>>> *Solution:* Remove this parameter from testCreateRequirement as it is
>>>> not
>>>> part of Requirement entity.
>>>> But, on the same time I found a seca on *createRequirement* calling
>>>> *associatedRequirementWithRequestItem*
>>>> if *custRequestId* and *custRequestItemSeqId* is not empty.
>>>>
>>>> Another solution could be add *custRequestId* and
>>>> *custRequestItemSeqId* as
>>>> IN parameter in createRequirement service attributes.
>>>> Please suggest what should be the idle thing to do.
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> *Suraj Khurana* | Omni-channel OMS Technical Expert
>>>> HotWax Commerce  by  HotWax Systems
>>>> Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010
>>>>
>>>>
>>>> On Sat, May 12, 2018 at 4:53 PM, <jler...@apache.org> wrote:
>>>>
>>>> Author: jleroux
>>>>> Date: Sat May 12 11:23:29 2018
>>>>> New Revision: 1831467
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1831467=rev
>>>>> Log:
>>>>> Improved: Convert Requirement related services from simple to
>>>>> entity-auto
>>>>> (OFBIZ-10395)
>>>>>
>>>>> There is nothing extra in these services and they can be made to
>>>>> entity-auto.
>>>>>
>>>>> Thanks: Suraj Khurana
>>>>>
>>>>> Modified:
>>>>> ofbiz/ofbiz-framework/trunk/applications/order/minilang/requirement/
>>>>> RequirementServices.xml
>>>>> ofbiz/ofbiz-framework/trunk/applications/order/servicedef/
>>>>> services_requirement.xml
>>>>>
>>>>> Modified: ofbiz/ofbiz-framework/trunk/applications/order/minilang/
>>>>> requirement/RequirementServices.xml
>>>>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
>>>>> applications/order/minilang/requirement/RequirementServices.xml?rev=
>>>>> 1831467=1831466=1831467=diff
>>>>> 
>>>>> ==
>>>>> --- ofbiz/ofbiz-framework/trunk/applications/order/minilang/requ
>>>>> irement/
>>>>>
>>>> RequirementServices.xml
>>>>
>>>>> (original)
>>>>> +++ ofbiz/ofbiz-framework/trunk/applications/order/minilang/requ
>>>>> irement/
>>>>>
>>>> RequirementServices.xml
>>>>
>>>>> Sat May 12 11:23:29 2018
>>>>> @@ -20,35 +20,6 @@ under the License.
>>>>>
>>>>>   http://www.w3.org/2001/XMLSchema-instance
>>>>> "
>>>>>   xmlns="http://ofbiz.apache.org/Simple-Method;
>>>>> xsi:schemaLocation="http://ofbiz.apache.org/S

Re: svn commit: r1831467 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/requirement/RequirementServices.xml servicedef/services_requirement.xml

2018-05-12 Thread Rishi Solanki
I would add the *custRequestId* and *custRequestItemSeqId* as IN parameter
in createRequirement service. The idea behind the ticket is to not to do
functional changes and just to convert the services to entity-auto.

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Sat, May 12, 2018 at 5:57 PM, Suraj Khurana <
suraj.khur...@hotwaxsystems.com> wrote:

> Thanks Jacques,
>
> I was checking *testIntegration* and *createRequirement* service is failing
> due to missing *custRequestId* in it.
> *Solution:* Remove this parameter from testCreateRequirement as it is not
> part of Requirement entity.
> But, on the same time I found a seca on *createRequirement* calling
> *associatedRequirementWithRequestItem*
> if *custRequestId* and *custRequestItemSeqId* is not empty.
>
> Another solution could be add *custRequestId* and *custRequestItemSeqId* as
> IN parameter in createRequirement service attributes.
> Please suggest what should be the idle thing to do.
>
> --
> Thanks and Regards,
> *Suraj Khurana* | Omni-channel OMS Technical Expert
> HotWax Commerce  by  HotWax Systems
> Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010
>
>
> On Sat, May 12, 2018 at 4:53 PM, <jler...@apache.org> wrote:
>
> > Author: jleroux
> > Date: Sat May 12 11:23:29 2018
> > New Revision: 1831467
> >
> > URL: http://svn.apache.org/viewvc?rev=1831467=rev
> > Log:
> > Improved: Convert Requirement related services from simple to entity-auto
> > (OFBIZ-10395)
> >
> > There is nothing extra in these services and they can be made to
> > entity-auto.
> >
> > Thanks: Suraj Khurana
> >
> > Modified:
> > ofbiz/ofbiz-framework/trunk/applications/order/minilang/requirement/
> > RequirementServices.xml
> > ofbiz/ofbiz-framework/trunk/applications/order/servicedef/
> > services_requirement.xml
> >
> > Modified: ofbiz/ofbiz-framework/trunk/applications/order/minilang/
> > requirement/RequirementServices.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> > applications/order/minilang/requirement/RequirementServices.xml?rev=
> > 1831467=1831466=1831467=diff
> > 
> > ==
> > --- ofbiz/ofbiz-framework/trunk/applications/order/minilang/requirement/
> RequirementServices.xml
> > (original)
> > +++ ofbiz/ofbiz-framework/trunk/applications/order/minilang/requirement/
> RequirementServices.xml
> > Sat May 12 11:23:29 2018
> > @@ -20,35 +20,6 @@ under the License.
> >
> >  http://www.w3.org/2001/XMLSchema-instance;
> >  xmlns="http://ofbiz.apache.org/Simple-Method;
> > xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method
> > http://ofbiz.apache.org/dtds/simple-methods.xsd;>
> > - > short-description="Create a new requirement">
> > -
> > - field="requirementId"/>
> > - from-field="requirementId"/>
> > -
> > -
> > -
> > -
> > -
> > -
> > - > from-field="nowTimestamp"/>
> > - from-field="userLogin.
> > userLoginId"/>
> > - > from-field="userLogin.userLoginId"/>
> > -
> > - > result-name="requirementId"/>
> > -
> > -
> > - > short-description="Update a requirement">
> > - value-field="lookupPKMap"/>
> > -
> > - > value-field="lookedUpValue"/>
> > - > result-name="oldStatusId"/>
> > -
> > -
> > - > from-field="nowTimestamp"/>
> > - > from-field="userLogin.userLoginId"/>
> > -
> > -
> > -
> >   > short-description="Delete a requirement">
> >   > auto-field-map="true"/>
> >  
> >
> > Modified: ofbiz/ofbiz-framework/trunk/applications/order/servicedef/
> > services_requirement.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> > applications/order/servicedef/services_requirement.xml?rev=
> > 1831467=1831466=1831467=diff
> > 
> > ==
> > --- ofbiz/ofbiz-framework/trunk/applications/order/servicedef/
> services_requirement.xml
&g

Re: Send E-Mails

2018-05-09 Thread Rishi Solanki
Hello,

Can you please check the SystemProperty records with
systemResourceId="general". Possible reason seems these records may have
empty values at your end. The db values used to override the
general.properties file mentioned in the Production Setup Guide. Please add
your configuration if it is missing and let us know if it works.

Community, I think we should mention the SystemProperty where required in
Production Setup Guide or may be we can add version of production setup
guide which will tells user upto which release this production setup guide
will work. I know we discuss this kind of effort in past for all the
documents and we agree on some point. But this is quicker to manage
Production Setup Guide, if we agree then I can do it.

I'm fine with either change the existing one or maintain the version. But
first we should have one which works always with latest. Thanks!


Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Wed, May 9, 2018 at 3:33 AM, i...@agentur-m3.de <i...@agentur-m3.de>
wrote:

> Hello,
>
> here is a problem with my e-mail base-configuration.
>
> I configured email according to the setup guide:
>
> https://cwiki.apache.org/confluence/display/OFBIZ/Apache+OFBiz+Technical+
> Production+Setup+Guide#ApacheOFBizTechnicalProduction
> SetupGuide-EmailServerSettings
>
>
> Unfortunately no email seems to be sent from server
> (the send email button in partymgr works fine now (thanks to Jacques!),
> but no email reaches client). No error message, no error in log.
>
> Also I tried to register in the ecommerce system and send
> an "Forgot Your Password" email, but none of the emails were sent.
>
> To get more info about the problem, I wrote a groovy script and copied
> parts of the sendEmail-code from EmailServices.java.
> The script below surprisingly works fine and sends emails!
>
> So I don't understand, why OFBiz itself does not send mails.
> Is there any further configuration necessary?
>
>
>
> The script (which sends mails):
>
> import javax.mail.Session;
>
> import javax.activation.DataHandler;
> import javax.activation.DataSource;
> import javax.mail.Message;
> import javax.mail.MessagingException;
> import javax.mail.SendFailedException;
> import javax.mail.Session;
> import javax.mail.Transport;
> import javax.mail.internet.InternetAddress;
> import javax.mail.internet.MimeBodyPart;
> import javax.mail.internet.MimeMessage;
> import javax.mail.internet.MimeMultipart;
> import javax.xml.parsers.ParserConfigurationException;
> import javax.xml.transform.stream.StreamSource;
>
> import org.apache.fop.apps.Fop;
> import org.apache.fop.apps.MimeConstants;
> import org.apache.ofbiz.base.util.Debug;
> import org.apache.ofbiz.base.util.GeneralException;
> import org.apache.ofbiz.base.util.HttpClient;
> import org.apache.ofbiz.base.util.HttpClientException;
> import org.apache.ofbiz.base.util.UtilGenerics;
> import org.apache.ofbiz.base.util.UtilMisc;
> import org.apache.ofbiz.base.util.UtilProperties;
> import org.apache.ofbiz.base.util.UtilValidate;
> import org.apache.ofbiz.base.util.collections.MapStack;
> import org.apache.ofbiz.base.util.string.FlexibleStringExpander;
> import org.apache.ofbiz.entity.Delegator;
> import org.apache.ofbiz.entity.GenericValue;
> import org.apache.ofbiz.entity.util.EntityUtilProperties;
> import org.apache.ofbiz.service.DispatchContext;
> import org.apache.ofbiz.service.GenericServiceException;
> import org.apache.ofbiz.service.LocalDispatcher;
> import org.apache.ofbiz.service.ServiceUtil;
> import org.apache.ofbiz.service.mail.MimeMessageWrapper;
> import org.apache.ofbiz.webapp.view.ApacheFopWorker;
> import org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer;
> import org.apache.ofbiz.widget.renderer.ScreenRenderer;
> import org.apache.ofbiz.widget.renderer.ScreenStringRenderer;
> import org.xml.sax.SAXException;
>
> def testMail() {
> sendType = "mail.smtp.host"
> sendVia = "smtp.myhost.com"
> Properties props = System.getProperties()
> props.put(sendType, sendVia)
> Session session
> session = Session.getInstance(props);
> MimeMessage mail
> mail = new MimeMessage(session);
> Transport trans = null
> sendFrom = "obfiz.example.com"
> sendTo = "m...@myserver.de"
> subject = "testMail from OFBiz"
> mp = new MimeMultipart();
>
> MimeBodyPart mbp = new MimeBodyPart();
> mbp.setText("Content: a test mail from OFBiz system")
>
> mp.addBodyPart(mbp);
> mail.setContent(mp);
&

Re: [Proposal] Make accounting entry configurable

2018-05-08 Thread Rishi Solanki
Interesting!!
Scott you are suggesting plugin or base component?

Thanks!


Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Mon, May 7, 2018 at 11:54 PM, Scott Gray <scott.g...@hotwaxsystems.com>
wrote:

> Another additional option we could consider at some point is to extract the
> GL out to it's own component. It would simplify evaluation for people who
> do want to use it, and removal for that don't or replacement for anyone who
> wants to use something else.
>
> Regards
> Scott
>
> On Thu, 3 May 2018, 18:12 Aman Agrawal, <aman.agra...@hotwaxsystems.com>
> wrote:
>
> > Hello,
> >
> > In current flow, if we want to disable the accounting then we need to
> > disable the set of seca's. We don't have any configurable setting to
> > disable accounting.
> > So, I have a proposal to make accounting transaction entries
> configurable.
> > We can manage this by adding a new field 'enableAccounting' in the
> > 'PartyAcctgPreference' entity. Accounting transaction entries will be
> > entertained accordingly.
> >
> > Thanks and regards,
> > *Aman Agrawal*
> > Sr. Enterprise Software Engineer
> > www.hotwaxsystems.com
> > www.hotwax.co
> >
>


Re: [Proposal] Make accounting entry configurable

2018-05-04 Thread Rishi Solanki
Thanks Sharan for the exact use case I was looking for.

+1 for the overall proposal.

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Thu, May 3, 2018 at 2:43 PM, Sharan Foga <sha...@apache.org> wrote:

>
>
> On 2018/05/03 06:40:43, Rishi Solanki <rishisolan...@gmail.com> wrote:
> > Hi Aman,
> > +1 for making it configurable.
> >
> > By PartyAcctgPreference.enableAccounting flag you mean for an OFBiz
> > instance if flag is enable then for that company/organization accounting
> > transactions recorded otherwise not. That also mean, for an instance we
> may
> > record the accounting transaction for one organization and do not record
> > accounting transaction for other organization.
> >
> > This is something I couldn't imagine in real world business scenario.
>
> Hi Rishi
>
> Something I've come across quite a few times is this.
>
> Imagine the case where you have several companies recording transactions
> then one stops trading temporarily or permanently, becomes insolvent or
> merges with another one, which means that from a specific date you don’t
> want it any new transactions recorded a against it.
>
> The existing transactions that have been processed are still valid in the
> previous company party and you will probably want to report on them from a
> historic perspective – but you would want to stop any new transactions
> being posted to that previous company.
>
> Thanks
> Sharan
>
> So
> > big +1 for making it configurable but not sure about weather we should go
> > for PartyAcctgPreference or may consider SystemProperty for that.
> >
> > Looking for others input, BTW, no objection on using PartyAcctgPreference
> > but thinking if it is useful to add checks/efforts for organizations over
> > same instance.
> >
> >
> >
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
> > On Thu, May 3, 2018 at 11:41 AM, Aman Agrawal <
> > aman.agra...@hotwaxsystems.com> wrote:
> >
> > > Hello,
> > >
> > > In current flow, if we want to disable the accounting then we need to
> > > disable the set of seca's. We don't have any configurable setting to
> > > disable accounting.
> > > So, I have a proposal to make accounting transaction entries
> configurable.
> > > We can manage this by adding a new field 'enableAccounting' in the
> > > 'PartyAcctgPreference' entity. Accounting transaction entries will be
> > > entertained accordingly.
> > >
> > > Thanks and regards,
> > > *Aman Agrawal*
> > > Sr. Enterprise Software Engineer
> > > www.hotwaxsystems.com
> > > www.hotwax.co
> > >
> >
>


Re: [Proposal] Make accounting entry configurable

2018-05-03 Thread Rishi Solanki
Hi Aman,
+1 for making it configurable.

By PartyAcctgPreference.enableAccounting flag you mean for an OFBiz
instance if flag is enable then for that company/organization accounting
transactions recorded otherwise not. That also mean, for an instance we may
record the accounting transaction for one organization and do not record
accounting transaction for other organization.

This is something I couldn't imagine in real world business scenario. So
big +1 for making it configurable but not sure about weather we should go
for PartyAcctgPreference or may consider SystemProperty for that.

Looking for others input, BTW, no objection on using PartyAcctgPreference
but thinking if it is useful to add checks/efforts for organizations over
same instance.



Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Thu, May 3, 2018 at 11:41 AM, Aman Agrawal <
aman.agra...@hotwaxsystems.com> wrote:

> Hello,
>
> In current flow, if we want to disable the accounting then we need to
> disable the set of seca's. We don't have any configurable setting to
> disable accounting.
> So, I have a proposal to make accounting transaction entries configurable.
> We can manage this by adding a new field 'enableAccounting' in the
> 'PartyAcctgPreference' entity. Accounting transaction entries will be
> entertained accordingly.
>
> Thanks and regards,
> *Aman Agrawal*
> Sr. Enterprise Software Engineer
> www.hotwaxsystems.com
> www.hotwax.co
>


Re: New ASF Member from OFBiz Community

2018-05-03 Thread Rishi Solanki
Superb!!!

Many Congratulations Deepak!!

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Thu, May 3, 2018 at 11:45 AM, deepak nigam <deepak.nigam1...@gmail.com>
wrote:

> Congratulations Deepak!
>
> Thanks & Regards
> --
> Deepak Nigam
>
> On Thu, May 3, 2018 at 11:34 AM, Devanshu Vyas <vyas.devansh...@gmail.com>
> wrote:
>
> > Many Congratulations Deepak!!!
> >
> >
> > Thanks & Regards,
> > Devanshu Vyas.
> >
> >
> > On Wed, May 2, 2018 at 9:08 PM Jacopo Cappellato <
> > jacopo.cappell...@hotwaxsystems.com> wrote:
> >
> > > Hi Everyone,
> > >
> > > today the ASF has published the list of newly nominated members and
> "our"
> > > Deepak Dixit is one of them:
> > >
> > >
> > > https://blogs.apache.org/foundation/entry/the-apache-
> > software-foundation-welcomes2
> > > <
> > > https://www.google.com/url?q=https://blogs.apache.org/
> > foundation/entry/the-apache-software-foundation-welcomes2&
> > sa=D=hangouts=1525357595561000=
> > AFQjCNHXDpgnyJ1wgnbZ06kEPTsbXs9MDQ
> > > >
> > >
> > > Congratulations Deepak!
> > >
> > > Jacopo
> > >
> >
>


Re: [Proposal] Return History Feature in eCommerce

2018-04-28 Thread Rishi Solanki
+1

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Sat, Apr 28, 2018 at 7:13 PM, Ratnesh Upadhyay <
upadhyay.ratn...@gmail.com> wrote:

> Hi Devs,
>
> I have gone through eCommerce application and noticed that we have order
> history section there but we don't have return history. So I would like to
> propose "Return History" feature in eCommerce application. Please let me
> know your views on it.
>
> Thanks!!
>
> Regards,
> Ratnesh Upadhyay
> HotWax Systems | www.hotwaxsystems.com
>


Re: buildbot failure in on ofbizTrunkFramework

2018-04-28 Thread Rishi Solanki
Here is the  ticket and reason why that work goes in
https://issues.apache.org/jira/browse/OFBIZ-10369



Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Sat, Apr 28, 2018 at 5:41 PM, Taher Alkhateeb <slidingfilame...@gmail.com
> wrote:

> Hi Suraj, did you get the latest revision and applied cleanAll first? I
> notice that the error is emanating from the converter class for
> LinkedHashMap for some reason.
>
> On Sat, Apr 28, 2018, 3:04 PM Suraj Khurana <suraj.khurana@hotwaxsystems.
> com>
> wrote:
>
> > Hello all,
> > I tried ./gradlew testIntegration locally.
> >
> > All test passed.
> > Is there a connection problem or something else causing this build fail?
> >
> > --
> > Best Regards,
> > *Suraj Khurana* | Sr. Enterprise Software Engineer
> > *HotWax Commerce*  by  *HotWax Systems*
> > Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010
> > Cell phone: +91 96697-50002
> >
> > On Sat, Apr 28, 2018 at 5:15 PM, <build...@apache.org> wrote:
> >
> > > The Buildbot has detected a new failure on builder ofbizTrunkFramework
> > > while building . Full details are available at:
> > > https://ci.apache.org/builders/ofbizTrunkFramework/builds/204
> > >
> > > Buildbot URL: https://ci.apache.org/
> > >
> > > Buildslave for this Build: lares_ubuntu
> > >
> > > Build Reason: The AnyBranchScheduler scheduler named
> > > 'onTrunkFrameworkCommit' triggered this build
> > > Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1830429
> > > Blamelist: rishi
> > >
> > > BUILD FAILED: failed shell_2
> > >
> > > Sincerely,
> > >  -The Buildbot
> > >
> > >
> > >
> > >
> >
>


Re: File transfer management with communicationEvent and new contactMech FTP_ADDRESS

2018-04-27 Thread Rishi Solanki
Thanks for update Gil!

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Thu, Apr 26, 2018 at 9:44 PM, Gil Portenseigne <
gil.portensei...@nereide.fr> wrote:

> Hello,
>
> I cannot remember if i already announced it but you can find a new
> patch for https://issues.apache.org/jira/browse/OFBIZ-10245 jira.
>
> This implementation add sshd-core (from Apache Mina) lib and a new entity
> FtpAddress into
> the codebase, with some services to transfer content to ftp implemented
> in a similar way as the mail communicationEvent system.
>
> More details in Jira :)
>
> Regards
>
> Gil
>
>
>


Re: datamodel book query : page 2-Top Level Product Entities, Entity ProductCategory

2018-04-23 Thread Rishi Solanki
Rajesh,
Where you are referring, could you please share the link. I checked the
data model book vol1 do not see anything related you are sharing.

Thanks!

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Mon, Apr 23, 2018 at 4:07 PM, Rajesh Mallah <mallah.raj...@gmail.com>
wrote:

> Hi ,
>
> The entity  ProductCategory in Page 2 is abridged and there is no
> indication of
> that. Page 14 has the full blown version.
>
> Should we inflate in page 1 , so indicate that fact ?
>
> regds
> mallah.
>


Re: Confusing entity names

2018-04-18 Thread Rishi Solanki
+1 Scott.
I'm also not in favor of changing the names. Suraj suggested better names
but existing are also fine. Another point is OrderItemShipGrpInvRes have
relation with both the mentioned entities. Which tells by modeling that,
one OISG may have more than one OISGIR which may in turn have different
shipgroups. That means, one OISG having one order may be connected with
with single OISGIR or more than one OISGIR. And here item word makes sense
in the entity names.



Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Wed, Apr 18, 2018 at 1:20 PM, Scott Gray <scott.g...@hotwaxsystems.com>
wrote:

> Just to throw in my 2 cents, I don't think the naming is so confusing that
> it warrants changing.  The number of replies in this thread highlights that
> it isn't a straightforward thing to change, and personally I don't think
> the names are so bad that it's worth any of the pain that might come from
> changing them.
>
> IMO "OrderShipGroup" could just as easily imply a group of orders that
> should be shipped together as though they were a single order.  So to me,
> "OrderItemShipGroup" does make some sense for the parent entity.
>
> The child entity is a bit trickier, because "OrderItemShipGroupOrderItem"
> is terrible so I guess that's why "Assoc" was chosen as the suffix.
> "OrderItemShipGroupItem" could work but it's not much better than "Assoc".
>
> Sometime's names aren't perfect, but they're usually close enough that it
> doesn't matter very much.
>
> Regards
> Scott
>
>
> On 10 April 2018 at 23:24, Suraj Khurana <suraj.khur...@hotwaxsystems.com>
> wrote:
>
> > Hello,
> >
> > There are some entities which could be renamed as per their usage.
> >
> >- *OrderItemShipGroup*: It shows order ship groups and it doesn't
> >contain anything at order item level. So, it could be re-named as
> >*OrderShipGroup.*
> >- *OrderItemShipGroupAssoc: *It do not maintain any association type,
> it
> >just contains order item with respect to ship group, so this could be
> >re-named as *OrderItemShipGroup *to maintain consistency and code
> >readablity.
> >
> > I know that these entities are crucial part of OOTB data model since
> > inception. Having thought in mind that 'Naming should be self
> explanatory',
> > this is a proposal and It would be great to hear communities thought on
> > this topic.
> >
> > Please share your opinions on this.
> >
> > --
> >
> > Thanks and Regards,
> > *Suraj Khurana* | Omni-channel OMS Technical Expert
> > *HotWax Commerce*  by  *HotWax Systems*
> > Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010
> > Cell phone: +91 96697-50002
> >
>


Re: Check for only QOH while doing reservations

2018-04-11 Thread Rishi Solanki
Thanks Swapnil for adding the use case.

After this it looks like, this is kind of scenario when we couldn't lean on
the ATP. Which should be discussed and addressed. But now I'm sure that
what Suraj suggested makes sense we can go with the improvement Suraj
suggested.

In isolation we can discuss and try to address the race condition issue and
follow the steps.

- Add script to replicate the issue multiple multiple times.
- Discuss and finalize the fix.
- Provide fix.

I would like to help in the race condition issue Swapnil shared.

+1 for Suraj to move ahead for the improvement.


Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Wed, Apr 11, 2018 at 11:08 AM, Swapnil Shah <
swapnil.s...@hotwaxsystems.com> wrote:

> There are certain business cases around order promising where we found that
> systemic ATP hasn't proved that much reliable. Especially when its business
> decision to not accept or promise more orders than allocated units of
> supply
> for sale.
>
> For example, during heavy load(ordering) there could be instances when
> higher number of open orders/carts are competing for same systemic ATP at
> any given point of time. In such scenarios due to any reason if rate of
> performing systemic reservations lags behind the rate of ordering than
> systemic ATP would also keep lagging behind the actual allocation being
> made
> with respect to QOH. Thus system would always keep on accepting orders and
> promising them unless systemic ATP goes down to zero (but in reality the
> QOH
> Is already exhausted way before than systemic ATP went to zero). It leads
> to
> the problem of "Over Promising" and eventually higher than acceptable
> number
> of backorders to honor for business.  In the hindsight it looks like this
> could be one of the reason why the additional check on QOH was in place
> before.
>
> I am not sure if it’s the best way, but one of the possible alternative we
> tried to handle such cases was by grounding the order creation logic based
> on the fact whether there is positive "Available to Order (ATO)" at the
> time
> of order submission or adding items to cart rather than ATP.  At high level
> ATO for any given SKU could be determined on run time as follows:
> ATO = QOH + Incoming Shipments(Scheduled Receipts) - (Total unshipped units
> on Open Orders & Carts)
>
> I hope such cases could help in providing more holistic view while
> leveraging or relying upon the reservation logic.
>
> Thanks,
> Swapnil
>
> -Original Message-
> From: Jacopo Cappellato <jacopo.cappell...@hotwaxsystems.com>
> Sent: Tuesday, April 10, 2018 1:47 PM
> To: dev@ofbiz.apache.org
> Subject: Re: Check for only QOH while doing reservations
>
> Thanks Suraj,
>
> after reviewing that old commit I am inclined to think that the change you
> are suggesting makes sense.
> Before that old commit all the inventory items (regardless of their type
> and
> qty) were selected and there was logic to iterate thru the result set and
> exclude the ones with the wrong type and reserve only the ones with ATP.
> With that commit the type constraint was added to the query and also an
> additional constraint on QOH (rather than ATP): maybe at that time there
> was
> code requiring it or maybe it was done that way to be extra careful.
> I think we can now proceed as you suggest but before we do we should review
> the code that calls the following services:
> reserveProductInventoryByFacility
> reserveProductInventoryByContainer
>
> and make sure that the change will not impact them negatively.
>
> Kind regards,
>
> Jacopo
>
>
> On Mon, Apr 9, 2018 at 3:27 PM, Suraj Khurana <
> suraj.khur...@hotwaxsystems.com> wrote:
>
> > Thanks Scott,
> >
> > I looked around and found some relevant commit.
> > IMO, it has been mistakenly committed as commit log also doesn't shows
> > any functional change in commit.
> > Here
> > <https://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script
> > / org/ofbiz/product/inventory/InventoryReserveServices.xml?
> > r1=650764=650763=650764>
> > is the link for reference.
> >
> > --
> > Thanks and Regards,
> > *Suraj Khurana* | Omni-channel OMS Technical Expert HotWax Commerce
> > by  HotWax Systems Plot no. 80, Scheme no. 78, Vijay Nagar, Indore,
> > M.P. India 452010
> >
> >
> > On Sat, Apr 7, 2018 at 3:24 AM, Scott Gray
> > <scott.g...@hotwaxsystems.com>
> > wrote:
> >
> > > Hi Suraj,
> > >
> > > I haven't reviewed the code in question so I don't have any comment

Re: Question on entity definition for ProductCategoryAttribute

2018-04-06 Thread Rishi Solanki
Benjamin,

The base idea behind such data modeling to force business user to use the
category attribute based on category type. But it does not force at entity
level as such does not mean at all at db level.
IMO we can remove such relations from db layer as anyways we are going to
maintain such constraints on service layer only.

Alternatively, we should rethink on this type of modeling if we want to
maintain relationship somehow. In first look it seems that we should remove
such occurrences.

I would prefer to take others opinion on this, I may be wrong.


Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Thu, Apr 5, 2018 at 8:57 PM, Benjamin Jugl <benjamin.j...@ecomify.de>
wrote:

> Hi everyone,
>
> while I was working onJira Issue OFBIZ-10327 <
> https://issues.apache.org/jira/browse/OFBIZ-10327> and 10328 <
> https://issues.apache.org/jira/browse/OFBIZ-10328> I stumbled across the
> entity definition for ProductCategoryAttribute  (in
> /ofbiz/applications/datamodel/entitydef/product-entitymodel.xml).
>
> The last lines of the definition state:
>
>   
> 
>   
>
> I am quite new to this, but I think this statement does not make sense.
> a) The primary key of ProductCategoryAttribute is composite. Just the
> field "attrName" does not suffice for a relation to another table, if I am
> not mistaken.
> b) I am not quite sure about the nature of a relation between
> CategoryAttribute and CategoryTypeAttribute.
>
> Does anyone have background knowledge to this and can perhaps explain or
> even verify that this is obsolete?
>
> Many thanks, yours Benjamin
>
>
>


Re: why some fields are set to enable-audit-log true by default?

2018-04-05 Thread Rishi Solanki
+1 for removal.
+1 to Scott for having an example in the system ... Example entities seems
right place as mentioned.

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Thu, Apr 5, 2018 at 5:38 AM, Scott Gray <scott.g...@hotwaxsystems.com>
wrote:

> It would be good to leave it on somewhere in the system like the example
> entities maybe
>
> On Wed, 4 Apr 2018, 22:13 Jacques Le Roux, <jacques.le.r...@les7arts.com>
> wrote:
>
> > Le 04/04/2018 à 12:07, Taher Alkhateeb a écrit :
> > > I'm not sure about the field in the entity component though! it
> > > might be needed in some unit tests?
> > Yes
> >
> > Jacques
> >
> >
>


Re: buildbot exception in on ofbizTrunkFramework

2018-03-27 Thread Rishi Solanki
Great!

Thank you Michael!

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Tue, Mar 27, 2018 at 5:54 PM, Michael Brohl <michael.br...@ecomify.de>
wrote:

> Hi Rishi,
>
> no worries, this seems to be a connection problem to jcenter:
>
> FAILURE: Build failed with an exception. * What went wrong: A problem
> occurred configuring root project 'ofbiz'. > Could not resolve all
> dependencies for configuration ':classpath'. > Could not resolve
> at.bxm.gradleplugins:gradle-svntools-plugin:latest.release. Required by:
> project : > Could not resolve 
> at.bxm.gradleplugins:gradle-svntools-plugin:latest.release.
> > Failed to list versions for at.bxm.gradleplugins:gradle-svntools-plugin.
> > Unable to load Maven meta-data from https://jcenter.bintray.com/at
> /bxm/gradleplugins/gradle-svntools-plugin/maven-metadata.xml. > Could not
> GET 'https://jcenter.bintray.com/at/bxm/gradleplugins/gradle-svn
> tools-plugin/maven-metadata.xml'. Received status code 502 from server:
> Bad Gateway
>
> I guess it has nothing to do with your commit.
>
> Regards,
>
> Michael
>
>
> Am 27.03.18 um 13:41 schrieb Rishi Solanki:
>
> Tested again, no test failure. So not reverting the changes and will close
>> the ticket soon.
>>
>> Rishi Solanki
>> Sr Manager, Enterprise Software Development
>> HotWax Systems Pvt. Ltd.
>> Direct: +91-9893287847
>> http://www.hotwaxsystems.com
>> www.hotwax.co
>>
>> On Tue, Mar 27, 2018 at 4:15 PM, Rishi Solanki <rishisolan...@gmail.com>
>> wrote:
>>
>> Not sure why this failure, my recent commit passes all the tests locally
>>> and working fine. I will be surely monitor the upcoming builds and act
>>> accordingly.
>>>
>>> Rishi Solanki
>>> Sr Manager, Enterprise Software Development
>>> HotWax Systems Pvt. Ltd.
>>> Direct: +91-9893287847
>>> http://www.hotwaxsystems.com
>>> www.hotwax.co
>>>
>>> On Tue, Mar 27, 2018 at 4:10 PM, <build...@apache.org> wrote:
>>>
>>> The Buildbot has detected a build exception on builder
>>>> ofbizTrunkFramework while building . Full details are available at:
>>>>  https://ci.apache.org/builders/ofbizTrunkFramework/builds/171
>>>>
>>>> Buildbot URL: https://ci.apache.org/
>>>>
>>>> Buildslave for this Build: orcus_ubuntu
>>>>
>>>> Build Reason: The AnyBranchScheduler scheduler named
>>>> 'onTrunkFrameworkCommit' triggered this build
>>>> Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1827827
>>>> Blamelist: rishi
>>>>
>>>> BUILD FAILED: exception shell upload
>>>>
>>>> Sincerely,
>>>>   -The Buildbot
>>>>
>>>>
>>>>
>>>>
>>>>
>
>


Re: buildbot exception in on ofbizTrunkFramework

2018-03-27 Thread Rishi Solanki
Tested again, no test failure. So not reverting the changes and will close
the ticket soon.

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Tue, Mar 27, 2018 at 4:15 PM, Rishi Solanki <rishisolan...@gmail.com>
wrote:

> Not sure why this failure, my recent commit passes all the tests locally
> and working fine. I will be surely monitor the upcoming builds and act
> accordingly.
>
> Rishi Solanki
> Sr Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
> www.hotwax.co
>
> On Tue, Mar 27, 2018 at 4:10 PM, <build...@apache.org> wrote:
>
>> The Buildbot has detected a build exception on builder
>> ofbizTrunkFramework while building . Full details are available at:
>> https://ci.apache.org/builders/ofbizTrunkFramework/builds/171
>>
>> Buildbot URL: https://ci.apache.org/
>>
>> Buildslave for this Build: orcus_ubuntu
>>
>> Build Reason: The AnyBranchScheduler scheduler named
>> 'onTrunkFrameworkCommit' triggered this build
>> Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1827827
>> Blamelist: rishi
>>
>> BUILD FAILED: exception shell upload
>>
>> Sincerely,
>>  -The Buildbot
>>
>>
>>
>>
>


Re: buildbot exception in on ofbizTrunkFramework

2018-03-27 Thread Rishi Solanki
Not sure why this failure, my recent commit passes all the tests locally
and working fine. I will be surely monitor the upcoming builds and act
accordingly.

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Tue, Mar 27, 2018 at 4:10 PM, <build...@apache.org> wrote:

> The Buildbot has detected a build exception on builder ofbizTrunkFramework
> while building . Full details are available at:
> https://ci.apache.org/builders/ofbizTrunkFramework/builds/171
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: orcus_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named
> 'onTrunkFrameworkCommit' triggered this build
> Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1827827
> Blamelist: rishi
>
> BUILD FAILED: exception shell upload
>
> Sincerely,
>  -The Buildbot
>
>
>
>


Re: Separation database for inventory module

2018-03-26 Thread Rishi Solanki
Jaya,

How do you register the group under delegator?

If it is under same delegator then it shouldn't be problem ideally. And if
it is different then you should try to register all groups under the same
delegator then it should work.



Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Mon, Mar 26, 2018 at 12:29 PM, jayachandr...@gmail.com <
jayachandr...@gmail.com> wrote:

>
>
> On 2018/03/26 05:00:58, Rishi Solanki <rishisolan...@gmail.com> wrote:
> > Paul,
> >
> > Thank you for your reply and more insights. I was just trying to tell the
> > group OFBiz capabilities that how quickly entities can be separated among
> > databases if required (not to everyone but to those who are newer). And
> yes
> > in that case CRUD would be slower and only gains is in reads.
> >
> > If we talk about FKs, I did this in past and in case of mysql it maintain
> > the FKs the referential integrity among different db. I do agree with you
> > on the fact that, this is not good idea to have more database, instead
> > OFBiz supports many ways to retrieve the data way faster rather
> separating
> > the database.
> >
> > So rather that using the separate database, considering the flat
> > information storage would be better idea IMO for faster read.
> >
> > Best Regards,
> >
> >
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
> > On Sun, Mar 25, 2018 at 7:12 AM, Paul Foxworthy <p...@cohsoft.com.au>
> wrote:
> >
> > > On 25 March 2018 at 01:58, Rishi Solanki <rishisolan...@gmail.com>
> wrote:
> > >
> > >
> > > > Register new group in entityengine.xml with new name and data
> resource;
> > > >
> > > >  > > > datasource-name="yourDataResourceName"/>
> > > >
> > > > Add new data resource entry in the entityengine.xml like we have
> many. In
> > > > your case entityengine will contains two entry as localmysql and
> > > > localmysql2 (or any name you prefer).
> > > > Now register all the entities with "your.group.name" in
> > > entity-group.xml.
> > > >
> > > > Refer  > > > datasource-name="localderbytenant"/> and related entries for more
> > > details.
> > > >
> > >
> > > Thanks Rishi.
> > >
> > > If you do define a new group, does that mean:
> > >
> > > - any transaction that modifies entities in two different groups will
> be
> > > slower as the transaction must be a distributed transaction with
> two-phase
> > > commit? To put it another way, with good design decisions, entity
> groups
> > > may well give you  faster reads, but writes very likely won't be?
> > > - Foreign key constraints and thus guaranteed referential integrity
> might
> > > not be possible between groups because not all DBMSes support FKs that
> > > refer to another database?
> > >
> > > Thanks
> > >
> > > Paul Foxworthy
> > >
> > > --
> > > Coherent Software Australia Pty Ltd
> > > PO Box 2773
> > > Cheltenham Vic 3192
> > > Australia
> > >
> > > Phone: +61 3 9585 6788
> > > Web: http://www.coherentsoftware.com.au/
> > > Email: i...@coherentsoftware.com.au
> > >
> >
>
>
> Hi Rishi,
>
> Thanks for your reply on this.
>
> As i said different entity groups allow us  to make different database
> with set of entities. And we have done successfully for communication event
> related tables.
>
> As you said about FKs thats absolutely right about referential integrity
> among different db in mysql.
>
> Coming to the CRUD operations with different groups : ofbiz will create DB
> datasource for each group and maintain the connection pool and perform the
> CRUD operations. While performing ofbiz delegator  uses the group related
> datasource connection perform the actions and its depend on the  DB how
> quickly respond.
>
> With CommunicationEvent related group in our case was performing good and
> not have the issue with writing how ever it's totally different process
> from order/product info.
>
> Now issue is when we want read data from view entity(tables are in
> differents groups(databases)) then ofbiz only uses primary db connection
> and throwing another table not available error.
>
>
> Like communication event to different for inventory we have so many
> dependent view entities in ofbiz.
>
> So looking for solution to maintain this facility data as separtion from
> the actual process.
>
>
> Thanks & Regards
> Jaya
>
>
>
>
>


Re: Separation database for inventory module

2018-03-25 Thread Rishi Solanki
Paul,

Thank you for your reply and more insights. I was just trying to tell the
group OFBiz capabilities that how quickly entities can be separated among
databases if required (not to everyone but to those who are newer). And yes
in that case CRUD would be slower and only gains is in reads.

If we talk about FKs, I did this in past and in case of mysql it maintain
the FKs the referential integrity among different db. I do agree with you
on the fact that, this is not good idea to have more database, instead
OFBiz supports many ways to retrieve the data way faster rather separating
the database.

So rather that using the separate database, considering the flat
information storage would be better idea IMO for faster read.

Best Regards,


Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Sun, Mar 25, 2018 at 7:12 AM, Paul Foxworthy <p...@cohsoft.com.au> wrote:

> On 25 March 2018 at 01:58, Rishi Solanki <rishisolan...@gmail.com> wrote:
>
>
> > Register new group in entityengine.xml with new name and data resource;
> >
> >  > datasource-name="yourDataResourceName"/>
> >
> > Add new data resource entry in the entityengine.xml like we have many. In
> > your case entityengine will contains two entry as localmysql and
> > localmysql2 (or any name you prefer).
> > Now register all the entities with "your.group.name" in
> entity-group.xml.
> >
> > Refer  > datasource-name="localderbytenant"/> and related entries for more
> details.
> >
>
> Thanks Rishi.
>
> If you do define a new group, does that mean:
>
> - any transaction that modifies entities in two different groups will be
> slower as the transaction must be a distributed transaction with two-phase
> commit? To put it another way, with good design decisions, entity groups
> may well give you  faster reads, but writes very likely won't be?
> - Foreign key constraints and thus guaranteed referential integrity might
> not be possible between groups because not all DBMSes support FKs that
> refer to another database?
>
> Thanks
>
> Paul Foxworthy
>
> --
> Coherent Software Australia Pty Ltd
> PO Box 2773
> Cheltenham Vic 3192
> Australia
>
> Phone: +61 3 9585 6788
> Web: http://www.coherentsoftware.com.au/
> Email: i...@coherentsoftware.com.au
>


Re: Welcome Paul Foxworthy as a new PMC member

2018-03-24 Thread Rishi Solanki
Congratulation Paul!!!


Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Fri, Mar 23, 2018 at 10:57 AM, Sanjeev Gupta <sanj...@sanjeevg.com>
wrote:

> Heartiest  Congratulations Paul !!
>
>
>
> -
> Rgds
> Sanjeev Gupta
> --
> Sent from: http://ofbiz.135035.n4.nabble.com/OFBiz-Dev-f165671.html
>


  1   2   3   4   5   6   >