Re: Unused jQuery MockJax Plugin

2019-01-10 Thread Aditya Sharma 
Thanks Michael and Jacques :-)

Done for trunk at r1851013 and R18.12 at r1851014

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

[image: https://www.linkedin.com/in/aditya-p-sharma/]



On Thu, Jan 10, 2019 at 7:13 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Aditya, Michael,
>
> Yes indeed it's not used in OFBiz, I think we are good to remove it and
> mention it in OFBIZ-9978
>
> Jacques
>
> Le 10/01/2019 à 11:37, Aditya Sharma a écrit :
> >   Thanks for the quick response Michael.
> >
> > Indeed it was upgraded with the Jquery upgrade at
> > https://issues.apache.org/jira/browse/OFBIZ-9978  but there was no
> trace of
> > its use. Even I couldn't find it being loaded.
> > I guess it is used by jquery.validation for test
> >
> https://github.com/jquery-validation/jquery-validation/blob/master/test/test.js
> > &
> > must have been added in OFBiz by mistake.
> >
> >
> > Thanks and Regards,
> >
> > *Aditya Sharma* | Enterprise Software Engineer
> > HotWax Commerce  by HotWax Systems
> > 
> > [image: https://www.linkedin.com/in/aditya-p-sharma/]
> > 
> >
> >
> > On Thu, Jan 10, 2019 at 2:55 PM Michael Brohl 
> > wrote:
> >
> >> Hi Aditya,
> >>
> >> a quick search shows that it was added in r1815824 by Jacques for the
> >> update from Jquery 1.11.0 to JQuery 3.2.1.
> >>
> >> Maybe it's a dependency or part of the Jquery stack?
> >>
> >> Regards,
> >>
> >> Michael
> >>
> >> Am 10.01.19 um 10:07 schrieb Aditya Sharma:
> >>> Hello all,
> >>>
> >>> I can't find any use of the jQuery MockJax
> >>>  Plugin included in
> OFBiz.
> >> If
> >>> it is not used anywhere, we can remove it.
> >>>
> >>> Is there anything I am missing?
> >>>
> >>> Thanks and Regards,
> >>>
> >>> *Aditya Sharma* | Enterprise Software Engineer
> >>> HotWax Commerce  by HotWax Systems
> >>> 
> >>> [image: https://www.linkedin.com/in/aditya-p-sharma/]
> >>> 
> >>>
> >>
>

Re: Unused jQuery MockJax Plugin

2019-01-10 Thread Jacques Le Roux 

Hi Aditya, Michael,

Yes indeed it's not used in OFBiz, I think we are good to remove it and mention 
it in OFBIZ-9978

Jacques

Le 10/01/2019 à 11:37, Aditya Sharma a écrit :

  Thanks for the quick response Michael.

Indeed it was upgraded with the Jquery upgrade at
https://issues.apache.org/jira/browse/OFBIZ-9978  but there was no trace of
its use. Even I couldn't find it being loaded.
I guess it is used by jquery.validation for test
https://github.com/jquery-validation/jquery-validation/blob/master/test/test.js
&
must have been added in OFBiz by mistake.


Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

[image: https://www.linkedin.com/in/aditya-p-sharma/]



On Thu, Jan 10, 2019 at 2:55 PM Michael Brohl 
wrote:


Hi Aditya,

a quick search shows that it was added in r1815824 by Jacques for the
update from Jquery 1.11.0 to JQuery 3.2.1.

Maybe it's a dependency or part of the Jquery stack?

Regards,

Michael

Am 10.01.19 um 10:07 schrieb Aditya Sharma:

Hello all,

I can't find any use of the jQuery MockJax
 Plugin included in OFBiz.

If

it is not used anywhere, we can remove it.

Is there anything I am missing?

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

[image: https://www.linkedin.com/in/aditya-p-sharma/]

Re: Unused jQuery MockJax Plugin

2019-01-10 Thread Aditya Sharma 
 Thanks for the quick response Michael.

Indeed it was upgraded with the Jquery upgrade at
https://issues.apache.org/jira/browse/OFBIZ-9978  but there was no trace of
its use. Even I couldn't find it being loaded.
I guess it is used by jquery.validation for test
https://github.com/jquery-validation/jquery-validation/blob/master/test/test.js
&
must have been added in OFBiz by mistake.


Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

[image: https://www.linkedin.com/in/aditya-p-sharma/]



On Thu, Jan 10, 2019 at 2:55 PM Michael Brohl 
wrote:

> Hi Aditya,
>
> a quick search shows that it was added in r1815824 by Jacques for the
> update from Jquery 1.11.0 to JQuery 3.2.1.
>
> Maybe it's a dependency or part of the Jquery stack?
>
> Regards,
>
> Michael
>
> Am 10.01.19 um 10:07 schrieb Aditya Sharma:
> > Hello all,
> >
> > I can't find any use of the jQuery MockJax
> >  Plugin included in OFBiz.
> If
> > it is not used anywhere, we can remove it.
> >
> > Is there anything I am missing?
> >
> > Thanks and Regards,
> >
> > *Aditya Sharma* | Enterprise Software Engineer
> > HotWax Commerce  by HotWax Systems
> > 
> > [image: https://www.linkedin.com/in/aditya-p-sharma/]
> > 
> >
>
>

Re: Unused jQuery MockJax Plugin

2019-01-10 Thread Michael Brohl 

Hi Aditya,

a quick search shows that it was added in r1815824 by Jacques for the 
update from Jquery 1.11.0 to JQuery 3.2.1.


Maybe it's a dependency or part of the Jquery stack?

Regards,

Michael

Am 10.01.19 um 10:07 schrieb Aditya Sharma:

Hello all,

I can't find any use of the jQuery MockJax
 Plugin included in OFBiz. If
it is not used anywhere, we can remove it.

Is there anything I am missing?

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

[image: https://www.linkedin.com/in/aditya-p-sharma/]






smime.p7s
Description: S/MIME Cryptographic Signature