[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193280#comment-14193280 ] Adrian Crum commented on OFBIZ-3774: Work on this begun with rev 1635990. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171529#comment-13171529 ] Adrian Crum commented on OFBIZ-3774: I added abstract visitor classes in rev 1215462. They are empty for now, but I imagine they will accumulate functionality as the conversion progresses. The next step is to extend the abstract classes to rendering classes and copy existing rendering code over to them. The tree widget and menu widget are fairly simple, so we might want to convert those first. Then we can take the lessons learned from those and apply them to the screen and form widgets. We will leave the original model classes untouched from now on so we can keep them updated from the trunk. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171532#comment-13171532 ] Hans Bakker commented on OFBIZ-3774: In this refactoring, may we also expect junit tests? Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171533#comment-13171533 ] Adrian Crum commented on OFBIZ-3774: Certainly! Would you be willing to contribute those? Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171537#comment-13171537 ] Hans Bakker commented on OFBIZ-3774: As with any refactoring i am concerned about the introduction of new errors. Junit tests will certainly help here. I appreciate your your input here however for me i do not see the actual need of doing this. I am just concerned about new errors creeping in. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171546#comment-13171546 ] Adrian Crum commented on OFBIZ-3774: I agree that tests will help. Like any other effort in the OFBiz community, this is a voluntary one. The scope depends on the availability of volunteers. I appreciate your concerns and I believe those concerns have been addressed by creating a branch so development here will not interfere with the trunk. One thing I can assure, however (and my track record with this community bears this out) is that any issues caused by the redesign will not be left as-is with the excuse that I am too busy to fix them. The need for this change was covered thoroughly in the previous comments. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165088#comment-13165088 ] Dimitri Unruh commented on OFBIZ-3774: -- Thank you Adrian, so I will continue with the screens. Shouldn't we open a new Jira issue now? Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165111#comment-13165111 ] Adrian Crum commented on OFBIZ-3774: Yes, we need a separate Jira issue for the package rename. My hope is that we can stay in scope and provide a clear change trail for others to follow. With that in mind, I would like to see the redesign occur with small, easily defined steps: 1. Add the visitor interfaces and accept methods. 2. Create abstract classes for the interfaces. 3. Extend the abstract classes to rendering classes and artifact-info-gatherer classes. 4. Move existing widget model code to the new classes. 5. Merge all changes to the trunk. 6. Close this issue and start on the next one. The package rename would be a good candidate for the next redesign effort, and we will merge those changes to the trunk when they are completed. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165166#comment-13165166 ] Dimitri Unruh commented on OFBIZ-3774: -- New Jira issue: OFBIZ-4616 Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165196#comment-13165196 ] Adrian Crum commented on OFBIZ-3774: Dimitri, Thank you, but I think there is some confusion here. We don't need separate Jira issues for adding the visitor pattern to the screen widgets. Instead, we need separate Jira issues for other screen widget tasks that are not related to adding the visitor pattern to the screen widgets - tasks like the package rename you proposed. Steps 1 - 6 that I mentioned in my previous comment can be carried out in this issue. I was only suggesting that we make the changes *for this issue* in small steps so they are easy for others to follow and understand. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165198#comment-13165198 ] Adrian Crum commented on OFBIZ-3774: In rev 1211809 I added exception handling to the two visitor interfaces. Classes that implement the visitor interfaces will need the ability to throw exceptions. We still need visitor interfaces/accept methods for menu models and form models. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164381#comment-13164381 ] Dimitri Unruh commented on OFBIZ-3774: -- Adrian, maybe you will have a chance to review the current patch. You will see my idea for the package refactoring (package: org.ofbiz.widget.screen.widget). If this is something you could agree with, I will continue with it. Anyway, I did some dirty workarounds for the current version, wich we will remove at the end of the refactoring process. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164422#comment-13164422 ] Adrian Crum commented on OFBIZ-3774: Thank you Dimitri. I do not understand the need for a package change. Could you explain the reason for it please? Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[
https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164449#comment-13164449
]
Dimitri Unruh commented on OFBIZ-3774:
--
The main reason is a better overview :) A ModeScreenWidget.java with 2000 lines
isn't easy to maintain.
At the end I would prefer something like:
{code}
org.ofbiz.widget.screen.action
org.ofbiz.widget.screen.condition
org.ofbiz.widget.screen.handler
org.ofbiz.widget.screen.renderer
org.ofbiz.widget.screen.widget
{code}
I also would do this for form, menu and tree. So it would be more clear if you
are searching for something.
Add The Visitor Pattern To Screen Widget Model Classes
--
Key: OFBIZ-3774
URL: https://issues.apache.org/jira/browse/OFBIZ-3774
Project: OFBiz
Issue Type: Improvement
Components: framework
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch,
OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch
From time to time there has been interest expressed in introducing the
visitor pattern to the screen widget model classes. This issue is intended to
provide a forum on the subject and a means to vote on it. Details are in the
comments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[
https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164462#comment-13164462
]
Adrian Crum commented on OFBIZ-3774:
Thank you Dimitri. I understand now. If we are going to change the package,
then I would suggest something like:
{code}
org.ofbiz.widget.factory
org.ofbiz.widget.model.action
org.ofbiz.widget.model.condition
org.ofbiz.widget.model.widget
org.ofbiz.widget.parser
org.ofbiz.widget.renderer
{code}
From my perspective, that type of packaging will facilitate code reuse.
Add The Visitor Pattern To Screen Widget Model Classes
--
Key: OFBIZ-3774
URL: https://issues.apache.org/jira/browse/OFBIZ-3774
Project: OFBiz
Issue Type: Improvement
Components: framework
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch,
OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch
From time to time there has been interest expressed in introducing the
visitor pattern to the screen widget model classes. This issue is intended to
provide a forum on the subject and a means to vote on it. Details are in the
comments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164806#comment-13164806 ] Adrian Crum commented on OFBIZ-3774: Added ScreenWidgetVisitor interface in rev 1211693. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159484#comment-13159484 ] Dimitri Unruh commented on OFBIZ-3774: -- Adrian, if we don't need backward compatibility, I would like to do some package refactoring. I will provide a patch for the screen package as an example. Also I will provide a first patch file for the visitor pattern (at first, only your visitor interface). What do you think? Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159488#comment-13159488 ] Adrian Crum commented on OFBIZ-3774: Incremental changes will be easier for me to review. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150353#comment-13150353 ] Dimitri Unruh commented on OFBIZ-3774: -- Adrian, what should we do with this? Vote? This is really nice:) Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150379#comment-13150379 ] Adrian Crum commented on OFBIZ-3774: The first thing we need to do is get a team assembled who are willing to work on this. It is a sizable effort. Second, we should create a branch for the screen widget refactoring. In addition to the visitor pattern, there have been some other very good ideas on screen widget changes - so those could be discussed and included in the branch too. Finally, when the work in the branch is completed, we will ask the community to review it and vote on merging it back to the trunk. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150400#comment-13150400 ] Dimitri Unruh commented on OFBIZ-3774: -- I would like to help and work on it Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150457#comment-13150457 ] Adrian Crum commented on OFBIZ-3774: Cool! Branch has been created: https://svn.apache.org/repos/asf/ofbiz/branches/2015ScreenWidgetRedesign Check out the branch to a local copy, make your changes, and post patches here. I will review them and commit them to the branch. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150524#comment-13150524 ] Adrian Crum commented on OFBIZ-3774: By the way, the existing patches are POC type work - they should not be used directly. Instead, use them as a guideline. One of the things I tried to do in those patches was maintain backward compatibility, but recent discussions on the dev mailing list have opened up the possibility to make newer versions of OFBiz less backwards compatible - if there is a significant improvement involved. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150529#comment-13150529 ] Adrian Crum commented on OFBIZ-3774: Once all of the behavior has been moved to external classes, we could continue the process (in a separate Jira issue) to turn the screen widget models into immutable data structures. That will improve performance and memory use, and it can help cut down on the instances of thread-unsafe code being introduced into the project (a recurring problem in this project). Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868470#action_12868470 ] Marc Morin commented on OFBIZ-3774: --- We did a similar visitor pattern to the entire presentment (Screen, Form, Menu) space and the controller. This path, mainly separation of concern, is very powerful, and allows easy extension to the system. The typical implementation path that has been taken, is to develop a series of abstract visitors that have a few base behaviors, navigation of the components, and throwing exceptions for each component. This enables a specific visitors to extend the base navigation class, to get full model navigation and add any specific behavior with a surprisingly small amount of code. We've done Presentment visitors for walking, validation (examining location/name references looking for dangling screen/from/controller references, etc.. used in junit test cases - fail build if broken links), security auto-notation (propagates service security declarations, to screens model objects, and will automatically remove buttons, links to areas in the application that the user doesn't have rights to access.) We have a partial dump (pretty-print) for the PresentmentModel as well. Externalizing the creation of the model objects, is crucial to getting the full power of this type of change. The model objects should have nothing but their attributes with their getter/setter methods (and the accept). Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868503#action_12868503 ] Adrian Crum commented on OFBIZ-3774: One thing I would like to clarify: the patch only includes screen sub-widgets, but the goal would be apply the visitor pattern to all screen widget model classes - like Marc mentioned. An abstract class for renderers that navigates the model structure probably won't work - because each rendering format will require its own sequence of events, or its own mode of navigation. You can't determine in advance how a particular rendering format will need to navigate the structure. The existing widget models try to do this form of prediction and it has caused problems in the past. I'm currently working on porting the macro renderer over to the visitor interface to see what kind of problems we might encounter. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
