Re: Add to cart with zero quantity

2018-09-10 Thread Suraj Khurana
Thanks everyone for your inputs. I have created a Jira here . -- Best Regards, Suraj Khurana Omnichannel OMS Technical Expert HotWax Systems m: +91 96697-50002 e: suraj.khur...@hotwaxsystems.com On Mon, Sep 10, 2018 at 11:48 AM, Jacques Le Roux

Re: Add to cart with zero quantity

2018-09-10 Thread Jacques Le Roux
Hi Suraj, I did not get enough time yet to continue on my idea of creating a [PROPOSAL] following the thread "[QUESTION] Should we not check fields consistency?" So please feel free to create an improvement Jira for this task. We can later link appropriately. Thanks Jacques Le 05/09/2018

Re: Add to cart with zero quantity

2018-09-06 Thread Jacques Le Roux
Thanks Sharan for the details, There are certainly other "little" quirks like that and we should try to act globally on them OK, I'm rehashing my idea and should rather create a Jira main task/umbrella and begin to work on it :D Jacques Le 06/09/2018 à 17:37, Sharan Foga a écrit : Hi

Re: Add to cart with zero quantity

2018-09-06 Thread Sharan Foga
Hi Suraj I also can’t think of a reason a zero quantity of an item would need to be added to the shopping cart. So yes I think adding a check so that any zero quantities are removed from the cart before creating the order would be good. For info - I did a quick test using the stable demo and

Re: Add to cart with zero quantity

2018-09-05 Thread Pierre Smits
At the moment I can't see the business case either. If you have the time and the willingness, please raise a JIRA ticket and address accordingly. Best regards, Pierre Smits Apache Trafodion , Vice President Apache Directory , PMC

Re: Add to cart with zero quantity

2018-09-05 Thread Jacques Le Roux
Hi Suraj, Thanks for you report and suggestion. I'd recommend to make this part of the global reflection about fields validation I called about in the "[QUESTION] Should we not check fields consistency?" thread. The idea is not not have such changes scattered all over the place when we could

Add to cart with zero quantity

2018-09-05 Thread Suraj Khurana
Hello team, Currently, it is possible to add items in cart with zero quantity. I can't think of any use case for this. We also have a method available in shopping cart as *removeEmptyCartItems*, but it is always called while handling exceptions. I think we can call this method before create