Re: Adding fromDate and thruDate in GoodIdentification Entity

Thanks so much, everyone for the valuable feedback. This indeed increases my understanding. Based on inputs I will have more look into this. For now, I have discarded the ticket OFBIZ-10963 [1], we can reopen it in the future if required. [1] https://issues.apache.org/jira/browse/OFBIZ-10963

Re: Adding fromDate and thruDate in GoodIdentification Entity

Thanks so much, everyone for the valuable feedback. This indeed increases my understanding. Based on inputs I will have more look into this. For now, I have discarded the ticket OFBIZ-10963 [1], we can reopen it in the future if required. [1] https://issues.apache.org/jira/browse/OFBIZ-10963

Re: Adding fromDate and thruDate in GoodIdentification Entity

Thanks so much, everyone for the valuable feedback. This indeed increases my understanding. Based on inputs I will have more look into this. For now, I have discarded the ticket OFBIZ-10963 [1], we can reopen it in the future if required. [1] https://issues.apache.org/jira/browse/OFBIZ-10963

Re: Adding fromDate and thruDate in GoodIdentification Entity

Agree with Rishi here, and a -1 for the proposal. The GoodIdentification or the PartyIdentification entity should only contain the information to uniquely identify a product(which said by everyone, is rarely), so adding fromDate/thruDate will not be much beneficial. On the other hand, the

Re: Adding fromDate and thruDate in GoodIdentification Entity

-1 for the proposal. For a product identification code will be one of one type. The universal data model book by Len Silverston suggested the same. Best Regards, -- *Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax Systems Plot no. 80, Scheme no.

Re: Adding fromDate and thruDate in GoodIdentification Entity

Hi Aishwary, can you elaborate a bit more why a history of GoodIdentification is needed? It is used for identification numbers as ISBN, EAN etc.. Those numbers are rarely subject to change for the same product. I don't see any use case for history tracking so I would appreciate some

Re: Adding fromDate and thruDate in GoodIdentification Entity

+1 Nicolas for maintaining history(if we are going to maintain it) in separate entity rather than adding fromDate, thruDate to GoodIdentification table. The purpose of this entity is to store the identification codes for the product. I don't find any use case where product identifications codes

Re: Adding fromDate and thruDate in GoodIdentification Entity

Hello Deepak, We might need to change good identification value anytime due to change in the third-party system or due to other reason. So to track the previous/old value we may need to maintain it by date constraint. At a time only one identification will be active for a product of the same

Re: Adding fromDate and thruDate in GoodIdentification Entity

I'm mixed about that idea. GoodIdentification like PartyIdentification are useful to search on multiple identification shared by other system.  Add life-stamp will add complexity the resolve quickly a element. Like a name 99% case it's more important to have the current identification list.

Re: Adding fromDate and thruDate in GoodIdentification Entity

+1, looks good to me. This will require changes in existing CRUD operations related to GoodIdentifications. Also may need migration service or SQL scripts. -- Best Regards, Arun Patidar www.hotwax.co On Sat, Apr 27, 2019 at 12:42 PM Aishwary Shrivastava <

Re: Adding fromDate and thruDate in GoodIdentification Entity

Hi Aishwarys, On Sat, Apr 27, 2019 at 12:42 PM Aishwary Shrivastava < aishwary.shrivast...@hotwaxsystems.com> wrote: > Hello, Devs > > We should add support of fromDate and thruDate in the GoodIdentification > entity for tracking and history purpose. > > Sounds good. > As of now, if we need

Re: Adding fromDate and thruDate in GoodIdentification Entity

+1 with fromDate as part of primary key. -- Best Regards, Suraj Khurana On Sat, Apr 27, 2019 at 12:42 PM Aishwary Shrivastava < aishwary.shrivast...@hotwaxsystems.com> wrote: > Hello, Devs > > We should add support of fromDate and thruDate in the GoodIdentification > entity for tracking

Adding fromDate and thruDate in GoodIdentification Entity

Hello, Devs We should add support of fromDate and thruDate in the GoodIdentification entity for tracking and history purpose. As of now, if we need to update any Good Identification record for a product, then we have to replace its value and this history isn't maintained. It will also enable the