Hello Jacques,
Thanks for your feedback, I'll go with that.
Gil
On Mon, Jul 25, 2022 at 10:08:20AM +0200, Jacques Le Roux wrote:
> Hi Gil,
>
> Here are my preferences inline...
>
> Le 20/07/2022 à 23:49, Gil Portenseigne a écrit :
> > Thanks All for the feedback.
> >
> > I continue in my
Hi Gil,
Here are my preferences inline...
Le 20/07/2022 à 23:49, Gil Portenseigne a écrit :
Thanks All for the feedback.
I continue in my spare time and did analyse some rule that I propose to disable.
Here are my thought :
* DuplicateStringLiteral : Not Adapted to OFBiz : String
Thanks All for the feedback.
I continue in my spare time and did analyse some rule that I propose to disable.
Here are my thought :
* DuplicateStringLiteral : Not Adapted to OFBiz : String Literal are
massively entityName. No need to make them constants.
* LineLength : Can be configured :
Hello Michael,
Sure, you can see in the pull request I started to separate the commit, a
commit for one rule fix.
The last one is a big one :)
https://github.com/apache/ofbiz-framework/pull/517/commits/384894dfafce5e7261e2564b40261650deda7a22
Regards,
Gil
Le Dimanche, Juillet 10, 2022
Forgot the ref https://github.com/CodeNarc/CodeNarc/issues/331
Le 12 juillet 2022 21:11:13 GMT+02:00, Gil Portenseigne
a écrit :
>Hello,
>
>I agree with you, i find out here [1] that it is customisable.
>
>So we can agree upon this variation of the rule !
>
>I have not tested yet, will see in
Hello,
I agree with you, i find out here [1] that it is customisable.
So we can agree upon this variation of the rule !
I have not tested yet, will see in the near future
Thanks
Gil
Le 11 juillet 2022 17:57:45 GMT+02:00, Scott Gray a écrit :
>+1 in general from me although some of those
+1
This can be a great addition to the project. Thank you, Gil.
--
Kind Regards,
Ashish Vijaywargiya
Vice President of Operations
*HotWax Systems*
*Enterprise open source experts*
http://www.hotwaxsystems.com
On Mon, Jul 4, 2022 at 8:54 PM Gil Portenseigne
wrote:
> Hello Devs,
>
> I would
+1 in general from me although some of those rules might be challenging to
resolve. For example DuplicateStringLiteral could be referring to an
entity name being used in delegator queries more than once, I don't think
we'd prefer to see that extracted to a constant.
SpaceAroundMapEntryColon I'm
+1
Thank you Gil!
Jacopo
On Mon, Jul 4, 2022 at 5:24 PM Gil Portenseigne
wrote:
> Hello Devs,
>
> I would like to continue Codenarc integration in OFBiz (OFBIZ-11167).
>
> For those who are not aware, Codenarc is an analysis tools for Groovy
> for defects, bad practices, inconsistencies,
Hi Gil,
I was on vacation so a bit late: I fully agree to apply these rules.
We should, however, encourage contributors to apply those changes in
separate commits which ONLY contain those changes and not mix it up with
other changes to make review work easier.
Thanks for the initiative,
Hi Gil,
Great initiative, so far it seems we have a lazy consensus
We (almost*) did it for Java, why not for Groovy :)
Jacques
* OFBIZ-12341
Le 04/07/2022 à 17:24, Gil Portenseigne a écrit :
Hello Devs,
I would like to continue Codenarc integration in OFBiz (OFBIZ-11167).
For those who
Hello Devs,
I would like to continue Codenarc integration in OFBiz (OFBIZ-11167).
For those who are not aware, Codenarc is an analysis tools for Groovy
for defects, bad practices, inconsistencies, style issues and more.
For this purpose we need to agree about the ruleset to put in place.
I
12 matches
Mail list logo
