Re: Enabling HTTP/2 in the embedded Tomcat connectors

2019-02-28 Thread Jacopo Cappellato
Thank you Jacques and Taher for your review and useful comments: I have committed this work with rev. 1854532. Taher, I have reviewed the configuration options but I don't feel like changing any of them by default; for now I have added a comment to the commit about them and I will leave the

Re: Enabling HTTP/2 in the embedded Tomcat connectors

2019-02-25 Thread Jacques Le Roux
I had a look, I don't think we need to worry about those vars. If/When needed we can change defaults. Jacques Le 19/02/2019 à 19:05, Jacques Le Roux a écrit : Good question, I guess most are OK, but what are Trailer Headers for instance? BTW

Re: Enabling HTTP/2 in the embedded Tomcat connectors

2019-02-19 Thread Jacques Le Roux
Good question, I guess most are OK, but what are Trailer Headers for instance? BTW https://tomcat.apache.org/tomcat-9.0-doc/config/http2.html is our reference for the trunk Jacques Le 19/02/2019 à 10:24, Taher Alkhateeb a écrit : clean and simple implementation, +1 on a side note, I wonder

Re: Enabling HTTP/2 in the embedded Tomcat connectors

2019-02-19 Thread Taher Alkhateeb
clean and simple implementation, +1 on a side note, I wonder if we need to set any of the http2 attributes listed in [1] or whether the defaults are okay. [1] https://tomcat.apache.org/tomcat-8.5-doc/config/http2.html On Mon, Feb 18, 2019 at 5:58 PM Jacques Le Roux wrote: > > Hi Jacopo, > >

Re: Enabling HTTP/2 in the embedded Tomcat connectors

2019-02-18 Thread Jacques Le Roux
Hi Jacopo, Sounds good to me, we can always easily revert in case of unexpected issue anyway Thanks Jacques Le 18/02/2019 à 11:43, Jacopo Cappellato a écrit : Hi all, I think it is time to enable the instance of Tomcat that is embedded in OFBiz to communicate using the HTTP/2 protocol,

Enabling HTTP/2 in the embedded Tomcat connectors

2019-02-18 Thread Jacopo Cappellato
Hi all, I think it is time to enable the instance of Tomcat that is embedded in OFBiz to communicate using the HTTP/2 protocol, when the client supports it. For your review, before I commit, I am pasting here the patch that will enable it (it is quite simple) . In it I have enabled HTTP/2 by