Re: Entity and Service definition

2016-07-19 Thread Divesh Dutta
Very good initiative. Thanks -- Divesh Dutta . On Sun, Jul 17, 2016 at 6:00 PM, Rishi Solanki wrote: > Starter effort on this under - OFBIZ-7828. Community review / feedback / > suggestion / concerns are welcome. > > Thanks! > > Rishi Solanki > Manager, Enterprise

Re: Entity and Service definition

2016-07-17 Thread Rishi Solanki
Starter effort on this under - OFBIZ-7828. Community review / feedback / suggestion / concerns are welcome. Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Thu, Jul 14, 2016 at 9:58 AM, Rishi Solanki

[jira] [Commented] (OFBIZ-7828) Entity and Service definition

2016-07-16 Thread Rishi Solanki (JIRA)
ckage-name="org.ofbiz.order.reservations" then we will add its service defintion under order/servicedef/services_reservations.xml. Community, please raise flag in case of concerns in this pattern. Thanks! > Entity and Service definition > - > > Key:

[jira] [Assigned] (OFBIZ-7828) Entity and Service definition

2016-07-16 Thread Arun Patidar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar reassigned OFBIZ-7828: --- Assignee: Arun Patidar > Entity and Service definit

[jira] [Updated] (OFBIZ-7828) Entity and Service definition

2016-07-16 Thread Rishi Solanki (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7828: - Priority: Major (was: Minor) > Entity and Service definit

[jira] [Created] (OFBIZ-7828) Entity and Service definition

2016-07-16 Thread Rishi Solanki (JIRA)
Rishi Solanki created OFBIZ-7828: Summary: Entity and Service definition Key: OFBIZ-7828 URL: https://issues.apache.org/jira/browse/OFBIZ-7828 Project: OFBiz Issue Type: Improvement

Re: Entity and Service definition

2016-07-13 Thread Rishi Solanki
Thank you everyone for your approval and suggestion. We would try to follow most, and log Jira accordingly. Soon will start on this. Nicolas, thanks for pointing expire action on entity-auto. Jacques, Pierre, thanks for suggestion on managing Jira tickets, and you guys anyways helped us in our

Re: Entity and Service definition

2016-07-13 Thread Jacques Le Roux
Le 13/07/2016 à 09:39, Pierre Smits a écrit : At this moment in time, I can't fathom how much effort is involved in this factoring, but I suggest to break it down as much as possible into separate JIRA issues. For instance, the rework on the removal of the OrderHeaderNoteView and

Re: Entity and Service definition

2016-07-13 Thread Pranay Pandey
+1 Thanks for posting idea in detail. Best regards, Pranay Pandey HotWax Systems http://www.hotwaxsystems.com/ On Tue, Jul 12, 2016 at 2:01 PM, Rishi Solanki wrote: > Dear Folks, > > While working/reviewing recent work in community, I observed some >

Re: Entity and Service definition

2016-07-13 Thread Arun Patidar
+1 for all suggestions. Thanks & Regards --- Arun Patidar Manager, Enterprise Software Development HotWax Systems www.hotwaxsystems.com On Tuesday 12 July 2016 02:01 PM, Rishi Solanki wrote: Dear Folks, While working/reviewing recent work in community, I observed some improvement/fixes

Re: Entity and Service definition

2016-07-13 Thread Pierre Smits
I am all for improving the code base towards more consistency. Having service definitions for CRUD functions for all entities, but the view entities, is part of that. And it opens the opportunity to get a potential future where OFBiz is opened up - in a relative easy way - to the external

Re: Entity and Service definition

2016-07-13 Thread Amardeep Singh Jhajj
+1 Thanks & Regards -- Amardeep Singh Jhajj On Tue, Jul 12, 2016 at 2:01 PM, Rishi Solanki wrote: > Dear Folks, > > While working/reviewing recent work in community, I observed some > improvement/fixes required at entity and related service implementation. > For few

Re: Entity and Service definition

2016-07-13 Thread Deepak Dixit
+1 Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com On Wed, Jul 13, 2016 at 11:19 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > +1 > > Jacques > > > > Le 12/07/2016 à 14:02, Nicolas Malin a écrit : > >> Hi Rishi, >> >> :) I totaly agree with your remarks >> >> In line >> >>

Re: Entity and Service definition

2016-07-12 Thread Jacques Le Roux
+1 Jacques Le 12/07/2016 à 14:02, Nicolas Malin a écrit : Hi Rishi, :) I totaly agree with your remarks In line Le 12/07/2016 10:31, Rishi Solanki a écrit : Dear Folks, While working/reviewing recent work in community, I observed some improvement/fixes required at entity and related

Re: Entity and Service definition

2016-07-12 Thread Nicolas Malin
Hi Rishi, :) I totaly agree with your remarks In line Le 12/07/2016 10:31, Rishi Solanki a écrit : Dear Folks, While working/reviewing recent work in community, I observed some improvement/fixes required at entity and related service implementation. For few entities like InvoiceAttribute,

Re: Entity and Service definition

2016-07-12 Thread Swapnil Mane
+1 for all suggestions, seems good improvements to me :-) - Best Regards, Swapnil M Mane H otWax Systems - *The global leader in innovative enterprise commerce s**olutions **powered by Apache OFBiz.* ApacheCon US 2015 Silver Sponsor

Re: Entity and Service definition

2016-07-12 Thread Rishi Solanki
Thank you Taher, and yes I had the same concern for it, even when we are working on enforcing noninstantiability, but we will be able to achieve zero regression till now by doing internal multi-level QA. Thanks for pointing this, we will ensure before proceeding for any changes. :) Rishi Solanki

Re: Entity and Service definition

2016-07-12 Thread Taher Alkhateeb
Hi Rishi, Great Ideas, +1 for all suggestions. I only have one warning because this happened in the past: Do not switch from Services to entity-auto without being 100% sure this is the right thing to do. Sometimes you miss important logic that breaks things elsewhere. Thank you for the

Entity and Service definition

2016-07-12 Thread Rishi Solanki
Dear Folks, While working/reviewing recent work in community, I observed some improvement/fixes required at entity and related service implementation. For few entities like InvoiceAttribute, InvoiceType, etc. no service exists to create/update/delete. At the time of writing migration scripts I