Re: Reducing excessive and improperly studied commits

2017-06-29 Thread Taher Alkhateeb
Hi Nicolas, Good input and good to have your perspective on this, thank you! I started a thread last year [1] exactly to advocate for being brave and innovative and to shift our somewhat conservative culture. This is something I definitely hold near to my heart and I'm happy to say that I think o

Re: Reducing excessive and improperly studied commits

2017-06-29 Thread Nicolas Malin
It's a difficult subject because I'm sure Jacques realized some change with the clear aims to improve the framework with his knowledge. When your knowledge is completed by other commiter's remark you are on the crossway : * revert all your work to try to continue to sharing on the resolution to

Re: Reducing excessive and improperly studied commits

2017-06-29 Thread Jacopo Cappellato
+1 Review Than Commit should be used more often. I also wish that Jacques, from now on, will to be less resistant to requests to revert his commits: the act of reverting a commit is not a shame on the author nor a punishment but instead it is a mechanism that helps to keep the code clean while som

Re: Reducing excessive and improperly studied commits

2017-06-27 Thread Sharan Foga
+1 Since this discussion thread started I've seen in a recent thread [1] where this issue has happened again so I agree something needs to be done to manage it. Thanks Sharan [1] https://s.apache.org/EB1E On 2017-06-21 13:03 (+0200), Michael Brohl wrote: > +1 > > I agree, this matches my

Re: Reducing excessive and improperly studied commits

2017-06-21 Thread Michael Brohl
+1 I agree, this matches my suggestions in [1]. [1] https://lists.apache.org/thread.html/1cc84ded035247ec439199ae0694d699fe1bcffb5d067c3ae732a0e9@%3Cdev.ofbiz.apache.org%3E Regards, Michael Brohl ecomify GmbH www.ecomify.de Am 21.06.17 um 12:37 schrieb Taher Alkhateeb: Hello Everyone, I

Reducing excessive and improperly studied commits

2017-06-21 Thread Taher Alkhateeb
Hello Everyone, I am starting this thread because of the latest unexpected release thread [1] due to a major bug introduced by Jacques Le Roux in [2]. We had multiple discussion with Jacques, one such discussion [3] was due to a bad commit in which I made a recommendation to stop doing bulk commi