Re: Review Multi-Tenancy Setup regarding OFBIZ-5898, commit r1645310 and OFBIZ-5986

2015-04-14 Thread Jacques Le Roux
Thanks for the feedback Arun. Jacques Le 14/04/2015 08:34, Arun Patidar a écrit : Hi Jacques, I have discussed these issues with Pierre on Skype chat. It seems that these issues needs more discussions to come up with a proper fix. Currently I am not working on these issues so any one who

Re: Review Multi-Tenancy Setup regarding OFBIZ-5898, commit r1645310 and OFBIZ-5986

2015-04-14 Thread Arun Patidar
Hi Jacques, I have discussed these issues with Pierre on Skype chat. It seems that these issues needs more discussions to come up with a proper fix. Currently I am not working on these issues so any one who wants to work and have proper fix can start on same. Thanks Regards --- Arun

Re: Review Multi-Tenancy Setup regarding OFBIZ-5898, commit r1645310 and OFBIZ-5986

2015-03-19 Thread Jacques Le Roux
Le 19/03/2015 23:35, Jacques Le Roux a écrit : Hi Arun, Sorry it was hard to follow, are there Jiras? Ah, Pierre created them: https://issues.apache.org/jira/browse/OFBIZ-6065 https://issues.apache.org/jira/browse/OFBIZ-6066 BTW from Pierre message I guess the committer is also committed...

Re: Review Multi-Tenancy Setup regarding OFBIZ-5898, commit r1645310 and OFBIZ-5986

2015-03-19 Thread Jacques Le Roux
Hi Arun, Sorry it was hard to follow, are there Jiras? For 2. Pierre Smits does not seem to agree: http://markmail.org/message/pjqjw4s4mzwkczvz Did you get a chance to look at it, is it done? Thanks Jacques Le 09/02/2015 21:44, Jacques Le Roux a écrit : Thanks for the update Arun! Le

Re: Review Multi-Tenancy Setup regarding OFBIZ-5898, commit r1645310 and OFBIZ-5986

2015-02-09 Thread Jacques Le Roux
Thanks for the update Arun! Le 09/02/2015 13:54, Arun Patidar a écrit : A). Below are the two issues on which I will work: 1. Domain name should not create for tenant if its left empty during tenant creation. 2. Tenant component should not visible to other tenant or default. -- Its

Re: Review Multi-Tenancy Setup regarding OFBIZ-5898, commit r1645310 and OFBIZ-5986

2015-02-09 Thread Ashish Vijaywargiya
Hello Pierre, Thanks for providing all the details for tenant functionality. Today Arun and I had a good discussion on all the points that you shared here. Arun will provide the concluded details here. -- Kind Regards, Ashish Vijaywargiya On Thu, Jan 29, 2015 at 7:19 AM, Pierre Smits

Re: Review Multi-Tenancy Setup regarding OFBIZ-5898, commit r1645310 and OFBIZ-5986

2015-02-09 Thread Arun Patidar
Hi Pierre, As I am the creator of issue and patch so trying to provide details on each concern you mentioned. Here is a document 'Extension in Multitenancy support https://cwiki.apache.org/confluence/x/9oT0Ag' in which I explained the extended multi tenancy functionality of OFBiz. Please see

Review Multi-Tenancy Setup regarding OFBIZ-5898, commit r1645310 and OFBIZ-5986

2015-01-28 Thread Pierre Smits
This is a review regarding the effect of recent changes committed through r1645310 (patch provided through issue OFBIZ-5898) and the patch provided through OFBIZ-5986. *References:* - OFBIZ-5898 Tenant should run with specified domain name. Front store should support mulit tenancy feature