Re: svn commit: r1627940 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java

2014-10-01 Thread Hans Bakker
Hi Scott, this is indeed nice, although a duplicate of an existing featureyes every advantage often has a disadvantage. :-) However, can you please add a junit test? These days in the continuous integration age i do not think it is acceptable anymore adding new functions to the existing

Re: svn commit: r1627940 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java

2014-09-30 Thread Pranay Pandey
+1 Thanks Scott. Pranay Pandey HotWax Media http://www.hotwaxmedia.com On Sep 27, 2014, at 3:29 PM, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: This is really an amazing contribution! Thank you Scott. Jacopo On Sep 27, 2014, at 11:22 AM, lekt...@apache.org wrote:

Re: svn commit: r1627940 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java

2014-09-29 Thread Scott Gray
Thanks Jacopo! I've begun converting the accounting component to use EntityQuery in r1628288, if anyone wants to help please feel free :-) Regards Scott On 27/09/2014, at 9:59 pm, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: This is really an amazing contribution! Thank you

Re: svn commit: r1627940 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java

2014-09-27 Thread Jacopo Cappellato
This is really an amazing contribution! Thank you Scott. Jacopo On Sep 27, 2014, at 11:22 AM, lekt...@apache.org wrote: Author: lektran Date: Sat Sep 27 09:22:31 2014 New Revision: 1627940 URL: http://svn.apache.org/r1627940 Log: OFBIZ-4053 Implement an entity query builder to be used