Re: svn commit: r1832199 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/JavaEventHandler.java

2018-05-27 Thread Mathieu Lirzin
Hello Taher, Taher Alkhateeb writes: > So just to make sure I understand this correctly, we're replacing the > old synchronized block with a ConcurrentHashMap using the atomic > function "computeIfAbsent" and then refactored the class loading logic > into a separate method right? That's correct

Re: svn commit: r1832199 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/JavaEventHandler.java

2018-05-27 Thread Jacques Le Roux
Le 27/05/2018 à 00:33, Taher Alkhateeb a écrit : So just to make sure I understand this correctly, we're replacing the old synchronized block with a ConcurrentHashMap using the atomic function "computeIfAbsent" and then refactored the class loading logic into a separate method right? Yes, that's

Re: svn commit: r1832199 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/JavaEventHandler.java

2018-05-26 Thread Taher Alkhateeb
So just to make sure I understand this correctly, we're replacing the old synchronized block with a ConcurrentHashMap using the atomic function "computeIfAbsent" and then refactored the class loading logic into a separate method right? Given how critical this piece of code is, wouldn't it be more