Re: svn commit: r1838797 - in /ofbiz/ofbiz-plugins/trunk/ecommerce: template/includes/HeaderHead.ftl widget/Theme.xml

[Aditya Sharma]

Thanks Deepak for the suggestions.

Intializing variables once & using it on all page loads seems a better
proposition than concatenation on each page load.

I have added this comment on OFBIZ-10522
. I will wait for inputs
from Julien before I update.

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

[image: https://www.linkedin.com/in/aditya-p-sharma/]



On Fri, Aug 24, 2018 at 3:57 PM Deepak Dixit  wrote:

> Hi Aditya,
>
> I think instead of adding a name in Theme file and concat the sizes while
> rendering, we can add a new property for each size icon.
> e.g VT_SHORTCUT_ICON_32,VT_SHORTCUT_ICON_64 etc.
>
> Thanks & Regards
> --
> Deepak Dixit
>
>
> On Fri, Aug 24, 2018 at 2:48 PM,  wrote:
>
> > Author: adityasharma
> > Date: Fri Aug 24 09:18:59 2018
> > New Revision: 1838797
> >
> > URL: http://svn.apache.org/viewvc?rev=1838797&view=rev
> > Log:
> > Improved: Change the uggly favicon with the new one ! | Using new OFBiz
> > logo
> > (OFBIZ-10522)
> > Updated the icon for the ecommerce.
> >
> > Modified:
> > ofbiz/ofbiz-plugins/trunk/ecommerce/template/includes/HeaderHead.ftl
> > ofbiz/ofbiz-plugins/trunk/ecommerce/widget/Theme.xml
> >
> > Modified: ofbiz/ofbiz-plugins/trunk/ecommerce/template/includes/
> > HeaderHead.ftl
> > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/
> > ecommerce/template/includes/HeaderHead.ftl?rev=1838797&r1=
> > 1838796&r2=1838797&view=diff
> > 
> > ==
> > --- ofbiz/ofbiz-plugins/trunk/ecommerce/template/includes/HeaderHead.ftl
> > (original)
> > +++ ofbiz/ofbiz-plugins/trunk/ecommerce/template/includes/HeaderHead.ftl
> > Fri Aug 24 09:18:59 2018
> > @@ -34,7 +34,12 @@ under the License.
> >  <#assign shortcutIcon = layoutSettings.shortcutIcon/>
> >
> ><#if shortcutIcon?has_content>
> > -
> > +"
> > type="image/x-icon">
> > +" type="image/png">
> > +"
> > type="image/png">
> > +"
> > type="image/png">
> > +"
> > type="image/png">
> > +<#>
> >
> ><#if layoutSettings.styleSheets?has_content>
> ><#--layoutSettings.styleSheets is a list of style sheets. So, you can
> > have a user-specified "main" style sheet,
> >
> > Modified: ofbiz/ofbiz-plugins/trunk/ecommerce/widget/Theme.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/
> > ecommerce/widget/Theme.xml?rev=1838797&r1=1838796&r2=1838797&view=diff
> > 
> > ==
> > --- ofbiz/ofbiz-plugins/trunk/ecommerce/widget/Theme.xml (original)
> > +++ ofbiz/ofbiz-plugins/trunk/ecommerce/widget/Theme.xml Fri Aug 24
> > 09:18:59 2018
> > @@ -37,7 +37,7 @@ under the License.
> >  
> >  
> >   > />
> > -
> > +
> >  
> >  
> >  
> >
> >
> >
>

Re: svn commit: r1838797 - in /ofbiz/ofbiz-plugins/trunk/ecommerce: template/includes/HeaderHead.ftl widget/Theme.xml

[Deepak Dixit]

Hi Aditya,

I think instead of adding a name in Theme file and concat the sizes while
rendering, we can add a new property for each size icon.
e.g VT_SHORTCUT_ICON_32,VT_SHORTCUT_ICON_64 etc.

Thanks & Regards
--
Deepak Dixit


On Fri, Aug 24, 2018 at 2:48 PM,  wrote:

> Author: adityasharma
> Date: Fri Aug 24 09:18:59 2018
> New Revision: 1838797
>
> URL: http://svn.apache.org/viewvc?rev=1838797&view=rev
> Log:
> Improved: Change the uggly favicon with the new one ! | Using new OFBiz
> logo
> (OFBIZ-10522)
> Updated the icon for the ecommerce.
>
> Modified:
> ofbiz/ofbiz-plugins/trunk/ecommerce/template/includes/HeaderHead.ftl
> ofbiz/ofbiz-plugins/trunk/ecommerce/widget/Theme.xml
>
> Modified: ofbiz/ofbiz-plugins/trunk/ecommerce/template/includes/
> HeaderHead.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/
> ecommerce/template/includes/HeaderHead.ftl?rev=1838797&r1=
> 1838796&r2=1838797&view=diff
> 
> ==
> --- ofbiz/ofbiz-plugins/trunk/ecommerce/template/includes/HeaderHead.ftl
> (original)
> +++ ofbiz/ofbiz-plugins/trunk/ecommerce/template/includes/HeaderHead.ftl
> Fri Aug 24 09:18:59 2018
> @@ -34,7 +34,12 @@ under the License.
>  <#assign shortcutIcon = layoutSettings.shortcutIcon/>
>
><#if shortcutIcon?has_content>
> -
> +"
> type="image/x-icon">
> +" type="image/png">
> +"
> type="image/png">
> +"
> type="image/png">
> +"
> type="image/png">
> +<#>
>
><#if layoutSettings.styleSheets?has_content>
><#--layoutSettings.styleSheets is a list of style sheets. So, you can
> have a user-specified "main" style sheet,
>
> Modified: ofbiz/ofbiz-plugins/trunk/ecommerce/widget/Theme.xml
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/
> ecommerce/widget/Theme.xml?rev=1838797&r1=1838796&r2=1838797&view=diff
> 
> ==
> --- ofbiz/ofbiz-plugins/trunk/ecommerce/widget/Theme.xml (original)
> +++ ofbiz/ofbiz-plugins/trunk/ecommerce/widget/Theme.xml Fri Aug 24
> 09:18:59 2018
> @@ -37,7 +37,7 @@ under the License.
>  
>  
>   />
> -
> +
>  
>  
>  
>
>
>