Re: svn commit: r1854306 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

2019-03-14 Thread Jacques Le Roux 

Thanks Deepak!

Le 14/03/2019 à 10:38, Deepak Dixit a écrit :

Done, Committed slightly modified version of the suggested patch.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Mar 14, 2019 at 2:41 PM Deepak Dixit  wrote:


Sure Jacques, Will do
Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Mar 14, 2019 at 2:16 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Thanks Deepak,

Unfortunately it's difficult to use it as us and I have not created a
Jira for that.

Could you please commit it?

TIA

Jacques

Le 13/03/2019 à 06:42, Deepak Dixit a écrit :

Hi Jacques,

I tested the following patch and it works
=

Index: build.gradle

===

--- build.gradle (revision 1855081)

+++ build.gradle (working copy)

@@ -638,7 +638,7 @@

   revision = revisionOutput.toString()

   gitFooterFile.delete()

   gitFooterFile.createNewFile()

-gitFooterFile << '${uiLabelMap.CommonBranch} : ' + "${branch}"

+

System.lineSeparator()

+gitFooterFile << ' ${uiLabelMap.CommonBranch} : ' +

"${branch}" +

System.lineSeparator()

   gitFooterFile << '${uiLabelMap.CommonRevision} : ' +

"${revision}"

+ System.lineSeparator()

   gitFooterFile << '${uiLabelMap.CommonBuiltOn} : ' +

"${timestamp}"

+ System.lineSeparator()

   gitFooterFile << '${uiLabelMap.CommonJavaVersion} : ' +
"${org.gradle.internal.jvm.Jvm.current()}"

@@ -663,7 +663,7 @@

   def info = new XmlParser().parseText(svnOutput.toString())

   svnFooterFile.delete()

   svnFooterFile.createNewFile()

-svnFooterFile << '${uiLabelMap.CommonBranch} : ' +
"${info.entry.url.text()}" + System.lineSeparator()

+svnFooterFile << ' ${uiLabelMap.CommonBranch} : ' +
"${info.entry.url.text()}" + System.lineSeparator()

   svnFooterFile << '${uiLabelMap.CommonRevision} : ' +
"${info.entry.commit.@revision}" + System.lineSeparator()

   svnFooterFile << '${uiLabelMap.CommonBuiltOn} : ' +

"${timestamp}"

+ System.lineSeparator()

   svnFooterFile << '${uiLabelMap.CommonJavaVersion} : ' +
"${org.gradle.internal.jvm.Jvm.current()}"

Index: framework/common/config/CommonUiLabels.xml

===

--- framework/common/config/CommonUiLabels.xml (revision 1855081)

+++ framework/common/config/CommonUiLabels.xml (working copy)

@@ -1389,9 +1389,9 @@

   回報

   

   

- branch

- rama

- branche

+branch

+rama

+branche

   

   

   built on


=


Kind Regards,
Deepak Dixit

On Wed, Mar 13, 2019 at 2:16 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Actually I changed it there because it does not work in build.gradle

where

it's already

gitFooterFile << '${uiLabelMap.CommonBranch} : ' + "${branch}" +
System.lineSeparator()

svnFooterFile << '${uiLabelMap.CommonBranch} : ' +
"${info.entry.url.text()}" + System.lineSeparator()

Jacques

Le 12/03/2019 à 10:33, Jacques Le Roux a écrit :

Agreed Deepak,

Makes sense, I 'll change that

Thanks

Jacques

Le 12/03/2019 à 10:07, Deepak Dixit a écrit :

Hi Jacques,

I think instead of adding space in uiLabel it would be food if we add

space in the template

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org 


On Mon, Feb 25, 2019 at 4:03 PM 
jler...@apache.org>> wrote:

  Author: jleroux
  Date: Mon Feb 25 10:33:53 2019
  New Revision: 1854306

  URL: http://svn.apache.org/viewvc?rev=1854306=rev
  Log:
  Improved: no functional change

  A missing space before CommonBranch label made the word

trunkbranch

instead of

  trunk branch.

  I'll backport this

  Modified:


  ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

  Modified:

ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

  URL:


http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml?rev=1854306=1854305=1854306=diff
  ==

  ---

ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
(original)

  +++

ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

Mon

Feb 25 10:33:53 2019

  @@ -1389,9 +1389,9 @@
   å›žå ±
   
   
  -branch
  -rama
  -branche
  + branch
  + rama
  + branche
   
   
   built on

Re: svn commit: r1854306 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

2019-03-14 Thread Deepak Dixit 
Done, Committed slightly modified version of the suggested patch.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Mar 14, 2019 at 2:41 PM Deepak Dixit  wrote:

> Sure Jacques, Will do
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Thu, Mar 14, 2019 at 2:16 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
>> Thanks Deepak,
>>
>> Unfortunately it's difficult to use it as us and I have not created a
>> Jira for that.
>>
>> Could you please commit it?
>>
>> TIA
>>
>> Jacques
>>
>> Le 13/03/2019 à 06:42, Deepak Dixit a écrit :
>> > Hi Jacques,
>> >
>> > I tested the following patch and it works
>> > =
>> >
>> > Index: build.gradle
>> >
>> > ===
>> >
>> > --- build.gradle (revision 1855081)
>> >
>> > +++ build.gradle (working copy)
>> >
>> > @@ -638,7 +638,7 @@
>> >
>> >   revision = revisionOutput.toString()
>> >
>> >   gitFooterFile.delete()
>> >
>> >   gitFooterFile.createNewFile()
>> >
>> > -gitFooterFile << '${uiLabelMap.CommonBranch} : ' + "${branch}"
>> +
>> > System.lineSeparator()
>> >
>> > +gitFooterFile << ' ${uiLabelMap.CommonBranch} : ' +
>> "${branch}" +
>> > System.lineSeparator()
>> >
>> >   gitFooterFile << '${uiLabelMap.CommonRevision} : ' +
>> "${revision}"
>> > + System.lineSeparator()
>> >
>> >   gitFooterFile << '${uiLabelMap.CommonBuiltOn} : ' +
>> "${timestamp}"
>> > + System.lineSeparator()
>> >
>> >   gitFooterFile << '${uiLabelMap.CommonJavaVersion} : ' +
>> > "${org.gradle.internal.jvm.Jvm.current()}"
>> >
>> > @@ -663,7 +663,7 @@
>> >
>> >   def info = new XmlParser().parseText(svnOutput.toString())
>> >
>> >   svnFooterFile.delete()
>> >
>> >   svnFooterFile.createNewFile()
>> >
>> > -svnFooterFile << '${uiLabelMap.CommonBranch} : ' +
>> > "${info.entry.url.text()}" + System.lineSeparator()
>> >
>> > +svnFooterFile << ' ${uiLabelMap.CommonBranch} : ' +
>> > "${info.entry.url.text()}" + System.lineSeparator()
>> >
>> >   svnFooterFile << '${uiLabelMap.CommonRevision} : ' +
>> > "${info.entry.commit.@revision}" + System.lineSeparator()
>> >
>> >   svnFooterFile << '${uiLabelMap.CommonBuiltOn} : ' +
>> "${timestamp}"
>> > + System.lineSeparator()
>> >
>> >   svnFooterFile << '${uiLabelMap.CommonJavaVersion} : ' +
>> > "${org.gradle.internal.jvm.Jvm.current()}"
>> >
>> > Index: framework/common/config/CommonUiLabels.xml
>> >
>> > ===
>> >
>> > --- framework/common/config/CommonUiLabels.xml (revision 1855081)
>> >
>> > +++ framework/common/config/CommonUiLabels.xml (working copy)
>> >
>> > @@ -1389,9 +1389,9 @@
>> >
>> >   回報
>> >
>> >   
>> >
>> >   
>> >
>> > - branch
>> >
>> > - rama
>> >
>> > - branche
>> >
>> > +branch
>> >
>> > +rama
>> >
>> > +branche
>> >
>> >   
>> >
>> >   
>> >
>> >   built on
>> >
>> >
>> > =
>> >
>> >
>> > Kind Regards,
>> > Deepak Dixit
>> >
>> > On Wed, Mar 13, 2019 at 2:16 AM Jacques Le Roux <
>> > jacques.le.r...@les7arts.com> wrote:
>> >
>> >> Actually I changed it there because it does not work in build.gradle
>> where
>> >> it's already
>> >>
>> >> gitFooterFile << '${uiLabelMap.CommonBranch} : ' + "${branch}" +
>> >> System.lineSeparator()
>> >>
>> >> svnFooterFile << '${uiLabelMap.CommonBranch} : ' +
>> >> "${info.entry.url.text()}" + System.lineSeparator()
>> >>
>> >> Jacques
>> >>
>> >> Le 12/03/2019 à 10:33, Jacques Le Roux a écrit :
>> >>> Agreed Deepak,
>> >>>
>> >>> Makes sense, I 'll change that
>> >>>
>> >>> Thanks
>> >>>
>> >>> Jacques
>> >>>
>> >>> Le 12/03/2019 à 10:07, Deepak Dixit a écrit :
>>  Hi Jacques,
>> 
>>  I think instead of adding space in uiLabel it would be food if we add
>> >> space in the template
>>  Thanks & Regards
>>  --
>>  Deepak Dixit
>>  ofbiz.apache.org 
>> 
>> 
>>  On Mon, Feb 25, 2019 at 4:03 PM > >> jler...@apache.org>> wrote:
>>   Author: jleroux
>>   Date: Mon Feb 25 10:33:53 2019
>>   New Revision: 1854306
>> 
>>   URL: http://svn.apache.org/viewvc?rev=1854306=rev
>>   Log:
>>   Improved: no functional change
>> 
>>   A missing space before CommonBranch label made the word
>> trunkbranch
>> >> instead of
>>   trunk branch.
>> 
>>   I'll backport this
>> 
>>   Modified:
>> 
>> >>
>>  ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
>>   Modified:
>> >> ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
>>   URL:
>> 
>> >>
>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml?rev=1854306=1854305=1854306=diff
>> >>
>>  
>>

Re: svn commit: r1854306 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

2019-03-14 Thread Deepak Dixit 
Sure Jacques, Will do
Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Mar 14, 2019 at 2:16 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks Deepak,
>
> Unfortunately it's difficult to use it as us and I have not created a Jira
> for that.
>
> Could you please commit it?
>
> TIA
>
> Jacques
>
> Le 13/03/2019 à 06:42, Deepak Dixit a écrit :
> > Hi Jacques,
> >
> > I tested the following patch and it works
> > =
> >
> > Index: build.gradle
> >
> > ===
> >
> > --- build.gradle (revision 1855081)
> >
> > +++ build.gradle (working copy)
> >
> > @@ -638,7 +638,7 @@
> >
> >   revision = revisionOutput.toString()
> >
> >   gitFooterFile.delete()
> >
> >   gitFooterFile.createNewFile()
> >
> > -gitFooterFile << '${uiLabelMap.CommonBranch} : ' + "${branch}" +
> > System.lineSeparator()
> >
> > +gitFooterFile << ' ${uiLabelMap.CommonBranch} : ' + "${branch}"
> +
> > System.lineSeparator()
> >
> >   gitFooterFile << '${uiLabelMap.CommonRevision} : ' +
> "${revision}"
> > + System.lineSeparator()
> >
> >   gitFooterFile << '${uiLabelMap.CommonBuiltOn} : ' +
> "${timestamp}"
> > + System.lineSeparator()
> >
> >   gitFooterFile << '${uiLabelMap.CommonJavaVersion} : ' +
> > "${org.gradle.internal.jvm.Jvm.current()}"
> >
> > @@ -663,7 +663,7 @@
> >
> >   def info = new XmlParser().parseText(svnOutput.toString())
> >
> >   svnFooterFile.delete()
> >
> >   svnFooterFile.createNewFile()
> >
> > -svnFooterFile << '${uiLabelMap.CommonBranch} : ' +
> > "${info.entry.url.text()}" + System.lineSeparator()
> >
> > +svnFooterFile << ' ${uiLabelMap.CommonBranch} : ' +
> > "${info.entry.url.text()}" + System.lineSeparator()
> >
> >   svnFooterFile << '${uiLabelMap.CommonRevision} : ' +
> > "${info.entry.commit.@revision}" + System.lineSeparator()
> >
> >   svnFooterFile << '${uiLabelMap.CommonBuiltOn} : ' +
> "${timestamp}"
> > + System.lineSeparator()
> >
> >   svnFooterFile << '${uiLabelMap.CommonJavaVersion} : ' +
> > "${org.gradle.internal.jvm.Jvm.current()}"
> >
> > Index: framework/common/config/CommonUiLabels.xml
> >
> > ===
> >
> > --- framework/common/config/CommonUiLabels.xml (revision 1855081)
> >
> > +++ framework/common/config/CommonUiLabels.xml (working copy)
> >
> > @@ -1389,9 +1389,9 @@
> >
> >   回報
> >
> >   
> >
> >   
> >
> > - branch
> >
> > - rama
> >
> > - branche
> >
> > +branch
> >
> > +rama
> >
> > +branche
> >
> >   
> >
> >   
> >
> >   built on
> >
> >
> > =
> >
> >
> > Kind Regards,
> > Deepak Dixit
> >
> > On Wed, Mar 13, 2019 at 2:16 AM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> Actually I changed it there because it does not work in build.gradle
> where
> >> it's already
> >>
> >> gitFooterFile << '${uiLabelMap.CommonBranch} : ' + "${branch}" +
> >> System.lineSeparator()
> >>
> >> svnFooterFile << '${uiLabelMap.CommonBranch} : ' +
> >> "${info.entry.url.text()}" + System.lineSeparator()
> >>
> >> Jacques
> >>
> >> Le 12/03/2019 à 10:33, Jacques Le Roux a écrit :
> >>> Agreed Deepak,
> >>>
> >>> Makes sense, I 'll change that
> >>>
> >>> Thanks
> >>>
> >>> Jacques
> >>>
> >>> Le 12/03/2019 à 10:07, Deepak Dixit a écrit :
>  Hi Jacques,
> 
>  I think instead of adding space in uiLabel it would be food if we add
> >> space in the template
>  Thanks & Regards
>  --
>  Deepak Dixit
>  ofbiz.apache.org 
> 
> 
>  On Mon, Feb 25, 2019 at 4:03 PM  >> jler...@apache.org>> wrote:
>   Author: jleroux
>   Date: Mon Feb 25 10:33:53 2019
>   New Revision: 1854306
> 
>   URL: http://svn.apache.org/viewvc?rev=1854306=rev
>   Log:
>   Improved: no functional change
> 
>   A missing space before CommonBranch label made the word
> trunkbranch
> >> instead of
>   trunk branch.
> 
>   I'll backport this
> 
>   Modified:
> 
> >>   ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
>   Modified:
> >> ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
>   URL:
> 
> >>
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml?rev=1854306=1854305=1854306=diff
> >>
>  
> ==
>   ---
> >> ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
> >> (original)
>   +++
> >> ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
> Mon
> >> Feb 25 10:33:53 2019
>   @@ -1389,9 +1389,9 @@
>    å›žå ±
>

Re: svn commit: r1854306 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

2019-03-14 Thread Jacques Le Roux 

Thanks Deepak,

Unfortunately it's difficult to use it as us and I have not created a Jira for 
that.

Could you please commit it?

TIA

Jacques

Le 13/03/2019 à 06:42, Deepak Dixit a écrit :

Hi Jacques,

I tested the following patch and it works
=

Index: build.gradle

===

--- build.gradle (revision 1855081)

+++ build.gradle (working copy)

@@ -638,7 +638,7 @@

  revision = revisionOutput.toString()

  gitFooterFile.delete()

  gitFooterFile.createNewFile()

-gitFooterFile << '${uiLabelMap.CommonBranch} : ' + "${branch}" +
System.lineSeparator()

+gitFooterFile << ' ${uiLabelMap.CommonBranch} : ' + "${branch}" +
System.lineSeparator()

  gitFooterFile << '${uiLabelMap.CommonRevision} : ' + "${revision}"
+ System.lineSeparator()

  gitFooterFile << '${uiLabelMap.CommonBuiltOn} : ' + "${timestamp}"
+ System.lineSeparator()

  gitFooterFile << '${uiLabelMap.CommonJavaVersion} : ' +
"${org.gradle.internal.jvm.Jvm.current()}"

@@ -663,7 +663,7 @@

  def info = new XmlParser().parseText(svnOutput.toString())

  svnFooterFile.delete()

  svnFooterFile.createNewFile()

-svnFooterFile << '${uiLabelMap.CommonBranch} : ' +
"${info.entry.url.text()}" + System.lineSeparator()

+svnFooterFile << ' ${uiLabelMap.CommonBranch} : ' +
"${info.entry.url.text()}" + System.lineSeparator()

  svnFooterFile << '${uiLabelMap.CommonRevision} : ' +
"${info.entry.commit.@revision}" + System.lineSeparator()

  svnFooterFile << '${uiLabelMap.CommonBuiltOn} : ' + "${timestamp}"
+ System.lineSeparator()

  svnFooterFile << '${uiLabelMap.CommonJavaVersion} : ' +
"${org.gradle.internal.jvm.Jvm.current()}"

Index: framework/common/config/CommonUiLabels.xml

===

--- framework/common/config/CommonUiLabels.xml (revision 1855081)

+++ framework/common/config/CommonUiLabels.xml (working copy)

@@ -1389,9 +1389,9 @@

  回報

  

  

- branch

- rama

- branche

+branch

+rama

+branche

  

  

  built on


=


Kind Regards,
Deepak Dixit

On Wed, Mar 13, 2019 at 2:16 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Actually I changed it there because it does not work in build.gradle where
it's already

gitFooterFile << '${uiLabelMap.CommonBranch} : ' + "${branch}" +
System.lineSeparator()

svnFooterFile << '${uiLabelMap.CommonBranch} : ' +
"${info.entry.url.text()}" + System.lineSeparator()

Jacques

Le 12/03/2019 à 10:33, Jacques Le Roux a écrit :

Agreed Deepak,

Makes sense, I 'll change that

Thanks

Jacques

Le 12/03/2019 à 10:07, Deepak Dixit a écrit :

Hi Jacques,

I think instead of adding space in uiLabel it would be food if we add

space in the template

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org 


On Mon, Feb 25, 2019 at 4:03 PM 
jler...@apache.org>> wrote:

 Author: jleroux
 Date: Mon Feb 25 10:33:53 2019
 New Revision: 1854306

 URL: http://svn.apache.org/viewvc?rev=1854306=rev
 Log:
 Improved: no functional change

 A missing space before CommonBranch label made the word trunkbranch

instead of

 trunk branch.

 I'll backport this

 Modified:


  ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

 Modified:

ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

 URL:


http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml?rev=1854306=1854305=1854306=diff
  ==

 ---

ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
(original)

 +++

ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml Mon
Feb 25 10:33:53 2019

 @@ -1389,9 +1389,9 @@
  å›žå ±
  
  
 -branch
 -rama
 -branche
 + branch
 + rama
 + branche
  
  
  built on

Re: svn commit: r1854306 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

2019-03-12 Thread Deepak Dixit 
Hi Jacques,

I tested the following patch and it works
=

Index: build.gradle

===

--- build.gradle (revision 1855081)

+++ build.gradle (working copy)

@@ -638,7 +638,7 @@

 revision = revisionOutput.toString()

 gitFooterFile.delete()

 gitFooterFile.createNewFile()

-gitFooterFile << '${uiLabelMap.CommonBranch} : ' + "${branch}" +
System.lineSeparator()

+gitFooterFile << ' ${uiLabelMap.CommonBranch} : ' + "${branch}" +
System.lineSeparator()

 gitFooterFile << '${uiLabelMap.CommonRevision} : ' + "${revision}"
+ System.lineSeparator()

 gitFooterFile << '${uiLabelMap.CommonBuiltOn} : ' + "${timestamp}"
+ System.lineSeparator()

 gitFooterFile << '${uiLabelMap.CommonJavaVersion} : ' +
"${org.gradle.internal.jvm.Jvm.current()}"

@@ -663,7 +663,7 @@

 def info = new XmlParser().parseText(svnOutput.toString())

 svnFooterFile.delete()

 svnFooterFile.createNewFile()

-svnFooterFile << '${uiLabelMap.CommonBranch} : ' +
"${info.entry.url.text()}" + System.lineSeparator()

+svnFooterFile << ' ${uiLabelMap.CommonBranch} : ' +
"${info.entry.url.text()}" + System.lineSeparator()

 svnFooterFile << '${uiLabelMap.CommonRevision} : ' +
"${info.entry.commit.@revision}" + System.lineSeparator()

 svnFooterFile << '${uiLabelMap.CommonBuiltOn} : ' + "${timestamp}"
+ System.lineSeparator()

 svnFooterFile << '${uiLabelMap.CommonJavaVersion} : ' +
"${org.gradle.internal.jvm.Jvm.current()}"

Index: framework/common/config/CommonUiLabels.xml

===

--- framework/common/config/CommonUiLabels.xml (revision 1855081)

+++ framework/common/config/CommonUiLabels.xml (working copy)

@@ -1389,9 +1389,9 @@

 回報

 

 

- branch

- rama

- branche

+branch

+rama

+branche

 

 

 built on


=


Kind Regards,
Deepak Dixit

On Wed, Mar 13, 2019 at 2:16 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Actually I changed it there because it does not work in build.gradle where
> it's already
>
> gitFooterFile << '${uiLabelMap.CommonBranch} : ' + "${branch}" +
> System.lineSeparator()
>
> svnFooterFile << '${uiLabelMap.CommonBranch} : ' +
> "${info.entry.url.text()}" + System.lineSeparator()
>
> Jacques
>
> Le 12/03/2019 à 10:33, Jacques Le Roux a écrit :
> >
> > Agreed Deepak,
> >
> > Makes sense, I 'll change that
> >
> > Thanks
> >
> > Jacques
> >
> > Le 12/03/2019 à 10:07, Deepak Dixit a écrit :
> >> Hi Jacques,
> >>
> >> I think instead of adding space in uiLabel it would be food if we add
> space in the template
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Dixit
> >> ofbiz.apache.org 
> >>
> >>
> >> On Mon, Feb 25, 2019 at 4:03 PM  jler...@apache.org>> wrote:
> >>
> >> Author: jleroux
> >> Date: Mon Feb 25 10:33:53 2019
> >> New Revision: 1854306
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1854306=rev
> >> Log:
> >> Improved: no functional change
> >>
> >> A missing space before CommonBranch label made the word trunkbranch
> instead of
> >> trunk branch.
> >>
> >> I'll backport this
> >>
> >> Modified:
> >>
>  ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
> >>
> >> Modified:
> ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
> >> URL:
> >>
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml?rev=1854306=1854305=1854306=diff
> >>
>  
> ==
> >> ---
> ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
> (original)
> >> +++
> ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml Mon
> Feb 25 10:33:53 2019
> >> @@ -1389,9 +1389,9 @@
> >>  å›žå ±
> >>  
> >>  
> >> -branch
> >> -rama
> >> -branche
> >> + branch
> >> + rama
> >> + branche
> >>  
> >>  
> >>  built on
> >>
> >>
>

Re: svn commit: r1854306 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

2019-03-12 Thread Jacques Le Roux 

Actually I changed it there because it does not work in build.gradle where it's 
already

gitFooterFile << '${uiLabelMap.CommonBranch} : ' + "${branch}" + 
System.lineSeparator()

svnFooterFile << '${uiLabelMap.CommonBranch} : ' + "${info.entry.url.text()}" + 
System.lineSeparator()

Jacques

Le 12/03/2019 à 10:33, Jacques Le Roux a écrit :


Agreed Deepak,

Makes sense, I 'll change that

Thanks

Jacques

Le 12/03/2019 à 10:07, Deepak Dixit a écrit :

Hi Jacques,

I think instead of adding space in uiLabel it would be food if we add space in 
the template

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org 


On Mon, Feb 25, 2019 at 4:03 PM mailto:jler...@apache.org>> wrote:

Author: jleroux
Date: Mon Feb 25 10:33:53 2019
New Revision: 1854306

URL: http://svn.apache.org/viewvc?rev=1854306=rev
Log:
Improved: no functional change

A missing space before CommonBranch label made the word trunkbranch instead 
of
trunk branch.

I'll backport this

Modified:
ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

Modified: 
ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
URL:

http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml?rev=1854306=1854305=1854306=diff

==
--- ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml 
(original)
+++ ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml 
Mon Feb 25 10:33:53 2019
@@ -1389,9 +1389,9 @@
         å›žå ±
     
     
-        branch
-        rama
-        branche
+         branch
+         rama
+         branche
     
     
         built on

Re: svn commit: r1854306 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

2019-03-12 Thread Deepak Dixit 
Hi Jacques,

I think instead of adding space in uiLabel it would be food if we add space
in the template

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Feb 25, 2019 at 4:03 PM  wrote:

> Author: jleroux
> Date: Mon Feb 25 10:33:53 2019
> New Revision: 1854306
>
> URL: http://svn.apache.org/viewvc?rev=1854306=rev
> Log:
> Improved: no functional change
>
> A missing space before CommonBranch label made the word trunkbranch
> instead of
> trunk branch.
>
> I'll backport this
>
> Modified:
> ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
>
> Modified:
> ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml?rev=1854306=1854305=1854306=diff
>
> ==
> --- ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
> (original)
> +++ ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml
> Mon Feb 25 10:33:53 2019
> @@ -1389,9 +1389,9 @@
>  å›žå ±
>  
>  
> -branch
> -rama
> -branche
> + branch
> + rama
> + branche
>  
>  
>  built on
>
>
>