Github user ohadshacham commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/23#discussion_r167857492
--- Diff:
tso-server/src/test/java/org/apache/omid/tso/TestPersistenceProcessorHandler.java
---
@@ -126,6 +126,36 @@ void afterMethod() {
[
https://issues.apache.org/jira/browse/OMID-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362302#comment-16362302
]
Ohad Shacham commented on OMID-88:
--
LGTM
> Add 0.9.0.0 and phoenix-integration branches to
[
https://issues.apache.org/jira/browse/OMID-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362301#comment-16362301
]
Ohad Shacham commented on OMID-87:
--
LGTM
> Fix BatchPool initialization
> -
[
https://issues.apache.org/jira/browse/OMID-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362300#comment-16362300
]
Ohad Shacham commented on OMID-89:
--
LGTM, just as a general comment. These metrics significa
[
https://issues.apache.org/jira/browse/OMID-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362275#comment-16362275
]
ASF GitHub Bot commented on OMID-89:
Github user ohadshacham commented on a diff in the p
[
https://issues.apache.org/jira/browse/OMID-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362229#comment-16362229
]
Ohad Shacham commented on OMID-86:
--
LGTM +1
> Add Tx info in RollbackException
> --