[jira] [Commented] (OMID-110) Support HBase 2.0
[
https://issues.apache.org/jira/browse/OMID-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617150#comment-16617150
]
ASF GitHub Bot commented on OMID-110:
-
Github user yonigottesman closed the pull request at:
https://github.com/apache/incubator-omid/pull/43
> Support HBase 2.0
> -
>
> Key: OMID-110
> URL: https://issues.apache.org/jira/browse/OMID-110
> Project: Apache Omid
> Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Yonatan Gottesman
>Priority: Major
> Attachments: 0001-omid-110.patch, OMID-110_wip1.patch, omid110.patch
>
>
> Once OMID-107 is committed (which replaced all deprecated methods), the only
> things I've identified that need to change are:
> * Instantiation of CellComparator should be done through HBaseShims since
> it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was
> changed to an interface. Another alternative would be to write our own
> CellComparator.
> {code:java}
> public static SortedMap>
> mapCellsToShadowCells(List cells) {
> // Move CellComparator to HBaseSims for 2.0 support
> // Need to access through CellComparatorImpl.COMPARATOR
> SortedMap> cellToShadowCellMap
> = new TreeMap>(new CellComparator());{code}
> The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of
> instantiating a CellComparator.
> * Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase
> 2.0 uses TableDescriptor and TableDescriptorBuilder.
> [~chrajeshbab...@gmail.com] and [~an...@apache.org] - do you know why
> existing admin.createTable(HTableDescriptor) wouldn't work? HTableDescriptor
> implements TableDescriptor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OMID-110) Support HBase 2.0
[
https://issues.apache.org/jira/browse/OMID-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616742#comment-16616742
]
ASF GitHub Bot commented on OMID-110:
-
Github user ohadshacham commented on the issue:
https://github.com/apache/incubator-omid/pull/43
+1
> Support HBase 2.0
> -
>
> Key: OMID-110
> URL: https://issues.apache.org/jira/browse/OMID-110
> Project: Apache Omid
> Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Yonatan Gottesman
>Priority: Major
> Attachments: 0001-omid-110.patch, OMID-110_wip1.patch
>
>
> Once OMID-107 is committed (which replaced all deprecated methods), the only
> things I've identified that need to change are:
> * Instantiation of CellComparator should be done through HBaseShims since
> it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was
> changed to an interface. Another alternative would be to write our own
> CellComparator.
> {code:java}
> public static SortedMap>
> mapCellsToShadowCells(List cells) {
> // Move CellComparator to HBaseSims for 2.0 support
> // Need to access through CellComparatorImpl.COMPARATOR
> SortedMap> cellToShadowCellMap
> = new TreeMap>(new CellComparator());{code}
> The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of
> instantiating a CellComparator.
> * Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase
> 2.0 uses TableDescriptor and TableDescriptorBuilder.
> [~chrajeshbab...@gmail.com] and [~an...@apache.org] - do you know why
> existing admin.createTable(HTableDescriptor) wouldn't work? HTableDescriptor
> implements TableDescriptor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OMID-110) Support HBase 2.0
[
https://issues.apache.org/jira/browse/OMID-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616631#comment-16616631
]
ASF GitHub Bot commented on OMID-110:
-
GitHub user yonigottesman opened a pull request:
https://github.com/apache/incubator-omid/pull/43
[OMID-110]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yonigottesman/incubator-omid
phoenix-integration
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-omid/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
commit cedfe50ed15cc407ca7d840a9477afac62aaab24
Author: Yonatan Gottesman
Date: 2018-09-04T18:12:19Z
omid-110
> Support HBase 2.0
> -
>
> Key: OMID-110
> URL: https://issues.apache.org/jira/browse/OMID-110
> Project: Apache Omid
> Issue Type: Improvement
>Reporter: James Taylor
>Assignee: Yonatan Gottesman
>Priority: Major
> Attachments: 0001-omid-110.patch, OMID-110_wip1.patch
>
>
> Once OMID-107 is committed (which replaced all deprecated methods), the only
> things I've identified that need to change are:
> * Instantiation of CellComparator should be done through HBaseShims since
> it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was
> changed to an interface. Another alternative would be to write our own
> CellComparator.
> {code:java}
> public static SortedMap>
> mapCellsToShadowCells(List cells) {
> // Move CellComparator to HBaseSims for 2.0 support
> // Need to access through CellComparatorImpl.COMPARATOR
> SortedMap> cellToShadowCellMap
> = new TreeMap>(new CellComparator());{code}
> The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of
> instantiating a CellComparator.
> * Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase
> 2.0 uses TableDescriptor and TableDescriptorBuilder.
> [~chrajeshbab...@gmail.com] and [~an...@apache.org] - do you know why
> existing admin.createTable(HTableDescriptor) wouldn't work? HTableDescriptor
> implements TableDescriptor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OMID-110) Support HBase 2.0
[
https://issues.apache.org/jira/browse/OMID-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616629#comment-16616629
]
ASF GitHub Bot commented on OMID-110:
-
Github user yonigottesman closed the pull request at:
https://github.com/apache/incubator-omid/pull/42
> Support HBase 2.0
> -
>
> Key: OMID-110
> URL: https://issues.apache.org/jira/browse/OMID-110
> Project: Apache Omid
> Issue Type: Improvement
>Reporter: James Taylor
>Assignee: Yonatan Gottesman
>Priority: Major
> Attachments: 0001-omid-110.patch, OMID-110_wip1.patch
>
>
> Once OMID-107 is committed (which replaced all deprecated methods), the only
> things I've identified that need to change are:
> * Instantiation of CellComparator should be done through HBaseShims since
> it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was
> changed to an interface. Another alternative would be to write our own
> CellComparator.
> {code:java}
> public static SortedMap>
> mapCellsToShadowCells(List cells) {
> // Move CellComparator to HBaseSims for 2.0 support
> // Need to access through CellComparatorImpl.COMPARATOR
> SortedMap> cellToShadowCellMap
> = new TreeMap>(new CellComparator());{code}
> The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of
> instantiating a CellComparator.
> * Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase
> 2.0 uses TableDescriptor and TableDescriptorBuilder.
> [~chrajeshbab...@gmail.com] and [~an...@apache.org] - do you know why
> existing admin.createTable(HTableDescriptor) wouldn't work? HTableDescriptor
> implements TableDescriptor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OMID-110) Support HBase 2.0
[
https://issues.apache.org/jira/browse/OMID-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604827#comment-16604827
]
Yonatan Gottesman commented on OMID-110:
[~jamestaylor]
I added a patch here that works with hbase-2. This patch is on top of hbase-107.
The pull request includes omid-107 and omid-110.
Ill get to work on making omid be like tephra in the way you include it in
phoenix: core+compat. So you include omid + shims-[1,2]
> Support HBase 2.0
> -
>
> Key: OMID-110
> URL: https://issues.apache.org/jira/browse/OMID-110
> Project: Apache Omid
> Issue Type: Improvement
>Reporter: James Taylor
>Assignee: Yonatan Gottesman
>Priority: Major
> Attachments: 0001-omid-110.patch, OMID-110_wip1.patch
>
>
> Once OMID-107 is committed (which replaced all deprecated methods), the only
> things I've identified that need to change are:
> * Instantiation of CellComparator should be done through HBaseShims since
> it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was
> changed to an interface. Another alternative would be to write our own
> CellComparator.
> {code:java}
> public static SortedMap>
> mapCellsToShadowCells(List cells) {
> // Move CellComparator to HBaseSims for 2.0 support
> // Need to access through CellComparatorImpl.COMPARATOR
> SortedMap> cellToShadowCellMap
> = new TreeMap>(new CellComparator());{code}
> The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of
> instantiating a CellComparator.
> * Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase
> 2.0 uses TableDescriptor and TableDescriptorBuilder.
> [~chrajeshbab...@gmail.com] and [~an...@apache.org] - do you know why
> existing admin.createTable(HTableDescriptor) wouldn't work? HTableDescriptor
> implements TableDescriptor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OMID-110) Support HBase 2.0
[
https://issues.apache.org/jira/browse/OMID-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603415#comment-16603415
]
ASF GitHub Bot commented on OMID-110:
-
GitHub user yonigottesman opened a pull request:
https://github.com/apache/incubator-omid/pull/42
[OMID-110]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yonigottesman/incubator-omid omid-110
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-omid/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
commit 05a0520f04e738cd14d1df633d10b9870f8d387b
Author: Yonatan Gottesman
Date: 2018-08-26T20:55:05Z
OMID-107
commit f9e6f70997260e9164ba5c4ebd24ff98cf9dbacb
Author: Yonatan Gottesman
Date: 2018-09-04T18:12:19Z
omid-110
> Support HBase 2.0
> -
>
> Key: OMID-110
> URL: https://issues.apache.org/jira/browse/OMID-110
> Project: Apache Omid
> Issue Type: Improvement
>Reporter: James Taylor
>Assignee: Yonatan Gottesman
>Priority: Major
> Attachments: OMID-110_wip1.patch
>
>
> Once OMID-107 is committed (which replaced all deprecated methods), the only
> things I've identified that need to change are:
> * Instantiation of CellComparator should be done through HBaseShims since
> it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was
> changed to an interface. Another alternative would be to write our own
> CellComparator.
> {code:java}
> public static SortedMap>
> mapCellsToShadowCells(List cells) {
> // Move CellComparator to HBaseSims for 2.0 support
> // Need to access through CellComparatorImpl.COMPARATOR
> SortedMap> cellToShadowCellMap
> = new TreeMap>(new CellComparator());{code}
> The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of
> instantiating a CellComparator.
> * Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase
> 2.0 uses TableDescriptor and TableDescriptorBuilder.
> [~chrajeshbab...@gmail.com] and [~an...@apache.org] - do you know why
> existing admin.createTable(HTableDescriptor) wouldn't work? HTableDescriptor
> implements TableDescriptor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OMID-110) Support HBase 2.0
[
https://issues.apache.org/jira/browse/OMID-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603390#comment-16603390
]
Yonatan Gottesman commented on OMID-110:
Hi,
I finished the implementation but im having some trouble with the coprocesor
tests.
It seems like the coprocessors are installed but the functions are not called
(preGet...)
Hope it will be done in a 1-2 days
> Support HBase 2.0
> -
>
> Key: OMID-110
> URL: https://issues.apache.org/jira/browse/OMID-110
> Project: Apache Omid
> Issue Type: Improvement
>Reporter: James Taylor
>Assignee: Yonatan Gottesman
>Priority: Major
> Attachments: OMID-110_wip1.patch
>
>
> Once OMID-107 is committed (which replaced all deprecated methods), the only
> things I've identified that need to change are:
> * Instantiation of CellComparator should be done through HBaseShims since
> it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was
> changed to an interface. Another alternative would be to write our own
> CellComparator.
> {code:java}
> public static SortedMap>
> mapCellsToShadowCells(List cells) {
> // Move CellComparator to HBaseSims for 2.0 support
> // Need to access through CellComparatorImpl.COMPARATOR
> SortedMap> cellToShadowCellMap
> = new TreeMap>(new CellComparator());{code}
> The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of
> instantiating a CellComparator.
> * Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase
> 2.0 uses TableDescriptor and TableDescriptorBuilder.
> [~chrajeshbab...@gmail.com] and [~an...@apache.org] - do you know why
> existing admin.createTable(HTableDescriptor) wouldn't work? HTableDescriptor
> implements TableDescriptor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OMID-110) Support HBase 2.0
[
https://issues.apache.org/jira/browse/OMID-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603387#comment-16603387
]
James Taylor commented on OMID-110:
---
[~yonigo] - any progress on this one? FWIW, the way Tephra does compat modules
works pretty well. They have the HBase dependencies specified in their shim
module. Other projects that want to use Tephra specify two dependencies: the
tephra core dependency and the tephra compat module (based on the version of
HBase they use).
> Support HBase 2.0
> -
>
> Key: OMID-110
> URL: https://issues.apache.org/jira/browse/OMID-110
> Project: Apache Omid
> Issue Type: Improvement
>Reporter: James Taylor
>Assignee: Yonatan Gottesman
>Priority: Major
> Attachments: OMID-110_wip1.patch
>
>
> Once OMID-107 is committed (which replaced all deprecated methods), the only
> things I've identified that need to change are:
> * Instantiation of CellComparator should be done through HBaseShims since
> it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was
> changed to an interface. Another alternative would be to write our own
> CellComparator.
> {code:java}
> public static SortedMap>
> mapCellsToShadowCells(List cells) {
> // Move CellComparator to HBaseSims for 2.0 support
> // Need to access through CellComparatorImpl.COMPARATOR
> SortedMap> cellToShadowCellMap
> = new TreeMap>(new CellComparator());{code}
> The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of
> instantiating a CellComparator.
> * Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase
> 2.0 uses TableDescriptor and TableDescriptorBuilder.
> [~chrajeshbab...@gmail.com] and [~an...@apache.org] - do you know why
> existing admin.createTable(HTableDescriptor) wouldn't work? HTableDescriptor
> implements TableDescriptor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
