----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14513/ -----------------------------------------------------------
Review request for oodt, Chris Mattmann and Rishi Verma. Bugs: OODT-612 and OODT-613 https://issues.apache.org/jira/browse/OODT-612 https://issues.apache.org/jira/browse/OODT-613 Repository: oodt Description ------- This patch aims to address issues OODT-612 and OODT-613. Please see the JIRA issues for discussions on the chosen designs/implementations. The Java code for this patch is contained in a new package 'org.apache.oodt.cas.product.jaxrs'. This package is intended to replace the 'org.apache.oodt.cas.product.service' package that was committed for the GSoC (Google Summer of Code 2013) midterm, i.e. the cas.product.service package will be deleted and replaced with this reworked design. Documentation for this work has been added to the OODT wiki as detailed on OODT-614. Work is ongoing for this package and many improvements can be made, for example those mentioned in the 'development ideas' section at the bottom of the developer guide. Diffs ----- trunk/webapp/fmprod/pom.xml 1517156 trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/configurations/RdfConfiguration.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/configurations/RssConfiguration.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/configurations/RssNamespace.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/configurations/RssTag.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/configurations/RssTagAttribute.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/configurations/package-info.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/exceptions/BadRequestException.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/exceptions/InternalServerErrorException.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/exceptions/NotFoundException.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/exceptions/package-info.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/filters/BackwardsCompatibleInterceptor.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/filters/package-info.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/package-info.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/resources/DatasetResource.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/resources/MetadataResource.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/resources/ProductResource.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/resources/ReferenceResource.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/resources/TransferResource.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/resources/TransfersResource.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/resources/package-info.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/services/CasProductJaxrsService.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/services/package-info.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/servlets/CasProductJaxrsServlet.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/servlets/package-info.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/DatasetRdfWriter.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/DatasetRssWriter.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/DatasetZipWriter.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/DatasetZipper.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/ProductRssWriter.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/ProductZipWriter.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/ProductZipper.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/RdfWriter.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/ReferenceFileWriter.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/ReferenceRssWriter.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/ReferenceZipWriter.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/RssWriter.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/TransfersRssWriter.java PRE-CREATION trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/jaxrs/writers/package-info.java PRE-CREATION trunk/webapp/fmprod/src/main/resources/georss-config.xml 1517156 trunk/webapp/fmprod/src/main/resources/logging.properties 1517156 trunk/webapp/fmprod/src/main/resources/rdfconf.xml 1517156 trunk/webapp/fmprod/src/main/resources/rss-transfer-conf.xml 1517156 trunk/webapp/fmprod/src/main/resources/rssconf.xml 1517156 trunk/webapp/fmprod/src/main/webapp/META-INF/context.xml 1517156 trunk/webapp/fmprod/src/main/webapp/WEB-INF/web.xml 1517156 trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/jaxrs/resources/DatasetResourceTest.java PRE-CREATION trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/jaxrs/resources/MetadataResourceTest.java PRE-CREATION trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/jaxrs/resources/ProductResourceTest.java PRE-CREATION trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/jaxrs/resources/ReferenceResourceTest.java PRE-CREATION trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/jaxrs/resources/TransferResourceTest.java PRE-CREATION trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/jaxrs/resources/TransfersResourceTest.java PRE-CREATION trunk/webapp/fmprod/src/test/resources/test.logging.properties 1517156 Diff: https://reviews.apache.org/r/14513/diff/ Testing ------- I implemented several JUnit tests for the new package. Some of these unit tests are included in this patch, while others have yet to be formalised but will be presented in future patches. I also performed a lot of manual testing by deploying the web application and testing sets of URLs via web browsers and command line tools (e.g. curl). I checked all of the outputs for validity (e.g. as valid XML, RSS, RDF, etc). Thanks, Ross Laidlaw