[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516801#comment-16516801
]
Peter Cseh commented on OOZIE-2339:
---
+1, thanks for the fixes!
> [fluent-job] Minimum Viable Fluent
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516752#comment-16516752
]
Peter Bacsko commented on OOZIE-2339:
-
+1 LGTM
> [fluent-job] Minimum Viable Fluent Job API
>
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515789#comment-16515789
]
Hadoop QA commented on OOZIE-2339:
--
Testing JIRA OOZIE-2339
Cleaning local git workspace
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515670#comment-16515670
]
Hadoop QA commented on OOZIE-2339:
--
PreCommit-OOZIE-Build started
> [fluent-job] Minimum Viable Fluent
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515646#comment-16515646
]
Andras Piros commented on OOZIE-2339:
-
Addressing FindBugs warnings, removing star imports.
>
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515606#comment-16515606
]
Hadoop QA commented on OOZIE-2339:
--
Testing JIRA OOZIE-2339
Cleaning local git workspace
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515506#comment-16515506
]
Andras Piros commented on OOZIE-2339:
-
[~pbacsko] [~gezapeti] last patch 020 addressing review
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514879#comment-16514879
]
Andras Piros commented on OOZIE-2339:
-
[~pbacsko] thanks for the review rounds!
Here is what I've
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512962#comment-16512962
]
Robert Kanter commented on OOZIE-2339:
--
+1 on not using {{ImmutableMap}}, etc. We should be careful
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512805#comment-16512805
]
Peter Bacsko commented on OOZIE-2339:
-
Just a couple of random thoughts. I'm listing them here, I'm a
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512761#comment-16512761
]
Peter Bacsko commented on OOZIE-2339:
-
I've completed Round #2.
I was thinking about adding some
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512317#comment-16512317
]
Andras Piros commented on OOZIE-2339:
-
Thank you all for your review efforts [~rkanter] [~gezapeti]
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511650#comment-16511650
]
Robert Kanter commented on OOZIE-2339:
--
+1 LGTM. Looks like the remaining comments [~pbacsko] is
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509739#comment-16509739
]
Hadoop QA commented on OOZIE-2339:
--
Testing JIRA OOZIE-2339
Cleaning local git workspace
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509633#comment-16509633
]
Andras Piros commented on OOZIE-2339:
-
Addressing CheckStyle issues.
> [fluent-job] Minimum Viable
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507869#comment-16507869
]
Hadoop QA commented on OOZIE-2339:
--
Testing JIRA OOZIE-2339
Cleaning local git workspace
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507799#comment-16507799
]
Hadoop QA commented on OOZIE-2339:
--
PreCommit-OOZIE-Build started
> [fluent-job] Minimum Viable Fluent
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507382#comment-16507382
]
Hadoop QA commented on OOZIE-2339:
--
Testing JIRA OOZIE-2339
Cleaning local git workspace
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507351#comment-16507351
]
Andras Piros commented on OOZIE-2339:
-
Addressing pre-commit build errors.
> [fluent-job] Minimum
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507349#comment-16507349
]
Hadoop QA commented on OOZIE-2339:
--
PreCommit-OOZIE-Build started
> [fluent-job] Minimum Viable Fluent
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506973#comment-16506973
]
Hadoop QA commented on OOZIE-2339:
--
Testing JIRA OOZIE-2339
Cleaning local git workspace
[
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506970#comment-16506970
]
Hadoop QA commented on OOZIE-2339:
--
PreCommit-OOZIE-Build started
> [fluent-job] Minimum Viable Fluent
22 matches
Mail list logo
