Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/#review155786 --- Ship it! Ship It! - Robert Kanter On Nov. 9, 2016, 4:24

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Nov. 9, 2016, 4:24 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/#review155414 --- core/src/main/java/org/apache/oozie/util/ConfigUtils.java (line

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/#review155413 --- Ship it! Ship It! - András Piros On Nov. 8, 2016, 10:50

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 26, 2016, 4:18 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

> On okt. 26, 2016, 11:01 de, Peter Bacsko wrote: > > Ship It! Looks pretty good, especially the Guice enhancements. - Peter --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/#review153863 --- Ship it! Ship It! - Peter Bacsko On okt. 25, 2016, 3:42 du,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/#review153860 --- Ship it! Ship It! - András Piros On Oct. 25, 2016, 3:42

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 25, 2016, 3:42 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/#review153780 ---

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 24, 2016, 4:32 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/#review153574 --- core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 19, 2016, 9:43 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 15, 2016, 2:44 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

> On Oct. 15, 2016, 12:11 p.m., András Piros wrote: > > server/src/main/java/org/apache/oozie/server/JspHandler.java, line 67 > > > > > > Why do you think it's necessary? otherwise Findbugs reports unsafe usage.

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

> On Oct. 6, 2016, 11:04 p.m., Robert Kanter wrote: > > distro/src/main/bin/oozie-jetty-server.sh, line 187 > > > > > > Can we set this up in such that there is no war file when using Jetty? Created new maven

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 15, 2016, 1:12 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/#review152781 --- distro/pom.xml (line 115)

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 15, 2016, 11:30 a.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 15, 2016, 11:08 a.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 14, 2016, 1:02 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 13, 2016, 9:53 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 13, 2016, 6:35 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 13, 2016, 6:27 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

> On Oct. 3, 2016, 4:27 p.m., Peter Bacsko wrote: > > distro/src/main/bin/oozied.sh, line 115 > > > > > > Is this TODO still relevant? It is. - Attila ---

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

> On Oct. 6, 2016, 11:04 p.m., Robert Kanter wrote: > > distro/src/main/bin/oozie-jetty-server.sh, lines 40-61 > > > > > > IMO, we should move as many of these as possible to oozie-default/site. > > We had a bunch

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

> On Oct. 6, 2016, 11:04 p.m., Robert Kanter wrote: > > distro/src/main/bin/oozie-jetty-server.sh, line 1 > > > > > > Please run all new/updated shell scripts through shellcheck > > (https://www.shellcheck.net/). It

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

> On Oct. 3, 2016, 4:27 p.m., Peter Bacsko wrote: > > server/pom.xml, line 26 > > > > > > +1, I'd remove versions tags here all other mvn properties have ".version" suffix > On Oct. 3, 2016, 4:27 p.m., Peter

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 13, 2016, 2:17 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

> On Oct. 6, 2016, 11:04 p.m., Robert Kanter wrote: > > server/src/main/java/org/apache/oozie/server/JspHandler.java, line 51 > > > > > > This typically points to /tmp right? In a long running Oozie Server, > >

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 13, 2016, 1:37 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 7, 2016, 2:59 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 7, 2016, 7:18 a.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/#review151728 --- core/src/main/java/org/apache/oozie/util/Instrumentation.java

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 6, 2016, 10:09 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Oct. 4, 2016, 2:42 p.m.) Review request for oozie, András Piros,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/#review151176 --- core/src/main/java/org/apache/oozie/util/Instrumentation.java

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/#review151159 --- core/src/main/java/org/apache/oozie/util/Instrumentation.java

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Sept. 30, 2016, 10:45 a.m.) Review request for oozie, Peter Cseh,

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/ --- (Updated Sept. 30, 2016, 9:27 a.m.) Review request for oozie, Peter Cseh,