Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-06-18 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/ --- (Updated June 18, 2018, 8:58 a.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-06-18 Thread András Piros via Review Board
> On June 13, 2018, 3:06 p.m., Peter Bacsko wrote: > > fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/mapping/DistcpConfigurationConverter.java > > Lines 32 (patched) > > > > > > Please use

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-06-18 Thread András Piros via Review Board
> On June 14, 2018, 7:40 a.m., Peter Cseh wrote: > > fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/workflow/Credentials.java > > Lines 39-45 (patched) > > > > > > This should be a map

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-06-15 Thread Peter Cseh via Review Board
> On June 14, 2018, 7:50 a.m., Peter Cseh wrote: > > mvn clean install -DskipTests fails for me with a ton of checkstyle errors. > > The strange thing is that ./bin/mkdistro.sh -DskipTests does not. Can you > > check on this as well? This is fine with the latest patch, sorry for the false

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-06-14 Thread Peter Bacsko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review204771 ---

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-06-14 Thread Peter Cseh via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review204766 ---

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-06-14 Thread Peter Cseh via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review204762 --- mvn clean install -DskipTests fails for me with a ton of

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-06-14 Thread Peter Cseh via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review204761 ---

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-06-13 Thread Peter Bacsko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review204692 ---

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-06-12 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/ --- (Updated June 12, 2018, 1:42 p.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-06-11 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/ --- (Updated June 11, 2018, 8:12 a.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-06-10 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/ --- (Updated June 10, 2018, 11:31 a.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-06-09 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/ --- (Updated June 9, 2018, 12:53 p.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-05-28 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/ --- (Updated May 28, 2018, 8:50 a.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-05-24 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/ --- (Updated May 24, 2018, 7:36 p.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-05-24 Thread András Piros via Review Board
> On May 20, 2018, 10:14 p.m., Robert Kanter wrote: > > core/src/main/resources/oozie-default.xml > > Lines 3326 (patched) > > > > > > When using the Fluent API, how does Oozie choose which HDFS to use? The same

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-05-24 Thread András Piros via Review Board
> On March 27, 2018, 1:02 a.m., Robert Kanter wrote: > > docs/src/site/twiki/DG_JobsAPI.twiki > > Lines 61 (patched) > > > > > > How does this work for backwards compatibility? i.e. If I generate a > > jar using wf

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-05-20 Thread Robert Kanter via Review Board
> On May 20, 2018, 10:14 p.m., Robert Kanter wrote: > > A bunch on minor things. Looks good though! - Robert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review203465

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-05-20 Thread Robert Kanter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review203465 --- A bunch on minor things.

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-05-14 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/ --- (Updated May 14, 2018, 8:36 p.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-05-06 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/ --- (Updated May 6, 2018, 1:27 p.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-05-06 Thread András Piros via Review Board
> On March 27, 2018, 1:02 a.m., Robert Kanter wrote: > > client/src/main/java/org/apache/oozie/cli/ApiJarFactory.java > > Lines 41 (patched) > > > > > > Looks like this is used only by unit tests. If so, then

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-03-26 Thread Robert Kanter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review21 --- .gitignore Lines 1-5 (original), 1-8 (patched)

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-03-20 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/ --- (Updated March 20, 2018, 9:58 p.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-03-20 Thread András Piros via Review Board
> On Jan. 11, 2018, 1:53 a.m., Robert Kanter wrote: > > client/src/main/java/org/apache/oozie/cli/ApiJarFactory.java > > Lines 68-73 (patched) > > > > > > Oozie's copyStream already has a method that does

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-02-07 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review196991 ---

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-02-01 Thread András Piros via Review Board
> On Jan. 11, 2018, 1:53 a.m., Robert Kanter wrote: > > .gitignore > > Line 10 (original), 13 (patched) > > > > > > This can be in a followup JIRA if you want (in which case, please file > > it), but we should add

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-01-10 Thread Robert Kanter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review195200 --- .gitignore Line 10 (original), 13 (patched)

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2017-11-23 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/ --- (Updated Nov. 23, 2017, 7:19 p.m.) Review request for oozie. Changes ---

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2017-11-23 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/ --- (Updated Nov. 23, 2017, 4:41 p.m.) Review request for oozie. Changes ---

Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2017-11-22 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/ --- Review request for oozie. Repository: oozie-git Description ---