Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Alisha Prabhu


> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/resources/jetty-logging.properties
> > Line 1 (original), 1 (patched)
> > 
> >
> > Please leave .properties files intact. ``/**/`` is not a valid comment. 
> > Format: 
> > https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-
> 
> Alisha Prabhu wrote:
> Have now kept all the .properties files intact.
> 
> Peter Cseh wrote:
> I think the proper solution here is to don't use CheckStyle for header 
> checking. We have RAT to check the headers.
> Please remove this section from the checkstyle config: 
> https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle.xml#L29-L31
>  and the corresponging file: 
> https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle-header.txt

Uploaded the patch by making the above changes.


- Alisha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
---


On March 20, 2018, 5:36 a.m., Alisha Prabhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> ---
> 
> (Updated March 20, 2018, 5:36 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
>   core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
>   core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
>   core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
>   core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
>   core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
>   core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 122dfd0 
>   core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
>  669ac5e 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  179cc45 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  16d7036 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> ff7bf8a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> fbc6152 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b91253 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1e864ea 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
> 1998924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 42bdc99 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
> 1195ef0 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
> 86ee1cc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
> 61891b8 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> 71c29cd 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
>  18ceb10 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  02a4f68 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
>  274b3c1 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  51449db 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  43c7d08 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
>  4b8adfb 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
> d76e1ea 
>   core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b 
>   

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Alisha Prabhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/
---

(Updated March 20, 2018, 5:36 a.m.)


Review request for oozie.


Changes
---

Modified checkstyle.xml, removed checkstyle-header.txt


Bugs: OOZIE-3176
https://issues.apache.org/jira/browse/OOZIE-3176


Repository: oozie-git


Description
---

There are multiple checkstyle violations in the Oozie-core module.
Maven command used is mvn clean install -DskipTests


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
  core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
  core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
  core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
  core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
  core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
  core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
  core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
  core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
122dfd0 
  core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
  
core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
 669ac5e 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
 179cc45 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 
16d7036 
  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
ff7bf8a 
  core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
fbc6152 
  
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
 2b91253 
  
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
 1e864ea 
  core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
1998924 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
42bdc99 
  core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
1195ef0 
  core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc 
  core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
61891b8 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
71c29cd 
  core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
  core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
  core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
  
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
 18ceb10 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
 02a4f68 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
 274b3c1 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
 51449db 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
 43c7d08 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
 4b8adfb 
  core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea 
  core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd 
  core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915 
  core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989 
  core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd 
  core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c 
  core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba 
  core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 
d08521c 
  core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5 
  core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c 
  core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630 
  core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java 
ef9a591 
  core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 
03279eb 
  core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1 
  core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134 
  core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java 
dd6afa0 
  core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 
78b0652 
  core/src/main/resources/localoozie-log4j.properties 906397f 
  

[jira] [Commented] (OOZIE-2600) OYA: Update Documentation

2018-03-19 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405549#comment-16405549
 ] 

Hadoop QA commented on OOZIE-2600:
--


Testing JIRA OOZIE-2600

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:red}-1{color} the patch contains 1 line(s) with tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 7 line(s) longer than 132 
characters
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2096
.Tests failed: 2
.Tests errors: 1

.The patch failed the following testcases:

testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService)

.Tests failing with errors:
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)

.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
TestCoordActionInputCheckXCommandNonUTC>TestCoordActionInputCheckXCommand#testNone
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/449/



> OYA: Update Documentation
> -
>
> Key: OOZIE-2600
> URL: https://issues.apache.org/jira/browse/OOZIE-2600
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: oya, 5.0.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2600.001.patch
>
>
> Based on the work done in OOZIE-2896, document also the way how 
> {{oozie.launcher.override.\*}} and {{oozie.launcher.prepend.\*}} parameters 
> function.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Failed: OOZIE-2600 PreCommit Build #449

2018-03-19 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/OOZIE-2600
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/449/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.74 MB...]
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2252 bytes
[TRACE] Full summary file size is 1314 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-2600

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
-1 the patch contains 1 line(s) with tabs
+1 the patch does not introduce any trailing spaces
-1 the patch contains 7 line(s) longer than 132 characters
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [server].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 2096
Tests failed: 2
Tests errors: 1

The patch failed the following testcases:

testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService)

Tests failing with errors:
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)

Tests failed at first run:
TestJavaActionExecutor#testCredentialsSkip
TestCoordActionInputCheckXCommandNonUTC>TestCoordActionInputCheckXCommand#testNone
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/449/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0{"self":"https://issues.apache.org/jira/rest/api/2/issue/12985913/comment/16405549","id":"16405549","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","emailAddress":"blackhole
 at hadoop dot apache dot 
org","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small=hadoopqa=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall=hadoopqa=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium=hadoopqa=10393"},"displayName":"Hadoop
 QA","active":true,"timeZone":"Etc/UTC"},"body":"\nTesting JIRA 
OOZIE-2600\n\nCleaning local git 
workspace\n\n\n\n{color:green}+1 
PATCH_APPLIES{color}\n{color:green}+1 CLEAN{color}\n{color:red}-1 
RAW_PATCH_ANALYSIS{color}\n.{color:green}+1{color} the patch does not 
introduce 

[jira] [Commented] (OOZIE-2600) OYA: Update Documentation

2018-03-19 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405436#comment-16405436
 ] 

Hadoop QA commented on OOZIE-2600:
--

PreCommit-OOZIE-Build started


> OYA: Update Documentation
> -
>
> Key: OOZIE-2600
> URL: https://issues.apache.org/jira/browse/OOZIE-2600
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: oya, 5.0.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2600.001.patch
>
>
> Based on the work done in OOZIE-2896, document also the way how 
> {{oozie.launcher.override.\*}} and {{oozie.launcher.prepend.\*}} parameters 
> function.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 66149: OOZIE-2600 OYA: Update Documentation

2018-03-19 Thread András Piros via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66149/
---

Review request for oozie, Peter Cseh and Robert Kanter.


Repository: oozie-git


Description
---

OOZIE-2600 OYA: Update Documentation


Diffs
-

  docs/src/site/twiki/AG_Install.twiki 15042151f11666517f328f700cca022375bad8ae 
  docs/src/site/twiki/DG_DistCpActionExtension.twiki 
260cd2578e7a4d78067512461fac72f47d32e7cb 
  docs/src/site/twiki/DG_Examples.twiki 
87cac48bcb7bfb2c6628ad33429a036d0d2b676e 
  docs/src/site/twiki/DG_Hive2ActionExtension.twiki 
094307fd81e57f51c25e6c6e30a2c7564a2bba76 
  docs/src/site/twiki/DG_HiveActionExtension.twiki 
a0d7b578ba0dd30fa8cd8c0b8a6c796c20e78c93 
  docs/src/site/twiki/DG_ShellActionExtension.twiki 
493254a6f5d77eaa3dfa56ba39047e0847fa15ee 
  docs/src/site/twiki/DG_SparkActionExtension.twiki 
294e7dd566b8849742e42962ce164c71b9caaed9 
  docs/src/site/twiki/DG_SqoopActionExtension.twiki 
906ba5476f7628b3bf70dc3d6d5ef4a48418ea94 
  docs/src/site/twiki/DG_SshActionExtension.twiki 
c2e33c90c154df1e978e09c1534474a107191cd5 
  docs/src/site/twiki/ENG_MiniOozie.twiki 
2c397264e1d758bae0c0590289d329a82fa3fd8c 
  docs/src/site/twiki/WorkflowFunctionalSpec.twiki 
038c430d37887617070f2cb13dd0eba0962600d2 


Diff: https://reviews.apache.org/r/66149/diff/1/


Testing
---

This is a documentation-only task, hence no testing except for generating the 
documentation, and checking, is done:
```
mvn clean install -DskipTests -Denforcer.skip=true -Dcheckstyle.skip=true 
-Dfindbugs.skip=true -PgenerateDocs
```


Thanks,

András Piros



[jira] [Comment Edited] (OOZIE-2600) OYA: Update Documentation

2018-03-19 Thread Andras Piros (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405286#comment-16405286
 ] 

Andras Piros edited comment on OOZIE-2600 at 3/19/18 8:14 PM:
--

Following is covered here:
* document OOZIE-2896
* upgrade to 1.0 XSDs across documentation
* rework examples to use 1.0 XSDs across documentation
* cover {{OozieClient}} / {{MiniOozie}} extensions

[~gezapeti] [~rkanter] do you see anything more within the existing 
documentation that is worth reworking / updating?


was (Author: andras.piros):
Following is covered here:
* document OOZIE-2896
* upgrade to 1.0 XSDs across documentation
* rework examples to use 1.0 XSDs across documentation
* cover {{OozieClient}} / {{MiniOozie}} extensions

[~gezapeti] do you see anything more within the existing documentation that is 
worth reworking / updating?

> OYA: Update Documentation
> -
>
> Key: OOZIE-2600
> URL: https://issues.apache.org/jira/browse/OOZIE-2600
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: oya, 5.0.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2600.001.patch
>
>
> Based on the work done in OOZIE-2896, document also the way how 
> {{oozie.launcher.override.\*}} and {{oozie.launcher.prepend.\*}} parameters 
> function.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-2600) OYA: Update Documentation

2018-03-19 Thread Andras Piros (JIRA)

 [ 
https://issues.apache.org/jira/browse/OOZIE-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2600:

Attachment: OOZIE-2600.001.patch

> OYA: Update Documentation
> -
>
> Key: OOZIE-2600
> URL: https://issues.apache.org/jira/browse/OOZIE-2600
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: oya, 5.0.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2600.001.patch
>
>
> Based on the work done in OOZIE-2896, document also the way how 
> {{oozie.launcher.override.\*}} and {{oozie.launcher.prepend.\*}} parameters 
> function.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-2600) OYA: Update Documentation

2018-03-19 Thread Andras Piros (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405286#comment-16405286
 ] 

Andras Piros commented on OOZIE-2600:
-

Following is covered here:
* document OOZIE-2896
* upgrade to 1.0 XSDs across documentation
* rework examples to use 1.0 XSDs across documentation
* cover {{OozieClient}} / {{MiniOozie}} extensions

[~gezapeti] do you see anything more within the existing documentation that is 
worth reworking / updating?

> OYA: Update Documentation
> -
>
> Key: OOZIE-2600
> URL: https://issues.apache.org/jira/browse/OOZIE-2600
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: oya, 5.0.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
>
> Based on the work done in OOZIE-2896, document also the way how 
> {{oozie.launcher.override.\*}} and {{oozie.launcher.prepend.\*}} parameters 
> function.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3197) Can you please guide me how to to exception handling at action level in oozie

2018-03-19 Thread Robert Kanter (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405182#comment-16405182
 ] 

Robert Kanter commented on OOZIE-3197:
--

[~kunu] JIRA is for bugs, feature requests, and other improvements.  For help 
_using_ Oozie, the user mailing list is more appropriate:
https://oozie.apache.org/mail-lists.html

You're using the Hortonworks distribution of Oozie, so you can also ask on 
Hortonwork's support and/or forums as well.

> Can you please guide me how to to exception handling at action level in oozie
> -
>
> Key: OOZIE-3197
> URL: https://issues.apache.org/jira/browse/OOZIE-3197
> Project: Oozie
>  Issue Type: Bug
>  Components: action
> Environment: i am using oozie 4.2 and distribution is hortonworks.
>Reporter: kunal kishore
>Priority: Blocker
>
> I am developing workflow and i would like to do exception handling at action 
> level, if it is possible to implement exception handling at action level.
>  
> Please guide me with example or code snippet.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-3197) Can you please guide me how to to exception handling at action level in oozie

2018-03-19 Thread Robert Kanter (JIRA)

 [ 
https://issues.apache.org/jira/browse/OOZIE-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Kanter updated OOZIE-3197:
-
Priority: Minor  (was: Blocker)

> Can you please guide me how to to exception handling at action level in oozie
> -
>
> Key: OOZIE-3197
> URL: https://issues.apache.org/jira/browse/OOZIE-3197
> Project: Oozie
>  Issue Type: Bug
>  Components: action
> Environment: i am using oozie 4.2 and distribution is hortonworks.
>Reporter: kunal kishore
>Priority: Minor
>
> I am developing workflow and i would like to do exception handling at action 
> level, if it is possible to implement exception handling at action level.
>  
> Please guide me with example or code snippet.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3189) Update the release script and wiki page to use sha512 instead of md5

2018-03-19 Thread Robert Kanter (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405175#comment-16405175
 ] 

Robert Kanter commented on OOZIE-3189:
--

I already updated the wiki :)

I think you have to file an INFRA JIRA to ask for edit permissions on the wiki. 
 

> Update the release script and wiki page to use sha512 instead of md5
> 
>
> Key: OOZIE-3189
> URL: https://issues.apache.org/jira/browse/OOZIE-3189
> Project: Oozie
>  Issue Type: Improvement
>  Components: scripts
>Reporter: Robert Kanter
>Assignee: Robert Kanter
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-3189.001.patch, OOZIE-3189.002.patch
>
>
> Apache has updated it's policy on the release signatures, as per it's website 
> [here|https://www.apache.org/dev/release-distribution#sigs-and-sums] and a 
> recent email. Basically, all future releases should be providing a sha512 
> checksum instead of an md5 one.
> There are two tasks:
>  # Update the release script to use sha512 instead of md5
>  [https://github.com/apache/oozie/blob/master/bin/create-release-artifact#L71]
>  [https://www.apache.org/dev/release-signing#sha-checksum]
>  # Update the wiki (requires committer/pmc permissions?)
>  [https://cwiki.apache.org/confluence/display/OOZIE/How+To+Release]
> While we're updating the wiki, we should add details on:
>  # Making sure the gpg key used for signing releases is 4096 bit RSA
>  # Publishing your gpg public key to a key server 
> ([https://www.apache.org/dev/release-signing#keyserver])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3189) Update the release script and wiki page to use sha512 instead of md5

2018-03-19 Thread Peter Cseh (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404907#comment-16404907
 ] 

Peter Cseh commented on OOZIE-3189:
---

Committed to master!

I can't update the wiki though even when I'm logging in with my Apache 
credentials.

> Update the release script and wiki page to use sha512 instead of md5
> 
>
> Key: OOZIE-3189
> URL: https://issues.apache.org/jira/browse/OOZIE-3189
> Project: Oozie
>  Issue Type: Improvement
>  Components: scripts
>Reporter: Robert Kanter
>Assignee: Robert Kanter
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-3189.001.patch, OOZIE-3189.002.patch
>
>
> Apache has updated it's policy on the release signatures, as per it's website 
> [here|https://www.apache.org/dev/release-distribution#sigs-and-sums] and a 
> recent email. Basically, all future releases should be providing a sha512 
> checksum instead of an md5 one.
> There are two tasks:
>  # Update the release script to use sha512 instead of md5
>  [https://github.com/apache/oozie/blob/master/bin/create-release-artifact#L71]
>  [https://www.apache.org/dev/release-signing#sha-checksum]
>  # Update the wiki (requires committer/pmc permissions?)
>  [https://cwiki.apache.org/confluence/display/OOZIE/How+To+Release]
> While we're updating the wiki, we should add details on:
>  # Making sure the gpg key used for signing releases is 4096 bit RSA
>  # Publishing your gpg public key to a key server 
> ([https://www.apache.org/dev/release-signing#keyserver])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3189) Update the release script and wiki page to use sha512 instead of md5

2018-03-19 Thread Peter Cseh (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404898#comment-16404898
 ] 

Peter Cseh commented on OOZIE-3189:
---

Thanks for the fix! It works perfectly now.
+1

> Update the release script and wiki page to use sha512 instead of md5
> 
>
> Key: OOZIE-3189
> URL: https://issues.apache.org/jira/browse/OOZIE-3189
> Project: Oozie
>  Issue Type: Improvement
>  Components: scripts
>Reporter: Robert Kanter
>Assignee: Robert Kanter
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-3189.001.patch, OOZIE-3189.002.patch
>
>
> Apache has updated it's policy on the release signatures, as per it's website 
> [here|https://www.apache.org/dev/release-distribution#sigs-and-sums] and a 
> recent email. Basically, all future releases should be providing a sha512 
> checksum instead of an md5 one.
> There are two tasks:
>  # Update the release script to use sha512 instead of md5
>  [https://github.com/apache/oozie/blob/master/bin/create-release-artifact#L71]
>  [https://www.apache.org/dev/release-signing#sha-checksum]
>  # Update the wiki (requires committer/pmc permissions?)
>  [https://cwiki.apache.org/confluence/display/OOZIE/How+To+Release]
> While we're updating the wiki, we should add details on:
>  # Making sure the gpg key used for signing releases is 4096 bit RSA
>  # Publishing your gpg public key to a key server 
> ([https://www.apache.org/dev/release-signing#keyserver])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OOZIE-3198) Extend remaining job tracker references in code and documentation

2018-03-19 Thread Andras Piros (JIRA)
Andras Piros created OOZIE-3198:
---

 Summary: Extend remaining job tracker references in code and 
documentation
 Key: OOZIE-3198
 URL: https://issues.apache.org/jira/browse/OOZIE-3198
 Project: Oozie
  Issue Type: Sub-task
  Components: action, core, docs
Affects Versions: 5.0.0b1
Reporter: Andras Piros
Assignee: Andras Piros
 Fix For: 5.0.0


Extend the places in configuration, code and documentation where {{jobTracker}} 
and {{job-tracker}} is still referenced without a proper {{resourceManager}}, 
{{resource-manager}} reference that precedes it.

Example: {{oozie.service.HadoopAccessorService.jobTracker.whitelist}} in 
{{AG_HadoopConfiguration.twiki}}, {{HadoopAccessorService.java}}, and 
{{oozie-default.xml}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Peter Cseh via Review Board


> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/resources/jetty-logging.properties
> > Line 1 (original), 1 (patched)
> > 
> >
> > Please leave .properties files intact. ``/**/`` is not a valid comment. 
> > Format: 
> > https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-
> 
> Alisha Prabhu wrote:
> Have now kept all the .properties files intact.

I think the proper solution here is to don't use CheckStyle for header 
checking. We have RAT to check the headers.
Please remove this section from the checkstyle config: 
https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle.xml#L29-L31
 and the corresponging file: 
https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle-header.txt


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
---


On March 19, 2018, 12:32 p.m., Alisha Prabhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> ---
> 
> (Updated March 19, 2018, 12:32 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
>   core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
>   core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
>   core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
>   core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
>   core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
>   core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 122dfd0 
>   core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
>  669ac5e 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  179cc45 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  16d7036 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> ff7bf8a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> fbc6152 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b91253 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1e864ea 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
> 1998924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 42bdc99 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
> 1195ef0 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
> 86ee1cc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
> 61891b8 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> 71c29cd 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
>  18ceb10 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  02a4f68 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
>  274b3c1 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  51449db 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  43c7d08 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
>  4b8adfb 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
> d76e1ea 
>   core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd 
>   

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Alisha Prabhu


> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java
> > Lines 44 (patched)
> > 
> >
> > It breaks the precommit build (mkdistro, see 
> > https://builds.apache.org/job/PreCommit-OOZIE-Build/416/artifact/test-patch/reports/DISTRO.out)

Have kept the BasicDataSourceWrapper.java file intact.
Got build success after running the below command :
bin/mkdistro.sh -DskipTests -Puber -DtargetJavaVersion=1.8 -DjavaVersion=1.8


> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/resources/jetty-logging.properties
> > Line 1 (original), 1 (patched)
> > 
> >
> > Please leave .properties files intact. ``/**/`` is not a valid comment. 
> > Format: 
> > https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-

Have now kept all the .properties files intact.


- Alisha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
---


On March 19, 2018, 12:32 p.m., Alisha Prabhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> ---
> 
> (Updated March 19, 2018, 12:32 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
>   core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
>   core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
>   core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
>   core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
>   core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
>   core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 122dfd0 
>   core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
>  669ac5e 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  179cc45 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  16d7036 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> ff7bf8a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> fbc6152 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b91253 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1e864ea 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
> 1998924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 42bdc99 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
> 1195ef0 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
> 86ee1cc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
> 61891b8 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> 71c29cd 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
>  18ceb10 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  02a4f68 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
>  274b3c1 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  51449db 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  43c7d08 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
>  4b8adfb 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
> d76e1ea 
>   

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Alisha Prabhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/
---

(Updated March 19, 2018, 12:32 p.m.)


Review request for oozie.


Bugs: OOZIE-3176
https://issues.apache.org/jira/browse/OOZIE-3176


Repository: oozie-git


Description
---

There are multiple checkstyle violations in the Oozie-core module.
Maven command used is mvn clean install -DskipTests


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
  core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
  core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
  core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
  core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
  core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
  core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
  core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
  core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
122dfd0 
  core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
  
core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
 669ac5e 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
 179cc45 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 
16d7036 
  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
ff7bf8a 
  core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
fbc6152 
  
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
 2b91253 
  
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
 1e864ea 
  core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
1998924 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
42bdc99 
  core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
1195ef0 
  core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc 
  core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
61891b8 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
71c29cd 
  core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
  core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
  core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
  
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
 18ceb10 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
 02a4f68 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
 274b3c1 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
 51449db 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
 43c7d08 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
 4b8adfb 
  core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea 
  core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd 
  core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915 
  core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989 
  core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd 
  core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c 
  core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba 
  core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 
d08521c 
  core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5 
  core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c 
  core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630 
  core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java 
ef9a591 
  core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 
03279eb 
  core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1 
  core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134 
  core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java 
dd6afa0 
  core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 
78b0652 
  core/src/main/resources/localoozie-log4j.properties 906397f 
  core/src/test/java/org/apache/hadoop/examples/SleepJob.java 342f8b3 
  

Re: Review Request 65481: OOZIE-3134 - Potential inconsistency between the in-memory SLA map and the Oozie database

2018-03-19 Thread András Piros via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65481/#review199405
---




core/src/main/java/org/apache/oozie/util/db/FailingDBHelperForTest.java
Lines 27-30 (patched)


If it's visible because of testing, please add `@VisibleForTesting`.



core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java
Lines 1095 (patched)


Please add a more self-descriptive name like 
`testWhenSLARegistrationIsAddedBeanIsStoredCorrectly()`.



core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java
Lines 1104 (patched)


Please add a more self-descriptive name like 
`testWhenSLARegistrationIsAddedAndAllDBCallsAreDisruptedBeanIsNotStored()`.



core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java
Lines 1123 (patched)


Please add a more self-descriptive name like 
`testWhenSLARegistrationIsUpdatedBeanIsStoredCorrectly()`.



core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java
Lines 1141 (patched)


Please add a more self-descriptive name like 
`testWhenSLARegistrationIsUpdatedAndAllDBCallsAreDisruptedBeanIsNotStored()`.



core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java
Lines 1179 (patched)


Use a more descriptive name as `SLARegistrationDmlPredicate`.



core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java
Lines 1185 (patched)


Please use Guava's 
[`Strings#isNullOrEmpty()`](https://google.github.io/guava/releases/23.0/api/docs/com/google/common/base/Strings.html#isNullOrEmpty-java.lang.String-)
 instead.


- András Piros


On Feb. 19, 2018, 2:14 p.m., Kinga Marton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65481/
> ---
> 
> (Updated Feb. 19, 2018, 2:14 p.m.)
> 
> 
> Review request for oozie, András Piros and Attila Sasvari.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Upon SLACalculatorMemory.addRegistration, Oozie puts an entry into an 
> in-memory concurrent hashmap ("slaMap"), and later persists it in the Oozie 
> database.
> However, if there is a failure during the database operation, a 
> JPAExecutorException is thrown, and the entry is not removed from the SLA map.
> It may introduce inconsistency between the Oozie database and the SLA map.
> To prevent this, a rollback mechanism (with proper logging) should be 
> implemented. It would also make sense to do more sanity/consistency check in 
> the Oozie server.
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java ef019e73 
>   
> core/src/main/java/org/apache/oozie/util/db/AlwaysFailingHSQLDriverMapper.java
>  PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/db/FailingConnectionWrapper.java 
> 0e310253 
>   core/src/main/java/org/apache/oozie/util/db/FailingDBHelperForTest.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/db/FailingHSQLDBDriverWrapper.java 
> fe9f08b1 
>   core/src/main/java/org/apache/oozie/util/db/FailingMySQLDriverWrapper.java 
> f0e2b181 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 
> ee906f45 
> 
> 
> Diff: https://reviews.apache.org/r/65481/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kinga Marton
> 
>



[jira] [Commented] (OOZIE-3195) Typo in WebServicesAPI.twiki: Proxy Hive Job Submission

2018-03-19 Thread Andras Piros (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404553#comment-16404553
 ] 

Andras Piros commented on OOZIE-3195:
-

Thanks for the contribution [~kmarton]! +1

> Typo in WebServicesAPI.twiki: Proxy Hive Job Submission
> ---
>
> Key: OOZIE-3195
> URL: https://issues.apache.org/jira/browse/OOZIE-3195
> Project: Oozie
>  Issue Type: Bug
>  Components: docs
>Affects Versions: trunk
>Reporter: Julia Kinga Marton
>Assignee: Julia Kinga Marton
>Priority: Minor
> Attachments: OOZIE-3195-001.patch
>
>
> There is a typo at the Proxy Hive Job Submission description.
> [https://github.com/apache/oozie/blob/master/docs/src/site/twiki/WebServicesAPI.twiki#L851]
>  * =oozie.hive.options.size=: The number of options you'll be passing to 
> {color:#d04437}Pig. {color:#33}It has to be Hive, not Pig.{color}{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3197) Can you please guide me how to to exception handling at action level in oozie

2018-03-19 Thread Andras Piros (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404549#comment-16404549
 ] 

Andras Piros commented on OOZIE-3197:
-

[~kunu] please have a look at [*Decision Control 
Node*|https://oozie.apache.org/docs/4.2.0/WorkflowFunctionalSpec.html#a3.1.4_Decision_Control_Node],
 and [*Error 
Transition*|https://oozie.apache.org/docs/4.2.0/WorkflowFunctionalSpec.html#a3.2.1.3_Actions_Have_2_Transitions_ok_and_error],
 and [*{{wf:lastErrorNode()}}, {{wf:errorCode(String node)}} and 
{{wf:errorMessage(String message)}} EL 
function*|https://oozie.apache.org/docs/4.2.0/WorkflowFunctionalSpec.html#a4.2.3_Workflow_EL_Functions]
 documentation sections.

> Can you please guide me how to to exception handling at action level in oozie
> -
>
> Key: OOZIE-3197
> URL: https://issues.apache.org/jira/browse/OOZIE-3197
> Project: Oozie
>  Issue Type: Bug
>  Components: action
> Environment: i am using oozie 4.2 and distribution is hortonworks.
>Reporter: kunal kishore
>Priority: Blocker
>
> I am developing workflow and i would like to do exception handling at action 
> level, if it is possible to implement exception handling at action level.
>  
> Please guide me with example or code snippet.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Attila Sasvari via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
---




core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java
Lines 44 (patched)


It breaks the precommit build (mkdistro, see 
https://builds.apache.org/job/PreCommit-OOZIE-Build/416/artifact/test-patch/reports/DISTRO.out)



core/src/main/resources/jetty-logging.properties
Line 1 (original), 1 (patched)


Please leave .properties files intact. ``/**/`` is not a valid comment. 
Format: 
https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-



core/src/main/resources/localoozie-log4j.properties
Line 1 (original), 1 (patched)


Please leave .properties files intact. ``/**/`` is not a valid comment. 
Format: 
https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-



core/src/main/resources/oozie-log4j.properties
Line 1 (original), 1 (patched)


Please leave .properties files intact. ``/**/`` is not a valid comment. 
Format: 
https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-


- Attila Sasvari


On March 15, 2018, 9:49 a.m., Alisha Prabhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> ---
> 
> (Updated March 15, 2018, 9:49 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
>   core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
>   core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
>   core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
>   core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
>   core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
>   core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> bc0f405 
>   core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
>  669ac5e 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  179cc45 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  16d7036 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> ff7bf8a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> fbc6152 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b91253 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1e864ea 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
> 1998924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 42bdc99 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
> 1195ef0 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
> 86ee1cc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
> 61891b8 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> 71c29cd 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
>  18ceb10 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  02a4f68 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
>  274b3c1 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  51449db 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  43c7d08 
>   
> 

[jira] Subscription: Oozie Patch Available

2018-03-19 Thread jira
Issue Subscription
Filter: Oozie Patch Available (107 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-3195  Typo in WebServicesAPI.twiki: Proxy Hive Job Submission
https://issues.apache.org/jira/browse/OOZIE-3195
OOZIE-3194  Oozie should set proper permissions to sharelib after upload
https://issues.apache.org/jira/browse/OOZIE-3194
OOZIE-3189  Update the release script and wiki page to use sha512 instead of md5
https://issues.apache.org/jira/browse/OOZIE-3189
OOZIE-3186  Oozie is unable to use configuration linked using jceks://file/...
https://issues.apache.org/jira/browse/OOZIE-3186
OOZIE-3185  Conflicting JARs org.apache.derby exist in Oozie
https://issues.apache.org/jira/browse/OOZIE-3185
OOZIE-3179  Adding a configurable config-default.xml location to a workflow
https://issues.apache.org/jira/browse/OOZIE-3179
OOZIE-3176  Oozie-core fails with checkstyle errors.
https://issues.apache.org/jira/browse/OOZIE-3176
OOZIE-3170  Oozie Diagnostic Bundle tool fails with NPE due to missing service 
class
https://issues.apache.org/jira/browse/OOZIE-3170
OOZIE-3135  Configure log4j2 in SqoopMain
https://issues.apache.org/jira/browse/OOZIE-3135
OOZIE-3134  Potential inconsistency between the in-memory SLA map and the Oozie 
database
https://issues.apache.org/jira/browse/OOZIE-3134
OOZIE-3109  Escape log-streaming's HTML-specific characters
https://issues.apache.org/jira/browse/OOZIE-3109
OOZIE-3105  testJMXInstrumentation from the 
org.apache.oozie.util.TestMetricsInstrumentation class is flaky
https://issues.apache.org/jira/browse/OOZIE-3105
OOZIE-3094  fix for grammar mistake
https://issues.apache.org/jira/browse/OOZIE-3094
OOZIE-3091  Oozie Sqoop Avro Import fails with "java.lang.NoClassDefFoundError: 
org/apache/avro/mapred/AvroWrapper"
https://issues.apache.org/jira/browse/OOZIE-3091
OOZIE-3071  Oozie 4.3 Spark sharelib ueses a different version of commons-lang3 
than Spark 2.2.0
https://issues.apache.org/jira/browse/OOZIE-3071
OOZIE-3063  Sanitizing variables that are part of openjpa.ConnectionProperties
https://issues.apache.org/jira/browse/OOZIE-3063
OOZIE-3062  Set HADOOP_CONF_DIR for spark action
https://issues.apache.org/jira/browse/OOZIE-3062
OOZIE-3061  Kill only those child jobs which are not already killed
https://issues.apache.org/jira/browse/OOZIE-3061
OOZIE-3002  address findbugs errors in client lib
https://issues.apache.org/jira/browse/OOZIE-3002
OOZIE-2975  code clean up in pig sharelib, replace Exception with more 
explicit, add try with resources, StringBuilder instead of StringBuffer
https://issues.apache.org/jira/browse/OOZIE-2975
OOZIE-2956  Fix Findbugs warnings related to reliance on default encoding in 
oozie-core
https://issues.apache.org/jira/browse/OOZIE-2956
OOZIE-2955  Fix Findbugs warnings related to reliance on default encoding in 
oozie-client
https://issues.apache.org/jira/browse/OOZIE-2955
OOZIE-2954  Fix Checkstyle issues in oozie-client
https://issues.apache.org/jira/browse/OOZIE-2954
OOZIE-2953  Fix Checkstyle issues in oozie-tools
https://issues.apache.org/jira/browse/OOZIE-2953
OOZIE-2952  Fix Findbugs warnings in oozie-sharelib-oozie
https://issues.apache.org/jira/browse/OOZIE-2952
OOZIE-2949  Escape quotes whitespaces in Sqoop  field
https://issues.apache.org/jira/browse/OOZIE-2949
OOZIE-2942  Fix Findbugs warnings in oozie-examples
https://issues.apache.org/jira/browse/OOZIE-2942
OOZIE-2937  Remove redundant groupId from the child pom's
https://issues.apache.org/jira/browse/OOZIE-2937
OOZIE-2934  Fix "Exceptional return value of java.io.File.mkdirs() ignored" 
Findbugs error in oozie-sharelib-spark
https://issues.apache.org/jira/browse/OOZIE-2934
OOZIE-2927  Append new line character for Hive2 query using query tag
https://issues.apache.org/jira/browse/OOZIE-2927
OOZIE-2914  Consolidate Trim 
https://issues.apache.org/jira/browse/OOZIE-2914
OOZIE-2883  OOZIE throw the error "Missing 
[oozie.service.ProxyUserService.proxyuser.oozie.service.ProxyUserService.proxyuser.mr.groups]
 property"
https://issues.apache.org/jira/browse/OOZIE-2883
OOZIE-2877  Oozie Git Action
https://issues.apache.org/jira/browse/OOZIE-2877
OOZIE-2867  Timezone handling for Coordinators: emphasize "Continent/City" 
format
https://issues.apache.org/jira/browse/OOZIE-2867
OOZIE-2834  ParameterVerifier logging non-useful warning for workflow definition
https://issues.apache.org/jira/browse/OOZIE-2834
OOZIE-2833  when using uber mode the regex pattern used in the 
extractHeapSizeMB method does not allow heap sizes specified in bytes.