Re: Review Request 69492: OOZIE-3389 Getting input dependency list on the UI throws NPE

2018-12-01 Thread Kinga Marton via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69492/#review210999
---


Ship it!




Ship It!

- Kinga Marton


On Dec. 1, 2018, 2:21 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69492/
> ---
> 
> (Updated Dec. 1, 2018, 2:21 p.m.)
> 
> 
> Review request for oozie, Andras Salamon and Kinga Marton.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-3389 Getting input dependency list on the UI throws NPE
> 
> 
> Diffs
> -
> 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
>  d37cfe5125a5c3a665b3e33e6ac3fd5581fe278f 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
>  56aef1c1779ed7446852af42f25c5ca058e473e4 
>   
> core/src/test/java/org/apache/oozie/coord/input/dependency/TestCoordOldInputDependency.java
>  PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java 
> bacfe89bb3d836da1f6e559fa68a5bf4db970b09 
> 
> 
> Diff: https://reviews.apache.org/r/69492/diff/2/
> 
> 
> Testing
> ---
> 
> Introduced new unit test class `TestCoordOldInputDependency`.
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 69492: OOZIE-3389 Getting input dependency list on the UI throws NPE

2018-12-01 Thread András Piros via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69492/
---

(Updated Dec. 1, 2018, 2:21 p.m.)


Review request for oozie, Andras Salamon and Kinga Marton.


Changes
---

Addressing review comments.


Repository: oozie-git


Description
---

OOZIE-3389 Getting input dependency list on the UI throws NPE


Diffs (updated)
-

  
core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
 d37cfe5125a5c3a665b3e33e6ac3fd5581fe278f 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
 56aef1c1779ed7446852af42f25c5ca058e473e4 
  
core/src/test/java/org/apache/oozie/coord/input/dependency/TestCoordOldInputDependency.java
 PRE-CREATION 
  core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java 
bacfe89bb3d836da1f6e559fa68a5bf4db970b09 


Diff: https://reviews.apache.org/r/69492/diff/2/

Changes: https://reviews.apache.org/r/69492/diff/1-2/


Testing
---

Introduced new unit test class `TestCoordOldInputDependency`.


Thanks,

András Piros

Re: Review Request 69492: OOZIE-3389 Getting input dependency list on the UI throws NPE

2018-12-01 Thread András Piros via Review Board 


> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Line 121 (original), 120 (patched)
> > 
> >
> > Could you please add assert message.

It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in 
a separate JIRA.


> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 127 (patched)
> > 
> >
> > Could you please assertMessage

Done.


> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 179-184 (original), 183-188 (patched)
> > 
> >
> > This code (PUT) appears multiple times. Could you extract it to a 
> > method?

It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in 
a separate JIRA.


> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Line 184 (original), 188 (patched)
> > 
> >
> > Could you please add assert message.

It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in 
a separate JIRA.


> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 218-223 (original), 222-227 (patched)
> > 
> >
> > This code (PUT) appears multiple times. Could you extract it to a 
> > method?

It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in 
a separate JIRA.


> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Line 223 (original), 227 (patched)
> > 
> >
> > Could you please add assert message.

It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in 
a separate JIRA.


> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 313-316 (original), 317-320 (patched)
> > 
> >
> > This code (GET) appears multiple times. Could you extract it to a 
> > method?

It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in 
a separate JIRA.


> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 334-337 (original), 338-341 (patched)
> > 
> >
> > This code (GET) appears multiple times. Could you extract it to a 
> > method?

It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in 
a separate JIRA.


> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 355-358 (original), 359-362 (patched)
> > 
> >
> > This code (GET) appears multiple times. Could you extract it to a 
> > method?

It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in 
a separate JIRA.


> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 419-422 (original), 423-426 (patched)
> > 
> >
> > This code (GET) appears multiple times. Could you extract it to a 
> > method?

It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in 
a separate JIRA.


> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 440-443 (original), 444-447 (patched)
> > 
> >
> > This code (GET) appears multiple times. Could you extract it to a 
> > method?

It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in 
a separate JIRA.


- András


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69492/#review210973
---


On Nov. 30, 2018, 12:49 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
>

Re: Review Request 69492: OOZIE-3389 Getting input dependency list on the UI throws NPE

2018-11-30 Thread Andras Salamon 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69492/#review210973
---




core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
Line 121 (original), 121 (patched)


!isEmpty() might be nicer



core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Line 121 (original), 120 (patched)


Could you please add assert message.



core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 127 (patched)


Could you please assertMessage



core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 179-184 (original), 183-188 (patched)


This code (PUT) appears multiple times. Could you extract it to a method?



core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Line 184 (original), 188 (patched)


Could you please add assert message.



core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 218-223 (original), 222-227 (patched)


This code (PUT) appears multiple times. Could you extract it to a method?



core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Line 223 (original), 227 (patched)


Could you please add assert message.



core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 313-316 (original), 317-320 (patched)


This code (GET) appears multiple times. Could you extract it to a method?



core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 334-337 (original), 338-341 (patched)


This code (GET) appears multiple times. Could you extract it to a method?



core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 355-358 (original), 359-362 (patched)


This code (GET) appears multiple times. Could you extract it to a method?



core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 419-422 (original), 423-426 (patched)


This code (GET) appears multiple times. Could you extract it to a method?



core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 440-443 (original), 444-447 (patched)


This code (GET) appears multiple times. Could you extract it to a method?


- Andras Salamon


On Nov. 30, 2018, 12:49 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69492/
> ---
> 
> (Updated Nov. 30, 2018, 12:49 p.m.)
> 
> 
> Review request for oozie, Andras Salamon and Kinga Marton.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-3389 Getting input dependency list on the UI throws NPE
> 
> 
> Diffs
> -
> 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
>  d37cfe5125a5c3a665b3e33e6ac3fd5581fe278f 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
>  56aef1c1779ed7446852af42f25c5ca058e473e4 
>   
> core/src/test/java/org/apache/oozie/coord/input/dependency/TestCoordOldInputDependency.java
>  PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java 
> bacfe89bb3d836da1f6e559fa68a5bf4db970b09 
> 
> 
> Diff: https://reviews.apache.org/r/69492/diff/1/
> 
> 
> Testing
> ---
> 
> Introduced new unit test class `TestCoordOldInputDependency`.
> 
> 
> Thanks,
> 
> András Piros
> 
>

Review Request 69492: OOZIE-3389 Getting input dependency list on the UI throws NPE

2018-11-30 Thread András Piros via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69492/
---

Review request for oozie, Andras Salamon and Kinga Marton.


Repository: oozie-git


Description
---

OOZIE-3389 Getting input dependency list on the UI throws NPE


Diffs
-

  
core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
 d37cfe5125a5c3a665b3e33e6ac3fd5581fe278f 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
 56aef1c1779ed7446852af42f25c5ca058e473e4 
  
core/src/test/java/org/apache/oozie/coord/input/dependency/TestCoordOldInputDependency.java
 PRE-CREATION 
  core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java 
bacfe89bb3d836da1f6e559fa68a5bf4db970b09 


Diff: https://reviews.apache.org/r/69492/diff/1/


Testing
---

Introduced new unit test class `TestCoordOldInputDependency`.


Thanks,

András Piros