[jira] [Commented] (OOZIE-3024) Email action ignores value of content_type attribute when attachment attribute is set

2019-07-18 Thread Andras Salamon (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887669#comment-16887669
 ] 

Andras Salamon commented on OOZIE-3024:
---

Thanks for the contribution [~matijhs], +1, committed to master.

> Email action ignores value of content_type attribute when attachment 
> attribute is set
> -
>
> Key: OOZIE-3024
> URL: https://issues.apache.org/jira/browse/OOZIE-3024
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.2.0
>Reporter: Jim Hopper
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-3024-V2.patch, OOZIE-3024.patch
>
>
> The email action ignores value of content_type attribute when attachment 
> attribute is set.
> This results in an email with a html body sent as a plaintext.
> https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java#L251
> {code}
> if(contentType.equals("text/html")) {
> MimeBodyPart bodyHtmlPart = new MimeBodyPart();
> bodyHtmlPart.setContent(body, contentType);
> multipart.addBodyPart(bodyHtmlPart);
> }
> else{
> MimeBodyPart bodyTextPart = new MimeBodyPart();
> bodyTextPart.setText(body);
> multipart.addBodyPart(bodyTextPart);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (OOZIE-3024) email action ignores value of content_type attribute when attachment attribute is set

2019-07-17 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887429#comment-16887429
 ] 

Hadoop QA commented on OOZIE-3024:
--


Testing JIRA OOZIE-3024

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [2] new bugs found below threshold in total that 
must be fixed.
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:red}-1{color} There are [2] new bugs found below threshold in 
[core] that must be fixed.
.You can find the SpotBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
.The most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 206]: This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 176]: At BulkJPAExecutor.java:[line 175]
.At BulkJPAExecutor.java:[line 205]: At BulkJPAExecutor.java:[line 199]
.java/io/File.init(Ljava/lang/String;Ljava/lang/String;)V reads a 
file whose location might be specified by user input: At 
BulkJPAExecutor.java:[line 206]
.At AuthorizationService.java:[line 189]: At 
AuthorizationService.java:[line 192]
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2969
.Tests failed : 1
.Tests in error   : 0
.Tests timed out  : 0

{color:red}-1{color} [ERROR] There are [1] test failures in [core]. Listing 
only the first [5] ones
testPurgeableWorkflowOverTheLimitSucceededSubWorkflows:org.apache.oozie.command.TestPurgeXCommand

Check console output for the full list of errors/failures
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/1185/



> email action ignores value of content_type attribute when attachment 
> attribute is set
> -
>
> Key: OOZIE-3024
> URL: https://issues.apache.org/jira/browse/OOZIE-3024
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.2.0
>Reporter: Jim Hopper
>Assignee: Mate Juhasz
>Priority: Major
> 

[jira] [Commented] (OOZIE-3024) email action ignores value of content_type attribute when attachment attribute is set

2019-07-17 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887385#comment-16887385
 ] 

Hadoop QA commented on OOZIE-3024:
--

PreCommit-OOZIE-Build started


> email action ignores value of content_type attribute when attachment 
> attribute is set
> -
>
> Key: OOZIE-3024
> URL: https://issues.apache.org/jira/browse/OOZIE-3024
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.2.0
>Reporter: Jim Hopper
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-3024-V2.patch, OOZIE-3024.patch
>
>
> The email action ignores value of content_type attribute when attachment 
> attribute is set.
> This results in an email with a html body sent as a plaintext.
> https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java#L251
> {code}
> if(contentType.equals("text/html")) {
> MimeBodyPart bodyHtmlPart = new MimeBodyPart();
> bodyHtmlPart.setContent(body, contentType);
> multipart.addBodyPart(bodyHtmlPart);
> }
> else{
> MimeBodyPart bodyTextPart = new MimeBodyPart();
> bodyTextPart.setText(body);
> multipart.addBodyPart(bodyTextPart);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (OOZIE-3024) email action ignores value of content_type attribute when attachment attribute is set

2019-07-17 Thread Andras Salamon (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887335#comment-16887335
 ] 

Andras Salamon commented on OOZIE-3024:
---

I hardly think that the test error are related, but I retrigger the precommit.

> email action ignores value of content_type attribute when attachment 
> attribute is set
> -
>
> Key: OOZIE-3024
> URL: https://issues.apache.org/jira/browse/OOZIE-3024
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.2.0
>Reporter: Jim Hopper
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-3024-V2.patch, OOZIE-3024.patch
>
>
> The email action ignores value of content_type attribute when attachment 
> attribute is set.
> This results in an email with a html body sent as a plaintext.
> https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java#L251
> {code}
> if(contentType.equals("text/html")) {
> MimeBodyPart bodyHtmlPart = new MimeBodyPart();
> bodyHtmlPart.setContent(body, contentType);
> multipart.addBodyPart(bodyHtmlPart);
> }
> else{
> MimeBodyPart bodyTextPart = new MimeBodyPart();
> bodyTextPart.setText(body);
> multipart.addBodyPart(bodyTextPart);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (OOZIE-3024) email action ignores value of content_type attribute when attachment attribute is set

2019-07-17 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887253#comment-16887253
 ] 

Hadoop QA commented on OOZIE-3024:
--


Testing JIRA OOZIE-3024

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [6] new bugs found below threshold in total that 
must be fixed.
.{color:red}-1{color} There are [6] new bugs found below threshold in 
[core] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 206]: This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 176]: At BulkJPAExecutor.java:[line 175]
.At BulkJPAExecutor.java:[line 205]: At BulkJPAExecutor.java:[line 199]
.This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 206]
.At BulkJPAExecutor.java:[line 111]: At BulkJPAExecutor.java:[line 127]
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [tools].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 3168
.Tests failed : 0
.Tests in error   : 4
.Tests timed out  : 0

{color:red}-1{color} [ERROR] There are [4] test errors in [tools]. Listing only 
the first [5] ones
testCallCopyTaskMoreThreadsThanFiles:org.apache.oozie.tools.TestCopyTaskCallable
testCallCopyTaskSameFileNrAndThreadNr:org.apache.oozie.tools.TestCopyTaskCallable
testCallCopyTaskMoreFilesThanThreads:org.apache.oozie.tools.TestCopyTaskCallable
testCallCopyTaskOneThread:org.apache.oozie.tools.TestCopyTaskCallable

Check console output for the full list of errors/failures
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/1184/



> email action ignores value of content_type attribute when attachment 
> attribute is set
> -
>
> Key: OOZIE-3024
>

[jira] [Commented] (OOZIE-3024) email action ignores value of content_type attribute when attachment attribute is set

2019-07-17 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887130#comment-16887130
 ] 

Hadoop QA commented on OOZIE-3024:
--

PreCommit-OOZIE-Build started


> email action ignores value of content_type attribute when attachment 
> attribute is set
> -
>
> Key: OOZIE-3024
> URL: https://issues.apache.org/jira/browse/OOZIE-3024
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.2.0
>Reporter: Jim Hopper
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-3024-V2.patch, OOZIE-3024.patch
>
>
> The email action ignores value of content_type attribute when attachment 
> attribute is set.
> This results in an email with a html body sent as a plaintext.
> https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java#L251
> {code}
> if(contentType.equals("text/html")) {
> MimeBodyPart bodyHtmlPart = new MimeBodyPart();
> bodyHtmlPart.setContent(body, contentType);
> multipart.addBodyPart(bodyHtmlPart);
> }
> else{
> MimeBodyPart bodyTextPart = new MimeBodyPart();
> bodyTextPart.setText(body);
> multipart.addBodyPart(bodyTextPart);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (OOZIE-3024) email action ignores value of content_type attribute when attachment attribute is set

2019-07-17 Thread Mate Juhasz (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887091#comment-16887091
 ] 

Mate Juhasz commented on OOZIE-3024:


[~asalamon74], I added a test for emails with attachments and verified that the 
fix is working.

> email action ignores value of content_type attribute when attachment 
> attribute is set
> -
>
> Key: OOZIE-3024
> URL: https://issues.apache.org/jira/browse/OOZIE-3024
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.2.0
>Reporter: Jim Hopper
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-3024-V2.patch, OOZIE-3024.patch
>
>
> The email action ignores value of content_type attribute when attachment 
> attribute is set.
> This results in an email with a html body sent as a plaintext.
> https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java#L251
> {code}
> if(contentType.equals("text/html")) {
> MimeBodyPart bodyHtmlPart = new MimeBodyPart();
> bodyHtmlPart.setContent(body, contentType);
> multipart.addBodyPart(bodyHtmlPart);
> }
> else{
> MimeBodyPart bodyTextPart = new MimeBodyPart();
> bodyTextPart.setText(body);
> multipart.addBodyPart(bodyTextPart);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (OOZIE-3024) email action ignores value of content_type attribute when attachment attribute is set

2019-07-15 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885359#comment-16885359
 ] 

Hadoop QA commented on OOZIE-3024:
--


Testing JIRA OOZIE-3024

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [6] new bugs found below threshold in total that 
must be fixed.
.{color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:red}-1{color} There are [6] new bugs found below threshold in 
[core] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 206]: This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 176]: At BulkJPAExecutor.java:[line 175]
.At BulkJPAExecutor.java:[line 205]: At BulkJPAExecutor.java:[line 199]
.This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 206]
.At BulkJPAExecutor.java:[line 111]: At BulkJPAExecutor.java:[line 127]
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2964
.Tests failed : 1
.Tests in error   : 0
.Tests timed out  : 0

{color:red}-1{color} [ERROR] There are [1] test failures in [core]. Listing 
only the first [5] ones
testCoordMaterializeTriggerService3:org.apache.oozie.service.TestCoordMaterializeTriggerService

Check console output for the full list of errors/failures
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/1175/



> email action ignores value of content_type attribute when attachment 
> attribute is set
> -
>
> Key: OOZIE-3024
> URL: https://issues.apache.org/jira/browse/OOZIE-3024
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.2.0
>Reporter: Jim Hopper
>

[jira] [Commented] (OOZIE-3024) email action ignores value of content_type attribute when attachment attribute is set

2019-07-15 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885300#comment-16885300
 ] 

Hadoop QA commented on OOZIE-3024:
--

PreCommit-OOZIE-Build started


> email action ignores value of content_type attribute when attachment 
> attribute is set
> -
>
> Key: OOZIE-3024
> URL: https://issues.apache.org/jira/browse/OOZIE-3024
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.2.0
>Reporter: Jim Hopper
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-3024.patch
>
>
> The email action ignores value of content_type attribute when attachment 
> attribute is set.
> This results in an email with a html body sent as a plaintext.
> https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java#L251
> {code}
> if(contentType.equals("text/html")) {
> MimeBodyPart bodyHtmlPart = new MimeBodyPart();
> bodyHtmlPart.setContent(body, contentType);
> multipart.addBodyPart(bodyHtmlPart);
> }
> else{
> MimeBodyPart bodyTextPart = new MimeBodyPart();
> bodyTextPart.setText(body);
> multipart.addBodyPart(bodyTextPart);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (OOZIE-3024) email action ignores value of content_type attribute when attachment attribute is set

2019-07-15 Thread Andras Salamon (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885221#comment-16885221
 ] 

Andras Salamon commented on OOZIE-3024:
---

[~matijhs] Thanks for the patch, could you please add a unit test for the 
text/html + attachment case?

> email action ignores value of content_type attribute when attachment 
> attribute is set
> -
>
> Key: OOZIE-3024
> URL: https://issues.apache.org/jira/browse/OOZIE-3024
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.2.0
>Reporter: Jim Hopper
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-3024.patch
>
>
> The email action ignores value of content_type attribute when attachment 
> attribute is set.
> This results in an email with a html body sent as a plaintext.
> https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java#L251
> {code}
> if(contentType.equals("text/html")) {
> MimeBodyPart bodyHtmlPart = new MimeBodyPart();
> bodyHtmlPart.setContent(body, contentType);
> multipart.addBodyPart(bodyHtmlPart);
> }
> else{
> MimeBodyPart bodyTextPart = new MimeBodyPart();
> bodyTextPart.setText(body);
> multipart.addBodyPart(bodyTextPart);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (OOZIE-3024) email action ignores value of content_type attribute when attachment attribute is set

2019-07-15 Thread Mate Juhasz (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885210#comment-16885210
 ] 

Mate Juhasz commented on OOZIE-3024:


This issue has popped up recently, so I picked it up quickly. [~asalamon74] 
could you take a look?

> email action ignores value of content_type attribute when attachment 
> attribute is set
> -
>
> Key: OOZIE-3024
> URL: https://issues.apache.org/jira/browse/OOZIE-3024
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.2.0
>Reporter: Jim Hopper
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-3024.patch
>
>
> The email action ignores value of content_type attribute when attachment 
> attribute is set.
> This results in an email with a html body sent as a plaintext.
> https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java#L251
> {code}
> if(contentType.equals("text/html")) {
> MimeBodyPart bodyHtmlPart = new MimeBodyPart();
> bodyHtmlPart.setContent(body, contentType);
> multipart.addBodyPart(bodyHtmlPart);
> }
> else{
> MimeBodyPart bodyTextPart = new MimeBodyPart();
> bodyTextPart.setText(body);
> multipart.addBodyPart(bodyTextPart);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)