Peter Orova created OOZIE-3234:
----------------------------------

             Summary: Revise TestAuthorizationService
                 Key: OOZIE-3234
                 URL: https://issues.apache.org/jira/browse/OOZIE-3234
             Project: Oozie
          Issue Type: Improvement
          Components: tests
    Affects Versions: 5.0.0
            Reporter: Peter Orova
            Assignee: Peter Orova


The {{TestAuthorizationService}}'s maintainability is low due to
 * the many magic boolean variables
 * the init methods having 3+ parameters

One way this could be addressed is to introduce a simplified version of Builder 
pattern via a private nested class, to replace the functionality of the 
{{init}} methods.
This approach would allow for a much more readable, flexible and maintainable 
code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to