Re: Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

2016-10-15 Thread Peter Bacsko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52737/ --- (Updated okt. 15, 2016, 11:41 de) Review request for oozie, András Piros, Attil

Re: Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

2016-10-15 Thread Peter Bacsko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52737/ --- (Updated okt. 15, 2016, 11:33 de) Review request for oozie, András Piros, Attil

Re: Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

2016-10-14 Thread András Piros
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52737/#review152652 --- Ship it! Ship It! - András Piros On Oct. 14, 2016, 10:01 a.m

Re: Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

2016-10-14 Thread Peter Bacsko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52737/ --- (Updated okt. 14, 2016, 10:01 de) Review request for oozie, András Piros, Attil

Re: Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

2016-10-14 Thread Peter Bacsko
- Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52737/#review152319 --- On okt. 11, 2016, 1:42 du, Peter Bacsko wrote: > >

Re: Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

2016-10-14 Thread Peter Bacsko
> On okt. 12, 2016, 4:03 du, András Piros wrote: > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/AMRMCallBackHandler.java, > > line 41 > > > > > > Why `synchronized`? I don't see we reach out to globa

Re: Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

2016-10-13 Thread Attila Sasvari
> On Oct. 13, 2016, 6:12 p.m., Attila Sasvari wrote: > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java, > > line 103 > > > > > > The second parameter of checkNotNull is incorrect, it is

Re: Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

2016-10-13 Thread Attila Sasvari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52737/#review152545 --- sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/Launc

Re: Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

2016-10-12 Thread András Piros
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52737/#review152319 --- sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/AMRMC

Re: Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

2016-10-11 Thread Peter Bacsko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52737/#review152128 --- sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/AMRMC

Re: Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

2016-10-11 Thread Peter Bacsko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52737/ --- (Updated okt. 11, 2016, 1:42 du) Review request for oozie, András Piros, Attila

Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

2016-10-11 Thread Peter Bacsko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52737/ --- Review request for oozie, András Piros, Attila Sasvari, Peter Cseh, and Robert K