subject:"Review Request 66084\: Oozie\-core fails with checkstyle errors."

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-27 Thread András Piros via Review Board

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66084/#review200041 --- Ship it! Ship It! - András Piros On March 20, 2018, 5:36

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-26 Thread Peter Cseh via Review Board

> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote: > > core/src/main/resources/jetty-logging.properties > > Line 1 (original), 1 (patched) > > > > > > Please leave .properties files intact. ``/**/`` is not a valid

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-26 Thread Alisha Prabhu

> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote: > > Hi Attila Sasvari, can you please review the updated patch. Thank you. - Alisha --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Alisha Prabhu

> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote: > > core/src/main/resources/jetty-logging.properties > > Line 1 (original), 1 (patched) > > > > > > Please leave .properties files intact. ``/**/`` is not a valid

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Alisha Prabhu

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66084/ --- (Updated March 20, 2018, 5:36 a.m.) Review request for oozie. Changes

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Peter Cseh via Review Board

> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote: > > core/src/main/resources/jetty-logging.properties > > Line 1 (original), 1 (patched) > > > > > > Please leave .properties files intact. ``/**/`` is not a valid

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Alisha Prabhu

> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote: > > core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java > > Lines 44 (patched) > > > > > > It breaks the precommit build (mkdistro, see > >

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Alisha Prabhu

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66084/ --- (Updated March 19, 2018, 12:32 p.m.) Review request for oozie. Bugs: