Re: Adding GitHub Actions for PR validation

2020-07-17 Thread Romain Manni-Bucau
Jenkins builds are used AFAIK (but likely most of them by people doing $upport on older versions ;)) Personally I only use master but if you want to start a cleanup thread +1. It also seems unlikely we get PR support on jenkins from my understanding - if wrong it would be awesome - this is why I t

Re: Adding GitHub Actions for PR validation

2020-07-17 Thread Enrico Olivelli
Here it is the ticket https://issues.apache.org/jira/browse/OPENJPA-2819 I am going to send a patch Enrico Il giorno ven 17 lug 2020 alle ore 16:31 Francesco Chicchiriccò < ilgro...@apache.org> ha scritto: > On 17/07/20 16:19, Enrico Olivelli wrote: > > Il Ven 17 Lug 2020, 16:14 Romain Manni-Buc

Re: Adding GitHub Actions for PR validation

2020-07-17 Thread Francesco Chicchiriccò
On 17/07/20 16:19, Enrico Olivelli wrote: > Il Ven 17 Lug 2020, 16:14 Romain Manni-Bucau ha > scritto: > >> Hi Enrico, >> >> While we have a single type of this build tool +1 (= I don't think it would >> be good to have GH Action + Travis + AppVeryor + SemaphoreCI + ...). >> What would do the defa

Re: Adding GitHub Actions for PR validation

2020-07-17 Thread Romain Manni-Bucau
works for me Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: Adding GitHub Actions for PR validation

2020-07-17 Thread Enrico Olivelli
Il Ven 17 Lug 2020, 16:14 Romain Manni-Bucau ha scritto: > Hi Enrico, > > While we have a single type of this build tool +1 (= I don't think it would > be good to have GH Action + Travis + AppVeryor + SemaphoreCI + ...). > What would do the default build? mvn install or would it run all DB > prof

Re: Adding GitHub Actions for PR validation

2020-07-17 Thread Romain Manni-Bucau
Hi Enrico, While we have a single type of this build tool +1 (= I don't think it would be good to have GH Action + Travis + AppVeryor + SemaphoreCI + ...). What would do the default build? mvn install or would it run all DB profiles based on docker images? Romain Manni-Bucau @rmannibucau

Adding GitHub Actions for PR validation

2020-07-17 Thread Enrico Olivelli
Hey, what about adding a simple validation of Pull Requests using GitHub actions ? I can create a very simple configuration file if you like this idea. It will help a lot in contributing patches, this way it is sure for the committer that the patch is not breaking unit tests (not integration tests