Re: Docker profiles for starting various databases

2018-10-23 Thread Mark Struberg
Yes, what I personally like about the approach of kind of half-manually starting up the DB is that you can later look at the results. And it is WAY faster than a JUnit rule which runs on every test. Plus I know the author, so if any problems arise... ;) The goal of all this junit4/docker change

Re: Docker profiles for starting various databases

2018-10-23 Thread Romain Manni-Bucau
Le mar. 23 oct. 2018 à 09:53, Mark Struberg a écrit : > Yes, what I personally like about the approach of kind of half-manually > starting up the DB is that you can later look at the results. And it is WAY > faster than a JUnit rule which runs on every test. > > This part is wrong Mark and you k

[jira] [Created] (OPENJPA-2754) update to latest dbcp and verify moving from maxActive to maxTotal

2018-10-23 Thread Mark Struberg (JIRA)
Mark Struberg created OPENJPA-2754: -- Summary: update to latest dbcp and verify moving from maxActive to maxTotal Key: OPENJPA-2754 URL: https://issues.apache.org/jira/browse/OPENJPA-2754 Project: Ope

[jira] [Commented] (OPENJPA-2753) Create profiles to start various databases via Docker

2018-10-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660343#comment-16660343 ] ASF subversion and git services commented on OPENJPA-2753: -- Co

[jira] [Commented] (OPENJPA-2753) Create profiles to start various databases via Docker

2018-10-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660344#comment-16660344 ] ASF subversion and git services commented on OPENJPA-2753: -- Co

Re: Docker profiles for starting various databases

2018-10-23 Thread Mark Struberg
What you said is true for custom Rules. But as far as I've understood the default behaviour for the docker rule is per-class afair. Anyway. I agree that docker is really only optional!Setting up docker is e.g. not possible on non-pro Windows versions. And anything lower than Win10. And it is a

[jira] [Commented] (OPENJPA-2754) update to latest dbcp and verify moving from maxActive to maxTotal

2018-10-23 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660571#comment-16660571 ] Romain Manni-Bucau commented on OPENJPA-2754: - we shouldnt do any magic in

[jira] [Commented] (OPENJPA-2754) update to latest dbcp and verify moving from maxActive to maxTotal

2018-10-23 Thread Maxim Solodovnik (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660602#comment-16660602 ] Maxim Solodovnik commented on OPENJPA-2754: --- If I remember correctly there is

[jira] [Commented] (OPENJPA-2754) update to latest dbcp and verify moving from maxActive to maxTotal

2018-10-23 Thread Maxim Solodovnik (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660606#comment-16660606 ] Maxim Solodovnik commented on OPENJPA-2754: --- BTW it affects 3.0.1 (not 3.0.0)

[jira] [Commented] (OPENJPA-2754) update to latest dbcp and verify moving from maxActive to maxTotal

2018-10-23 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660608#comment-16660608 ] Romain Manni-Bucau commented on OPENJPA-2754: - [~solomax] point was more to

[jira] [Updated] (OPENJPA-2753) Create profiles to start various databases via Docker

2018-10-23 Thread Mark Struberg (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg updated OPENJPA-2753: --- Description: We currently rely on fix installed versions of various databases. With the adv

[jira] [Commented] (OPENJPA-2754) update to latest dbcp and verify moving from maxActive to maxTotal

2018-10-23 Thread Mark Struberg (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661188#comment-16661188 ] Mark Struberg commented on OPENJPA-2754: we could probably issue a warning? >