[GitHub] openjpa pull request #5: [OPENJPA-2669] Add karaf feature and adapt imports

2016-10-12 Thread cschneider 
Github user cschneider closed the pull request at:

https://github.com/apache/openjpa/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (OPENJPA-2669) Add apache karaf feature for openjpa and adapt OSGi imports

2016-10-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/OPENJPA-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569132#comment-15569132
 ] 

ASF GitHub Bot commented on OPENJPA-2669:
-

Github user cschneider closed the pull request at:

https://github.com/apache/openjpa/pull/5


> Add apache karaf feature for openjpa and adapt OSGi imports
> ---
>
> Key: OPENJPA-2669
> URL: https://issues.apache.org/jira/browse/OPENJPA-2669
> Project: OpenJPA
>  Issue Type: Improvement
>Reporter: Christian Schneider
> Fix For: 3.0.0
>
>
> The apache karaf enterprise feature contains too many different features and 
> versions. This can easily confuse users and cause wrong versions to be 
> installed. It is also not possible to install e.g. openjpa 3 in an apache 
> karaf that is already released as the enterprise feature can not be changed 
> for a release.
> So we plan to move feature definitions to the projects that create the 
> software to be installed.
> The main advantage is that the user can freely choose which openjpa version 
> to install independent of the karaf version.
> This issue tackles to create a feature repo for openjpa 3.0.0 and also to 
> adapt the OSGi package imports to the jpa 2.1 spec. I will create a github PR 
> for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OPENJPA-2673) Table is not created in openjpa 3.0.0-SNAPSHOT and OSGi

2016-10-12 Thread Christian Schneider (JIRA) 

[ 
https://issues.apache.org/jira/browse/OPENJPA-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569127#comment-15569127
 ] 

Christian Schneider commented on OPENJPA-2673:
--

It turned out that the problem was exclude-unlisted-classes true which I still 
had in the config as Aries JPA scans the classes itself. So it seems there 
still might be some problem when combining with Aries JPA but plain openjpa 
works.

I will update to PR with a working test that shows openjpa is working in karaf.


> Table is not created in openjpa 3.0.0-SNAPSHOT and OSGi
> ---
>
> Key: OPENJPA-2673
> URL: https://issues.apache.org/jira/browse/OPENJPA-2673
> Project: OpenJPA
>  Issue Type: Bug
>Reporter: Christian Schneider
> Fix For: 3.0.0
>
>
> When testing the openjpa 3 feature in karaf I had the problem that my table 
> was not there when openjpa tried to access it even though I have specified 
> the options to create tables. 
> This first case where I found the issue was using Aries JPA. So I was not 
> sure if the problem might be in Aries JPA.
> I have now created a pax exam test that reproduces the issue without Aries 
> JPA. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OPENJPA-2673) Table is not created in openjpa 3.0.0-SNAPSHOT and OSGi

2016-10-12 Thread Christian Schneider (JIRA) 

[ 
https://issues.apache.org/jira/browse/OPENJPA-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568687#comment-15568687
 ] 

Christian Schneider commented on OPENJPA-2673:
--

You can run the test from openjpa-integration/karaf.

This is the output from the test:
Running org.apache.openjpa.itest.karaf.KarafTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.13 sec <<< 
FAILURE! - in org.apache.openjpa.itest.karaf.KarafTest
test1(org.apache.openjpa.itest.karaf.KarafTest)  Time elapsed: 5.004 sec  <<< 
ERROR!
java.lang.Exception: 
org.apache.openjpa.lib.jdbc.ReportingSQLException: Table "TASK" not found; SQL 
statement:
SELECT t0.id, t0.description, t0.dueDate, t0.finished, t0.title FROM Task t0 
[42102-172] {SELECT t0.id, t0.description, t0.dueDate, t0.finished, t0.title 
FROM Task t0} [code=42102, state=42S02]
at 
org.apache.openjpa.util.Exceptions.replaceNestedThrowables(Exceptions.java:254)
at 
org.apache.openjpa.persistence.PersistenceException.writeObject(PersistenceException.java:99)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:1028)
at 
java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1496)
at 
java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
at 
java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
at 
java.io.ObjectOutputStream.defaultWriteObject(ObjectOutputStream.java:441)
at java.lang.Throwable.writeObject(Throwable.java:985)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:1028)
at 
java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1496)
at 
java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
at 
java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
at 
java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
at 
java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:362)
at sun.rmi.transport.Transport$1.run(Transport.java:200)
at sun.rmi.transport.Transport$1.run(Transport.java:197)
at java.security.AccessController.doPrivileged(Native Method)
at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
at 
sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:683)
at java.security.AccessController.doPrivileged(Native Method)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:682)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)



> Table is not created in openjpa 3.0.0-SNAPSHOT and OSGi
> ---
>
> Key: OPENJPA-2673
> URL: https://issues.apache.org/jira/browse/OPENJPA-2673
> Project: OpenJPA
>  Issue Type: Bug
>Reporter: Christian Schneider
> Fix For: 3.0.0
>
>
> When testing the openjpa 3 feature in karaf I had the problem that my table 
> was not there when openjpa tried to access it even though I have specified 
> the options to create tables. 
> This first case where I found the issue was using Aries JPA. So I was not 
> sure if the problem might be in Aries JPA.
> I have now created a pax exam test that reproduces the issue without Aries 
> JPA. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] openjpa pull request #6: [OPENJPA-2673] Reproduce problem using test

2016-10-12 Thread cschneider 
GitHub user cschneider opened a pull request:

https://github.com/apache/openjpa/pull/6

[OPENJPA-2673] Reproduce problem using test



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cschneider/openjpa OPENJPA-2673

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/openjpa/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6


commit 4ed70ad77969cdd1b86711a022478941eb34027f
Author: Christian Schneider 
Date:   2016-10-12T13:18:32Z

[OPENJPA-2673] Reproduce problem using test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (OPENJPA-2673) Table is not created in openjpa 3.0.0-SNAPSHOT and OSGi

2016-10-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/OPENJPA-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568691#comment-15568691
 ] 

ASF GitHub Bot commented on OPENJPA-2673:
-

GitHub user cschneider opened a pull request:

https://github.com/apache/openjpa/pull/6

[OPENJPA-2673] Reproduce problem using test



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cschneider/openjpa OPENJPA-2673

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/openjpa/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6


commit 4ed70ad77969cdd1b86711a022478941eb34027f
Author: Christian Schneider 
Date:   2016-10-12T13:18:32Z

[OPENJPA-2673] Reproduce problem using test




> Table is not created in openjpa 3.0.0-SNAPSHOT and OSGi
> ---
>
> Key: OPENJPA-2673
> URL: https://issues.apache.org/jira/browse/OPENJPA-2673
> Project: OpenJPA
>  Issue Type: Bug
>Reporter: Christian Schneider
> Fix For: 3.0.0
>
>
> When testing the openjpa 3 feature in karaf I had the problem that my table 
> was not there when openjpa tried to access it even though I have specified 
> the options to create tables. 
> This first case where I found the issue was using Aries JPA. So I was not 
> sure if the problem might be in Aries JPA.
> I have now created a pax exam test that reproduces the issue without Aries 
> JPA. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OPENJPA-2673) Table is not created in openjpa 3.0.0-SNAPSHOT and OSGi

2016-10-12 Thread Christian Schneider (JIRA) 
Christian Schneider created OPENJPA-2673:


 Summary: Table is not created in openjpa 3.0.0-SNAPSHOT and OSGi
 Key: OPENJPA-2673
 URL: https://issues.apache.org/jira/browse/OPENJPA-2673
 Project: OpenJPA
  Issue Type: Bug
Reporter: Christian Schneider


When testing the openjpa 3 feature in karaf I had the problem that my table was 
not there when openjpa tried to access it even though I have specified the 
options to create tables. 
This first case where I found the issue was using Aries JPA. So I was not sure 
if the problem might be in Aries JPA.

I have now created a pax exam test that reproduces the issue without Aries JPA. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OPENJPA-2672) ConfigurationImpl.loadGlobals() has java.util.ConcurrentModificationException vulnerability

2016-10-12 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/OPENJPA-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francesco Chicchiriccò updated OPENJPA-2672:

Affects Version/s: 2.4.1
Fix Version/s: 2.4.2

> ConfigurationImpl.loadGlobals() has java.util.ConcurrentModificationException 
> vulnerability
> ---
>
> Key: OPENJPA-2672
> URL: https://issues.apache.org/jira/browse/OPENJPA-2672
> Project: OpenJPA
>  Issue Type: Bug
>  Components: lib
>Affects Versions: 2.2.3, 2.4.1
>Reporter: Jody Grassel
>Assignee: Jody Grassel
> Fix For: 2.2.3, 2.4.2, 3.0.0
>
> Attachments: OPENJPA_22X-2672.patch
>
>
> The following block in the loadGlobals() method:
> // let system properties override other globals
> try {
> fromProperties(new HashMap(
> AccessController.doPrivileged(
> J2DoPrivHelper.getPropertiesAction(;
> retrieves a Properties object from System.getProperties(), which is passed to 
> HashMap's ctor.  The ctor interacts with an enumerator associated with the 
> Properties object to populate the new HashMap instance.  However, if another 
> thread mutates the JVM's System Properties, it can result in a 
> ConcurrentModificationException as observed below:
> Caused by: java.util.ConcurrentModificationException
> at java.util.Hashtable$Enumerator.next(Hashtable.java:1256)
> at java.util.HashMap.putAllForCreate(HashMap.java:566)
> at java.util.HashMap.(HashMap.java:310)
> at 
> org.apache.openjpa.lib.conf.ConfigurationImpl.loadGlobals(ConfigurationImpl.java:189)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (OPENJPA-2672) ConfigurationImpl.loadGlobals() has java.util.ConcurrentModificationException vulnerability

2016-10-12 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/OPENJPA-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francesco Chicchiriccò reopened OPENJPA-2672:
-

Re-opening to add 2.4.x

> ConfigurationImpl.loadGlobals() has java.util.ConcurrentModificationException 
> vulnerability
> ---
>
> Key: OPENJPA-2672
> URL: https://issues.apache.org/jira/browse/OPENJPA-2672
> Project: OpenJPA
>  Issue Type: Bug
>  Components: lib
>Affects Versions: 2.2.3, 2.4.1
>Reporter: Jody Grassel
>Assignee: Jody Grassel
> Fix For: 2.2.3, 2.4.2, 3.0.0
>
> Attachments: OPENJPA_22X-2672.patch
>
>
> The following block in the loadGlobals() method:
> // let system properties override other globals
> try {
> fromProperties(new HashMap(
> AccessController.doPrivileged(
> J2DoPrivHelper.getPropertiesAction(;
> retrieves a Properties object from System.getProperties(), which is passed to 
> HashMap's ctor.  The ctor interacts with an enumerator associated with the 
> Properties object to populate the new HashMap instance.  However, if another 
> thread mutates the JVM's System Properties, it can result in a 
> ConcurrentModificationException as observed below:
> Caused by: java.util.ConcurrentModificationException
> at java.util.Hashtable$Enumerator.next(Hashtable.java:1256)
> at java.util.HashMap.putAllForCreate(HashMap.java:566)
> at java.util.HashMap.(HashMap.java:310)
> at 
> org.apache.openjpa.lib.conf.ConfigurationImpl.loadGlobals(ConfigurationImpl.java:189)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OPENJPA-2672) ConfigurationImpl.loadGlobals() has java.util.ConcurrentModificationException vulnerability

2016-10-12 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/OPENJPA-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francesco Chicchiriccò closed OPENJPA-2672.
---
Resolution: Fixed

> ConfigurationImpl.loadGlobals() has java.util.ConcurrentModificationException 
> vulnerability
> ---
>
> Key: OPENJPA-2672
> URL: https://issues.apache.org/jira/browse/OPENJPA-2672
> Project: OpenJPA
>  Issue Type: Bug
>  Components: lib
>Affects Versions: 2.2.3, 2.4.1
>Reporter: Jody Grassel
>Assignee: Jody Grassel
> Fix For: 2.2.3, 2.4.2, 3.0.0
>
> Attachments: OPENJPA_22X-2672.patch
>
>
> The following block in the loadGlobals() method:
> // let system properties override other globals
> try {
> fromProperties(new HashMap(
> AccessController.doPrivileged(
> J2DoPrivHelper.getPropertiesAction(;
> retrieves a Properties object from System.getProperties(), which is passed to 
> HashMap's ctor.  The ctor interacts with an enumerator associated with the 
> Properties object to populate the new HashMap instance.  However, if another 
> thread mutates the JVM's System Properties, it can result in a 
> ConcurrentModificationException as observed below:
> Caused by: java.util.ConcurrentModificationException
> at java.util.Hashtable$Enumerator.next(Hashtable.java:1256)
> at java.util.HashMap.putAllForCreate(HashMap.java:566)
> at java.util.HashMap.(HashMap.java:310)
> at 
> org.apache.openjpa.lib.conf.ConfigurationImpl.loadGlobals(ConfigurationImpl.java:189)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OPENJPA-2672) ConfigurationImpl.loadGlobals() has java.util.ConcurrentModificationException vulnerability

2016-10-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/OPENJPA-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567788#comment-15567788
 ] 

ASF subversion and git services commented on OPENJPA-2672:
--

Commit 1764389 from [~ilgrosso] in branch 'openjpa/branches/2.4.x'
[ https://svn.apache.org/r1764389 ]

OPENJPA-2672: ConfigurationImpl.loadGlobals() has 
java.util.ConcurrentModificationException vulnerability

> ConfigurationImpl.loadGlobals() has java.util.ConcurrentModificationException 
> vulnerability
> ---
>
> Key: OPENJPA-2672
> URL: https://issues.apache.org/jira/browse/OPENJPA-2672
> Project: OpenJPA
>  Issue Type: Bug
>  Components: lib
>Affects Versions: 2.2.3
>Reporter: Jody Grassel
>Assignee: Jody Grassel
> Fix For: 2.2.3, 3.0.0
>
> Attachments: OPENJPA_22X-2672.patch
>
>
> The following block in the loadGlobals() method:
> // let system properties override other globals
> try {
> fromProperties(new HashMap(
> AccessController.doPrivileged(
> J2DoPrivHelper.getPropertiesAction(;
> retrieves a Properties object from System.getProperties(), which is passed to 
> HashMap's ctor.  The ctor interacts with an enumerator associated with the 
> Properties object to populate the new HashMap instance.  However, if another 
> thread mutates the JVM's System Properties, it can result in a 
> ConcurrentModificationException as observed below:
> Caused by: java.util.ConcurrentModificationException
> at java.util.Hashtable$Enumerator.next(Hashtable.java:1256)
> at java.util.HashMap.putAllForCreate(HashMap.java:566)
> at java.util.HashMap.(HashMap.java:310)
> at 
> org.apache.openjpa.lib.conf.ConfigurationImpl.loadGlobals(ConfigurationImpl.java:189)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)