Re: [DISCUSS] Enable Travis CI?

2019-10-17 Thread Romain Manni-Bucau 
IMHO we should take this (good) track as an awesome opportunity to "fix"
that ;)

Le jeu. 17 oct. 2019 à 10:12, Francesco Chicchiriccò 
a écrit :

> On 17/10/19 10:05, Romain Manni-Bucau wrote:
> > Oki so corrolar point to my initial thought: do we drop jenkins and ask
> > infra to also handle master build (+ maintenance branches) with
> credentials
> > to enable nightly deployments?
> >
> > I'm +1 while we keep all jobs on the same build platform and infra
> manages
> > it.
>
> FYI we are already using Jenkins and Buildbot as CI platforms, hence we
> are already not keeping all jobs on the same build platform.
>
> My proposal is not to replace either, but to add Travis CI.
> As said, Infra is fine with Travis CI (and AppVeyor, for example).
>
> Regards.
>
> > Le jeu. 17 oct. 2019 à 10:02, Francesco Chicchiriccò <
> ilgro...@apache.org>
> > a écrit :
> >
> >> On 17/10/19 10:00, Romain Manni-Bucau wrote:
> >>> I understand but I don't want something done without infra being aware
> of
> >>> it.
> >>> Typically who would be admin on the repo to enable travis and update it
> >>> when the webhook will be broken? Should be infra, not us IMHO.
> >> Of course! Only infra can enable our repo for Travis - and it's plenty
> of
> >> other ASF projects doing the same BTW.
> >>
> >> If we can not disagree on Travis CI, next step is to file a request for
> >> Infra on JIRA.
> >>
> >> Regards.
> >>
> >>> Le jeu. 17 oct. 2019 à 09:24, Francesco Chicchiriccò <
> >> ilgro...@apache.org>
> >>> a écrit :
> >>>
>  FYI, we have a working .travis.yml:
> 
>  https://travis-ci.org/ilgrosso/openjpa/builds/599012496
> 
>  Regards.
> 
>  On 17/10/19 08:45, Francesco Chicchiriccò wrote:
> > On 17/10/19 08:23, Romain Manni-Bucau wrote:
> >> Hi Francesco,
> >>
> >> Cant we do it on jenkins?
> >> Rational being to ensure we rely on a centralized and infra solution
> >> and
> >> not something on our own, even for PR.
> > Hi Romain,
> > we already have Jenkins jobs [1], but AFAICT they suffer from chronic
>  lack of resources to satisfy all projects' needs, especially when it
> >> comes
>  to build PRs.
> > Besides this aspect, PRs *are* already managed at GitHub, and Infra
> is
>  completely fine with this - as we are, since we decided to switch to
>  dual-hosted repository a while ago.
> > BTW, I am not proposing to replace Jenkins, only to add Travis CI.
> >
> > Regards.
> >
> > [1] https://builds.apache.org/view/M-R/view/OpenJPA/
> >
> >> Le jeu. 17 oct. 2019 à 08:21, Francesco Chicchiriccò <
>  ilgro...@apache.org>
> >> a écrit :
> >>
> >>> Hi all,
> >>> I think it would be really useful to enable Travis CI for our
> GItHub
> >>> repository; besides other benefits, this would also improve our
>  ability to
> >>> check PRs.
> >>>
> >>> WDYT?
> >>> Regards.
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>
>

Re: [DISCUSS] Enable Travis CI?

2019-10-17 Thread Francesco Chicchiriccò 
On 17/10/19 10:05, Romain Manni-Bucau wrote:
> Oki so corrolar point to my initial thought: do we drop jenkins and ask
> infra to also handle master build (+ maintenance branches) with credentials
> to enable nightly deployments?
>
> I'm +1 while we keep all jobs on the same build platform and infra manages
> it.

FYI we are already using Jenkins and Buildbot as CI platforms, hence we are 
already not keeping all jobs on the same build platform.

My proposal is not to replace either, but to add Travis CI.
As said, Infra is fine with Travis CI (and AppVeyor, for example).

Regards.

> Le jeu. 17 oct. 2019 à 10:02, Francesco Chicchiriccò 
> a écrit :
>
>> On 17/10/19 10:00, Romain Manni-Bucau wrote:
>>> I understand but I don't want something done without infra being aware of
>>> it.
>>> Typically who would be admin on the repo to enable travis and update it
>>> when the webhook will be broken? Should be infra, not us IMHO.
>> Of course! Only infra can enable our repo for Travis - and it's plenty of
>> other ASF projects doing the same BTW.
>>
>> If we can not disagree on Travis CI, next step is to file a request for
>> Infra on JIRA.
>>
>> Regards.
>>
>>> Le jeu. 17 oct. 2019 à 09:24, Francesco Chicchiriccò <
>> ilgro...@apache.org>
>>> a écrit :
>>>
 FYI, we have a working .travis.yml:

 https://travis-ci.org/ilgrosso/openjpa/builds/599012496

 Regards.

 On 17/10/19 08:45, Francesco Chicchiriccò wrote:
> On 17/10/19 08:23, Romain Manni-Bucau wrote:
>> Hi Francesco,
>>
>> Cant we do it on jenkins?
>> Rational being to ensure we rely on a centralized and infra solution
>> and
>> not something on our own, even for PR.
> Hi Romain,
> we already have Jenkins jobs [1], but AFAICT they suffer from chronic
 lack of resources to satisfy all projects' needs, especially when it
>> comes
 to build PRs.
> Besides this aspect, PRs *are* already managed at GitHub, and Infra is
 completely fine with this - as we are, since we decided to switch to
 dual-hosted repository a while ago.
> BTW, I am not proposing to replace Jenkins, only to add Travis CI.
>
> Regards.
>
> [1] https://builds.apache.org/view/M-R/view/OpenJPA/
>
>> Le jeu. 17 oct. 2019 à 08:21, Francesco Chicchiriccò <
 ilgro...@apache.org>
>> a écrit :
>>
>>> Hi all,
>>> I think it would be really useful to enable Travis CI for our GItHub
>>> repository; besides other benefits, this would also improve our
 ability to
>>> check PRs.
>>>
>>> WDYT?
>>> Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] Enable Travis CI?

2019-10-17 Thread Romain Manni-Bucau 
Oki so corrolar point to my initial thought: do we drop jenkins and ask
infra to also handle master build (+ maintenance branches) with credentials
to enable nightly deployments?

I'm +1 while we keep all jobs on the same build platform and infra manages
it.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le jeu. 17 oct. 2019 à 10:02, Francesco Chicchiriccò 
a écrit :

> On 17/10/19 10:00, Romain Manni-Bucau wrote:
> > I understand but I don't want something done without infra being aware of
> > it.
> > Typically who would be admin on the repo to enable travis and update it
> > when the webhook will be broken? Should be infra, not us IMHO.
>
> Of course! Only infra can enable our repo for Travis - and it's plenty of
> other ASF projects doing the same BTW.
>
> If we can not disagree on Travis CI, next step is to file a request for
> Infra on JIRA.
>
> Regards.
>
> > Le jeu. 17 oct. 2019 à 09:24, Francesco Chicchiriccò <
> ilgro...@apache.org>
> > a écrit :
> >
> >> FYI, we have a working .travis.yml:
> >>
> >> https://travis-ci.org/ilgrosso/openjpa/builds/599012496
> >>
> >> Regards.
> >>
> >> On 17/10/19 08:45, Francesco Chicchiriccò wrote:
> >>> On 17/10/19 08:23, Romain Manni-Bucau wrote:
>  Hi Francesco,
> 
>  Cant we do it on jenkins?
>  Rational being to ensure we rely on a centralized and infra solution
> and
>  not something on our own, even for PR.
> >>> Hi Romain,
> >>> we already have Jenkins jobs [1], but AFAICT they suffer from chronic
> >> lack of resources to satisfy all projects' needs, especially when it
> comes
> >> to build PRs.
> >>> Besides this aspect, PRs *are* already managed at GitHub, and Infra is
> >> completely fine with this - as we are, since we decided to switch to
> >> dual-hosted repository a while ago.
> >>> BTW, I am not proposing to replace Jenkins, only to add Travis CI.
> >>>
> >>> Regards.
> >>>
> >>> [1] https://builds.apache.org/view/M-R/view/OpenJPA/
> >>>
>  Le jeu. 17 oct. 2019 à 08:21, Francesco Chicchiriccò <
> >> ilgro...@apache.org>
>  a écrit :
> 
> > Hi all,
> > I think it would be really useful to enable Travis CI for our GItHub
> > repository; besides other benefits, this would also improve our
> >> ability to
> > check PRs.
> >
> > WDYT?
> > Regards.
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>
>

Re: [DISCUSS] Enable Travis CI?

2019-10-17 Thread Francesco Chicchiriccò 
On 17/10/19 10:00, Romain Manni-Bucau wrote:
> I understand but I don't want something done without infra being aware of
> it.
> Typically who would be admin on the repo to enable travis and update it
> when the webhook will be broken? Should be infra, not us IMHO.

Of course! Only infra can enable our repo for Travis - and it's plenty of other 
ASF projects doing the same BTW.

If we can not disagree on Travis CI, next step is to file a request for Infra 
on JIRA.

Regards.

> Le jeu. 17 oct. 2019 à 09:24, Francesco Chicchiriccò 
> a écrit :
>
>> FYI, we have a working .travis.yml:
>>
>> https://travis-ci.org/ilgrosso/openjpa/builds/599012496
>>
>> Regards.
>>
>> On 17/10/19 08:45, Francesco Chicchiriccò wrote:
>>> On 17/10/19 08:23, Romain Manni-Bucau wrote:
 Hi Francesco,

 Cant we do it on jenkins?
 Rational being to ensure we rely on a centralized and infra solution and
 not something on our own, even for PR.
>>> Hi Romain,
>>> we already have Jenkins jobs [1], but AFAICT they suffer from chronic
>> lack of resources to satisfy all projects' needs, especially when it comes
>> to build PRs.
>>> Besides this aspect, PRs *are* already managed at GitHub, and Infra is
>> completely fine with this - as we are, since we decided to switch to
>> dual-hosted repository a while ago.
>>> BTW, I am not proposing to replace Jenkins, only to add Travis CI.
>>>
>>> Regards.
>>>
>>> [1] https://builds.apache.org/view/M-R/view/OpenJPA/
>>>
 Le jeu. 17 oct. 2019 à 08:21, Francesco Chicchiriccò <
>> ilgro...@apache.org>
 a écrit :

> Hi all,
> I think it would be really useful to enable Travis CI for our GItHub
> repository; besides other benefits, this would also improve our
>> ability to
> check PRs.
>
> WDYT?
> Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] Enable Travis CI?

2019-10-17 Thread Romain Manni-Bucau 
I understand but I don't want something done without infra being aware of
it.
Typically who would be admin on the repo to enable travis and update it
when the webhook will be broken? Should be infra, not us IMHO.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le jeu. 17 oct. 2019 à 09:24, Francesco Chicchiriccò 
a écrit :

> FYI, we have a working .travis.yml:
>
> https://travis-ci.org/ilgrosso/openjpa/builds/599012496
>
> Regards.
>
> On 17/10/19 08:45, Francesco Chicchiriccò wrote:
> > On 17/10/19 08:23, Romain Manni-Bucau wrote:
> >> Hi Francesco,
> >>
> >> Cant we do it on jenkins?
> >> Rational being to ensure we rely on a centralized and infra solution and
> >> not something on our own, even for PR.
> > Hi Romain,
> > we already have Jenkins jobs [1], but AFAICT they suffer from chronic
> lack of resources to satisfy all projects' needs, especially when it comes
> to build PRs.
> >
> > Besides this aspect, PRs *are* already managed at GitHub, and Infra is
> completely fine with this - as we are, since we decided to switch to
> dual-hosted repository a while ago.
> >
> > BTW, I am not proposing to replace Jenkins, only to add Travis CI.
> >
> > Regards.
> >
> > [1] https://builds.apache.org/view/M-R/view/OpenJPA/
> >
> >> Le jeu. 17 oct. 2019 à 08:21, Francesco Chicchiriccò <
> ilgro...@apache.org>
> >> a écrit :
> >>
> >>> Hi all,
> >>> I think it would be really useful to enable Travis CI for our GItHub
> >>> repository; besides other benefits, this would also improve our
> ability to
> >>> check PRs.
> >>>
> >>> WDYT?
> >>> Regards.
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>
>

Re: [DISCUSS] Enable Travis CI?

2019-10-17 Thread Francesco Chicchiriccò 
FYI, we have a working .travis.yml:

https://travis-ci.org/ilgrosso/openjpa/builds/599012496

Regards.

On 17/10/19 08:45, Francesco Chicchiriccò wrote:
> On 17/10/19 08:23, Romain Manni-Bucau wrote:
>> Hi Francesco,
>>
>> Cant we do it on jenkins?
>> Rational being to ensure we rely on a centralized and infra solution and
>> not something on our own, even for PR.
> Hi Romain,
> we already have Jenkins jobs [1], but AFAICT they suffer from chronic lack of 
> resources to satisfy all projects' needs, especially when it comes to build 
> PRs.
>
> Besides this aspect, PRs *are* already managed at GitHub, and Infra is 
> completely fine with this - as we are, since we decided to switch to 
> dual-hosted repository a while ago.
>
> BTW, I am not proposing to replace Jenkins, only to add Travis CI.
>
> Regards.
>
> [1] https://builds.apache.org/view/M-R/view/OpenJPA/
>
>> Le jeu. 17 oct. 2019 à 08:21, Francesco Chicchiriccò 
>> a écrit :
>>
>>> Hi all,
>>> I think it would be really useful to enable Travis CI for our GItHub
>>> repository; besides other benefits, this would also improve our ability to
>>> check PRs.
>>>
>>> WDYT?
>>> Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] Enable Travis CI?

2019-10-17 Thread Francesco Chicchiriccò 
On 17/10/19 08:23, Romain Manni-Bucau wrote:
> Hi Francesco,
>
> Cant we do it on jenkins?
> Rational being to ensure we rely on a centralized and infra solution and
> not something on our own, even for PR.

Hi Romain,
we already have Jenkins jobs [1], but AFAICT they suffer from chronic lack of 
resources to satisfy all projects' needs, especially when it comes to build PRs.

Besides this aspect, PRs *are* already managed at GitHub, and Infra is 
completely fine with this - as we are, since we decided to switch to 
dual-hosted repository a while ago.

BTW, I am not proposing to replace Jenkins, only to add Travis CI.

Regards.

[1] https://builds.apache.org/view/M-R/view/OpenJPA/

> Le jeu. 17 oct. 2019 à 08:21, Francesco Chicchiriccò 
> a écrit :
>
>> Hi all,
>> I think it would be really useful to enable Travis CI for our GItHub
>> repository; besides other benefits, this would also improve our ability to
>> check PRs.
>>
>> WDYT?
>> Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] Enable Travis CI?

2019-10-17 Thread Maxim Solodovnik 
+1

On Thu, 17 Oct 2019 at 13:21, Francesco Chicchiriccò 
wrote:

> Hi all,
> I think it would be really useful to enable Travis CI for our GItHub
> repository; besides other benefits, this would also improve our ability to
> check PRs.
>
> WDYT?
> Regards.
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>
>

-- 
WBR
Maxim aka solomax

Re: [DISCUSS] Enable Travis CI?

2019-10-17 Thread Romain Manni-Bucau 
Hi Francesco,

Cant we do it on jenkins?
Rational being to ensure we rely on a centralized and infra solution and
not something on our own, even for PR.

Romain

Le jeu. 17 oct. 2019 à 08:21, Francesco Chicchiriccò 
a écrit :

> Hi all,
> I think it would be really useful to enable Travis CI for our GItHub
> repository; besides other benefits, this would also improve our ability to
> check PRs.
>
> WDYT?
> Regards.
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>
>

[DISCUSS] Enable Travis CI?

2019-10-17 Thread Francesco Chicchiriccò 
Hi all,
I think it would be really useful to enable Travis CI for our GItHub 
repository; besides other benefits, this would also improve our ability to 
check PRs.

WDYT?
Regards.

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

[jira] [Updated] (OPENJPA-2788) Anonymous parameters are not being picked when adding via CriteriaBuilder

2019-10-17 Thread Jira 


 [ 
https://issues.apache.org/jira/browse/OPENJPA-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francesco Chicchiriccò updated OPENJPA-2788:

Fix Version/s: 3.1.1

> Anonymous parameters are not being picked when adding via CriteriaBuilder
> -
>
> Key: OPENJPA-2788
> URL: https://issues.apache.org/jira/browse/OPENJPA-2788
> Project: OpenJPA
>  Issue Type: Bug
>  Components: criteria
>Affects Versions: 3.1.0
>Reporter: Michael Wiles
>Priority: Critical
> Fix For: 3.1.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Something that is almost certainly introduced via fixes for OPENJPA-2785 and 
> OPENJPA-2733 is that anonymous parameters are not picked up.
> The following piece of code does not add the second parameter successfully 
> and thus the test fails.
> With a Member entity that has a place and a name field:
> {code:java}
>Member m = new Member(1, "dave");
> m.setAge(5);
> m.setPlace("capetown");
> em.persist(m);
> CriteriaBuilder cb = em.getCriteriaBuilder();
> CriteriaQuery q = cb.createQuery(Member.class);
> Root c = q.from(Member.class);
> ParameterExpression name = cb.parameter(String.class);
> ParameterExpression place = cb.parameter(String.class);
> CriteriaQuery where = 
> q.select(c).where(cb.equal(c.get("name"), name), cb.equal(c.get("place"), 
> place));
> TypedQuery query = em.createQuery(where);
> query.setParameter(name, "dave");
> query.setParameter(place, "capetown");
> List results = query.getResultList();
> assertThat(results).isNotEmpty();
> {code}
> With query and parameter logging on you that the the sql call is made with 
> the same parameter twice...
> {noformat}
>  executing prepstmnt 2078396010 SELECT t0.id, 
> t0.age, t0.name, t0.place FROM Member t0 WHERE (t0.name = ? AND t0.place = ?) 
> [params=(String) dave, (String) dave]
> {noformat}
> And this kinda makes sense as this is what the 
> CriteriaQueryImpl.registerParameter looks like:
> {code:java}
> /**
>  * Registers the given parameter.
>  */
> void registerParameter(ParameterExpressionImpl p) {
> for (Object k : _params.keySet()) {
> if (p.paramEquals(k)) {
> // If a named ParameterExpressin did already get registered
> // with that exact name, then we do ignore it.
> // If we do a query.setParameter("someParamName", Bla)
> // then it must uniquely identify a Parameter.
> return;
> }
> }
> p.setIndex(_params.size());
> _params.put(p, p.getJavaType());
> }
> {code}
> And 
> [paramEquals|https://github.com/apache/openjpa/blob/9f26ed29bf31b5c8ab68c5257d42e8c88765cf9b/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/ParameterExpressionImpl.java#L142]
>  will not differentiate between two anonymous parameters.
> So I suspect we are going to need some mechanism for differentiating between 
> two anonymous parameters - and if we did this then I suspect the issue that 
> caused this in the first place might also be resolved. Possibly add some kind 
> of counter or something that can give identity to anonymous parameters.
>  Added test to [https://github.com/michaelwiles/openjpa-bugs]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)