thanks Jörn I'll follow your suggestion and change the test impl accordingly.
Regards, Tommaso 2015-01-29 13:16 GMT+01:00 Joern Kottmann <kottm...@gmail.com>: > In those serialization tests I usually write the Object into a byte > buffer, create it again from the byte buffer and then compare the two > objects, instead of the binary representation. > > Could that solve the problem we have in this test? > > Jörn > > On Thu, 2015-01-29 at 12:11 +0100, Tommaso Teofili wrote: > > I've just disabled that test, I'll fix it and re-enable it when done. > > > > Regards, > > Tommaso > > > > 2015-01-29 10:51 GMT+01:00 Joern Kottmann <kottm...@gmail.com>: > > > > > It still fails in the assert. I didn't check but I guess the build > > > server has the same problem. > > > > > > Jörn > > > > > > On Thu, 2015-01-29 at 10:25 +0100, Tommaso Teofili wrote: > > > > even after my latest commit? If so I'll rearrange the test a bit. > > > > > > > > Tommaso > > > > > > > > 2015-01-29 10:21 GMT+01:00 Joern Kottmann <kottm...@gmail.com>: > > > > > > > > > Or if that is a problem for the test, you could also tell RAT to > ignore > > > > > it. > > > > > > > > > > On my machine the test fails. The two strings don't match. > > > > > > > > > > Jörn > > > > > > > > > > On Thu, 2015-01-29 at 09:59 +0100, Tommaso Teofili wrote: > > > > > > right, thanks I'll fix both. > > > > > > > > > > > > Tommaso > > > > > > > > > > > > 2015-01-29 9:54 GMT+01:00 Joern Kottmann <kottm...@gmail.com>: > > > > > > > > > > > > > This file should have an AL header. > > > > > > > > > > > > > > Jörn > > > > > > > > > > > > > > On Thu, 2015-01-29 at 08:02 +0000, tomm...@apache.org wrote: > > > > > > > > Added: > > > > > > > > > > > > > > > > > > > > > > > > opennlp/trunk/opennlp-tools/src/test/resources/opennlp/tools/ngram/ngram-model.xml > > > > > > > > URL: > > > > > > > > > > > > > > > > > > > > > > > > http://svn.apache.org/viewvc/opennlp/trunk/opennlp-tools/src/test/resources/opennlp/tools/ngram/ngram-model.xml?rev=1655546&view=auto > > > > > > > > > > > > > > > > > > > > > > > > ============================================================================== > > > > > > > > --- > > > > > > > > > > > > > > > > > > > > > > > > opennlp/trunk/opennlp-tools/src/test/resources/opennlp/tools/ngram/ngram-model.xml > > > > > > > (added) > > > > > > > > +++ > > > > > > > > > > > > > > > > > > > > > > > > opennlp/trunk/opennlp-tools/src/test/resources/opennlp/tools/ngram/ngram-model.xml > > > > > > > Thu Jan 29 08:02:31 2015 > > > > > > > > @@ -0,0 +1,58 @@ > > > > > > > > +<?xml version="1.0" encoding="UTF-8"?> > > > > > > > > +<dictionary case_sensitive="false"> > > > > > > > > + <entry count="1"> > > > > > > > > + <token>brown</token> > > > > > > > > + <token>fox</token> > > > > > > > > + </entry> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >